On Mon, Mar 06, 2017 at 06:18:15PM +0100, Reinhold Straub wrote:
> Hi all,
>
> pdfgrep has been updated to v. 2.0.1
>
> It has a new option: --cache, which needs additional dependencies and some
> modification to the pledge(2) syscalls.
>
> Most of our previous patches have been accepted
Theo Buehler writes:
> On Tue, Mar 14, 2017 at 12:14:42PM +0100, Jeremie Courreges-Anglas wrote:
>> Theo Buehler writes:
>>
>> > On Tue, Mar 14, 2017 at 09:35:37AM +0100, Reinhold Straub wrote:
>> >> ok?
>> >>
>> >> On 06.03.17 18:18, Reinhold Straub
On Tue, Mar 14, 2017 at 09:29:48PM +, Stuart Henderson wrote:
> How about killing the wpath pledge if --cache is not used?
>
It already does that. It's not visible in the diff, but we have:
694 if (options.use_cache) {
[...]
704 } else {
705
How about killing the wpath pledge if --cache is not used?
I was a bit confused as to why it needs gcrypt for a caching option...
turns out it uses it to SHA1 the contents of the pdf.
On Tue, Mar 14, 2017 at 12:14:42PM +0100, Jeremie Courreges-Anglas wrote:
> Theo Buehler writes:
>
> > On Tue, Mar 14, 2017 at 09:35:37AM +0100, Reinhold Straub wrote:
> >> ok?
> >>
> >> On 06.03.17 18:18, Reinhold Straub wrote:
> >> > Hi all,
> >> >
> >> > pdfgrep has been
Theo Buehler writes:
> On Tue, Mar 14, 2017 at 09:35:37AM +0100, Reinhold Straub wrote:
>> ok?
>>
>> On 06.03.17 18:18, Reinhold Straub wrote:
>> > Hi all,
>> >
>> > pdfgrep has been updated to v. 2.0.1
>> >
>> > It has a new option: --cache, which needs additional
On Tue, Mar 14, 2017 at 09:35:37AM +0100, Reinhold Straub wrote:
> ok?
>
> On 06.03.17 18:18, Reinhold Straub wrote:
> > Hi all,
> >
> > pdfgrep has been updated to v. 2.0.1
> >
> > It has a new option: --cache, which needs additional dependencies and some
> > modification to the pledge(2)
ok?
On 06.03.17 18:18, Reinhold Straub wrote:
Hi all,
pdfgrep has been updated to v. 2.0.1
It has a new option: --cache, which needs additional dependencies and some
modification to the pledge(2) syscalls.
Most of our previous patches have been accepted upstream.
Regards,
Reinhold Straub
Hi all,
pdfgrep has been updated to v. 2.0.1
It has a new option: --cache, which needs additional dependencies and some
modification to the pledge(2) syscalls.
Most of our previous patches have been accepted upstream.
Regards,
Reinhold Straub
Index: pdfgrep/Makefile
One test still fails for me:
Running ./pdfgrep.tests/regex.exp ...
FAIL: Empty pattern -- error from pdfgrep
Indeed, when pdfgrep is called with argument "", instead of matching
every line it exits with error
pdfgrep: empty (sub)expression
This happens because our regex(3) doesn't allow
On 2016/01/15 13:21, Dmitrij D. Czarkoff wrote:
> This happens because our regex(3) doesn't allow empty patterns. As far
> as I can tell, this behavior is undesirable in something called "*grep",
> so I added a quirk for this particular use case.
Agreed.
On 2016/01/15 10:04, Reinhold Straub wrote:
> Hi,
>
> pdfgrep has a testsuite based on devel/dejagnu now. Unfortunately, some
> patches are necessary to make tests work on OpenBSD.
>
> I put pledge(2) calls into the source code, too.
Nice. I think the combination of PCRE and (often untrusted)
> + int main(int argc, char** argv)
> + {
> ++if (pledge("stdio rpath ioctl", NULL) == -1) {
> ++fprintf ( stderr, "pdfgrep: pledge\n" );
> ++exit ( 1 );
> ++}
This ioctl pledge feels wrong. I only have a lousy internet connection
and no gcc 4.9 installed, so I
On 2016/01/15 13:36, Theo Buehler wrote:
> > + int main(int argc, char** argv)
> > + {
> > ++ if (pledge("stdio rpath ioctl", NULL) == -1) {
> > ++ fprintf ( stderr, "pdfgrep: pledge\n" );
> > ++ exit ( 1 );
> > ++ }
>
> This ioctl pledge feels wrong. I only have a lousy
Stuart Henderson said:
> On 2016/01/15 13:36, Theo Buehler wrote:
> > > + int main(int argc, char** argv)
> > > + {
> > > ++if (pledge("stdio rpath ioctl", NULL) == -1) {
> > > ++fprintf ( stderr, "pdfgrep: pledge\n" );
> > > ++exit ( 1 );
> > > ++}
On 2016/01/15 14:42, Dmitrij D. Czarkoff wrote:
> Stuart Henderson said:
> > On 2016/01/15 13:36, Theo Buehler wrote:
> > > > + int main(int argc, char** argv)
> > > > + {
> > > > ++ if (pledge("stdio rpath ioctl", NULL) == -1) {
> > > > ++ fprintf ( stderr, "pdfgrep: pledge\n"
Hi,
pdfgrep has a testsuite based on devel/dejagnu now. Unfortunately, some patches
are necessary to make tests work on OpenBSD.
I put pledge(2) calls into the source code, too.
Regards,
Reinhold Straub
Index: Makefile
===
RCS
On Fri, Jan 15, 2016 at 10:04:36AM +0100, Reinhold Straub wrote:
> Hi,
>
> pdfgrep has a testsuite based on devel/dejagnu now. Unfortunately, some
> patches are necessary to make tests work on OpenBSD.
>
> I put pledge(2) calls into the source code, too.
So where are patches? Did you forget to
Reinhold Straub demarc...@web.de writes:
Hi,
Hi,
there is a new version of pdfgrep.
Works for me, committed. Minor nit: indentation should use tabs, not
spaces.
Thanks,
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Hi,
there is a new version of pdfgrep.
--
Reinhold Straub demarc...@web.de
pdfgrep.diff
Description: Binary data
Hi,
pdfgrep is hosted on a different server now.
Index: Makefile
===
RCS file: /cvs/ports/textproc/pdfgrep/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile24 Mar 2015 09:57:04 - 1.1.1.1
Reinhold Straub demarc...@web.de writes:
Hi,
pdfgrep is hosted on a different server now.
Committed, thanks. For the record the diff didn't apply (whitespace
change; copy/paste?) and lacked a REVISION bump (since HOMEPAGE
changed).
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC
22 matches
Mail list logo