I wasn't able to get to this this week. Will send out an email next week
with another date.
David
On Tue, Oct 13, 2020 at 12:52 PM David Davis wrote:
> During the pulpcore team meeting today there was a desire to move forward
> with auto-merging pulpcore PRs. This would mean automatically merg
During the pulpcore team meeting today there was a desire to move forward
with auto-merging pulpcore PRs. This would mean automatically merging of
pulpcore PRs that have all the necessary approvals (2), tests passing, no
changes requested, and are not draft PRs.
Here is the pulp-ci PR again for an
On Thu, Oct 1, 2020 at 7:35 AM Ina Panova wrote:
>
>
>
> Regards,
>
> Ina Panova
> Senior Software Engineer| Pulp| Red Hat Inc.
>
> "Do not go where the path may lead,
> go instead where there is no path and leave a trail."
>
>
> On Wed, Sep 30, 2020 at 2:38 PM David Davis wrote:
>
>>
Maybe we could implement a policy where, once the author of the PR is
finished, they add a +1 review (or tag) to their own PR, and only then
would it be merged (if the CI passes).
IMO having a reviewer enable the auto-merge functionality is basically
equivalent to having them merge the PR manually
Regards,
Ina Panova
Senior Software Engineer| Pulp| Red Hat Inc.
"Do not go where the path may lead,
go instead where there is no path and leave a trail."
On Wed, Sep 30, 2020 at 2:38 PM David Davis wrote:
> I am also concerned about the lack of human involvement and the potential
>
I used it recently (last week). Agreed that it is not commonly needed and
especially not in pulpcore though.
On Wed, Sep 30, 2020 at 8:52 AM Matthias Dellweg
wrote:
>
>
> On Wed, Sep 30, 2020 at 2:37 PM David Davis wrote:
>
>> I am also concerned about the lack of human involvement and the pot
On Wed, Sep 30, 2020 at 2:37 PM David Davis wrote:
> I am also concerned about the lack of human involvement and the potential
> for things to be merged accidentally. I definitely could see that happening.
>
> I like the idea of having the PR processor only merge if a label (eg
> "Merge when Read
I am also concerned about the lack of human involvement and the potential
for things to be merged accidentally. I definitely could see that happening.
I like the idea of having the PR processor only merge if a label (eg "Merge
when Ready") is present. The question then is whether it should be appl
This just reminds me that Gitlab has a very nice "merge when CI passes
button" to decouple the merge question from the reviews.
The only way i could see this happen in Github is via setting a label that
instructs the PR processor to merge when (label is set) && (ci is green) &&
(other conditions).
I have some doubts about the cost/benefit ratio of coding automation to
merge PRs vs. simply changing the default option / being selective about
which options are available.
I like the idea in general though. A lot of projects do something like
this. I occasionally contributed to the Servo proje
Hi all,
Last week the discussion about how to merge PRs got me thinking about how
we could potentially programmatically merge PRs. The openshift project on
github does this[0] and I wondered if it would work for Pulp.
I think the main benefits would be (1) we'd be able to code how to best
merge P
11 matches
Mail list logo
