Terry J. Reedy added the comment:
I agree with Serhiy: no bullet points, links to glossary (at least in doc),
without repeating.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21279
___
Serhiy Storchaka added the comment:
This is not so easy as look at first glance. PY_LONG_LONG should be used
instead of long long. And as far as this type is optional, its use should be
conditional if HAVE_LONG_LONG is defined.
May be needed complex converter like _Py_Uid_Converter because
New submission from Martin Panter:
IOBase.close() doc says file operations raise ValueError, but it is not obvious
to me that reading back the “file” buffer is a file operation.
with BytesIO() as b:
... b.write(b123)
...
3
b.getvalue()
Traceback (most recent call last):
File stdin,
Martin Panter added the comment:
Adding patch v2 after learning how to compile the docs and fixing my errors. I
also simplified the descriptions of the CodecInfo attributes by defering the
constructor signatures to where they are fully defined under “Codec base
classes”, and merged the list
Serhiy Storchaka added the comment:
getvalue() doesn't work after close() for purpose. close() frees memory used by
BytesIO.
import io, sys
bio = io.BytesIO()
sys.getsizeof(bio)
52
bio.write(b'x'*1000)
1000
sys.getsizeof(bio)
1053
bio.close()
sys.getsizeof(bio)
52
Changing the behavior
Jesús Cea Avión added the comment:
Serhiy, could you consider to create a patch for 2.7 and 3.4?. I am not
familiar with the details of Argument Clinic.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23098
Nick Coghlan added the comment:
Thanks for those drafts, Martin - they look like a strong improvement to me.
While I still had plenty of comments/questions on v2, I think that's more a
reflection on how long it has been since we gave these docs a thorough overall
review, moreso than a
Clement Rouault added the comment:
The call to PySequence_GetItem() may be expensive, and we have to drop
the result if an OverflowError is raised after the call.
You do realize that this error will be very rare and therefore
inconsequential.
The real question is: why would you call the
Serhiy Storchaka added the comment:
Here is a patch against 3.5. Unsigned bitwise int converter is used for dev_t
because dev_t can be unsigned (and it is on Linux). This is not ideal solution,
there is no overflow check, but at least it should work for correct code.
--
keywords:
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19548
___
___
Antoine Pitrou added the comment:
Even worse, the memoryview gets corrupted on close():
The BytesIO object should probably reject closing when a buffer is exported.
writing to the file seems to be completely disallowed, even if it
would not seem to change the size:
An enhancement is
Alexandre Vassalotti added the comment:
The repr for floats was changed some time ago to use a shorter decimal strings
when possible. Both representations should yield the same float value once
decoded. If we want to make the C and Python implementations of pickle
consistent, then we should
Martin Panter added the comment:
The problem with mappings and sequences is that they both require len() and
iter() implementations, but str.translate() only requires __getitem__().
Perhaps a qualifier could work, like:
The table must implement the __getitem__() method of mappings and
Serhiy Storchaka added the comment:
As pointed by Antoine there are other affected functions. Updated patch fixes
converting of arguments or results in makedev(), major() and minor().
--
Added file: http://bugs.python.org/file37527/posix_dev_t_converter-3.5_2.patch
Antoine Pitrou added the comment:
This looks less like a bug than an enhancement request.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23096
___
Antoine Pitrou added the comment:
This looks good to me.
--
nosy: +pitrou
stage: - commit review
type: - behavior
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23088
Martin Panter added the comment:
Adding patch v2 with readinto1() as a “mixin method” and dropped many of my
earlier changes for better consistency with the introduction of the classes
(which I never really read before :P)
--
Added file:
New submission from Davin Potts:
The organization and multiple sections of the multiprocessing module's
documentation do not adhere to the Python Dev Guidelines for economy of
expression, affirmative tone, and/or code examples.
Problem description:
The raw material and information in the
Davin Potts added the comment:
I am happy to provide proposed patches but first can someone please clarify for
me whether I should have those patches depend upon the patches from Issue 22952?
--
___
Python tracker rep...@bugs.python.org
Davin Potts added the comment:
Procedural question (wanting to understand the label given to this issue):
when documentation does not adhere to the Python Developer's Guide, is a fix
for this considered an enhancement?
--
versions: +Python 3.6
___
Changes by Greg Turner g...@be-evil.net:
--
components: Distutils
nosy: dstufft, eric.araujo, gmt
priority: normal
severity: normal
status: open
title: \\di
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23101
Changes by Greg Turner g...@be-evil.net:
--
status: open - closed
title: \\di - bleh, sorry, my cat reported this non-bug :)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23101
___
New submission from Éric Araujo:
:-)
--
resolution: - not a bug
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23101
___
___
New submission from Greg Turner:
Clinical Presentation:
Sometimes a developer consuming distutils will write what seems like a
perfectly sensible setup.py, but something inscrutable happens: setup.py bombs
out claiming error: each element of 'ext_modules' option must be an Extension
instance
Changes by Ned Deily n...@acm.org:
--
nosy: +sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23100
___
___
Python-bugs-list mailing list
Martin Panter added the comment:
New patch version addressing many of the comments; thanks for reviewing! Also
adds and extends some unit tests to confirm some of the corner cases I am
documenting.
--
Added file: http://bugs.python.org/file37530/codecs-doc.v3.patch
Serhiy Storchaka added the comment:
Here is a patch which rejects close() when a buffer is exported.
--
keywords: +patch
stage: - patch review
versions: +Python 2.7, Python 3.5
Added file: http://bugs.python.org/file37531/bytesio_exported_reject_close.patch
Serhiy Storchaka added the comment:
And here are patches for 2.7 and 3.4 (unfortunately none of patches is applied
clear to other version).
--
Added file: http://bugs.python.org/file37532/posix_dev_t_converter-2.7.patch
Added file:
28 matches
Mail list logo