[issue17860] subprocess docs lack info how to use output result

New submission from anatoly techtonik: http://docs.python.org/3/library/subprocess.html A common confusion is that result from subprocess calls in Python 3 is bytes, not string, and needs to be converted. The problem is complicated because you need to know the encoding of input/output streams

[issue17860] subprocess docs lack info how to use output result

Changes by Ezio Melotti : -- nosy: +ezio.melotti, haypo stage: -> needs patch type: -> enhancement versions: +Python 3.4 ___ Python tracker ___

[issue17860] subprocess docs lack info how to use output result

Andrew Svetlov added the comment: Actually stdin/stdout/stderr are string streams if universal_newline is True -- nosy: +asvetlov ___ Python tracker ___ _

[issue17860] subprocess docs lack info how to use output result

anatoly techtonik added the comment: > > > Actually stdin/stdout/stderr are string streams if universal_newline is > True > I believe that makes the issue even worse. =) -- ___ Python tracker _

[issue17860] subprocess docs lack info how to use output result

R. David Murray added the comment: Anatoly, do you have a specific suggestion for improved wording? This *is* documented in the subprocess documentation, in several appropriate places, including the fact that the appropriate encoding to use may need to be determined at the application level.

[issue17860] subprocess docs lack info how to use output result

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue17860] subprocess docs lack info how to use output result

Ronald Oussoren added the comment: The attached patch explicitly mentions that stdin/stdout/stderr are opened as binary streams when universal_newlines is False. I'm not convinced that adding this text will solve the confusion, subprocess has fairly complex documentation due to the rich API a

[issue17860] subprocess docs lack info how to use output result

anatoly techtonik added the comment: The only thing that can save the docs is pictures. Or tables. +-+---+ | | universal_newlines = True | +--+-+---+ |Py.2 | str | str

[issue17860] subprocess docs lack info how to use output result

Ronald Oussoren added the comment: I don't agree that adding a table/picture is the only thing that can be done, or even that it is a good idea. IMHO the subprocess documentation is clear enough about the distinction between bytes and string, especially in the section about convenience functio

[issue17860] subprocess docs lack info how to use output result

Ezio Melotti added the comment: Also in the Python 3 docs we don't compare the current behavior with Python 2. Ronald patch LGTM. -- ___ Python tracker ___

[issue17860] subprocess docs lack info how to use output result

Serhiy Storchaka added the comment: LGTM. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue17860] subprocess docs lack info how to use output result

Changes by Ronald Oussoren : -- assignee: docs@python -> ronaldoussoren stage: needs patch -> commit review ___ Python tracker ___ ___

[issue17860] subprocess docs lack info how to use output result

anatoly techtonik added the comment: On Thu, Jun 13, 2013 at 9:20 AM, Ezio Melotti wrote: > > Also in the Python 3 docs we don't compare the current behavior with > Python 2. > That's most unfortunate. Major PITA comes from attempts to port existing code. -- __

[issue17860] subprocess docs lack info how to use output result

anatoly techtonik added the comment: _failed_ attempts to port existing code. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17860] subprocess docs lack info how to use output result

Amaury Forgeot d'Arc added the comment: Surely there are already good places to help with 2->3 transition? The Library Reference is not such a place. -- nosy: +amaury.forgeotdarc ___ Python tracker

[issue17860] subprocess docs lack info how to use output result

Roundup Robot added the comment: New changeset a2c2ffa1a41c by Ronald Oussoren in branch '3.3': Issue #17860: explicitly mention that std* streams are opened in binary mode by default. http://hg.python.org/cpython/rev/a2c2ffa1a41c New changeset ae8b054155c1 by Ronald Oussoren in branch 'default

[issue17860] subprocess docs lack info how to use output result

Ronald Oussoren added the comment: The documentation for 3.3 and default now explicitly mentions that the std* streams are opened as binary streams when universal_newlines is false. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed _

[issue17860] subprocess docs lack info how to use output result

Roundup Robot added the comment: New changeset f4747e1ce2b1 by Ronald Oussoren in branch '3.3': Cleanup of documentation change from #17860 http://hg.python.org/cpython/rev/f4747e1ce2b1 New changeset 83810f67d16b by Ronald Oussoren in branch 'default': (3.3->default) Cleanup of documentation cha