[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-05-03 Thread Aaron Oakley
New submission from Aaron Oakley: It would really help to document that the C API can only use the default xml.etree.ElementTree.TreeBuilder for targets with iterparse (and by extension, IncrementalParser). I got a nice surprise about that when I went from 3.2 to 3.3 and started getting "Type

[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-05-03 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +eli.bendersky stage: -> patch review versions: +Python 3.3 ___ Python tracker ___ ___ Python-bu

[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-05-18 Thread Eli Bendersky
Eli Bendersky added the comment: Aaron, could you please sign the PSF CLA (http://www.python.org/psf/contrib/contrib-form/) - this will make it accepting patches from you easier. Other than that, I agree it's a legit patch. The alternative would be to fix _elementtree to actually allow arbitr

[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-06-17 Thread Aaron Oakley
Aaron Oakley added the comment: So sorry, I just found the emails from the bug tracker in my spam folder. Anyhow, I've now signed the CLA. -- ___ Python tracker ___

[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-08-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset a5a5ba4f71ad by Eli Bendersky in branch '3.3': Issue #17902: Clarify doc of ElementTree.iterparse http://hg.python.org/cpython/rev/a5a5ba4f71ad New changeset 96f45011957e by Eli Bendersky in branch 'default': Issue #17902: Clarify doc of ElementTree

[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-08-03 Thread Eli Bendersky
Changes by Eli Bendersky : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-08-26 Thread Eli Bendersky
Eli Bendersky added the comment: Aaron - could you describe your use case of passing a custom parser into iterparse? We're currently considering deprecating the feature of passing a parser into iterparse in a future release (this is being discussed in issue 17741). -- ___

[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-08-26 Thread Aaron Oakley
Aaron Oakley added the comment: >From memory, the use case at the time was using a custom TreeBuilder sub-class >fed into a builtin XMLParser object. The code would construct a builder >separately and keep a reference to it around. The builder would delegate calls >to start(), data(), end(), a

[issue17902] Document that _elementtree C API cannot use custom TreeBuilder for iterparse or IncrementalParser

2013-08-26 Thread Eli Bendersky
Eli Bendersky added the comment: On Mon, Aug 26, 2013 at 7:11 PM, Aaron Oakley wrote: > > Aaron Oakley added the comment: > > >From memory, the use case at the time was using a custom TreeBuilder > sub-class fed into a builtin XMLParser object. The code would construct a > builder separately and