[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Christian Heimes added the comment: 2.7, 3.6 and master are fixed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Christian Heimes added the comment: New changeset 05b7d9c6675b71d17f5fcf379b3888fba431f14e by Christian Heimes in branch '2.7': [2.7] bpo-30714: ALPN changes for OpenSSL 1.1.0f (#3094) https://github.com/python/cpython/commit/05b7d9c6675b71d17f5fcf379b3888fba431f14e --

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Christian Heimes added the comment: New changeset 7f6a13bd562ff6a265fc63a991327feaecb07a77 by Christian Heimes in branch '3.6': [3.6] bpo-30714: ALPN changes for OpenSSL 1.1.0f (#3093) https://github.com/python/cpython/commit/7f6a13bd562ff6a265fc63a991327feaecb07a77 --

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Christian Heimes added the comment: New changeset 7b40cb7293cb14e5c7c8ed123efaf9acb33edae2 by Christian Heimes in branch 'master': bpo-30714: ALPN changes for OpenSSL 1.1.0f (#2305) https://github.com/python/cpython/commit/7b40cb7293cb14e5c7c8ed123efaf9acb33edae2 --

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Changes by Christian Heimes : -- pull_requests: +3133 ___ Python tracker ___ ___

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Changes by Christian Heimes : -- pull_requests: +3134 ___ Python tracker ___ ___

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Stéphane Wirtel added the comment: Dear Christian, Have you found a solution for this issue ? -- nosy: +matrixise ___ Python tracker ___

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Gregory P. Smith added the comment: Naturally up to the release managers. If I were one, I'd consider it just because not addressing the failure one way or another will lead to people finding us and asking a question about why it is failing. Adding a SkipTest when the relevant library

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

R. David Murray added the comment: Well, the reason one *might* consider a test failure as a release blocker (and I'm not saying you should, I'm just explaining the possible logic) is that distros would understandably like the test suite to pass before they include a release in their

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

STINNER Victor added the comment: Test still fails. Failure on AMD64 Debian PGO 2.7: http://buildbot.python.org/all/builders/AMD64%20Debian%20PGO%202.7/builds/243/steps/test/logs/stdio == FAIL: test_alpn_protocols

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

Changes by STINNER Victor : -- title: test_ssl fails with openssl 1.1.0f -> test_ssl fails with openssl 1.1.0f: test_alpn_protocols() ___ Python tracker

[issue30714] test_ssl fails with openssl 1.1.0f

Larry Hastings added the comment: Quoting from the Python Dev Guide: "As a guideline, critical and above are usually reserved for crashes, serious regressions or breakage of very important APIs. Whether a bug is a release blocker is a decision better left to the release manager so, in any

[issue30714] test_ssl fails with openssl 1.1.0f

Larry Hastings added the comment: I don't see how a fix for a *test* can be considered a *release blocker*. The PR literally doesn't change Python's behavior; it only modifies two text files and a test. There is no crash or exploitable security hole being addressed here. --

[issue30714] test_ssl fails with openssl 1.1.0f

Gregory P. Smith added the comment: I updated to PGO buildbot from Debian 8 "jessie" to Debian 9 "stretch" which revealed the failures. -- nosy: +gregory.p.smith ___ Python tracker

[issue30714] test_ssl fails with openssl 1.1.0f

STINNER Victor added the comment: The test now fails on AMD64 Debian PGO 3.x: http://buildbot.python.org/all/builders/AMD64%20Debian%20PGO%203.x/builds/985/steps/test/logs/stdio FAIL: test_alpn_protocols (test.test_ssl.ThreadedTests) -- ___ Python

[issue30714] test_ssl fails with openssl 1.1.0f

Ned Deily added the comment: Sorry, this didn't make it in time for 3.6.2. There is still at least a couple of weeks to get it into 3.5.4 and 2.7.14. -- ___ Python tracker

[issue30714] test_ssl fails with openssl 1.1.0f

Ned Deily added the comment: Sorry for the delay. It's clear this needs to get fixed so there's no need to wait to merge PRs into 3.6, 3.5, and 2.7. If the PR gets merged into 3.6 soon, I'll pull it into 3.6.2 as well. -- ___ Python tracker

[issue30714] test_ssl fails with openssl 1.1.0f

Changes by Christian Heimes : -- assignee: -> christian.heimes stage: -> patch review type: -> behavior ___ Python tracker ___

[issue30714] test_ssl fails with openssl 1.1.0f

Christian Heimes added the comment: Ned, I like to address this issue for 3.6.2. The fix only affects one test and documentation. -- nosy: +benjamin.peterson, larry, ned.deily priority: normal -> release blocker versions: +Python 2.7, Python 3.5, Python 3.7

[issue30714] test_ssl fails with openssl 1.1.0f

Changes by Christian Heimes : -- pull_requests: +2352 ___ Python tracker ___ ___

[issue30714] test_ssl fails with openssl 1.1.0f

Christian Heimes added the comment: I can confirm that OpenSSL has changed behavior of ALPN hook between 1.1.0e and 1.1.0f. The change was probably introduced by https://github.com/openssl/openssl/pull/3158/commits/b3159f23b293c3d1870ab7b816e4e07386efbe53 I need to investigate further.

[issue30714] test_ssl fails with openssl 1.1.0f

STINNER Victor added the comment: The ALPN test expects an error on OpenSSL >= 1.1, and an error on older OpenSSL versions. Note: I don't know what is ALPN :-) I found: https://en.wikipedia.org/wiki/Application-Layer_Protocol_Negotiation -- ___

[issue30714] test_ssl fails with openssl 1.1.0f

Charalampos Stratakis added the comment: Note: Python version is 3.6.1 -- versions: +Python 3.6 ___ Python tracker ___

[issue30714] test_ssl fails with openssl 1.1.0f

Changes by STINNER Victor : -- nosy: +christian.heimes, haypo ___ Python tracker ___

[issue30714] test_ssl fails with openssl 1.1.0f

New submission from Charalampos Stratakis: After updating openssl in Fedora 26 from 1.1.0e to 1.1.0f the test_alpn_protocols from test_ssl started failing: == FAIL: test_alpn_protocols (test.test_ssl.ThreadedTests)