[issue5804] Add an 'offset' argument to zlib.decompress

Martin Panter added the comment: A different test case for “unused_data” attribute was added in 2012 for Issue 16350, so that part is no longer needed. If this feature goes ahead, it might be nice to also update the bzip and LZMA modules for consistency. In Python 3, the equivalent of the buf

[issue5804] Add an 'offset' argument to zlib.decompress

R. David Murray added the comment: Moving this from commit review back to no selection, since there doesn't yet seem to be an agreement on an API. -- nosy: +r.david.murray stage: commit review -> versions: +Python 3.5 -Python 3.2 ___ Python tracker

[issue5804] Add an 'offset' argument to zlib.decompress

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue5804] Add an 'offset' argument to zlib.decompress

Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue5804] Add an 'offset' argument to zlib.decompress

Kristján Valur Jónsson added the comment: decompressobj is indeed "enough". But if you are doing a lot of this (decompressing chunks), then using the unused_data, as it is, involves a lot of copying. If there were a "unused_data_pos" or some equivalent, then it would be possible to continue

[issue5804] Add an 'offset' argument to zlib.decompress

Amaury Forgeot d'Arc added the comment: The function returns different kind of data depending on the value of the last parameter. I don't like it at all. Why is decompressobj not enough? -- nosy: +amaury.forgeotdarc ___ Python tracker

[issue5804] Add an 'offset' argument to zlib.decompress

Mark Lawrence added the comment: This has been reviewed see msg87550, can we get this into 3.2? -- nosy: +BreamoreBoy stage: patch review -> commit review versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker

[issue5804] Add an 'offset' argument to zlib.decompress

Robert Collins added the comment: Well, I think its relatively uncommon to be doing such a loop with a static buffer anyway - often you'll instead be reading from disk or a network stream; if we could make those cases simpler and avoid copying that would be great. Anyhow, no strong opinions her

[issue5804] Add an 'offset' argument to zlib.decompress

Robert Collins added the comment: Maybe I'm missing something, but isn't the offset parameter just another way of spelling buffer(input, offset)? I like the avoiding of copying, just wondering if having a magic parameter to get a tuple is really better than (say) result, used = zlib.decompress2

[issue5804] Add an 'offset' argument to zlib.decompress

Gregory P. Smith added the comment: Overall, this looks good. Some mostly minor comments in this review. http://codereview.appspot.com/63060/diff/1/2 File Doc/library/zlib.rst (right): http://codereview.appspot.com/63060/diff/1/2#newcode136 Line 136: When specified, it will cause the function

[issue5804] Add an 'offset' argument to zlib.decompress

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m