[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

SilentGhost added the comment: All the tests pass now, not sure why your patch doesn't get associated rietveld link, it applies cleanly using hg patch --no-commit -- ___ Python tracker

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

Wiktor Niesiobedzki added the comment: Maybe something like this? Doesn't look too complicated and I haven't noticed any breakage yet. -- keywords: +patch Added file: http://bugs.python.org/file41390/http.client.put.fix.patch ___ Python tracker

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

Wiktor Niesiobedzki added the comment: Here is revised patch. Also covers changes to tests. -- Added file: http://bugs.python.org/file41392/http.client.put.fix.patch ___ Python tracker

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

SilentGhost added the comment: There is a test suite which can be run to test for breakages: ./python -m test test_httplib If you do that you'll notice that some things are broken, I got error in 5 different tests related to you select.select call: TypeError: argument must be an int, or have

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

SilentGhost added the comment: That was a testing issue, apparently test.test_httplib.FakeSocket is not fake enough. -- ___ Python tracker ___

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

R. David Murray added the comment: Perhaps by doing non-blocking reads between the writes[*]? I suppose it is possible, but it might complicate the code considerably. [*] or re-write it using asyncio, but that is definitely out of scope :) -- nosy: +r.david.murray

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

Changes by SilentGhost : -- components: +Library (Lib) -IO versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python tracker ___

[issue25919] htp.client PUT method ignores error responses sent immediatly after headers

New submission from Wiktor Niesiobedzki: It looks like, when doing PUT together with a file-like object to send, http.client will try to send the whole file before analysing the response from the server. If you do the following: $ dd if=/dev/zero of=/tmp/300mb.zero bs=1M count=300 And then