Re: [Python-Dev] DRAFT: python-dev summary for 2005-11-16 to 2005-11-31

2005-12-18 Thread Martin v. Löwis
Steven Bethard wrote: > Note that because of the way the subversion conversion was done, > by-date revision specifications for dates prior to the switchover > won't work. To work around this, you can use svn diff (find the > changes since some date), svn up (check out revision a some date), and >

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Barry Warsaw
On Sun, 2005-12-18 at 23:48 +0100, "Martin v. Löwis" wrote: > What does that achieve? It will give you the latest revision at which > getbuildinfo was changed (currently 41744). Dunno. It's better than nothing I guess. -Barry signature.asc Description: This is a digitally signed message part

Re: [Python-Dev] Incorporation of zlib sources into Python subversion

2005-12-18 Thread Martin v. Löwis
Scott David Daniels wrote: > I am trying to enable other compression forms in zipfile, in > particular bzip2, but eventually extensible. My primary intent > is to extend the useful life of .zips by allowing better > compression (and enabling reading and writing zip formats that > are starting to b

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Martin v. Löwis
Barry Warsaw wrote: > Yes, here's my thought: I have a mod to Makefile.pre.in and > getbuildinfo.c so that when we don't find .svn directory, we don't > define the BUILD macro when we compile getbuildinfo.c. Then, in that > file we have something like: > > #ifndef BUILD > #define BUILD "$Revision

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Barry Warsaw
On Sun, 2005-12-18 at 19:19 +0100, "Martin v. Löwis" wrote: > It stopped counting builds on Windows quite some time ago; perhaps it > is best to drop the build number entirely? I think so, because it doesn't really convey anything useful. -Barry signature.asc Description: This is a digitally

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Barry Warsaw
On Sun, 2005-12-18 at 18:58 +0100, Armin Rigo wrote: > On Sat, Dec 17, 2005 at 08:28:17PM -0500, Barry Warsaw wrote: > > Done. r41744. > > Doesn't appear to work for me: sys.build_number receives the value from > the buildno. Looking at the Makefile, the reason is that I'm building > CPython in a

Re: [Python-Dev] Incorporation of zlib sources into Python subversion

2005-12-18 Thread Scott David Daniels
Martin v. Löwis wrote: > Thomas (Heller) and I have been discussing whether the zlib > module should become builtin, atleast on Win32 (i.e. part > of python25.dll). This would simplify py2exe, which then could > bootstrap extraction from the compressed file just with > pythonxy.dll (clearly, zlib.p

Re: [Python-Dev] fixing log messages

2005-12-18 Thread Fredrik Lundh
Martin v. Löwis wrote: > I have now installed this hook to allow editing svn:log; please try > again. $ svn propedit --revprop -r 41759 svn:log Set new value for property 'svn:log' on revision 41759 thanks! /F ___ Python-Dev mailing list Python-Dev

Re: [Python-Dev] fixing log messages

2005-12-18 Thread Martin v. Löwis
Fredrik Lundh wrote: > just noticed an embarrasing misspelling in one of my recent checkins, only > to find that I cannot fix it: > > $ svn propedit --revprop -r 41759 svn:log > svn: Repository has not been enabled to accept revision propchanges; > ask the administrator to create a pre-revprop-ch

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Michael Hudson
"Martin v. Löwis" <[EMAIL PROTECTED]> writes: > It stopped counting builds on Windows quite some time ago; perhaps it > is best to drop the build number entirely? +1. I don't see how the information it contributes is meaningful in any way. Cheers, mwh -- Gullible editorial staff continues t

[Python-Dev] fixing log messages

2005-12-18 Thread Fredrik Lundh
just noticed an embarrasing misspelling in one of my recent checkins, only to find that I cannot fix it: $ svn propedit --revprop -r 41759 svn:log svn: Repository has not been enabled to accept revision propchanges; ask the administrator to create a pre-revprop-change hook $ would it be a good i

Re: [Python-Dev] fresh checkout won't build

2005-12-18 Thread Martin v. Löwis
Fredrik Lundh wrote: >>what am I missing ? > > > a C++ compiler, obviously, the arena code used C++ (C99?) constructs > in a couple of places. I've checked in a fix. C99 also allows to declare variables in the middle of a block. Regards, Martin ___

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Reinhold Birkenfeld
Martin v. Löwis wrote: > Propose first. I have the feeling that the feature will change forth > and back if everybody gets to say something. I would call it > sys.svnversion (because that's what it is). Perhaps it could make sense for sys.svnversion to exist only in a debug build. This way people

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Martin v. Löwis
Armin Rigo wrote: > Do we have any plan to make sys.build_number meaningful in the releases > as well (generally compiled from an svn export, as Michael pointed out), > or are we happy with a broken number in this case? I'm actually a bit confused that Barry changed the meaning of "build number" f

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Fredrik Lundh
Armin Rigo wrote: > Should I propose / check-in a patch to expose sys.build_info instead > ("CPython", "41761", "trunk"), as this got positive feedback so far? > It's also less surprizing than the current sys.build_number, which is a > string despite its name. fwiw, I'm still +1 on that. ___

Re: [Python-Dev] Expose Subversion revision number to Python

2005-12-18 Thread Armin Rigo
Hi Barry, On Sat, Dec 17, 2005 at 08:28:17PM -0500, Barry Warsaw wrote: > Done. r41744. Doesn't appear to work for me: sys.build_number receives the value from the buildno. Looking at the Makefile, the reason is that I'm building CPython in a separate directory (running '/some/path/configure; ma

Re: [Python-Dev] fresh checkout won't build

2005-12-18 Thread Fredrik Lundh
> $ svn up > At revision 41759. > $ make > ... > Python/compile.c: In function `PyNode_Compile': > Python/compile.c:301: parse error before `mod' > Python/compile.c:302: `mod' undeclared (first use in this function) > Python/compile.c:302: (Each undeclared identifier is reported only once > Python/

[Python-Dev] fresh checkout won't build

2005-12-18 Thread Fredrik Lundh
$ svn up At revision 41759. $ make ... Python/compile.c: In function `PyNode_Compile': Python/compile.c:301: parse error before `mod' Python/compile.c:302: `mod' undeclared (first use in this function) Python/compile.c:302: (Each undeclared identifier is reported only once Python/compile.c:302: for

Re: [Python-Dev] ref leak in element tree/pyexpat

2005-12-18 Thread Fredrik Lundh
Neal Norwitz wrote: > I'm not sure where the problem is, but this code leaks a reference: >parser = ET.XMLParser() ; parser.feed('text') > > You need this to set it up: > from xmlcore.etree import cElementTree as ET > > This isn't a memory leak according to valgrind. looks like it's stealin

Re: [Python-Dev] ref leak in element tree/pyexpat

2005-12-18 Thread Martin v. Löwis
Neal Norwitz wrote: > Also, I noticed several places where errors where being ignored. What > is the procedure for the element tree? Are we supposed to modify it > in the python SVN or treat it as read-only? You should add a bug report on sf.net/projects/python, and assign that to Fredrik Lundh.

[Python-Dev] Incorporation of zlib sources into Python subversion

2005-12-18 Thread Martin v. Löwis
Thomas (Heller) and I have been discussing whether the zlib module should become builtin, atleast on Win32 (i.e. part of python25.dll). This would simplify py2exe, which then could bootstrap extraction from the compressed file just with pythonxy.dll (clearly, zlib.pyd cannot be *in* the compressed