Xqt added a comment.
Since all of you recommend doing it the index way
Oh, I am fine with regex which might be less complex than index search implementation here.TASK DETAILhttps://phabricator.wikimedia.org/T200399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/T
Shreyasminocha added a comment.
@Framawiki Would it suffice if I handle only:
1. Georgia (Country)
2. Georgia (Something) (Country) // here it would remove both
with the index approach?
The following will break stuff:
3. Georgia ((Country))
4. Georgia (Country
5. Georgia Country)
Are any of th
Shreyasminocha added a comment.
@Xyt To clarify, I haven't implemented the second approach. We have two options—the regex-based approach I illustrated or an index-based approach (looping over the characters in the string, looking for an open parenthesis and trimming everything after that or a more
Xqt added a comment.
@D3r1ck01 @Xqt and others:
Do you prefer a regex or an index approach here ? The second looks cleaner to me.
Sorry, I don’t have it. Could you show me the different approach?
What about implementing this as a param like withoutDisambiguation in page.title() method? That woul
D3r1ck01 added a comment.
@Framawiki, will start creating corresponding GCI tasks for this and will tag us as mentors during the weekend. Thanks :)TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: F
D3r1ck01 updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION/scripts/listpages.py:161:17: W504 line break after binary operator
./scripts/welcome.py:800:31: W504 line break after binary operator
./scripts/nowcommons.py:278:25: W504 line break after binary operator...TASK DE
D3r1ck01 added a comment.
@Framawiki, if it's per this, https://gerrit.wikimedia.org/r/c/pywikibot/core/+/470627, then I'll say regex solutions become really confusing if they're trying to solve a complex problem hence making it difficult for one to understand a code base if we have many of them. R
Framawiki added a comment.
Will mentor too.TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, gerritbot, Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, Wenyi, Kieubinhtb, Wonnral, Asad
Framawiki removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avi
gerritbot added a comment.
Change 470550 merged by jenkins-bot:
[pywikibot/core@master] [deprecated] Use latest_file_info.user instead of getLatestUploader()[0]
https://gerrit.wikimedia.org/r/470550TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.o
Framawiki added a subscriber: D3r1ck01.Framawiki added a comment.
@D3r1ck01 @Xqt and others:
Do you prefer a regex or an index approach here ? The second looks cleaner to me.
What about implementing this as a param like withoutDisambiguation in page.title() method? That would allow to easily reuse
Multichill added a comment.
In T208292#4705393, @Xqt wrote:
Hm, this script never worked. Do we need it ;)
It worked, but someone broke it.
Tons of things have changed in the library part, but I don't think impact on the scripts that are using it is noticed enough.TASK DETAILhttps://phabricator
Dalba closed this task as "Resolved".Dalba assigned this task to matej_suchanek.Dalba added a comment.
Thanks, Matěj!TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, DalbaCc: matej_suchanek, Lo
matej_suchanek added a comment.
There was an error on test.wikidata: https://test.wikidata.org/w/index.php?title=Q123&oldid=314870#P10. I restored the earliest revision of the item.TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/
Xqt reassigned this task from Xqt to matej_suchanek.
TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, XqtCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi,
Xqt closed this task as "Resolved".Xqt claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420,
Xqt triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: matej_suchanek, Lokal_Profil, Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avice
Shreyasminocha claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T200399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ShreyasminochaCc: Liuxinyu970226, revi, jayvdb, JAnD, Framawiki, matej_suchanek, Xqt, Aklapper, pywikibot-bugs-list, Bugreport
Dalba added a project: Pywikibot-Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb,
Dalba created this task.Dalba added projects: Pywikibot, Pywikibot-tests.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONhttps://travis-ci.org/wikimedia/pywikibot/jobs/448209151
__ TestWikibaseCoordinateNonDry.test_Coordinate_get_globe_item_different_repo _
gerritbot added a comment.
Change 469930 merged by jenkins-bot:
[pywikibot/core@master] [Bugfix] Check appropriate key in Site.messages
https://gerrit.wikimedia.org/r/469930TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpr
Xqt removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Wenyi, AndyTan, Zylc, 1978Gage2
Xqt added a comment.
Hm, this script never worked. Do we need it ;)TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wen
Xqt triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, M
gerritbot added a comment.
Change 470550 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [deprecated] Use latest_file_info.user instead of getLatestUploader()[0]
https://gerrit.wikimedia.org/r/470550TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCE
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Ve
gerritbot added a comment.
Change 469049 merged by jenkins-bot:
[pywikibot/core@master] [test] Temporary accept imagecopy_tests.py failing
https://gerrit.wikimedia.org/r/469049TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emai
Dvorapa added a comment.
@Xqt I thought Magnus will be faster (he was for the first problem), the test disabling patch would be useless for one day, but now I think we can disable the tests until Magnus will have the time to fix the tool properly.TASK DETAILhttps://phabricator.wikimedia.org/T207579
Xqt created this task.Xqt added a project: Pywikibot.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONThere is a sample for this script given in the doc but it fails:
C:\pwb\GIT\core>pwb.py imagecopy -newimages:100
Retrieving 49 pages from wikipedia:de.
WARN
Xqt added a comment.
@Dvorapa: why shouldn't we disable thoses tests temporarily with that patch committed in https://gerrit.wikimedia.org/r/469049? The problem is noted here and it seems not easy to solve. All further travis and appveyor tests are failing now and there is no focus to other tests w
30 matches
Mail list logo