Hi Stefan,
I have sent a version 2 and it should fix this issue.
I also test it several times and I did not meet this issue again.
Thanks for your report.
Best Regards
Jin
> -Original Message-
> From: Stefan Hajnoczi
> Sent: Tuesday, November 3, 2020 12:57 AM
>
Virtqueue has split and packed, so before setting inflight,
you need to inform the back-end virtqueue format.
Signed-off-by: Jin Yu
Acked-by: Raphael Norwitz
---
v2:
* Fixed the segfault.
---
hw/block/vhost-user-blk.c | 6 ++
hw/virtio/vhost.c | 20
include/hw/
Patchew URL:
https://patchew.org/QEMU/bb45d748-01e4-2fde-9fe3-32a7db4b6...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: bb45d748-01e4-2fde-9fe3-32a7db4b6...@huawei.com
Subject: [PATCH] crypto: Add spaces
I am reading crypto related code, find some code style problems while
using checkpatch.pl to check crypto folder. Fix the error style
problems.
Signed-off-by: Liyang Shi
---
crypto/aes.c | 6 +++---
crypto/desrfb.c | 2 +-
crypto/tlscredsx509.c | 2 +-
3 files changed, 5 insertio
For debugging purpose, trace where DMA regions are mapped.
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
util/vfio-helpers.c | 3 ++-
util/trace-events | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/util/vfio-helpers.
The QEMU_VFIO_DEBUG definition is only modifiable at build-time.
Trace events can be enabled at run-time. As we prefer the latter,
convert qemu_vfio_dump_mappings() to use trace events instead
of fprintf().
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
mmap(2) states:
'offset' must be a multiple of the page size as returned
by sysconf(_SC_PAGE_SIZE).
Add an assertion to be sure we don't break this contract.
Signed-off-by: Philippe Mathieu-Daudé
---
util/vfio-helpers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/vfio-helpers
For debugging purpose, trace where a BAR is mapped.
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
util/vfio-helpers.c | 2 ++
util/trace-events | 1 +
2 files changed, 3 insertions(+)
diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
inde
We sometime get kernel panic with some devices on Aarch64
hosts. Alex Williamson suggests it might be broken PCIe
root complex. Add trace event to record the latest I/O
access before crashing. In case, assert our accesses are
aligned.
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-of
For debug purpose, trace BAR regions info.
Reviewed-by: Fam Zheng
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Philippe Mathieu-Daudé
---
util/vfio-helpers.c | 8
util/trace-events | 1 +
2 files changed, 9 insertions(+)
diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
index 1
v3:
- Extract reviewed patches from
"util/vfio-helpers: Allow using multiple MSIX IRQs"
- Added "Assert offset is aligned to page size"
which would have helped debugging:
"block/nvme: Fix use of write-only doorbells page on Aarch64 arch"
Missing review: 7
Based-on: <20201029093306.1063879-1
Change the confuse "VFIO IOMMU check failed" error message by
the explicit "VFIO IOMMU Type1 is not supported" once.
Example on POWER:
$ qemu-system-ppc64 -drive
if=none,id=nvme0,file=nvme://0001:01:00.0/1,format=raw
qemu-system-ppc64: -drive
if=none,id=nvme0,file=nvme://0001:01:00.0/1,format
a10903940501b43e8c0cc67af7c06d5:
>
> Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026'
> into staging (2020-10-26 17:19:26 +)
>
> are available in the Git repository at:
>
> git://git.infradead.org/qemu-nvme.
On Fri, 23 Oct 2020 at 16:22, Stefan Hajnoczi wrote:
>
> From: Coiby Xu
>
> By making use of libvhost-user, block device drive can be shared to
> the connected vhost-user client. Only one client can connect to the
> server one time.
>
> Since vhost-user-server needs a block drive to be created fi
On Mon, Nov 02, 2020 at 05:43:19AM -0500, Michael S. Tsirkin wrote:
> On Fri, Oct 30, 2020 at 08:42:22AM -0400, Michael S. Tsirkin wrote:
> > On Tue, Oct 27, 2020 at 05:35:16PM +, Stefan Hajnoczi wrote:
> > > This patch series solves some issues with the new vhost-user-blk-server
> > > and
> >
This reverts commit adb29c027341ba095a3ef4beef6aaef86d3a520e.
The commit broke -device vhost-user-blk-pci because the
vhost_dev_prepare_inflight() function it introduced segfaults in
vhost_dev_set_features() when attempting to access struct vhost_dev's
vdev pointer before it has been assigned.
To
f7c06d5:
>
> Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026'
> into staging (2020-10-26 17:19:26 +)
>
> are available in the Git repository at:
>
> git://git.infradead.org/qemu-nvme.git tags/pull-nvme-20201102
>
> for yo
ab/tags/sd-next-20201026'
into staging (2020-10-26 17:19:26 +)
are available in the Git repository at:
git://git.infradead.org/qemu-nvme.git tags/pull-nvme-20201102
for you to fetch changes up to 843c8f91a7ad63f8f3e4e564d3f41f3d030ab8a9:
hw/block/nvme: fix queue identifer validation
On 21/10/2020 07:40, Volker Rümelin wrote:
Commit 9ce44e2ce2 "qmp: Move dispatcher to a coroutine" modified
aio_poll() in util/aio-posix.c to avoid an assertion failure. This
change is missing in util/aio-win32.c.
Apply the changes to util/aio-posix.c to util/aio-win32.c too.
This fixes an asse
We should use printf format specifier "%u" instead of "%d" for
argument of type "unsigned int".
In addition, fix two error format problems found by checkpatch.pl:
ERROR: space required after that ',' (ctx:VxV)
+fprintf(stderr,"%s attributes=0x%02x begin=%u size=%d\n",
On Fri, Oct 30, 2020 at 08:42:22AM -0400, Michael S. Tsirkin wrote:
> On Tue, Oct 27, 2020 at 05:35:16PM +, Stefan Hajnoczi wrote:
> > This patch series solves some issues with the new vhost-user-blk-server and
> > adds the qtest test case. The test case was not included in the pull request
> >
@sn_opts is initialized at the beginning, so it should be deleted
after jumping to the lable 'fail_getopt'
Signed-off-by: Guoyi Tu
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 2103507..229cdf9 100644
--- a/qemu-img.c
+++ b/qemu-
On 01/11/20 17:15, Maxim Levitsky wrote:
> While most of the patches in V1 of this series are already merged upstream,
> the patch that fixes iotest 240 was broken on s390 and was not accepted.
>
> This is an updated version of this patch, based on Paulo's suggestion,
> that hopefully makes
23 matches
Mail list logo
