[PATCH 4/6] hw/block/nvme: support allocated namespace type

2021-02-05 Thread Minwoo Im
>From NVMe spec 1.4b "6.1.5. NSID and Namespace Relationships" defines valid namespace types: - Unallocated: Not exists in the NVMe subsystem - Allocated: Exists in the NVMe subsystem - Inactive: Not attached to the controller - Active: Attached to the controller T

[PATCH 5/6] hw/block/nvme: refactor nvme_select_ns_iocs

2021-02-05 Thread Minwoo Im
This patch has no functional changes. This patch just refactored nvme_select_ns_iocs() to iterate the attached namespaces of the controlller and make it invoke __nvme_select_ns_iocs(). Signed-off-by: Minwoo Im --- hw/block/nvme.c | 36 +--- 1 file changed, 21 ins

[PATCH 3/6] hw/block/nvme: fix allocated namespace list to 256

2021-02-05 Thread Minwoo Im
Expand allocated namespace list (subsys->namespaces) to have 256 entries which is a value lager than at least NVME_MAX_NAMESPACES which is for attached namespace list in a controller. Allocated namespace list should at least larger than attached namespace list. n->num_namespaces = NVME_MA

[PATCH 1/6] hw/block/nvme: support namespace detach

2021-02-05 Thread Minwoo Im
Given that now we have nvme-subsys device supported, we can manage namespace allocated, but not attached: detached. This patch introduced a parameter for nvme-ns device named 'detached'. This parameter indicates whether the given namespace device is detached from a entire NVMe subsystem('subsys'

[PATCH 6/6] hw/block/nvme: support namespace attachment command

2021-02-05 Thread Minwoo Im
This patch supports Namespace Attachment command for the pre-defined nvme-ns device nodes. Of course, attach/detach namespace should only be supported in case 'subsys' is given. This is because if we detach a namespace from a controller, somebody needs to manage the detached, but allocated namesp

[PATCH 2/6] hw/block/nvme: fix namespaces array to 1-based

2021-02-05 Thread Minwoo Im
subsys->namespaces array used to be sized to NVME_SUBSYS_MAX_NAMESPACES. But subsys->namespaces are being accessed with 1-based namespace id which means the very first array entry will always be empty(NULL). Signed-off-by: Minwoo Im --- hw/block/nvme-subsys.h | 2 +- 1 file changed, 1 insertion(

[PATCH 0/6] hw/block/nvme: support namespace attachment

2021-02-05 Thread Minwoo Im
Hello, This series supports namespace attachment: attach and detach. It means that this series also introduced a scheme for allocated namespace which is detached, but allocated in a NVMe subsystem. Given that now we have nvme-subsys device to specify a NVMe subsystem, it can manage detached name

Re: [PULL v3 00/27] Block patches

2021-02-05 Thread Peter Maydell
On Fri, 5 Feb 2021 at 16:45, Stefan Hajnoczi wrote: > > The following changes since commit e2c5093c993ef646e4e28f7aa78429853bcc06ac: > > iotests: 30: drop from auto group (and effectively from make check) > (2021-02-05 15:16:13 +) > > are available in the Git repository at: > > https://gi

Re: [PATCH v2] qemu-nbd: Use SOMAXCONN for socket listen() backlog

2021-02-05 Thread Richard W.M. Jones
On Fri, Feb 05, 2021 at 12:57:05PM -0600, Eric Blake wrote: > Our default of a backlog of 1 connection is rather puny, particularly > for scenarios where we expect multiple listeners to connect (such as > qemu-nbd -e X). This is especially important for Unix sockets, as a > definite benefit to cli

Re: [PATCH 2/4] hw/block/fdc: Remove the check_media_rate property

2021-02-05 Thread John Snow
On 2/5/21 1:37 AM, Thomas Huth wrote: On 05/02/2021 01.40, John Snow wrote: On 2/3/21 12:18 PM, Thomas Huth wrote: This was only required for the pc-1.0 and earlier machine types. Now that these have been removed, we can also drop the corresponding code from the FDC device. Signed-off-by: Thom

Re: [PATCH v2] qemu-nbd: Use SOMAXCONN for socket listen() backlog

2021-02-05 Thread Nir Soffer
On Fri, Feb 5, 2021 at 8:57 PM Eric Blake wrote: > > Our default of a backlog of 1 connection is rather puny, particularly > for scenarios where we expect multiple listeners to connect (such as > qemu-nbd -e X). This is especially important for Unix sockets, as a > definite benefit to clients: at

Re: [PATCH] sockets: Use SOMAXCONN for Unix socket listen()

2021-02-05 Thread Eric Blake
On 2/5/21 3:55 AM, Daniel P. Berrangé wrote: >> +++ b/util/qemu-sockets.c >> @@ -1059,7 +1059,7 @@ int unix_listen(const char *str, Error **errp) >> >> saddr = g_new0(UnixSocketAddress, 1); >> saddr->path = g_strdup(str); >> -sock = unix_listen_saddr(saddr, 1, errp); >> +sock = u

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Keith Busch
On Sat, Feb 06, 2021 at 01:48:29AM +0900, Minwoo Im wrote: > Not sure if this is okay just give ctrl->tagset for the head > request_queue, but this patch works fine as far. Huh, that's probably not supposed to work: bio-based drivers should never use tagsets. Since this is getting a little more c

[PATCH v2] qemu-nbd: Use SOMAXCONN for socket listen() backlog

2021-02-05 Thread Eric Blake
Our default of a backlog of 1 connection is rather puny, particularly for scenarios where we expect multiple listeners to connect (such as qemu-nbd -e X). This is especially important for Unix sockets, as a definite benefit to clients: at least on Linux, a client trying to connect to a Unix socket

Re: [PATCH v2 30/36] block: bdrv_reopen_multiple: refresh permissions on updated graph

2021-02-05 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > Move bdrv_reopen_multiple to new paradigm of permission update: > first update graph relations, then do refresh the permissions. > > We have to modify reopen process in file-posix driver: with new scheme > we don't have prepare

[PATCH v2 7/8] tests/fp/fp-test: Replace the word 'blacklist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Acked-by: Alex Bennée Reviewed-by: Daniel P. Berrangé Signed-off-

[PATCH v2 6/8] qemu-options: Replace the word 'blacklist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Signed-off-by: Philippe Mathieu-Daudé --- v2: Reword (danpb) ---

[PATCH v2 2/8] tools/virtiofsd: Replace the word 'whitelist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the words "whitelist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berran

Re: [PATCH 2/9] tests/qtest: Restrict xlnx-can-test to TCG builds

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/5/21 5:57 PM, Peter Maydell wrote: > On Fri, 5 Feb 2021 at 14:43, Philippe Mathieu-Daudé wrote: >> >> The Xilinx CAN controller test is uses the ZCU102 board which is >> based on a ZynqMP SoC. In the default configuration - used by this >> test - this SoC creates 2 Cortex R5F cores. Such core

Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

2021-02-05 Thread Eric Blake
On 1/26/21 3:31 AM, Markus Armbruster wrote: > Eric Blake writes: > >> These cases require a bit more thought to review; in each case, the >> code was appending to a list, but not with a FOOList **tail variable. >> >> Signed-off-by: Eric Blake >> Reviewed-by: Vladimir Sementsov-Ogievskiy >> >>

[PATCH v2 8/8] hw/vfio/pci-quirks: Replace the word 'blacklist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Alex Williamson Acked-by: Alex Williamson Reviewed-b

[PATCH v2 4/8] scripts/device-crash-test: Replace the word 'whitelist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "whitelist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Da

[PATCH v2 5/8] seccomp: Replace the word 'blacklist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the word "blacklist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Daniel P. Berrangé Acked-by: Eduardo Otubo Signed-of

[PATCH v2 0/8] misc: Replace the words 'blacklist/whitelist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the words "blacklist" and "whitelist" appropriately. Since v1: - dropped qemu-guest-agent patches - addressed review comments - added R-b tags Missing review: PATCH #6 "qemu-opti

[PATCH v2 1/8] ui: Replace the word 'whitelist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the words "whitelist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Gerd Hoffmann Signed-off-by: Philippe Mathieu-Daudé

[PATCH v2 3/8] scripts/tracetool: Replace the word 'whitelist'

2021-02-05 Thread Philippe Mathieu-Daudé
Follow the inclusive terminology from the "Conscious Language in your Open Source Projects" guidelines [*] and replace the words "whitelist" appropriately. [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md Reviewed-by: Daniel P. Berrangé Reviewed-by: Stefan Hajnoczi Sig

Re: [PATCH 2/9] tests/qtest: Restrict xlnx-can-test to TCG builds

2021-02-05 Thread Peter Maydell
On Fri, 5 Feb 2021 at 14:43, Philippe Mathieu-Daudé wrote: > > The Xilinx CAN controller test is uses the ZCU102 board which is > based on a ZynqMP SoC. In the default configuration - used by this > test - this SoC creates 2 Cortex R5F cores. Such cores are not > v8A archicture, thus can not be ru

[PULL v3 26/27] multi-process: perform device reset in the remote process

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Perform device reset in the remote process when QEMU performs device reset. This is required to reset the internal state (like registers, etc...) of emulated devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Daniel P . Berrangé
On Fri, Feb 05, 2021 at 05:52:59PM +0100, Thomas Huth wrote: > On 05/02/2021 17.23, Peter Maydell wrote: > > On Fri, 5 Feb 2021 at 16:21, Stefan Hajnoczi wrote: > > > Thanks, I update the patch in question. > > > > > > It looks like the GitLab CI doesn't include a clang version that > > > produce

[PULL v3 24/27] multi-process: create IOHUB object to handle irq

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD ioctl to create irqfd to injecting PCI interrupts to the guest. IOHUB object forwards the irqfd to the remote process. Remote process uses this fd to directly send interrupts to the guest, bypassing QEMU. Signed-

[PULL v3 23/27] multi-process: Synchronize remote memory

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Add ProxyMemoryListener object which is used to keep the view of the RAM in sync between QEMU and remote process. A MemoryListener is registered for system-memory AddressSpace. The listener sends SYNC_SYSMEM message to the remote process when memory listener commits the ch

Re: [PATCH 2/9] tests/qtest: Restrict xlnx-can-test to TCG builds

2021-02-05 Thread Alistair Francis
On Fri, Feb 5, 2021 at 6:45 AM Philippe Mathieu-Daudé wrote: > > The Xilinx CAN controller test is uses the ZCU102 board which is > based on a ZynqMP SoC. In the default configuration - used by this > test - this SoC creates 2 Cortex R5F cores. Such cores are not > v8A archicture, thus can not be

[PULL v3 18/27] multi-process: setup memory manager for remote device

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman SyncSysMemMsg message format is defined. It is used to send file descriptors of the RAM regions to remote device. RAM on the remote device is configured with a set of file descriptors. Old RAM regions are deleted and new regions, each with an fd, is added to the RAM. Sign

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Thomas Huth
On 05/02/2021 17.23, Peter Maydell wrote: On Fri, 5 Feb 2021 at 16:21, Stefan Hajnoczi wrote: Thanks, I update the patch in question. It looks like the GitLab CI doesn't include a clang version that produces this error because the pipeline passed for me: https://gitlab.com/stefanha/qemu/-/pipe

[PULL v3 27/27] docs: fix Parallels Image "dirty bitmap" section

2021-02-05 Thread Stefan Hajnoczi
From: "Denis V. Lunev" Original specification says that l1 table size if 64 * l1_size, which is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. Thus 64 is to be replaces with 8 as specification says about bytes. There is also minor tweak, field name is renamed from l1 to l1_ta

[PULL v3 25/27] multi-process: Retrieve PCI info from remote process

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Retrieve PCI configuration info about the remote device and configure the Proxy PCI object based on the returned information Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 85ee367

[PULL v3 20/27] multi-process: add proxy communication functions

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: d54edb4176361eed86b903e8f27058363b6c83b3.1611938319.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi --- include/hw/remote/mpq

[PULL v3 19/27] multi-process: introduce proxy object

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Defines a PCI Device proxy object as a child of TYPE_PCI_DEVICE. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: b5186ebfedf8e557044d09a768846c59230ad3a7.1611938319.git.jag.ra...@ora

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Minwoo Im
On 21-02-06 01:43:18, Minwoo Im wrote: > On 21-02-05 08:22:52, Keith Busch wrote: > > On Sat, Feb 06, 2021 at 01:07:57AM +0900, Minwoo Im wrote: > > > If multipath is enabled, the namespace head and hidden namespace will be > > > created. In this case, /sys/block/nvme0n1/queue/nr_zones are not > >

[PULL v3 17/27] multi-process: Associate fd of a PCIDevice with its object

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Associate the file descriptor for a PCIDevice in remote process with DeviceState object. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: f405a2ed5d7518b87bea7c59cfdf334d67e5ee51.16

[PULL v3 16/27] multi-process: Initialize message handler in remote device

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Initializes the message handler function in the remote process. It is called whenever there's an event pending on QIOChannel that registers this function. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan

[PULL v3 22/27] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Proxy device object implements handler for PCI BAR writes and reads. The handler uses BAR_WRITE/BAR_READ message to communicate to the remote process with the BAR address and value to be written/read. The remote process implements handler for BAR_WRITE/BAR_READ message. S

[PULL v3 14/27] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds qio_channel_readv_full_all_eof() and qio_channel_readv_full_all() to read both data and FDs. Refactors existing code to use these helpers. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Acked-by: Daniel P. Berrangé Mes

[PULL v3 21/27] multi-process: Forward PCI config space acceses to the remote process

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva The Proxy Object sends the PCI config space accesses as messages to the remote process over the communication channel Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: d3c94f4618813234

[PULL v3 12/27] multi-process: setup a machine object for remote device process

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman x-remote-machine object sets up various subsystems of the remote device process. Instantiate PCI host bridge object and initialize RAM, IO & PCI memory regions. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: S

[PULL v3 10/27] multi-process: Add config option for multi-process QEMU

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Add configuration options to enable or disable multiprocess QEMU code Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva Reviewed-by: Stefan Hajnoczi Message-id: 6cc37253e35418ebd7b675a31a3df6e3c7a12dc1.1611938319.git.jag.ra

[PULL v3 15/27] multi-process: define MPQemuMsg format and transmission functions

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Defines MPQemuMsg, which is the message that is sent to the remote process. This message is sent over QIOChannel and is used to command the remote process to perform various tasks. Define transmission functions used by proxy and by remote. Signed-off-by: Jagannathan Raman

[PULL v3 13/27] io: add qio_channel_writev_full_all helper

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds qio_channel_writev_full_all() to transmit both data and FDs. Refactors existing code to use this helper. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Acked-by: Daniel P. Berrangé Message

[PULL v3 09/27] memory: alloc RAM from file at offset

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva

[PULL v3 00/27] Block patches

2021-02-05 Thread Stefan Hajnoczi
The following changes since commit e2c5093c993ef646e4e28f7aa78429853bcc06ac: iotests: 30: drop from auto group (and effectively from make check) (2021-02-05 15:16:13 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to fetch

[PULL v3 08/27] multi-process: add configure and usage information

2021-02-05 Thread Stefan Hajnoczi
From: Elena Ufimtseva Adds documentation explaining the command-line arguments needed to use multi-process. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi Message-id: 49f757a84e5dd6fae14b22544897d1124c5fdbad.1611938

[PULL v3 06/27] get_maintainer: update repo URL to GitLab

2021-02-05 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL v3 01/27] .github: point Repo Lockdown bot to GitLab repo

2021-02-05 Thread Stefan Hajnoczi
Use the GitLab repo URL as the main repo location in order to reduce load on qemu.org. Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Message-id: 2021015017.156802-2-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- .github/lockdown.y

[PULL v3 11/27] multi-process: setup PCI host bridge for remote device

2021-02-05 Thread Stefan Hajnoczi
From: Jagannathan Raman PCI host bridge is setup for the remote device process. It is implemented using remote-pcihost object. It is an extension of the PCI host bridge setup by QEMU. Remote-pcihost configures a PCI bus which could be used by the remote PCI device to latch on to. Signed-off-by:

[PULL v3 07/27] multi-process: add the concept description to docs/devel/qemu-multiprocess

2021-02-05 Thread Stefan Hajnoczi
From: John G Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi Message-id: 02a68adef99f5df6a380bf8fd7b90948777e411c.1611938319.git.jag.ra...@oracle.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Minwoo Im
On 21-02-05 08:22:52, Keith Busch wrote: > On Sat, Feb 06, 2021 at 01:07:57AM +0900, Minwoo Im wrote: > > If multipath is enabled, the namespace head and hidden namespace will be > > created. In this case, /sys/block/nvme0n1/queue/nr_zones are not > > returning proper value for the namespace itsel

[PULL v3 04/27] docs: update README to use GitLab repo URLs

2021-02-05 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL v3 03/27] gitlab-ci: remove redundant GitLab repo URL command

2021-02-05 Thread Stefan Hajnoczi
It is no longer necessary to point .gitmodules at GitLab repos when running in GitLab CI since they are now used all the time. Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-id: 2021015017.156802-

[PULL v3 05/27] pc-bios: update mirror URLs to GitLab

2021-02-05 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PULL v3 02/27] gitmodules: use GitLab repos instead of qemu.org

2021-02-05 Thread Stefan Hajnoczi
qemu.org is running out of bandwidth and the QEMU project is moving towards a gating CI on GitLab. Use the GitLab repos instead of qemu.org (they will become mirrors). Signed-off-by: Stefan Hajnoczi Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-

[PATCH v2 08/10] iotests/264: add mirror-cancel test-case

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/264 | 38 ++ tests/qemu-iotests/264.out | 4 ++-- 2 files changed, 32 insertions(+), 10 deletions(

[PATCH v2 05/10] block/mirror: implement .cancel job handler

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/mirror.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 8e1ad6eceb..9faffe4707 100644 --- a/block/mirror.c +++ b

[PATCH v2 04/10] job: add .cancel handler for the driver

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
To be used in mirror in the following commit to cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/job.h | 5 + job.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/include/qemu/job.h b/include/qemu/job.h in

[PATCH v2 10/10] iotests/264: add backup-cancel test-case

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/264 | 21 ++--- tests/qemu-iotests/264.out | 4 ++-- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/t

[PATCH v2 02/10] block/nbd: implement .bdrv_cancel_in_flight

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Just stop waiting for connection in existing requests. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/nbd.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index b3cbbeb4b0..c26dc5a54f 100644 --- a/block/nbd.c +++ b/b

[PATCH v2 09/10] block/backup: implement .cancel job handler

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/backup.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/backup.c b/block/backup.c index cc525d5544..94e6dcd72e 100644 --- a/block/backup.c ++

[PATCH v2 07/10] iotests.py: qemu_nbd_popen: remove pid file after use

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
To not interfere with other qemu_nbd_popen() calls in same test. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iote

[PATCH v2 01/10] block: add new BlockDriver handler: bdrv_cancel_in_flight

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
It will be used to stop retrying NBD requests on mirror cancel. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/block.h | 3 +++ include/block/block_int.h | 9 + block/io.c| 11 +++ 3 files changed, 23 insertions(+) di

[PATCH v2 06/10] iotests/264: move to python unittest

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
We are going to add more test cases, so use the library supporting test cases. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/264 | 93 ++ tests/qemu-iotests/264.out | 20 ++-- 2 files changed, 58 insertions

[PATCH v2 03/10] block/raw-format: implement .bdrv_cancel_in_flight handler

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
We are going to cancel in-flight requests on mirror nbd target on job cancel. Still nbd is often used not directly but as raw-format child. So, add pass-through handler here. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/raw-format.c | 6 ++ 1 file changed, 6

[PATCH v2 00/10] mirror: cancel nbd reconnect

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
Hi all! The problem Assume we have mirror job with nbd target node with enabled reconnect. Connection failed. So, all current requests to nbd node are waiting for nbd driver to reconnect. And they will wait for reconnect-delay time specified in nbd blockdev options. This timeout may be long enoug

Re: [PATCH v2 29/36] blockdev: qmp_x_blockdev_reopen: acquire all contexts

2021-02-05 Thread Kevin Wolf
Am 05.02.2021 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > 05.02.2021 19:01, Kevin Wolf wrote: > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > During reopen we may add backing bs from other aio context, which may > > > lead to changing original context of

Re: [PATCH v2 28/36] block: add bdrv_set_backing_noperm() transaction action

2021-02-05 Thread Kevin Wolf
Am 05.02.2021 um 17:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > 05.02.2021 17:00, Kevin Wolf wrote: > > Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Split out no-perm part of bdrv_set_backing_hd() as a separate > > > transaction action. Note the in case of exist

Re: [PATCH v2 28/36] block: add bdrv_set_backing_noperm() transaction action

2021-02-05 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > Split out no-perm part of bdrv_set_backing_hd() as a separate > transaction action. Note the in case of existing BdrvChild we reuse it, > not recreate, just to do less actions. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Peter Maydell
On Fri, 5 Feb 2021 at 16:21, Stefan Hajnoczi wrote: > Thanks, I update the patch in question. > > It looks like the GitLab CI doesn't include a clang version that > produces this error because the pipeline passed for me: > https://gitlab.com/stefanha/qemu/-/pipelines/251524779 > > Is there somethi

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Keith Busch
On Sat, Feb 06, 2021 at 01:07:57AM +0900, Minwoo Im wrote: > If multipath is enabled, the namespace head and hidden namespace will be > created. In this case, /sys/block/nvme0n1/queue/nr_zones are not > returning proper value for the namespace itself. By the way, the hidden > namespace /sys/block

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Stefan Hajnoczi
On Thu, Feb 04, 2021 at 05:35:31PM +, Peter Maydell wrote: > On Thu, 4 Feb 2021 at 15:43, Stefan Hajnoczi wrote: > > > > The following changes since commit db754f8ccaf2f073c9aed46a4389e9c0c2080399: > > > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210202' > > into sta

Re: [PULL v2 00/27] Block patches

2021-02-05 Thread Stefan Hajnoczi
On Thu, Feb 04, 2021 at 10:49:26AM -0800, elena wrote: > On Thu, Feb 04, 2021 at 05:35:31PM +, Peter Maydell wrote: > > On Thu, 4 Feb 2021 at 15:43, Stefan Hajnoczi wrote: > > > > > > The following changes since commit > > > db754f8ccaf2f073c9aed46a4389e9c0c2080399: > > > > > > Merge remote

Re: [PATCH v2 29/36] blockdev: qmp_x_blockdev_reopen: acquire all contexts

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2021 19:01, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: During reopen we may add backing bs from other aio context, which may lead to changing original context of top bs. We are going to move graph modification to prepare stage. So, it will be po

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Keith Busch
On Sat, Feb 06, 2021 at 01:07:57AM +0900, Minwoo Im wrote: > On 21-02-05 08:02:10, Keith Busch wrote: > > On Fri, Feb 05, 2021 at 09:33:54PM +0900, Minwoo Im wrote: > > > On 21-02-05 12:42:30, Klaus Jensen wrote: > > > > On Feb 5 12:25, i...@dantalion.nl wrote: > > > > > On 05-02-2021 11:39, Klaus

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Minwoo Im
On 21-02-05 08:02:10, Keith Busch wrote: > On Fri, Feb 05, 2021 at 09:33:54PM +0900, Minwoo Im wrote: > > On 21-02-05 12:42:30, Klaus Jensen wrote: > > > On Feb 5 12:25, i...@dantalion.nl wrote: > > > > On 05-02-2021 11:39, Klaus Jensen wrote: > > > > > This is a good way to report it ;) > > > > >

Re: [PATCH v2 28/36] block: add bdrv_set_backing_noperm() transaction action

2021-02-05 Thread Vladimir Sementsov-Ogievskiy
05.02.2021 17:00, Kevin Wolf wrote: Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: Split out no-perm part of bdrv_set_backing_hd() as a separate transaction action. Note the in case of existing BdrvChild we reuse it, not recreate, just to do less actions. Signed-off-by: Vl

Re: [PATCH 1/9] tests/qtest/arm-cpu-features: Remove Cortex-A15 check

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/5/21 4:33 PM, Andrew Jones wrote: > On Fri, Feb 05, 2021 at 04:15:45PM +0100, Philippe Mathieu-Daudé wrote: >> Hi Drew, >> >> On 2/5/21 3:59 PM, Andrew Jones wrote: >>> On Fri, Feb 05, 2021 at 03:43:37PM +0100, Philippe Mathieu-Daudé wrote: Support for ARMv7 has been dropped in commit 82b

Re: [PATCH v11 00/13] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set

2021-02-05 Thread Keith Busch
On Fri, Feb 05, 2021 at 09:33:54PM +0900, Minwoo Im wrote: > On 21-02-05 12:42:30, Klaus Jensen wrote: > > On Feb 5 12:25, i...@dantalion.nl wrote: > > > On 05-02-2021 11:39, Klaus Jensen wrote: > > > > This is a good way to report it ;) > > > > It is super helpful and super appreciated! Thanks! >

Re: [PATCH v2 29/36] blockdev: qmp_x_blockdev_reopen: acquire all contexts

2021-02-05 Thread Kevin Wolf
Am 27.11.2020 um 15:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > During reopen we may add backing bs from other aio context, which may > lead to changing original context of top bs. > > We are going to move graph modification to prepare stage. So, it will > be possible that bdrv_flush() in b

Re: [RFC PATCH 9/9] tests/qtest/arm-cpu-features: Restrict TCG-only tests

2021-02-05 Thread Claudio Fontana
On 2/5/21 4:30 PM, Philippe Mathieu-Daudé wrote: > On 2/5/21 4:20 PM, Claudio Fontana wrote: >> On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote: >>> Some tests explicitly request the TCG accelerator. As these >>> tests will obviously fails if TCG is not present, disable >>> them in such case. >>> >

Re: [RFC PATCH 0/2] Allow changing bs->file on reopen

2021-02-05 Thread Kevin Wolf
Am 05.02.2021 um 13:47 hat Alberto Garcia geschrieben: > On Thu 21 Jan 2021 11:52:17 AM CET, Kevin Wolf wrote: > >> Hmm, still, removing a filter which want to unshare WRITE even when > >> doesn't have any parents will be a problem anyway, so we'll need a > >> new command to drop filter with a logi

Re: [PATCH 1/9] tests/qtest/arm-cpu-features: Remove Cortex-A15 check

2021-02-05 Thread Andrew Jones
On Fri, Feb 05, 2021 at 04:15:45PM +0100, Philippe Mathieu-Daudé wrote: > Hi Drew, > > On 2/5/21 3:59 PM, Andrew Jones wrote: > > On Fri, Feb 05, 2021 at 03:43:37PM +0100, Philippe Mathieu-Daudé wrote: > >> Support for ARMv7 has been dropped in commit 82bf7ae84ce > >> ("target/arm: Remove KVM supp

Re: [PATCH 0/9] hw/arm/virt: Improve CPU help and fix testing under KVM

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote: > Yet again bugfixes and cleanup patches noticed while > rebasing my "Support disabling TCG on ARM (part 2)" series. > > Sending them independently as they aren't directly dependent > of it so don't have to be delayed by other unanswered questions.

Re: [RFC PATCH 9/9] tests/qtest/arm-cpu-features: Restrict TCG-only tests

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/5/21 4:20 PM, Claudio Fontana wrote: > On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote: >> Some tests explicitly request the TCG accelerator. As these >> tests will obviously fails if TCG is not present, disable >> them in such case. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Cc: R

Re: [RFC PATCH 9/9] tests/qtest/arm-cpu-features: Restrict TCG-only tests

2021-02-05 Thread Andrew Jones
On Fri, Feb 05, 2021 at 03:43:45PM +0100, Philippe Mathieu-Daudé wrote: > Some tests explicitly request the TCG accelerator. As these > tests will obviously fails if TCG is not present, disable > them in such case. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Roman Bolshakov > Cc: Claud

Re: [PATCH 6/9] hw/arm/virt: Display list of valid CPUs for the Virt machine

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/5/21 4:12 PM, Andrew Jones wrote: > On Fri, Feb 05, 2021 at 03:43:42PM +0100, Philippe Mathieu-Daudé wrote: >> The Virt machine is restricted to a subset of the CPU provided >> by QEMU. Instead of having the user run '--cpu help' and try >> each CPUs until finding a match, display the list fro

Re: [PATCH 4/9] tests/qtest/cdrom-test: Only allow the Virt machine under KVM

2021-02-05 Thread Philippe Mathieu-Daudé
On 2/5/21 4:08 PM, Andrew Jones wrote: > On Fri, Feb 05, 2021 at 03:43:40PM +0100, Philippe Mathieu-Daudé wrote: >> Only the Virt and Versal machines are supported under KVM. >> Restrict the other ones to TCG. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> tests/qtest/cdrom-test.c | 5

Re: [PATCH 8/9] hw/arm/virt: Restrict 32-bit CPUs to TCG

2021-02-05 Thread Andrew Jones
On Fri, Feb 05, 2021 at 03:43:44PM +0100, Philippe Mathieu-Daudé wrote: > Support for ARMv7 has been dropped in commit 82bf7ae84ce > ("target/arm: Remove KVM support for 32-bit Arm hosts"). > Restrict the 32-bit CPUs to --enable-tcg builds. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ar

Re: [PATCH] iotests: 30: drop from auto group (and effectively from make check)

2021-02-05 Thread Peter Maydell
On Fri, 5 Feb 2021 at 14:48, Eric Blake wrote: > > On 2/5/21 5:10 AM, Vladimir Sementsov-Ogievskiy wrote: > > and trying to reproduce it on top of > > "block: update graph permissions update" I had 634 successful > > iterations > > and then the following crash (which looks much better): > > This p

Re: [RFC PATCH 9/9] tests/qtest/arm-cpu-features: Restrict TCG-only tests

2021-02-05 Thread Claudio Fontana
On 2/5/21 3:43 PM, Philippe Mathieu-Daudé wrote: > Some tests explicitly request the TCG accelerator. As these > tests will obviously fails if TCG is not present, disable > them in such case. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Roman Bolshakov > Cc: Claudio Fontana > > RFC be

Re: [PATCH 4/9] tests/qtest/cdrom-test: Only allow the Virt machine under KVM

2021-02-05 Thread Peter Maydell
On Fri, 5 Feb 2021 at 15:08, Andrew Jones wrote: > > On Fri, Feb 05, 2021 at 03:43:40PM +0100, Philippe Mathieu-Daudé wrote: > > Only the Virt and Versal machines are supported under KVM. > > Restrict the other ones to TCG. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > tests/qtest/cd

Re: [PATCH 1/9] tests/qtest/arm-cpu-features: Remove Cortex-A15 check

2021-02-05 Thread Philippe Mathieu-Daudé
Hi Drew, On 2/5/21 3:59 PM, Andrew Jones wrote: > On Fri, Feb 05, 2021 at 03:43:37PM +0100, Philippe Mathieu-Daudé wrote: >> Support for ARMv7 has been dropped in commit 82bf7ae84ce >> ("target/arm: Remove KVM support for 32-bit Arm hosts"), >> no need to check for Cortex A15 host cpu anymore. >>

Re: [PATCH 7/9] hw/arm/virt: Do not include 64-bit CPUs in 32-bit build

2021-02-05 Thread Andrew Jones
On Fri, Feb 05, 2021 at 03:43:43PM +0100, Philippe Mathieu-Daudé wrote: > Similarly to commit 210f47840dd, remove 64-bit CPUs (which have > never been available on 32-bit build, see commit d14d42f19bf), > to fix: > > $ make check-qtest-arm > ... > Running test qtest-arm/device-introspect-tes

Re: [PATCH 6/9] hw/arm/virt: Display list of valid CPUs for the Virt machine

2021-02-05 Thread Andrew Jones
On Fri, Feb 05, 2021 at 03:43:42PM +0100, Philippe Mathieu-Daudé wrote: > The Virt machine is restricted to a subset of the CPU provided > by QEMU. Instead of having the user run '--cpu help' and try > each CPUs until finding a match, display the list from start: > > $ qemu-system-aarch64 -M vir

  1   2   >