Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-18 Thread Markus Armbruster
Alexander Bulekov writes: > dd if=/dev/zero of=/tmp/fda.img bs=1024 count=1440 > cat << EOF | ./qemu-system-i386 -nographic -m 512M -nodefaults \ > -accel qtest -fda /tmp/fda.img -qtest stdio > outw 0x3f4 0x0500 > outb 0x3f5 0x00 > outb 0x3f5 0x00 > outw 0x3f4 0x00 > outb 0x3f5 0x00 > outw 0x3f1

[PATCH 2/2] floppy: add a regression test for CVE-2021-20196

2021-03-18 Thread Alexander Bulekov
dd if=/dev/zero of=/tmp/fda.img bs=1024 count=1440 cat << EOF | ./qemu-system-i386 -nographic -m 512M -nodefaults \ -accel qtest -fda /tmp/fda.img -qtest stdio outw 0x3f4 0x0500 outb 0x3f5 0x00 outb 0x3f5 0x00 outw 0x3f4 0x00 outb 0x3f5 0x00 outw 0x3f1 0x0400 outw 0x3f4 0x0 outw 0x3f4 0x00 outb

[PATCH 1/2] floppy: add a regression test for CVE-2020-25741

2021-03-18 Thread Alexander Bulekov
dd if=/dev/zero of=/tmp/fda.img bs=1024 count=1440 cat << EOF | ./qemu-system-i386 -nographic -m 512M -nodefaults \ -accel qtest -fda /tmp/fda.img -qtest stdio outw 0x3f4 0x0500 outb 0x3f5 0x00 outb 0x3f5 0x00 outw 0x3f4 0x00 outb 0x3f5 0x00 outw 0x3f1 0x0400 outw 0x3f4 0x0 outw 0x3f4 0x00 outb

Re: [PULL v2 00/11] emulated nvme updates and fixes

2021-03-18 Thread Peter Maydell
On Thu, 18 Mar 2021 at 11:58, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi Peter, > > The following changes since commit b12498fc575f2ad30f09fe78badc7fef526e2d76: > > Merge remote-tracking branch > 'remotes/vivier/tags/q800-for-6.0-pull-request' into staging (2021-03-18 > 10:05:37

Re: [PATCH 1/4] m68k: add the virtio devices aliases

2021-03-18 Thread Philippe Mathieu-Daudé
On 3/18/21 11:39 PM, Laurent Vivier wrote: > Similarly to 5f629d943cb0 ("s390x: fix s390 virtio aliases"), > define the virtio aliases. > > This allows to start machines with virtio devices without > knowledge of the implementation type. > > For instance, we can use "-device virtio-scsi" on >

Re: [PATCH 3/4] iotests: test m68k with the virt machine

2021-03-18 Thread Philippe Mathieu-Daudé
On 3/18/21 11:39 PM, Laurent Vivier wrote: > This allows to cover the virtio tests with a 32bit big-endian > virtio-mmio machine. > > Signed-off-by: Laurent Vivier > --- > tests/qemu-iotests/testenv.py | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 4/4] iotests: iothreads need ioeventfd

2021-03-18 Thread Laurent Vivier
And ioeventfd are only available with virtio-scsi-pci, so don't use the alias and add a rule to require virtio-scsi-pci for the tests that use iothreads. Signed-off-by: Laurent Vivier --- tests/qemu-iotests/127| 4 ++-- tests/qemu-iotests/256| 2 ++ tests/qemu-iotests/iotests.py

[PATCH 3/4] iotests: test m68k with the virt machine

2021-03-18 Thread Laurent Vivier
This allows to cover the virtio tests with a 32bit big-endian virtio-mmio machine. Signed-off-by: Laurent Vivier --- tests/qemu-iotests/testenv.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/testenv.py b/tests/qemu-iotests/testenv.py index 1fbec854c1f7..6d27712617a3

[PATCH 2/4] iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"

2021-03-18 Thread Laurent Vivier
Commit f1d5516ab583 introduces a test in some iotests to check if the machine is a s390-ssw-virtio and to select virtio-*-ccw rather than virtio-*-pci. We don't need that because QEMU already provides aliases to use the correct virtio interface according to the machine type. This patch removes

[PATCH 0/4] iotests: fix failures with non-PCI machines

2021-03-18 Thread Laurent Vivier
Tests are executed using virtio-*-pci even on a non PCI machine. The problem can be easily fixed using the virtio aliases (virtio-*), to run virtio-*-ccw on s390x and virtio-*-device on m68k. A first attempt was tried with virtio-*-ccw by detecting the machine type, this series removes it to use

[PATCH 1/4] m68k: add the virtio devices aliases

2021-03-18 Thread Laurent Vivier
Similarly to 5f629d943cb0 ("s390x: fix s390 virtio aliases"), define the virtio aliases. This allows to start machines with virtio devices without knowledge of the implementation type. For instance, we can use "-device virtio-scsi" on m68k, s390x or PC, and the device will be

Re: [RFC v5 1/6] qmp: add QMP command x-debug-query-virtio

2021-03-18 Thread Eric Blake
On 3/18/21 11:29 AM, Jonah Palmer wrote: > From: Laurent Vivier > > This new command lists all the instances of VirtIODevice with > their path and virtio type > > Signed-off-by: Laurent Vivier > Reviewed-by: Eric Blake > Signed-off-by: Jonah Palmer > --- We've missed soft freeze for 6.0,

[PATCH 1/1] iotests: fix 051.out expected output after error text touchups

2021-03-18 Thread Connor Kuehl
A patch was recently applied that touched up some error messages that pertained to key names like 'node-name'. The trouble is it only updated tests/qemu-iotests/051.pc.out and not tests/qemu-iotests/051.out as well. Do that now. Fixes: 785ec4b1b9 ("block: Clarify error messages pertaining to

[PATCH 0/1] iotests: fix 051.out expected output after error

2021-03-18 Thread Connor Kuehl
Oops, sorry about the churn. I can see why this would have caused a failure but I'm surprised I can't reproduce this when I run the test locally. Christian, would you be willing to test this patch out as a quick sanity check too? Connor Kuehl (1): iotests: fix 051.out expected output after

Re: [PULL v4 00/42] Block layer patches and object-add QAPIfication

2021-03-18 Thread Peter Maydell
On Thu, 18 Mar 2021 at 09:48, Kevin Wolf wrote: > > The following changes since commit 571d413b5da6bc6f1c2aaca8484717642255ddb0: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210316' > into staging (2021-03-17 21:02:37 +) > > are available in the Git repository

Re: [PULL v2 00/13] misc patches removing deprecated features

2021-03-18 Thread Peter Maydell
On Thu, 18 Mar 2021 at 09:30, Daniel P. Berrangé wrote: > > The following changes since commit 571d413b5da6bc6f1c2aaca8484717642255ddb0: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210316' > into staging (2021-03-17 21:02:37 +) > > are available in the Git

Re: How to create vhdx differencing disk using qemu-img

2021-03-18 Thread John Snow
On 3/17/21 10:37 PM, qi zhou wrote: When I create vhdx differencing disk using qemu-img, It says  qemu-img: xxx.vhd Backing file not supported for file format 'vhdx' The command I used is qemu-img create -f vhdx -b test.vhdx test-snapshot.vhdx Here is my questions 1. Is vhdx format [full]

Re: iotest 051 failure on s390

2021-03-18 Thread John Snow
On 3/18/21 12:32 PM, Christian Borntraeger wrote: On s390 with latest master I do get 051   fail   [17:30:00] [17:30:05]   5.4s output mismatch (see 051.out.bad) --- /home/cborntra/REPOS/qemu/tests/qemu-iotests/051.out +++ 051.out.bad @@ -61,13 +61,13 @@  (qemu) quit  

[RFC v5 6/6] hmp: add virtio commands

2021-03-18 Thread Jonah Palmer
From: Laurent Vivier This patch implements HMP version of the virtio QMP commands [Jonah: Added relative indicies, device type, and used index in HMP virtio queue-status command.] Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- docs/system/monitor.rst | 2 +

[RFC v5 2/6] qmp: add QMP command x-debug-virtio-status

2021-03-18 Thread Jonah Palmer
From: Laurent Vivier This new command shows the status of a VirtIODevice (features, endianness and number of virtqueues) Next patch will improve output by decoding feature bits. Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5

[RFC v5 4/6] qmp: add QMP command x-debug-virtio-queue-status

2021-03-18 Thread Jonah Palmer
From: Laurent Vivier This new command shows internal status of a VirtQueue. (vrings and indexes). [Jonah: Added 'device-type' field to VirtQueueStatus and qmp command x-debug-virtio-queue-status.] Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 6

[not a patch] sorry folks, this is a super important test

2021-03-18 Thread Paolo Bonzini
test test test!

[RFC v5 0/6] hmp,qmp: Add some commands to introspect virtio deices

2021-03-18 Thread Jonah Palmer
This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing and upstreaming Laurent's qmp/hmp virtio commands from last May (here: https://lore.kernel.org/qemu-devel/20200507134800.10837-1-lviv...@redhat.com/) which mainly included

[RFC v5 5/6] qmp: add QMP command x-debug-virtio-queue-element

2021-03-18 Thread Jonah Palmer
From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 hw/virtio/virtio.c | 135 qapi/virtio.json| 94

Re: Can not use hmp block_resize command with -blockdev option

2021-03-18 Thread LKML
On Thu, 18 Mar 2021 17:17:50 +0100 Kevin Wolf wrote: > Am 18.03.2021 um 16:15 hat zhao xiaojun geschrieben: > > Thanks you, that's really good idea. And I also have the following > > question: > > > > There are some hmp and qmp commands in my scripts, they need the > > device as an argument.

Re: Can not use hmp block_resize command with -blockdev option

2021-03-18 Thread zhao xiaojun
Thanks you, that's really good idea. And I also have the following question: There are some hmp and qmp commands in my scripts, they need the device as an argument. Recently. i used the -blockdev replace the -drive to specify the disk drive, then use qmp's query_block to query the device, but

[RFC v5 1/6] qmp: add QMP command x-debug-query-virtio

2021-03-18 Thread Jonah Palmer
From: Laurent Vivier This new command lists all the instances of VirtIODevice with their path and virtio type Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 ++

[RFC v5 3/6] qmp: decode feature bits in virtio-status

2021-03-18 Thread Jonah Palmer
From: Laurent Vivier Display feature names instead of a features bitmap for host, guest, and backend. Decode features according to device type, transport features are on the first line. Undecoded bits (if any) are stored in a separate field. Signed-off-by: Laurent Vivier Signed-off-by: Jonah

Re: [PULL 5/5] m68k: add Virtual M68k Machine

2021-03-18 Thread Max Reitz
On 18.03.21 17:25, Philippe Mathieu-Daudé wrote: On 3/18/21 4:56 PM, Laurent Vivier wrote: Le 18/03/2021 à 16:51, Laurent Vivier a écrit : Le 18/03/2021 à 16:36, Philippe Mathieu-Daudé a écrit : On 3/18/21 11:06 AM, Laurent Vivier wrote: Le 18/03/2021 à 11:02, Philippe Mathieu-Daudé a écrit 

Re: [RFC v5 0/6] hmp, qmp: Add some commands to introspect virtio deices

2021-03-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1616084984-11263-1-git-send-email-jonah.pal...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1616084984-11263-1-git-send-email-jonah.pal...@oracle.com Subject: [RFC

Re: Can not use hmp block_resize command with -blockdev option

2021-03-18 Thread Kevin Wolf
Am 18.03.2021 um 16:15 hat zhao xiaojun geschrieben: > Thanks you, that's really good idea. And I also have the following question: > > There are some hmp and qmp commands in my scripts, they need the device as > an argument. Recently. i used the -blockdev replace the -drive to > specify the disk

Re: [PULL 5/5] m68k: add Virtual M68k Machine

2021-03-18 Thread Philippe Mathieu-Daudé
On 3/18/21 4:56 PM, Laurent Vivier wrote: > Le 18/03/2021 à 16:51, Laurent Vivier a écrit : >> Le 18/03/2021 à 16:36, Philippe Mathieu-Daudé a écrit : >>> On 3/18/21 11:06 AM, Laurent Vivier wrote: Le 18/03/2021 à 11:02, Philippe Mathieu-Daudé a écrit : > On 3/18/21 10:52 AM, Laurent

Re: [PATCH v2(RFC) 0/3] qcow2: fix parallel rewrite and discard

2021-03-18 Thread Vladimir Sementsov-Ogievskiy
18.03.2021 18:37, Vladimir Sementsov-Ogievskiy wrote: 12.03.2021 18:24, Kevin Wolf wrote: Am 25.02.2021 um 12:52 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! It occurs that nothing prevents discarding and reallocating host cluster during data writing. This way data writing will

[PULL v2 11/11] hw/block/pflash_cfi: Replace DPRINTF with trace events

2021-03-18 Thread Philippe Mathieu-Daudé
From: David Edmondson Rather than having a device specific debug implementation in pflash_cfi01.c and pflash_cfi02.c, use the standard tracing facility. Signed-off-by: David Edmondson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210216142721.1985543-2-david.edmond...@oracle.com> [PMD:

Re: [PATCH v2(RFC) 0/3] qcow2: fix parallel rewrite and discard

2021-03-18 Thread Vladimir Sementsov-Ogievskiy
12.03.2021 18:24, Kevin Wolf wrote: Am 25.02.2021 um 12:52 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! It occurs that nothing prevents discarding and reallocating host cluster during data writing. This way data writing will pollute another newly allocated cluster of data or metadata.

Re: "make check" broken with everything but tools disabled

2021-03-18 Thread Philippe Mathieu-Daudé
On 3/18/21 10:16 AM, Claudio Fontana wrote: > On 3/16/21 2:28 PM, Markus Armbruster wrote: >> Watch this: >> >> $ mkdir bld-tools >> $ cd bld-tools >> $ ../configure --disable-system --disable-user --enable-tools >> $ make check >> [...] >> make: *** No rule to make target

Re: [PATCH v4 4/6] block: Support multiple reopening with x-blockdev-reopen

2021-03-18 Thread Vladimir Sementsov-Ogievskiy
17.03.2021 20:15, Alberto Garcia wrote: Signed-off-by: Alberto Garcia --- qapi/block-core.json | 18 + blockdev.c | 78 +++--- tests/qemu-iotests/155 | 9 +++-- tests/qemu-iotests/165 | 4 +- tests/qemu-iotests/245

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-03-18 Thread Vladimir Sementsov-Ogievskiy
17.03.2021 20:15, Alberto Garcia wrote: When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters.

Re: [PATCH v4 1/6] block: Add bdrv_reopen_queue_free()

2021-03-18 Thread Vladimir Sementsov-Ogievskiy
17.03.2021 20:15, Alberto Garcia wrote: Move the code to free a BlockReopenQueue to a separate function. It will be used in a subsequent patch. Signed-off-by: Alberto Garcia Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PULL 00/11] emulated nvme updates and fixes

2021-03-18 Thread Daniel P . Berrangé
On Thu, Mar 18, 2021 at 01:01:58PM +0100, Klaus Jensen wrote: > On Mar 18 11:28, Peter Maydell wrote: > > On Thu, 18 Mar 2021 at 11:27, Klaus Jensen wrote: > > > > > > On Mar 18 11:26, Peter Maydell wrote: > > > > On Tue, 16 Mar 2021 at 21:47, Klaus Jensen wrote: > > > > Hi. This tag includes a

Re: [PULL 00/11] emulated nvme updates and fixes

2021-03-18 Thread Klaus Jensen
On Mar 18 11:28, Peter Maydell wrote: > On Thu, 18 Mar 2021 at 11:27, Klaus Jensen wrote: > > > > On Mar 18 11:26, Peter Maydell wrote: > > > On Tue, 16 Mar 2021 at 21:47, Klaus Jensen wrote: > > > Hi. This tag includes a submodule update which is not mentioned > > > in the cover letter or

Re: [PULL v2 00/11] emulated nvme updates and fixes

2021-03-18 Thread Klaus Jensen
On Mar 18 12:57, Klaus Jensen wrote: > From: Klaus Jensen > > Hi Peter, > > The following changes since commit b12498fc575f2ad30f09fe78badc7fef526e2d76: > > Merge remote-tracking branch > 'remotes/vivier/tags/q800-for-6.0-pull-request' into staging (2021-03-18 > 10:05:37 +) > > are

[PULL v2 00/11] emulated nvme updates and fixes

2021-03-18 Thread Klaus Jensen
From: Klaus Jensen Hi Peter, The following changes since commit b12498fc575f2ad30f09fe78badc7fef526e2d76: Merge remote-tracking branch 'remotes/vivier/tags/q800-for-6.0-pull-request' into staging (2021-03-18 10:05:37 +) are available in the Git repository at:

Re: [PULL 00/11] emulated nvme updates and fixes

2021-03-18 Thread Peter Maydell
On Thu, 18 Mar 2021 at 11:27, Klaus Jensen wrote: > > On Mar 18 11:26, Peter Maydell wrote: > > On Tue, 16 Mar 2021 at 21:47, Klaus Jensen wrote: > > Hi. This tag includes a submodule update which is not mentioned > > in the cover letter or listed in the cover letter diffstat: > > > >

Re: [PULL 00/11] emulated nvme updates and fixes

2021-03-18 Thread Klaus Jensen
On Mar 18 11:26, Peter Maydell wrote: > On Tue, 16 Mar 2021 at 21:47, Klaus Jensen wrote: > > > > From: Klaus Jensen > > > > Hi Peter, > > > > The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: > > > > Merge remote-tracking branch

Re: [PULL 00/11] emulated nvme updates and fixes

2021-03-18 Thread Peter Maydell
On Tue, 16 Mar 2021 at 21:47, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi Peter, > > The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2021-03-16 10:53:47 +) > > are

Re: Can not use hmp block_resize command with -blockdev option

2021-03-18 Thread Kevin Wolf
Am 17.03.2021 um 23:49 hat John Snow geschrieben: > On 3/16/21 11:43 PM, zhao xiaojun wrote: > > Hi, > > I use -blockdev option to specify a drive when qemu boot and i want to > > resize it with hmp block_resize command. The hmp block_resize comand's > > arguments: block_resize device new_size. >

Re: iotests failing on gitlab CI check-system-fedora job

2021-03-18 Thread Paolo Bonzini
On 18/03/21 11:07, Peter Maydell wrote: On Wed, 17 Mar 2021 at 23:26, Paolo Bonzini wrote: On 17/03/21 23:23, Peter Maydell wrote: The check-system-fedora job in the gitlab CI seems to have started reliably failing on iotests 040 041 127 256 267:

Re: iotests failing on gitlab CI check-system-fedora job

2021-03-18 Thread Peter Maydell
On Wed, 17 Mar 2021 at 23:26, Paolo Bonzini wrote: > > On 17/03/21 23:23, Peter Maydell wrote: > > The check-system-fedora job in the gitlab CI seems to have > > started reliably failing on iotests 040 041 127 256 267: > > https://gitlab.com/qemu-project/qemu/-/jobs/1106977551 > > > > Could

Re: "make check" broken with everything but tools disabled

2021-03-18 Thread Paolo Bonzini
On 18/03/21 10:16, Claudio Fontana wrote: my experience with the new build system (meson-based), is that I have to do: make first, and then make check later, or bugs start happening This shouldn't be needed. Paolo

Re: [PATCH 2/2] qemu-img: align next status sector on destination alignment.

2021-03-18 Thread Maxim Levitsky
On Thu, 2020-11-12 at 17:04 +0200, Maxim Levitsky wrote: > On Thu, 2020-11-12 at 07:45 -0600, Eric Blake wrote: > > On 11/12/20 6:40 AM, Peter Lieven wrote: > > > > > > /* > > > > - * Avoid that s->sector_next_status becomes unaligned to the > > > > source > > > > - *

[PULL v4 00/42] Block layer patches and object-add QAPIfication

2021-03-18 Thread Kevin Wolf
The following changes since commit 571d413b5da6bc6f1c2aaca8484717642255ddb0: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210316' into staging (2021-03-17 21:02:37 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for

Re: [PULL v3 00/42] Block layer patches and object-add QAPIfication

2021-03-18 Thread Kevin Wolf
Am 17.03.2021 um 22:01 hat Peter Maydell geschrieben: > On Tue, 16 Mar 2021 at 18:12, Kevin Wolf wrote: > > > > The following changes since commit 6e31b3a5c34c6e5be7ef60773e607f189eaa15f3: > > > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' > > into staging

[PULL 11/13] block: remove dirty bitmaps 'status' field

2021-03-18 Thread Daniel P . Berrangé
The same information is available via the 'recording' and 'busy' fields. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Daniel P. Berrangé --- block/dirty-bitmap.c | 38 docs/system/deprecated.rst | 7 - docs/system/removed-features.rst | 7 +

[PULL 13/13] block: remove support for using "file" driver with block/char devices

2021-03-18 Thread Daniel P . Berrangé
The 'host_device' and 'host_cdrom' drivers must be used instead. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- block/file-posix.c | 17 ++--- docs/system/deprecated.rst | 7 --- docs/system/removed-features.rst | 7 +++

[PULL 12/13] block: remove 'dirty-bitmaps' field from 'BlockInfo' struct

2021-03-18 Thread Daniel P . Berrangé
The same data is available in the 'BlockDeviceInfo' struct. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Daniel P. Berrangé --- block/qapi.c| 5 - docs/system/deprecated.rst | 13 -

[PULL 09/13] hw/scsi: remove 'scsi-disk' device

2021-03-18 Thread Daniel P . Berrangé
The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 9 - docs/system/removed-features.rst | 6 hw/i386/pc.c | 1 - hw/scsi/scsi-disk.c |

[PULL 10/13] block: remove 'encryption_key_missing' flag from QAPI

2021-03-18 Thread Daniel P . Berrangé
This has been hardcoded to "false" since 2.10.0, since secrets required to unlock block devices are now always provided up front instead of using interactive prompts. Reviewed-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- block/qapi.c | 1 -

[PULL 08/13] hw/ide: remove 'ide-drive' device

2021-03-18 Thread Daniel P . Berrangé
The 'ide-hd' and 'ide-cd' devices provide suitable alternatives. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- docs/qdev-device-use.txt | 2 +- docs/system/deprecated.rst | 6 - docs/system/removed-features.rst | 8 +++ hw/i386/pc.c

[PULL 07/13] chardev: reject use of 'wait' flag for socket client chardevs

2021-03-18 Thread Daniel P . Berrangé
This only makes sense conceptually when used with listener chardevs. Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrangé --- chardev/char-socket.c| 12 docs/system/deprecated.rst | 6 -- docs/system/removed-features.rst | 6 ++ 3 files

[PULL 06/13] machine: remove 'arch' field from 'query-cpus-fast' QMP command

2021-03-18 Thread Daniel P . Berrangé
Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 6 - docs/system/removed-features.rst | 6 + hw/core/machine-qmp-cmds.c | 41 qapi/machine.json| 22 - 4 files

[PULL 01/13] ui, monitor: remove deprecated VNC ACL option and HMP commands

2021-03-18 Thread Daniel P . Berrangé
The VNC ACL concept has been replaced by the pluggable "authz" framework which does not use monitor commands. Reviewed-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 16 --- docs/system/removed-features.rst | 12

[PULL 05/13] machine: remove 'query-cpus' QMP command

2021-03-18 Thread Daniel P . Berrangé
The newer 'query-cpus-fast' command avoids side effects on the guest execution. Note that some of the field names are different in the 'query-cpus-fast' command. Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Daniel P. Berrangé ---

[PULL 02/13] monitor: raise error when 'pretty' option is used with HMP

2021-03-18 Thread Daniel P . Berrangé
This is only semantically useful for QMP. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- docs/system/deprecated.rst | 7 --- docs/system/removed-features.rst | 6 ++ monitor/monitor.c| 4 ++-- qemu-options.hx | 5 +++--

[PULL 04/13] migrate: remove QMP/HMP commands for speed, downtime and cache size

2021-03-18 Thread Daniel P . Berrangé
The generic 'migrate_set_parameters' command handle all types of param. Only the QMP commands were documented in the deprecations page, but the rationale for deprecating applies equally to HMP, and the replacements exist. Furthermore the HMP commands are just shims to the QMP commands, so

[PULL 03/13] monitor: remove 'query-events' QMP command

2021-03-18 Thread Daniel P . Berrangé
The code comment suggests removing QAPIEvent_(str|lookup) symbols too, however, these are both auto-generated as standard for any enum in QAPI. As such it they'll exist whether we use them or not. Reviewed-by: Eric Blake Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé ---

[PULL v2 00/13] misc patches removing deprecated features

2021-03-18 Thread Daniel P . Berrangé
The following changes since commit 571d413b5da6bc6f1c2aaca8484717642255ddb0: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20210316' into staging (2021-03-17 21:02:37 +) are available in the Git repository at: https://gitlab.com/berrange/qemu

Re: "make check" broken with everything but tools disabled

2021-03-18 Thread Claudio Fontana
On 3/16/21 2:28 PM, Markus Armbruster wrote: > Watch this: > > $ mkdir bld-tools > $ cd bld-tools > $ ../configure --disable-system --disable-user --enable-tools > $ make check > [...] > make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', > needed by

Re: "make check" broken with everything but tools disabled

2021-03-18 Thread Philippe Mathieu-Daudé
On 3/17/21 11:35 PM, John Snow wrote: > On 3/16/21 9:28 AM, Markus Armbruster wrote: >> Watch this: >> >> $ mkdir bld-tools >> $ cd bld-tools >> $ ../configure --disable-system --disable-user --enable-tools >> $ make check >> [...] >> make: *** No rule to make target

Re: [PATCH V3] file-posix: allow -EBUSY -EINVAL errors during write zeros on block

2021-03-18 Thread Vladimir Sementsov-Ogievskiy via
18.03.2021 02:23, John Snow wrote: On 3/9/21 7:16 PM, ChangLimin wrote: Since Linux 5.10, write zeros to a multipath device using ioctl(fd, BLKZEROOUT, range) with cache none or directsync return -EBUSY permanently. When do we get -EINVAL? Both of the commits referenced below don't

Re: [PATCH v3 00/36] block: update graph permissions update

2021-03-18 Thread Vladimir Sementsov-Ogievskiy
17.03.2021 20:33, Eric Blake wrote: On 3/17/21 10:38 AM, Vladimir Sementsov-Ogievskiy wrote: 6/36 Checking commit 5780b805277e (block: drop ctx argument from bdrv_root_attach_child) 7/36 Checking commit 68189c099a3a (block: make bdrv_reopen_{prepare, commit, abort} private) ERROR: Author email