Re: [PATCH V3 5/6] block/rbd: add write zeroes support

> Am 26.06.2021 um 17:57 schrieb Ilya Dryomov : > > On Mon, Jun 21, 2021 at 10:49 AM Peter Lieven wrote: >> >>> Am 18.06.21 um 12:34 schrieb Ilya Dryomov: >>> On Fri, Jun 18, 2021 at 11:00 AM Peter Lieven wrote: Am 16.06.21 um 14:34 schrieb Ilya Dryomov: > On Wed, May 19, 2021 at 4

Re: [PATCH v2] block/rbd: Add support for rbd image encryption

On Sun, Jun 27, 2021 at 1:46 PM Or Ozeri wrote: > > Starting from ceph Pacific, RBD has built-in support for image-level > encryption. > Currently supported formats are LUKS version 1 and 2. > > There are 2 new relevant librbd APIs for controlling encryption, both expect > an > open image contex

[PATCH v2] block/rbd: Add support for rbd image encryption

Starting from ceph Pacific, RBD has built-in support for image-level encryption. Currently supported formats are LUKS version 1 and 2. There are 2 new relevant librbd APIs for controlling encryption, both expect an open image context: rbd_encryption_format: formats an image (i.e. writes the LUKS

Re: [PATCH] block/rbd: Add support for rbd image encryption

On Sun, Jun 27, 2021 at 1:09 PM Or Ozeri wrote: > > Should I still leave the encryption format part of the state, and just not > report it? or should I also remove it from the state? I'd remove it, reverting to the previous version of the patch except instead of fetching the size with rbd_get_si

RE: [PATCH] block/rbd: Add support for rbd image encryption

Should I still leave the encryption format part of the state, and just not report it? or should I also remove it from the state?-"Ilya Dryomov" wrote: -To: "Or Ozeri" From: "Ilya Dryomov" Date: 06/27/2021 02:00PMCc: qemu-de...@nongnu

Re: [PATCH] block/rbd: Add support for rbd image encryption

On Sun, Jun 27, 2021 at 10:44 AM Or Ozeri wrote: > > Ilya, > > I fixed according to your suggestions, except for the passphrase zeroing. > Looks like it's not a one-liner, but rather a long list of ifdefs to try and > cover all possible platforms/compilers (this is what I've seen they do in > k5

Re: [PATCH] block/rbd: Add support for rbd image encryption

Ilya,I fixed according to your suggestions, except for the passphrase zeroing.Looks like it's not a one-liner, but rather a long list of ifdefs to try and cover all possible platforms/compilers (this is what I've seen they do in k5-int.h).I didn't want to copy this into rbd.c.I guess that the right

[PATCH] block/rbd: Add support for rbd image encryption

Starting from ceph Pacific, RBD has built-in support for image-level encryption. Currently supported formats are LUKS version 1 and 2. There are 2 new relevant librbd APIs for controlling encryption, both expect an open image context: rbd_encryption_format: formats an image (i.e. writes the LUKS