This patch adds some test cases for the memory limit concerning the
in-memory structures used to detect and prevent accidental metadata
overlaps.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/060 | 222 +
tests/qemu-iotests/060.out | 47
Expose the two new options for controlling the memory usage of the
overlap check implementation via QAPI.
Signed-off-by: Max Reitz
---
qapi/block-core.json | 31 +++
1 file changed, 31 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index
Add runtime options to qcow2 to control the size of the structures used
for metadata overlap prevention (one option to control the size of the
bitmap cache, another one to control the total memory size limit).
Signed-off-by: Max Reitz
---
block/qcow2.c | 35
Later, a mechanism to set a limit on how much memory may be used for the
overlap prevention structures will be introduced. If that limit is about
to be exceeded, a QMP event should be emitted. This very event is
specified by this patch.
Signed-off-by: Max Reitz
---
docs/qmp/qmp-events.txt | 27
Keep track of the inactive L1 tables in the metadata list to protect
them against accidental modifications.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-snapshot.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/block/qcow2-snapshot.c b/block
Keep track of the snapshot table in the metadata list to protect it
against accidental modifications.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
block/qcow2-snapshot.c | 10 ++
block/qcow2.c | 6 ++
2 files changed, 16 insertions(+)
diff --git a/block/qcow2
Make the static new overlap check function global and drop the old
function.
Signed-off-by: Max Reitz
---
block/qcow2-overlap.c | 8 +---
block/qcow2-refcount.c | 120 -
2 files changed, 2 insertions(+), 126 deletions(-)
diff --git a/block
ock: Add bdrv_filename()'
004/5:[0038] [FC] 'block: Drop BlockDriverState.filename'
005/5:[down] 'iotests: Test changed Quorum filename'
Max Reitz (5):
block: Change bdrv_get_encrypted_filename()
block: Avoid BlockDriverState.filename
block: Add bdrv_filename()
bl
.
Since bdrv_refresh_filename() therefore no longer refreshes that field,
some calls to that function have to be replaced by calls to
bdrv_filename() "manually" refreshing the BDS filename field (this is
only temporary).
Signed-off-by: Max Reitz
---
block.c
Instead of returning a pointer to the filename, copy it into a buffer
specified by the caller.
Signed-off-by: Max Reitz
---
block.c | 24 +---
include/block/block.h | 2 +-
monitor.c | 4 +++-
3 files changed, 21 insertions(+), 9 deletions
emove that field, using exact_filename is
fine, too (this is the only user of BlockDriverState.filename which
frequently queries that field).
Signed-off-by: Max Reitz
---
block.c | 4 ++--
block/gluster.c | 2 +-
block/raw-posix.c | 8
block/raw-win32.c | 4 ++--
qemu-
contained in the Quorum BDS's filename as returned by query-block.
As a nice side effect of confirming that the new BDS actually belongs to
the Quorum BDS, this checks whether the filename was properly updated.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 17 +
1 file ch
else a buffer is created on the stack to hold the result of
bdrv_filename(); any access to BlockDriverState.filename is then
replaced by this buffer
Signed-off-by: Max Reitz
---
block.c | 40
block/blkverify.c | 3 +--
block/co
On 06.08.2015 04:01, Wen Congyang wrote:
On 08/06/2015 04:52 AM, Max Reitz wrote:
Instead of returning a pointer to the filename, copy it into a buffer
specified by the caller.
Signed-off-by: Max Reitz
---
block.c | 24 +---
include/block/block.h | 2
On 06.08.2015 04:27, Wen Congyang wrote:
On 08/06/2015 04:52 AM, Max Reitz wrote:
In places which directly pass a filename to the OS, we should not use
the filename field at all but exact_filename instead (although the
former currently equals the latter if that is set).
In qemu-img'
NetBSD) or it is about a deprecated device
(i.e. floppy).
Signed-off-by: Max Reitz
---
block/raw-posix.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 855febe..30df8ad 100644
--- a/block/raw-posix.c
+++ b
ame()'
004/5:[0129] [FC] 'block: Drop BlockDriverState.filename'
005/5:[] [--] 'iotests: Test changed Quorum filename'
Max Reitz (5):
block: Change bdrv_get_encrypted_filename()
block: Avoid BlockDriverState.filename
block: Add bdrv_filename()
block: Drop Bloc
Instead of returning a pointer to the filename, copy it into a buffer
specified by the caller.
Signed-off-by: Max Reitz
---
block.c | 25 ++---
include/block/block.h | 2 +-
monitor.c | 6 +-
3 files changed, 24 insertions(+), 9 deletions
e else bdrv_filename_alloc() is used, any access to
BlockDriverState.filename is then replaced by the buffer returned, and
it is freed when it is no longer needed
Signed-off-by: Max Reitz
---
block.c | 47 ++-
block/blkverify.c
emove that field, using exact_filename is
fine, too (this is the only user of BlockDriverState.filename which
frequently queries that field).
Signed-off-by: Max Reitz
---
block.c | 5 +++--
block/gluster.c | 2 +-
block/raw-posix.c | 8
block/raw-win32.c | 4 ++--
qemu-
contained in the Quorum BDS's filename as returned by query-block.
As a nice side effect of confirming that the new BDS actually belongs to
the Quorum BDS, this checks whether the filename was properly updated.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 17 +
1 file ch
llocates a buffer of size PATH_MAX, call bdrv_filename() on that buffer
and returns it, since needing a temporary buffer for the filename is a
rather common pattern.
Signed-off-by: Max Reitz
---
block.c | 39 ---
block/blkverify.c | 3 ++-
bloc
pointing to the filename.
Signed-off-by: Max Reitz
---
block.c | 5 +++--
block/gluster.c | 2 +-
block/raw-posix.c | 12 ++--
block/raw-win32.c | 4 ++--
4 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/block.c b/block.c
index 41b0f85..1572785 100644
--- a/block.c
] 'block: Drop BlockDriverState.filename'
006/6:[] [--] 'iotests: Test changed Quorum filename'
Max Reitz (6):
block: Change bdrv_get_encrypted_filename()
block: Avoid BlockDriverState.filename
block: Add bdrv_filename()
qemu-img: Use bdrv_filename_alloc() for
Replaces bs->filename by the result of bdrv_filename_alloc() in the
qemu-img map subcommand. Since that value is queried relatively often,
however, it should be cached.
Signed-off-by: Max Reitz
---
qemu-img.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --gi
e else bdrv_filename_alloc() is used, any access to
BlockDriverState.filename is then replaced by the buffer returned, and
it is freed when it is no longer needed
Signed-off-by: Max Reitz
---
block.c | 47 ++-
block/blkverify.c
Instead of returning a pointer to the filename, copy it into a buffer
specified by the caller.
Signed-off-by: Max Reitz
---
block.c | 25 ++---
include/block/block.h | 2 +-
monitor.c | 6 +-
3 files changed, 24 insertions(+), 9 deletions
llocates a buffer of size PATH_MAX, call bdrv_filename() on that buffer
and returns it, since needing a temporary buffer for the filename is a
rather common pattern.
Signed-off-by: Max Reitz
---
block.c | 39 ---
block/blkverify.c | 3 ++-
bloc
contained in the Quorum BDS's filename as returned by query-block.
As a nice side effect of confirming that the new BDS actually belongs to
the Quorum BDS, this checks whether the filename was properly updated.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/041 | 17 +
1 file ch
fixed, too).
Reported-by: Dr. David Alan Gilbert
Cc: qemu-stable
Signed-off-by: Max Reitz
---
qemu-img.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 75f4ee4..3ddb391 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -2930,8 +2930,7 @@ static int
fixed, too).
Reported-by: Dr. David Alan Gilbert
Cc: qemu-stable
Signed-off-by: Max Reitz
---
v2:
- Fix leak introduced by trying to be clever [Eric]
(thank you for catching this!)
---
qemu-img.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
blocks * st.st_blksize);
+return (task.ret < 0 ? task.ret : st.st_blocks * 512);
}
static int nfs_file_truncate(BlockDriverState *bs, int64_t offset)
Reviewed-by: Max Reitz
On 2015-08-21 at 00:49, Peter Lieven wrote:
If the file is readonly its not expected to grow so
save the blocking call to nfs_fstat_async and use
the value saved at connection time. Also important
the monitor (and thus the main loop) will not hang
if block device info is queried and the NFS share
On 2015-08-21 at 11:11, Peter Lieven wrote:
Am 21.08.2015 um 18:46 schrieb Max Reitz:
On 2015-08-21 at 00:49, Peter Lieven wrote:
If the file is readonly its not expected to grow so
save the blocking call to nfs_fstat_async and use
the value saved at connection time. Also important
the monitor
ied and the NFS share
> is unresponsive.
>
> Signed-off-by: Peter Lieven
> ---
> v1->v2: update cache on reopen_prepare [Max]
>
> block/nfs.c | 35 +++
> 1 file changed, 35 insertions(+)
Reviewed-by: Max Reitz
I hope you're re
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 24.08.2015 15:05, Alberto Garcia wrote:
> If an image is opened with driver-specific options then attempting
> to use snapshot_blkdev will fail with "Driver specified twice".
>
> The reason is that bs->filename is replaced with a full JSON object
On 04.08.2015 14:14, Alberto Garcia wrote:
> v7:
> - Rebase against the current master.
> - Update version number in the 'since' field of the
> 'cache-clean-interval' option.
>
> v6: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01929.html
> - Update documentation to clarify what "unu
On 24.08.2015 21:34, Peter Lieven wrote:
> Am 24.08.2015 um 20:39 schrieb Max Reitz:
>> On 24.08.2015 10:06, Peter Lieven wrote:
>>> If the file is readonly its not expected to grow so
>>> save the blocking call to nfs_fstat_async and use
>>> the value save
On 25.08.2015 09:03, Alberto Garcia wrote:
> On Mon 24 Aug 2015 08:54:56 PM CEST, Max Reitz wrote:
>
> [bdrv_fill_options()]
>> User-specified options should always have precedence over any other
>> option. The thing is, we consider the filename to be specified by the
&
f you
feel this is a bad decision, feel free to argue but then I guess we'll
have to reevaluate all bdrv_find_format() calls whether they should
actually be bdrv_find_whitelisted_format() calls.
Max Reitz (5):
block: Always pass NULL as drv for bdrv_open()
block: Drop drv parameter from
Change all callers of bdrv_open() to pass the driver name in the options
QDict instead of passing its BlockDriver pointer.
Signed-off-by: Max Reitz
---
block.c | 24 ++--
block/qcow2.c | 16 -
block/vvfat.c | 8 +--
blockdev.c| 72
Now that this parameter is effectively unused, we can drop it and just
pass NULL to bdrv_fill_options().
Signed-off-by: Max Reitz
---
block.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/block.c b/block.c
index ac89487..8aa5f25 100644
--- a/block.c
Now that this parameter is effectively unused, we can drop it and just
pass NULL on to bdrv_open_inherit().
Signed-off-by: Max Reitz
---
block.c | 9 -
block/block-backend.c | 2 +-
block/parallels.c | 2 +-
block/qcow.c | 2 +-
block/qcow2.c | 6
Now that this parameter is effectively unused, we can drop it and change
the function accordingly.
Signed-off-by: Max Reitz
---
block.c | 59 ++-
1 file changed, 22 insertions(+), 37 deletions(-)
diff --git a/block.c b/block.c
index
It is unused by now, so we can drop it.
Signed-off-by: Max Reitz
---
block.c | 7 ---
include/block/block.h | 2 --
2 files changed, 9 deletions(-)
diff --git a/block.c b/block.c
index 434f43c..461eb94 100644
--- a/block.c
+++ b/block.c
@@ -313,13 +313,6 @@ static int
ied and the NFS share
> is unresponsive.
>
> Signed-off-by: Peter Lieven
> ---
> v1->v2: update cache on reopen_prepare [Max]
> v2->v3: use cache only if cache.direct=off [Max]
>
> block/nfs.c | 36
> 1 file c
fail anyway because of missing
output, but not necessarily (as happened with test 82 recently).
Fix this by making the corresponding environment variables point to
wrapper functions which execute the respective command in a subshell.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/039
the second patch adds a similar notification for the python
tests.
Max Reitz (2):
iotests: Do not suppress segfaults in bash tests
iotests: Warn if python subprocess is killed
tests/qemu-iotests/039 | 19 ++-
tests/qemu-iotests/039.out | 6 +++---
tests/qemu
Currently, if a subprocess of a python test (i.e. qemu-io, qemu-img, or
qemu) receives a signal and is subsequently aborted, this is not logged.
This patch makes python tests always check the exit code of these
subprocesses, and emit a message if they have been killed.
Signed-off-by: Max Reitz
On 31.08.2015 12:00, Alberto Garcia wrote:
> Snapshots created using blockdev-snapshot-sync are currently opened
> using their default options, not even inheriting those from the images
> they are based on.
>
> This patch extends the command by adding an 'options' parameter that
> takes a Blockdev
On 31.08.2015 22:05, Eric Blake wrote:
> On 08/31/2015 01:53 PM, Max Reitz wrote:
>
>> Design question: Would it make sense to instead add a "reference" mode
>> to blockdev-snapshot-sync where you can specify a BDS's node-name
>> instead of snapshot-fil
On 31.08.2015 22:50, Eric Blake wrote:
> On 08/18/2015 05:10 PM, Max Reitz wrote:
>> Instead of returning a pointer to the filename, copy it into a buffer
>> specified by the caller.
>>
>> Signed-off-by: Max Reitz
>> ---
>> block.c | 25
On 31.08.2015 23:00, Eric Blake wrote:
> On 08/18/2015 05:10 PM, Max Reitz wrote:
>> Split the part which actually refreshes the BlockDriverState.filename
>> field off of bdrv_refresh_filename() into a more generic function
>> bdrv_filename(), which first calls bdrv_refres
On 01.09.2015 00:55, Jeff Cody wrote:
> On Mon, Aug 31, 2015 at 09:05:12PM +0200, Max Reitz wrote:
>> Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a
>> segmentation fault, that message is invisible in most cases since the
>> output is generally filtere
lts in tests 41 and 55'
003/4:[0047] [FC] 'iotests: Do not suppress segfaults in bash tests'
004/4:[] [--] 'iotests: Warn if python subprocess is killed'
Max Reitz (4):
iotests: More options for VM.add_drive()
iotests: Respect -nodefaults in tests 41 and 55
iotests:
This patch allows specifying the interface to be used for the drive, and
makes specifying a path optional (if the path is None, the "file" option
will be omitted, thus creating an empty drive).
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
tests/qemu-iotests/iotests.py | 9 ++
While -nodefaults is set in $QEMU_OPTIONS, this is currently (wrongly)
ignored for Python iotests. In order to be prepared for when this is
fixed, we should explicitly add an IDE CD-ROM drive instead of relying
on it being created automatically.
Signed-off-by: Max Reitz
---
tests/qemu-iotests
were
broken for the Python tests; this patch "accidentally" fixes that.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/039 | 19 ++-
tests/qemu-iotests/039.out | 6 +++---
tests/qemu-iotests/061 | 6 --
tests/qemu-iotests/061.out
Currently, if a subprocess of a python test (i.e. qemu-io, qemu-img, or
qemu) receives a signal and is subsequently aborted, this is not logged.
This patch makes python tests always check the exit code of these
subprocesses, and emit a message if they have been killed.
Signed-off-by: Max Reitz
On 04.09.2015 19:18, Kevin Wolf wrote:
> qemu_opts_parse_noisily() already prints an error message with the exact
> reason why the parsing failed. No need to add another less specific one.
>
> Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
signature.asc
Description: Ope
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 04.09.2015 19:18, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> qemu-io-cmds.c | 90
> ++
> 1 file changed, 90 insertions(+)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
ook the functions up in
> bdrv_reopen().
>
> Signed-off-by: Kevin Wolf
> ---
> block/qcow2.c | 71
> ++-
> 1 file changed, 65 insertions(+), 6 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
MGOPTS="compat=1.1,lazy_refcounts=on"
> +_make_test_img $size
> +
> +$QEMU_IO -c "reopen -o lazy-refcounts=off" \
> + -c "write -P 0x5a 0 512" \
Maybe it would be nicer to test this the other way around, write first
and then disable lazy refcounts in
On 04.09.2015 19:18, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/137 | 143
> +
> tests/qemu-iotests/137.out | 43 ++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 187 insertions(+)
> create mod
On 07.09.2015 17:59, Kevin Wolf wrote:
> Am 20.07.2015 um 19:45 hat Max Reitz geschrieben:
>> It has been deprecated as of 2.3, so we can now remove it.
>>
>> Signed-off-by: Max Reitz
>
>> @@ -2241,8 +2188,9 @@ static BlockAIOCB *hdev_aio_ioctl(Bloc
On 07.09.2015 18:12, Kevin Wolf wrote:
> Am 20.07.2015 um 19:45 hat Max Reitz geschrieben:
>> If the "id" field is missing from the options given to blockdev-add,
>> just omit the BlockBackend and create the BlockDriverState tree alone.
>>
>> However, if
On 07.09.2015 18:20, Kevin Wolf wrote:
> Am 20.07.2015 um 19:45 hat Max Reitz geschrieben:
>> Tests 071 and 081 test giving references in blockdev-add. It is not
>> necessary to create a BlockBackend here, so omit it.
>>
>> Signed-off-by: Max Reitz
>> Review
On 07.09.2015 19:43, Kevin Wolf wrote:
> Am 20.07.2015 um 19:45 hat Max Reitz geschrieben:
>> If bdrv_is_inserted() is called on the top level BDS, it should make
>> sure all nodes in the BDS tree are actually inserted.
>>
>> Signed-off-by: Max Reitz
>> Review
On 07.09.2015 20:03, Kevin Wolf wrote:
> Am 20.07.2015 um 19:45 hat Max Reitz geschrieben:
>> bdrv_is_inserted() should be invoked recursively on the children of
>> quorum.
>>
>> Signed-off-by: Max Reitz
>> Reviewed-by: Eric Blake
>> Reviewed-by: Albert
On 07.09.2015 07:53, Wen Congyang wrote:
> On 09/02/2015 11:02 PM, Eric Blake wrote:
>> On 07/20/2015 11:45 AM, Max Reitz wrote:
>>> First of all: Thank you, Eric and Berto, for reviewing v3! And thank
>>> you, Fam, for at least having a peek at it and being confident
+---
> 6 files changed, 120 insertions(+), 120 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
block/qcow2.c | 57 +++--
> 1 file changed, 35 insertions(+), 22 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
lock/qcow2.c | 134
> +-
> 1 file changed, 68 insertions(+), 66 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
lock/qcow2.c | 113
> +-
> 1 file changed, 73 insertions(+), 40 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
file changed, 72 insertions(+), 9 deletions(-)
Whether you mention it or not (can be fixed up when applying the patch,
too):
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
sertions(+)
> create mode 100755 tests/qemu-iotests/137
> create mode 100644 tests/qemu-iotests/137.out
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
Add a test for checking a qcow2 file with a multiple of 2^32 clusters.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/138 | 73 ++
tests/qemu-iotests/138.out | 9 ++
tests/qemu-iotests/group | 1 +
3 files changed, 83 insertions
Some callers actually expected that function to return int64_t. As it
turns out, it doesn't. Fix that.
Max Reitz (2):
qcow2: Make size_to_clusters() return int64_t
iotests: Add test for checking large image files
block/qcow2-cluster.c | 20 +++--
block/qc
).
Signed-off-by: Max Reitz
---
block/qcow2-cluster.c | 20 +++-
block/qcow2.h | 2 +-
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 2975b83..a34f0b1 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2
On 08.09.2015 22:09, Max Reitz wrote:
> Sadly, some images may have more clusters than what can be represented
> using a plain int. We should be prepared for that case (in
> qcow2_check_refcounts() we actually were trying to catch that case, but
> since size_to_clusters() truncated
On 08.09.2015 22:22, Eric Blake wrote:
> On 09/08/2015 02:09 PM, Max Reitz wrote:
>> Sadly, some images may have more clusters than what can be represented
>> using a plain int. We should be prepared for that case (in
>> qcow2_check_refcounts() we actually were trying to
On 08.09.2015 11:13, Wen Congyang wrote:
> On 07/21/2015 01:45 AM, Max Reitz wrote:
>> And a helper function for that, which directly takes a pointer to the
>> BDS to be inserted instead of its node-name (which will be used for
>> implementing 'change' using blockd
On 08.09.2015 23:25, John Snow wrote:
>
>
> On 08/31/2015 03:05 PM, Max Reitz wrote:
>> Currently, if a subprocess of a python test (i.e. qemu-io, qemu-img, or
>> qemu) receives a signal and is subsequently aborted, this is not logged.
>>
>> This patch makes p
On 08.09.2015 23:37, John Snow wrote:
>
>
> On 09/08/2015 05:29 PM, Max Reitz wrote:
>> On 08.09.2015 23:25, John Snow wrote:
>>>
>>>
>>> On 08/31/2015 03:05 PM, Max Reitz wrote:
>>>> Currently, if a subprocess of a python test (i.e. qem
On 09.09.2015 12:01, Wen Congyang wrote:
> On 09/09/2015 05:20 AM, Max Reitz wrote:
>> On 08.09.2015 11:13, Wen Congyang wrote:
>>> On 07/21/2015 01:45 AM, Max Reitz wrote:
>>>> And a helper function for that, which directly takes a pointer to the
>>>> B
On 09.09.2015 10:45, Kevin Wolf wrote:
> Am 08.09.2015 um 22:09 hat Max Reitz geschrieben:
>> Sadly, some images may have more clusters than what can be represented
>> using a plain int. We should be prepared for that case (in
>> qcow2_check_refcounts() we actually were tryi
Add a test for checking a qcow2 file with a multiple of 2^32 clusters.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
tests/qemu-iotests/138 | 73 ++
tests/qemu-iotests/138.out | 9 ++
tests/qemu-iotests/group | 1 +
3 files changed
Some callers actually expected that function to return uint64_t. As it
turns out, it doesn't. Fix that.
v2:
- Patch 1:
- int64_t -> uint64_t [Eric]
- Several fixes in places calling size_to_clusters() (and
transitively, too) [Kevin]
- Patch 2:
- s/occuring/occurring/ [Eric]
M
).
Cc: qemu-stable
Signed-off-by: Max Reitz
---
block/qcow2-cluster.c | 30 +++---
block/qcow2-refcount.c | 10 +++---
block/qcow2.h | 6 +++---
3 files changed, 29 insertions(+), 17 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index
On 10.09.2015 03:12, Wen Congyang wrote:
> On 09/09/2015 08:59 PM, Max Reitz wrote:
>> On 09.09.2015 12:01, Wen Congyang wrote:
>>> On 09/09/2015 05:20 AM, Max Reitz wrote:
>>>> On 08.09.2015 11:13, Wen Congyang wrote:
>>>>> On 07/21/2015 01:45 AM, Max
On 10.09.2015 05:22, Wen Congyang wrote:
> On 09/09/2015 08:59 PM, Max Reitz wrote:
>> On 09.09.2015 12:01, Wen Congyang wrote:
>>> On 09/09/2015 05:20 AM, Max Reitz wrote:
>>>> On 08.09.2015 11:13, Wen Congyang wrote:
>>>>> On 07/21/2015 01:45 AM, Max
strictly monotonic increasing cluster offsets. However, this
behavior is not set in stone, and it is also not obvious when looking at
qcow2_alloc_bytes() alone, so we should not rely on it.
Reported-by: Kevin Wolf
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 6 ++
1 file changed, 6
On 11.09.2015 09:30, Wen Congyang wrote:
> On 09/11/2015 03:09 AM, Max Reitz wrote:
>> On 10.09.2015 03:12, Wen Congyang wrote:
>>> On 09/09/2015 08:59 PM, Max Reitz wrote:
>>>> On 09.09.2015 12:01, Wen Congyang wrote:
>>>>> On 09/09/2015 05:20 AM, Max
c Blake
> ---
> blockdev.c | 2 +-
> qapi-schema.json | 2 +-
> qapi/block-core.json | 8
> 3 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Max Reitz
signature.asc
Description: OpenPGP digital signature
On 10.09.2015 15:39, Alberto Garcia wrote:
> If set to true, the image will be opened with the BDRV_O_NO_BACKING
> flag. This is useful for creating snapshots using images opened with
> blockdev-add, since they are not supposed to have a backing image
> before the operation.
>
> Signed-off-by: Alb
On 11.09.2015 19:28, Kevin Wolf wrote:
> Am 11.09.2015 um 19:21 hat Max Reitz geschrieben:
>> On 10.09.2015 15:39, Alberto Garcia wrote:
>>> If set to true, the image will be opened with the BDRV_O_NO_BACKING
>>> flag. This is useful for creating snapshots using images o
s shared.
>
> Signed-off-by: Alberto Garcia
> ---
> blockdev.c | 163
> ---
> qapi-schema.json | 2 +
> qapi/block-core.json | 26
> qmp-commands.hx | 29 +
> 4 files changed, 160 i
On 14.09.2015 11:57, Kevin Wolf wrote:
> Am 14.09.2015 um 11:46 hat Peter Maydell geschrieben:
>> On 11 September 2015 at 20:40, Kevin Wolf wrote:
>>> The following changes since commit 30c38c90bd3f1bb105ebc069ac1821067c980b7c:
>>>
>>> scripts/qemu-gdb: Add brief comment describing usage (2015-0
upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/2:[0002] [FC] 'qcow2: Make size_to_clusters() return uint64_t'
002/2:[] [--] 'iotests: Add test for checking large image files'
1401 - 1500 of 2576 matches
Mail list logo
