Re: [PATCH 3/6] dump/win_dump: fix use after free of err

2020-03-30 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > It's possible that we'll try to set err twice (or more). It's bad, it > will crash. True. > Instead, use warn_report(). Improvement even without the potential crash enabled by the loop. > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

[PATCH 3/6] dump/win_dump: fix use after free of err

2020-03-24 Thread Vladimir Sementsov-Ogievskiy
It's possible that we'll try to set err twice (or more). It's bad, it will crash. Instead, use warn_report(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- dump/win_dump.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dump/win_dump.c b/dump/win_dump.c index