rning.
Signed-off-by: Peter Maydell
---
block/block-backend.c | 4
blockdev.c| 39 +++
include/sysemu/blockdev.h | 2 ++
3 files changed, 45 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index 93e46f3..a4
et no_cdrom to avoid getting a
default cdrom device -- this is needed because the virtio-blk
device will fail if it is connected to a block backend with
no media, which is what the default cdrom device typically is.
Providing a cdrom with media via -cdrom will still work.
Signed-off-by: Peter Maydel
user towards if=none.
Signed-off-by: Peter Maydell
---
hw/core/qdev-properties-system.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index 56954b4..bde9e12 100644
--- a/hw/core/qdev-prope
On 12 June 2015 at 17:23, Kevin Wolf wrote:
> The following changes since commit 4cb618abc1818586c08011ff0a84a015787b1672:
>
> Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150612' into
> staging (2015-06-12 12:49:40 +0100)
>
> are available in the git repository at:
>
>
> git://re
Ping?
thanks
-- PMM
On 12 June 2015 at 14:26, Peter Maydell wrote:
> This patchset attempts to improve the warning and error messages for
> bad user command lines that attempt to connect a drive up to two
> devices. The motivation here is patch #4, which changes the default
> inter
On 20 June 2015 at 16:00, Markus Armbruster wrote:
> Peter Maydell writes:
>> I do definitely want to enable short-options for virt for 2.4...
>
> "Enable short options" = change virt's default block interface type from
> IF_IDE to IF_VIRTIO, I presume.
On 22 June 2015 at 10:39, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> Instead of having set_pointer() call a parse callback which returns
>> an error number that we then convert to an Error string with
>> error_set_from_qdev_prop_error(), make the parse callbac
On 22 June 2015 at 10:12, Markus Armbruster wrote:
> I think we should just bite the bullet and extend Error to support
> additional helpful information for humans.
...I thought all of the string was already just helpful information
for humans? I certainly hope we aren't expecting anybody to pars
On 22 June 2015 at 10:59, Markus Armbruster wrote:
> What about this instead:
>
> 1. When -device creation connects a qdev_prop_drive property to a
> backend, fail when the backend has a DriveInfo and the DriveInfo has
> type != IF_NONE. Note: the connection is made in parse_drive().
So, the rea
On 22 June 2015 at 10:59, Markus Armbruster wrote:
> What about this instead:
>
> 1. When -device creation connects a qdev_prop_drive property to a
> backend, fail when the backend has a DriveInfo and the DriveInfo has
> type != IF_NONE. Note: the connection is made in parse_drive().
>
> 2. This
-drive if=none,file=tmp.qcow2,id=foo -device ide-hd,drive=foo \
-device ide-hd,drive=foo
Previously:
qemu-system-x86_64: -device ide-hd,drive=foo: Property 'ide-hd.drive'
can't take value 'foo', it's in use
Now:
qemu-system-x86_64: -device ide-hd,drive=foo: Dri
drive options?)
The command line will be changed to include 'if=none', as the
error message suggests.
Signed-off-by: Peter Maydell
---
hw/arm/virt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index f1e85c8..7e643ba 100644
--- a/hw/arm
than the generic ones.
Signed-off-by: Peter Maydell
---
hw/core/qdev-properties-system.c | 33 -
1 file changed, 20 insertions(+), 13 deletions(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index 0309fe5..56954b4 100644
--- a
wires it up manually
to two different devices; in this case their command line is doubly broken
and if they use if=none as suggested by message 1 they'll then get message 2
and can fix their own double-usage...)
Changes v1->v2:
* drop "warn if an if= drive was also connected manually&qu
On 25 June 2015 at 08:40, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> Now we have virtio-pci, we can make the virt board's default block
>> device type be IF_VIRTIO. This allows users to use simplified
>> command lines that don't have to explicitly cre
On 25 June 2015 at 10:26, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> This patchset attempts to improve the warning and error messages for
>> bad user command lines that attempt to connect a drive up to two
>> devices. The motivation here is patch #4, w
On 25 June 2015 at 18:56, Programmingkid wrote:
> Nice to hear from you again Laurent. The only way a solution in
> hdev_open() would work is if it could prevent find_image_format()
> from executing. Otherwise find_image_format() would just quit QEMU
> with an error.
The question you should be as
On 29 June 2015 at 17:54, Programmingkid wrote:
> @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = {
> .bdrv_ioctl = hdev_ioctl,
> .bdrv_aio_ioctl = hdev_aio_ioctl,
> #endif
> +
> +#ifdef __APPLE__
> +.bdrv_is_inserted = cdrom_is_inserted,
> +#endif
Why is
On 29 June 2015 at 19:04, Programmingkid wrote:
>
> On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote:
>
>> On 29 June 2015 at 17:54, Programmingkid wrote:
>>> @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = {
>>> .bdrv_ioctl = hd
On 13 July 2015 at 20:26, John Snow wrote:
> Just a handful of casts to quiet coverity up.
>
> s->ports should never exceed 32, but coverity doesn't know that.
> ncq_tfs->sector_count should also never exceed 64K.
Personally I tend to mark that kind of thing as a false
positive in the coverity UI
On 14 July 2015 at 16:39, Kevin Wolf wrote:
> The following changes since commit f3a1b5068cea303a55e2a21a97e66d057eaae638:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2015-07-13 13:35:51 +0100)
>
> are available in the git repository at:
>
>
> git://repo.o
On 15 July 2015 at 03:26, Jeff Cody wrote:
> The following changes since commit 661725da09f47eb92d356fac10a4cf3b7ad1f61d:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150714' into
> staging (2015-07-14 18:50:17 +0100)
>
> are available in the git repository at:
>
>
> g...@git
On 17 July 2015 at 20:24, Programmingkid wrote:
> Is pstrcpy() ansi c? I'm having trouble finding documentation for it.
No, it's something we provide in util/cutils.c. We recommend it
in HACKING, but we don't actually document the semantics, which
is a bit unhelpful. I've just sent a patch which
On 20 July 2015 at 15:54, Kevin Wolf wrote:
> The following changes since commit 71358470eec668f5dc53def25e585ce250cea9bf:
>
> Merge remote-tracking branch 'remotes/amit-virtio-rng/tags/vrng-2.4' into
> staging (2015-07-17 15:22:45 +0100)
>
> are available in the git repository at:
>
>
> git:
Use pow2ceil() to round up to the next power of 2, rather
than an inline calculation.
Signed-off-by: Peter Maydell
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 40d4880..5da41b2 100644
--- a/hw/block/nvme.c
+++ b
Nothing uses qemu_fls() any more, so delete it.
Signed-off-by: Peter Maydell
---
include/qemu-common.h | 1 -
util/cutils.c | 5 -
2 files changed, 6 deletions(-)
diff --git a/include/qemu-common.h b/include/qemu-common.h
index 237d654..bc6f8f8 100644
--- a/include/qemu-common.h
know the size can't be 0.
In the case where the size value had bit 31 set, the old code
would invoke undefined behaviour; the new code will give a
result of 0. Presumably that could never happen either.)
Signed-off-by: Peter Maydell
---
hw/pci/msix.c | 4 +---
hw/pci/pci.c | 4 +---
2
Use pow2floor() to round down to the nearest power of 2,
rather than an inline calculation.
Signed-off-by: Peter Maydell
---
exec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/exec.c b/exec.c
index 7d60e15..4710e2d 100644
--- a/exec.c
+++ b/exec.c
@@ -2371,9 +2371,7
Use the utility function pow2ceil() for rounding up to the next
largest power of 2, rather than inline calculation.
Signed-off-by: Peter Maydell
---
hw/virtio/virtio-pci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
anup a
day"; that may be a bit ambitious, so we'll see...)
Peter Maydell (5):
hw/pci: Use pow2ceil() rather than hand-calculation
hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation
hw/block/nvme.c: Use pow2ceil() rather than hand-calculation
exec.c: Use pow2floo
On 23 July 2015 at 17:54, Paolo Bonzini wrote:
>
>
> On 23/07/2015 13:08, Peter Maydell wrote:
>> We have a qemu_fls() function which is just a silly wrapper
>> around clz32() and which is used in only a handful of places
>> in the codebase. It turns out that all of th
On 24 July 2015 at 06:10, Paolo Bonzini wrote:
>
>
> On 23/07/2015 22:10, Peter Maydell wrote:
>>> > The series looks good, but I'd prefer (especially for patch 4 which is
>>> > in a fast path) if pow2ceil and pow2floor were made inline.
>> Yeah, I wa
the pow2ceil and pow2floor functions to inline.
Peter Maydell (6):
hw/pci: Use pow2ceil() rather than hand-calculation
hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation
hw/block/nvme.c: Use pow2ceil() rather than hand-calculation
exec.c: Use pow2floor() rather than hand
know the size can't be 0.
In the case where the size value had bit 31 set, the old code
would invoke undefined behaviour; the new code will give a
result of 0. Presumably that could never happen either.)
Signed-off-by: Peter Maydell
---
hw/pci/msix.c | 4 +---
hw/pci/pci.c | 4 +---
2
Use the utility function pow2ceil() for rounding up to the next
largest power of 2, rather than inline calculation.
Signed-off-by: Peter Maydell
---
hw/virtio/virtio-pci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
Nothing uses qemu_fls() any more, so delete it.
Signed-off-by: Peter Maydell
---
include/qemu-common.h | 1 -
util/cutils.c | 5 -
2 files changed, 6 deletions(-)
diff --git a/include/qemu-common.h b/include/qemu-common.h
index 237d654..bc6f8f8 100644
--- a/include/qemu-common.h
() along with them.
We then need to include host-utils.h from qemu-common.h so that
the files which use these functions via qemu-common.h still have
access to them.
Signed-off-by: Peter Maydell
---
include/qemu-common.h | 16 +---
include/qemu/host-utils.h | 33
Use pow2floor() to round down to the nearest power of 2,
rather than an inline calculation.
Signed-off-by: Peter Maydell
---
exec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/exec.c b/exec.c
index 7d60e15..4710e2d 100644
--- a/exec.c
+++ b/exec.c
@@ -2371,9 +2371,7
Use pow2ceil() to round up to the next power of 2, rather
than an inline calculation.
Signed-off-by: Peter Maydell
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 40d4880..5da41b2 100644
--- a/hw/block/nvme.c
+++ b
On 27 July 2015 at 16:46, Kevin Wolf wrote:
> The following changes since commit 122e7dab8ac549c8c5a9e1e13aa2464190e888de:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into
> staging (2015-07-27 14:53:42 +0100)
>
> are available in the git repository at:
>
>
> git
On 28 July 2015 at 05:23, Jeff Cody wrote:
> The following changes since commit f8787f8723eaca1be99e3b1873e54de163fffa93:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150727' into
> staging (2015-07-27 19:37:09 +0100)
>
> are available in the git repository at:
>
>
> g...@git
On 30 July 2015 at 19:41, John Snow wrote:
> Peter: I assume you still want this for 2.4 to fix the clang warnings, yes?
Yeah, it's safe enough. (I don't actually require these clang
warnings all fixed for 2.4; but it's a nice-to-have.)
thanks
-- PMM
On 4 August 2015 at 15:48, Sascha Silbe wrote:
> Commit 488981a4 [block: convert quorum blockdrv to use crypto APIs]
> broke qemu-iotest 041 on hosts with GnuTLS < 2.10.0. It converted a
> compile-time check to a run-time check at device open time. The result
> is that we now advertise a feature (
Ping?
(Patches 1 and 2 have been reviewed; thanks.)
-- PMM
On 24 July 2015 at 13:33, Peter Maydell wrote:
> We have a qemu_fls() function which is just a silly wrapper
> around clz32() and which is used in only a handful of places
> in the codebase. It turns out that all of those a
On 14 August 2015 at 14:57, Jeff Cody wrote:
> The following changes since commit be1f13ac9d9fc21908975460652a72f5f0c018c5:
>
> Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150813' into
> staging (2015-08-13 17:47:44 +0100)
>
> are available in the git repository at:
>
>
> g...@gi
On 14 August 2015 at 15:55, Jeff Cody wrote:
> On Fri, Aug 14, 2015 at 03:51:03PM +0100, Peter Maydell wrote:
>> Your pull req tag has not only these two commits in it,
>> but also a merge commit ("Merge branch 'block-next' into HEAD).
>> Why is that?
>
I've noticed recently that tests/hd-geo-test.c creates test disk
images which are 4GB in size, which is a problem if the filesystem
on the host doesn't support sparse files. In particular, OSX's HFS+
doesn't have sparse file support, and Windows probably doesn't either.
Worse, if the test fails an
On 31 August 2015 at 19:54, John Snow wrote:
> Oh, taking a look at it, it needs to writethat MBR data to the file
> before it opens it. We don't have an existing qemu-io dependency here to
> use.
>
> I could add it, but the line between iotest and qtest starts to get
> pretty fuzzy.
I don't care
There are two lines in 2.4's changelog (http://wiki.qemu.org/ChangeLog/2.4)
in the "Block devices in system emulation" section which read:
* FIXME: Throttle groups
and
* FIXME: incremental backup?
Could somebody fill these in with real content before we all forget
what was and wasn't in 2.4?
Ping?
Paolo, do you want to take these, should I just apply them
to master, or what?
thanks
-- PMM
On 24 July 2015 at 13:33, Peter Maydell wrote:
> We have a qemu_fls() function which is just a silly wrapper
> around clz32() and which is used in only a handful of places
> in the cod
On 4 September 2015 at 21:10, Kevin Wolf wrote:
> The following changes since commit b597aa037dbd98014c8dec3d69a5e2240f432533:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2015-09-04'
> into staging (2015-09-04 17:37:50 +0100)
>
> are available in the git repository at:
>
On 7 September 2015 at 13:34, Paolo Bonzini wrote:
>
>
> On 07/09/2015 13:04, Peter Maydell wrote:
>> Ping?
>>
>> Paolo, do you want to take these, should I just apply them
>> to master, or what?
>
> Sorry, I thought you were applying these or pulling the
On 11 September 2015 at 20:40, Kevin Wolf wrote:
> The following changes since commit 30c38c90bd3f1bb105ebc069ac1821067c980b7c:
>
> scripts/qemu-gdb: Add brief comment describing usage (2015-09-11 17:14:50
> +0100)
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu/kevin.gi
On 14 September 2015 at 16:25, Kevin Wolf wrote:
> The following changes since commit 2b750d9d261bda7f75b39dfc1e1e5f22502929d5:
>
> Merge remote-tracking branch 'remotes/aurel/tags/pull-sh4-next-20150913'
> into staging (2015-09-14 10:46:38 +0100)
>
> are available in the git repository at:
>
>
Hi. I was looking at adding ppc64be to the set of machines I do build
tests on before merging patches, but right now "make check" fails on
this host.
ERROR:/home/pm215/qemu/tests/ide-test.c:721:cdrom_pio_impl: assertion
failed ((data) & (DRQ | DRDY) == (DRQ | DRDY)): (0x0040 ==
0x0048)
GTe
On 25 September 2015 at 08:50, Jeff Cody wrote:
> The following changes since commit eb9d0ea063fc7bdfab76b84085602a9e48d13ec7:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20150924' into staging (2015-09-24
> 01:32:11 +0100)
>
> are available in the git repository
On 1 October 2015 at 20:05, Jeff Cody wrote:
> The following changes since commit fa500928ad9da6dd570918e3dfca13c029af07a8:
>
> Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20150930'
> into staging (2015-10-01 10:49:38 +0100)
>
> are available in the git repository at:
>
>
On 9 March 2018 at 16:18, Kevin Wolf wrote:
> The following changes since commit d9bbfea646e86426d549bd612cd9f91e49aa50c2:
>
> Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-upstream-v8.2'
> into staging (2018-03-09 10:58:57 +)
>
> are available in the git repository at:
>
>
On 12 March 2018 at 16:01, Stefan Hajnoczi wrote:
> The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2018-03-09 17:28:16 +)
>
> are available in the Git repository at:
>
>
On 13 March 2018 at 12:29, Jeff Cody wrote:
> The following changes since commit 834eddf22ec762839b724538c7be1d1d3b2d9d3b:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2018-03-13 10:49:02 +)
>
> are available in the git repository at:
>
> git
On 13 March 2018 at 16:17, Kevin Wolf wrote:
> The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804:
>
> Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into
> staging (2018-03-13 11:42:45 +)
>
> are available in the git repository at:
>
> git:
On 15 March 2018 at 17:18, Kevin Wolf wrote:
> The following changes since commit 56e8698ffa8aba9f762f980bc21b5340b006f24b:
>
> Merge remote-tracking branch
> 'remotes/stsquad/tags/pull-travis-speedup-130318-1' into staging (2018-03-15
> 14:48:09 +)
>
> are available in the git repository
On 19 March 2018 at 11:04, Kevin Wolf wrote:
> The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb:
>
> Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into
> staging (2018-03-17 14:15:03 +)
>
> are available in the git repository at:
>
> git://r
On 20 March 2018 at 09:44, Daniel P. Berrangé wrote:
> We can follow what autoconf does, and add a check to configure to see if
> there are generated files left in the source dir, when configuring with
> builddir != srcdir, and exit with error, telling user to clean their
> src dir first.
We alre
On 22 March 2018 at 17:19, Max Filippov wrote:
> Ok, I can add a fixup that changes #include to #include
> "xtensa-isa.h".
> Adding #include "qemu/osdep.h" there seems pointless to me.
Every top level .c file must start with including osdep.h.
Other headers that it might include rely on that.
It
On 22 March 2018 at 17:30, Eric Blake wrote:
> I'm less certain of whether our Coccinelle scripts have easy ways to exclude
> specific files. We already have scripts/cocci-macro-file.h to help
> Coccinelle not choke on some our existing files, but I'm not sure if
> Coccinelle has a config-file li
On 22 March 2018 at 17:57, wrote:
> Checking PATCH 4/4: Remove unnecessary variables for function return value...
> ERROR: return is not a function, parentheses are not required
> #251: FILE: target/mips/dsp_helper.c:3281:
> +return (temp[1] << 63) | (temp[0] >> 1);
This looks like a bug in
On 22 March 2018 at 19:12, Eric Blake wrote:
> Or if we don't patch the false negative, you can bypass checkpatch with an
> ugly hack:
>
> return 0 + (...) | (...);
>
> (I'm NOT going to do that bypass - it's too ugly for my taste)
Yeah, that's definitely not something we should be doing.
checkpa
On 26 March 2018 at 15:35, Kevin Wolf wrote:
> The following changes since commit 7b1db0908d88f0c9cfac24e214ff72a860692e23:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20180323' into staging (2018-03-25
> 13:51:33 +0100)
>
> are available in the git repository at:
On 26 March 2018 at 21:20, Max Reitz wrote:
> The following changes since commit 7b93d78a04aa242d377ae213b79db6c319c71847:
>
> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
> staging (2018-03-26 15:17:25 +0100)
>
> are available in the Git repository at:
>
> git://gith
On 3 April 2018 at 17:13, Jeff Cody wrote:
> The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5:
>
> Merge remote-tracking branch
> 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31
> 09:42:33 +0100)
>
> are available in the git repository at
On 3 April 2018 at 17:33, Kevin Wolf wrote:
> The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5:
>
> Merge remote-tracking branch
> 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31
> 09:42:33 +0100)
>
> are available in the git repository a
On 4 April 2018 at 17:10, Jeff Cody wrote:
> The following changes since commit fd69ad866b62ca8ed4337ffee83b6d82a4e99282:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2018-04-04 14:00:07 +0100)
>
> are available in the git repository at:
>
> git://github.
On 10 April 2018 at 16:37, Kevin Wolf wrote:
> The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request'
> into staging (2018-04-10 14:04:27 +0100)
>
> are available in the git repository at:
>
>
On 16 April 2018 at 13:38, Max Reitz wrote:
> The following changes since commit ae2b1b4e1bb89ea949446597c8776255da0a79d3:
>
> Merge remote-tracking branch
> 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2018-04-16
> 10:11:17 +0100)
>
> are available in the Git repository at:
On 12 March 2018 at 15:21, Vladimir Sementsov-Ogievskiy
wrote:
> Minimal realization: only one extent in server answer is supported.
> Flag NBD_CMD_FLAG_REQ_ONE is used to force this behavior.
Hi; Coverity complains about a possible use of uninitialized
variables in this function (CID 1390607, 13
On 9 March 2018 at 16:19, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to sheepdog, which enables
> image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> Reviewed-by: Max Reitz
Hi; Coverity (CID 1390614) thinks there's a resource leak in this function:
> +static int cor
On 9 March 2018 at 16:19, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to sheepdog, which enables
> image creation over QMP.
>
> Signed-off-by: Kevin Wolf
> Reviewed-by: Max Reitz
Hi; Coverity (CID 1390641) points out that the changes to
parse_redundancy_str() introduce a m
On 9 March 2018 at 16:19, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to file, which enables
> image creation over QMP.
> +static int coroutine_fn raw_co_create_opts(const char *filename, QemuOpts
> *opts,
> + Error **errp)
> +{
> +
On 13 February 2018 at 17:04, Kevin Wolf wrote:
> From: Max Reitz
>
> We want to use this function in sd_truncate() later on, so taking a
> filename is not exactly ideal.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Eric Blake
> Signed-off-by: Kevin Wolf
> ---
> block/sheepdog.c | 29 +
On 2 March 2018 at 18:54, Kevin Wolf wrote:
> From: Eric Blake
>
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Update the iscsi driver accordingly. In this case,
> it is handy to teach iscsi_co_block_status() to handle a NULL map
> and file parameter, even t
On 8 May 2018 at 16:19, Jeff Cody wrote:
> The following changes since commit d01beac177d44491d7db8747b79d94e1b53d173b:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/vga-20180507-pull-request' into staging (2018-05-08
> 14:23:02 +0100)
>
> are available in the git repository at:
>
>
On 12 May 2018 at 10:28, Stefan Hajnoczi wrote:
> The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544:
>
> Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
> staging (2018-05-08 17:05:58 +0100)
>
> are available in the Git repository at:
>
> git
On 14 May 2018 at 14:15, Peter Maydell wrote:
> On 12 May 2018 at 10:28, Stefan Hajnoczi wrote:
>> The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544:
>>
>> Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
>&g
On 12 May 2018 at 10:28, Stefan Hajnoczi wrote:
> The following changes since commit e5cd695266c5709308aa95b1baae499e4b5d4544:
>
> Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
> staging (2018-05-08 17:05:58 +0100)
>
> are available in the Git repository at:
>
> git
On 15 May 2018 at 16:39, Kevin Wolf wrote:
> The following changes since commit ad1b4ec39caa5b3f17cbd8160283a03a3dcfe2ae:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/input-20180515-pull-request' into staging (2018-05-15
> 12:50:06 +0100)
>
> are available in the git repository at:
On 16 May 2018 at 18:42, Jeff Cody wrote:
> The following changes since commit c416eecea5f3aea863ab8fda5a36a24157b8f704:
>
> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
> (2018-05-15 17:02:00 +0100)
>
> are available in the git repository at:
>
> git://github.c
On 12 May 2018 at 10:28, Stefan Hajnoczi wrote:
> From: Joe Perches
>
> Whenever files are added, moved, or deleted, the MAINTAINERS file
> patterns can be out of sync or outdated.
>
> To try to keep MAINTAINERS more up-to-date, add a one-time warning
> whenever a patch does any of those.
>
This
d-off-by: Peter Maydell
---
block/sheepdog.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 4237132419..2a5bc0a59a 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -1859,9 +1859,7 @@ out:
error_setg_errno(errp,
On 21 May 2018 at 07:35, Fam Zheng wrote:
> Coverity doesn't like the tests under fail label (report CID 1385847).
> Reset the fields so the clean up order is more apparent.
>
> Signed-off-by: Fam Zheng
> ---
> block/nvme.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/block/nv
On 23 May 2018 at 14:11, Kevin Wolf wrote:
> The following changes since commit 4f50c1673a89b07f376ce5c42d22d79a79cd466d:
>
> Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request'
> into staging (2018-05-22 09:43:58 +0100)
>
> are available in the git repository at:
>
> g
On 15 May 2018 at 16:40, Kevin Wolf wrote:
> From: Alberto Garcia
>
> The L2 and refcount caches have default sizes that can be overridden
> using the l2-cache-size and refcount-cache-size (an additional
> parameter named cache-size sets the combined size of both caches).
Hi; Coverity raises a n
On 28 May 2018 at 09:58, Alberto Garcia wrote:
> On Mon 28 May 2018 10:38:55 AM CEST, Kevin Wolf wrote:
>>> > +if (!refcount_cache_size_set) {
>>> > +*refcount_cache_size = MIN_REFCOUNT_CACHE_SIZE *
>>> > s->cluster_size;
>>>
>>> ...but in the else clause down here, we don't h
On 30 May 2018 at 16:56, Kevin Wolf wrote:
> Merge remote-tracking branch
> 'remotes/edgar/tags/edgar/xilinx-next-2018-05-29-v1.for-upstream' into
> staging (2018-05-29 13:01:11 +0100)
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for y
Half a dozen miscellaneous conversions away from old_mmio usage
in the MemoryRegionOps struct. This leaves us with only 10
remaining in the tree.
NB: mips parts tested only via 'make check'.
thanks
-- PMM
Peter Maydell (6):
hw/sh/sh7750: Convert away from old_mmio
hw/m68k/mcf520
Convert the pckbd device away from using the old_mmio field
of MemoryRegionOps. This change only affects the memory-mapped
variant of the i8042, which is used by the Unicore32 'puv3'
board and the MIPS Jazz boards 'magnum' and 'pica61'.
Signed-off-by: Peter Mayde
Convert the wdt_i6300esb device away from using the old_mmio field
of MemoryRegionOps.
Signed-off-by: Peter Maydell
---
hw/watchdog/wdt_i6300esb.c | 48 --
1 file changed, 36 insertions(+), 12 deletions(-)
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw
Convert the parallel device away from using the old_mmio field
of MemoryRegionOps. This change only affects the memory-mapped
variant, which is used by the MIPS Jazz boards 'magnum' and 'pica61'.
Signed-off-by: Peter Maydell
---
hw/
Convert the sh7750 device away from using the old_mmio field
of MemoryRegionOps. This device is used by the sh4 r2d board.
Signed-off-by: Peter Maydell
---
hw/sh4/sh7750.c | 44
1 file changed, 36 insertions(+), 8 deletions(-)
diff --git a/hw/sh4
Convert the mcf5206 device away from using the old_mmio field
of MemoryRegionOps. This device is used by the an5206 board.
Signed-off-by: Peter Maydell
---
hw/m68k/mcf5206.c | 48 +++
1 file changed, 36 insertions(+), 12 deletions(-)
diff --git a/hw
301 - 400 of 1579 matches
Mail list logo
