Re: [Qemu-block] [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename()

2017-11-15 Thread Peter Maydell
On 6 November 2017 at 16:55, Kevin Wolf wrote: > error_setg_errno() takes a positive errno code. > > Signed-off-by: Kevin Wolf > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index 684cb018da..f6415547fe 100644 > --- a/block.c > +++ b/

Re: [Qemu-block] [Qemu-devel] [PULL 00/25] Block layer patches for 2.11.0-rc2

2017-11-20 Thread Peter Maydell
On 17 November 2017 at 18:16, Kevin Wolf wrote: > The following changes since commit fec035a53fa15c4c8c4e62bfef56a35df4161e38: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20171117-pull-request' > into staging (2017-11-17 10:18:41 +) > > are available in the git repository at: >

Re: [Qemu-block] [Qemu-devel] [PULL 00/25] Block layer patches for 2.11.0-rc2

2017-11-20 Thread Peter Maydell
On 20 November 2017 at 15:24, Kevin Wolf wrote: > Am 20.11.2017 um 15:53 hat Peter Maydell geschrieben: >> GTESTER tests/test-replication >> ** >> ERROR:/home/petmay01/linaro/qemu-for-merges/tests/test-replication.c:117:test_blk_write: >> assertion failed: (async

Re: [Qemu-block] [PULL 0/7] Block layer patches for 2.11.0-rc2

2017-11-21 Thread Peter Maydell
On 21 November 2017 at 15:10, Kevin Wolf wrote: > The following changes since commit d0dead3b6df7f6cd970ed02e8369ab8730aac9d3: > > scripts/make-release: ship u-boot source as a tarball (2017-11-21 12:48:20 > +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.gi

Re: [Qemu-block] [PULL 0/4] Late blockjob / coroutine patches for -rc2

2017-11-21 Thread Peter Maydell
On 21 November 2017 at 17:03, Jeff Cody wrote: > The following changes since commit 7c3d1917fd7a3de906170fa3d6d3d4c5918b1e49: > > build: disarm the TCG unit test trap (2017-11-21 15:42:47 +) > > are available in the git repository at: > > git://github.com/codyprime/qemu-kvm-jtc.git tags/bl

Re: [Qemu-block] [PATCH v3 1/3] Switch AMD CFI flash to use new MMIO API

2017-11-23 Thread Peter Maydell
On 13 November 2017 at 16:14, Mike Nawrocki wrote: > Signed-off-by: Mike Nawrocki > --- > hw/block/pflash_cfi02.c | 97 > + > 1 file changed, 18 insertions(+), 79 deletions(-) > > diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c > in

Re: [Qemu-block] [PATCH v3 1/3] Switch AMD CFI flash to use new MMIO API

2017-11-23 Thread Peter Maydell
On 23 November 2017 at 11:26, Peter Maydell wrote: > On 13 November 2017 at 16:14, Mike Nawrocki > wrote: >> Signed-off-by: Mike Nawrocki >> --- >> hw/block/pflash_cfi02.c | 97 >> + >> 1 file cha

Re: [Qemu-block] [PATCH v3 2/3] Enable 8-byte wide access to AMD CFI devices

2017-11-23 Thread Peter Maydell
On 13 November 2017 at 16:14, Mike Nawrocki wrote: > Signed-off-by: Mike Nawrocki > --- > hw/block/pflash_cfi02.c | 143 > ++-- > 1 file changed, 102 insertions(+), 41 deletions(-) > > diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c > i

Re: [Qemu-block] [PATCH v3 3/3] Add partial flash interleaving to AMD CFI devices

2017-11-23 Thread Peter Maydell
On 13 November 2017 at 17:31, Mike Nawrocki wrote: > This mirrors the interleaving support already in place in > pflash_cfi01.c, using the max_device_width and device_width properties. > > Signed-off-by: Mike Nawrocki > --- > hw/block/pflash_cfi02.c | 244 > +

Re: [Qemu-block] [PULL 00/10] Block layer fixes for 2.11.0-rc3

2017-11-29 Thread Peter Maydell
On 29 November 2017 at 15:26, Kevin Wolf wrote: > The following changes since commit e7b47c22e2df14d55e3e4426688c929bf8e3f7fb: > > osdep.h: Make TIME_MAX handle different time_t types (2017-11-24 13:23:36 > +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git

Re: [Qemu-block] [Qemu-devel] Block layer complexity: what to do to keep it under control?

2017-12-01 Thread Peter Maydell
On 1 December 2017 at 17:03, Paolo Bonzini wrote: > Same here. Just like fixing the C code provides a good foundation for a > language switch, some more battle-tested code could be converted from > QEMU to Rust, in order to get familiar with it and probe whether the > benefits are real. Maybe th

Re: [Qemu-block] [Qemu-devel] Block layer complexity: what to do to keep it under control?

2017-12-04 Thread Peter Maydell
On 4 December 2017 at 10:16, Stefan Hajnoczi wrote: > Yes, please! __attribute__((cleanup)) is great and we should use it in > QEMU. > > I haven't looked at compiler support though... :) Looks like it came in in gcc 3.6, which is earlier than our earliest required version. For clang, it's harder

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: Fixed grammatical error in dump_human_image_check

2017-12-04 Thread Peter Maydell
On 4 December 2017 at 15:51, Max Reitz wrote: > On 2017-12-02 23:37, Shravan Rajinikanth wrote: >> Signed-off-by: Shravan Rajinikanth >> --- >> qemu-img.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index 68b375f..bea9268 100644 >> --- a

Re: [Qemu-block] [PULL 0/1] Block layer patch for 2.11.0-rc4

2017-12-04 Thread Peter Maydell
On 4 December 2017 at 17:01, Kevin Wolf wrote: > The following changes since commit 495566ec38817e6625294e6909cffb4de040c8e7: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171204' > into staging (2017-12-04 11:27:53 +) > > are available in the git repository at: > >

Re: [Qemu-block] [Qemu-devel] [PATCH 0/6] QTests: use Python to run complex tests

2017-12-14 Thread Peter Maydell
On 14 December 2017 at 17:33, Paolo Bonzini wrote: > And also in software collections. For 2.12 (as part of the above "drop > Python 2.x support" plan) I'm reluctant to require a non-system python on OSX to build. thanks -- PMM

Re: [Qemu-block] [PULL 00/10] Block patches

2017-12-19 Thread Peter Maydell
On 18 December 2017 at 21:08, Jeff Cody wrote: > The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging (2017-12-17 > 15:27:41 +) > > are available in the git repository

Re: [Qemu-block] [Qemu-devel] [PULL 00/14] Block layer patches

2017-12-20 Thread Peter Maydell
On 20 December 2017 at 13:19, Kevin Wolf wrote: > The following changes since commit af352675efb7e92a1f5f6461a042a12015ab3d12: > > Merge remote-tracking branch 'remotes/aurel/tags/pull-target-sh4-20171218' > into staging (2017-12-19 19:11:11 +) > > are available in the git repository at: >

Re: [Qemu-block] [Qemu-devel] STOP Re: [PULL 4/4] qmp: add nbd-server-remove

2017-12-21 Thread Peter Maydell
On 21 December 2017 at 09:07, Vladimir Sementsov-Ogievskiy wrote: > no, I've updated it, we discussed with Kevin that this approach is bad To say that a pullreq is bad you need to reply to the cover letter, there's no guarantee I'll notice a followup to one of the individual patches in it. (As it

Re: [Qemu-block] [PULL v2 00/13] Block layer patches

2017-12-21 Thread Peter Maydell
On 21 December 2017 at 15:26, Kevin Wolf wrote: > The following changes since commit 4da5c51cac8363f86ec92dc99c38f9382d617647: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-12-20' > into staging (2017-12-20 20:38:36 +) > > are available in the git repository at: > >

Re: [Qemu-block] [PULL v3 00/35] Block layer patches

2018-01-08 Thread Peter Maydell
On 22 December 2017 at 15:18, Kevin Wolf wrote: > The following changes since commit 281f327487c9c9b1599f93c589a408bbf4a651b8: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2017-12-22 > 00:11:36 +) > > are available in the git repository

Re: [Qemu-block] [Qemu-devel] [PULL 00/29] Block layer patches

2018-01-25 Thread Peter Maydell
On 23 January 2018 at 14:01, Kevin Wolf wrote: > The following changes since commit ee86981bda9ecd40c8daf81b7307b1d2aff68174: > > migration: Revert postcopy-blocktime commit set (2018-01-23 10:08:05 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for

Re: [Qemu-block] [PULL 0/2] Block patches

2018-02-02 Thread Peter Maydell
On 1 February 2018 at 04:06, Jeff Cody wrote: > The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into > staging (2018-01-31 15:50:29 +) > > are available in the git repository at: > > git://

Re: [Qemu-block] [Qemu-devel] [PULL 00/55] Block layer patches

2018-02-15 Thread Peter Maydell
On 13 February 2018 at 17:04, Kevin Wolf wrote: > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: > > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-u

Re: [Qemu-block] [PULL v2 0/3] Block patches

2018-02-15 Thread Peter Maydell
On 15 February 2018 at 09:42, Stefan Hajnoczi wrote: > The following changes since commit bec9c64ef7be8063f1192608b83877bc5c9ea217: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-02-13 18:24:08 +) > > are available in the Git repository at: > > g

Re: [Qemu-block] [Qemu-devel] [PULL 00/37] Block layer patches

2018-03-05 Thread Peter Maydell
On 2 March 2018 at 18:54, Kevin Wolf wrote: > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 > 14:37:10 +) > > are available in the git repository at:

Re: [Qemu-block] [PULL 0/6] Block patches

2018-03-05 Thread Peter Maydell
On 5 March 2018 at 09:40, Stefan Hajnoczi wrote: > The following changes since commit 136c67e07869227b21b3f627316e03679ce7b738: > > Merge remote-tracking branch > 'remotes/bkoppelmann/tags/pull-tricore-2018-03-02' into staging (2018-03-02 > 16:56:20 +) > > are available in the Git reposito

Re: [Qemu-block] [PULL v2 00/38] Block layer patches

2018-03-06 Thread Peter Maydell
On 5 March 2018 at 17:51, Kevin Wolf wrote: > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 > 14:37:10 +) > > are available in the git repository at:

Re: [Qemu-block] [PULL v2 00/38] Block layer patches

2018-03-06 Thread Peter Maydell
On 6 March 2018 at 10:24, Kevin Wolf wrote: > Am 06.03.2018 um 11:09 hat Peter Maydell geschrieben: >> On 5 March 2018 at 17:51, Kevin Wolf wrote: >> > The following changes since commit >> > 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: >> > >> >

Re: [Qemu-block] [PULL v2 00/38] Block layer patches

2018-03-06 Thread Peter Maydell
On 5 March 2018 at 17:51, Kevin Wolf wrote: > The following changes since commit 86f4c7e05b1c44dbe1b329a51f311f10aef6ff34: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180302' into staging (2018-03-02 > 14:37:10 +) > > are available in the git repository at:

Re: [Qemu-block] [PULL 0/6] Qio next patches

2018-03-08 Thread Peter Maydell
On 7 March 2018 at 11:25, Daniel P. Berrangé wrote: > The following changes since commit f2bb2d14c2958f3f5aef456bd2cdb1ff99f4a562: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-05 16:41:20 +) > > are available in the Git repository at: >

Re: [Qemu-block] [PULL 0/7] Block patches

2018-03-09 Thread Peter Maydell
On 9 March 2018 at 13:19, Stefan Hajnoczi wrote: > The following changes since commit 0ab4537f08e09b13788db67efd760592fb7db769: > > Merge remote-tracking branch > 'remotes/stefanberger/tags/pull-tpm-2018-03-07-1' into staging (2018-03-08 > 12:56:39 +) > > are available in the Git repositor

Re: [Qemu-block] [Qemu-devel] [PULL 00/56] Block layer patches

2018-03-12 Thread Peter Maydell
On 9 March 2018 at 16:18, Kevin Wolf wrote: > The following changes since commit d9bbfea646e86426d549bd612cd9f91e49aa50c2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-qemu-upstream-v8.2' > into staging (2018-03-09 10:58:57 +) > > are available in the git repository at: > >

Re: [Qemu-block] [PULL 0/1] Block patches

2018-03-13 Thread Peter Maydell
On 12 March 2018 at 16:01, Stefan Hajnoczi wrote: > The following changes since commit e4ae62b802cec437f877f2cadc4ef059cc0eca76: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-09 17:28:16 +) > > are available in the Git repository at: > >

Re: [Qemu-block] [PULL 0/1] Block patches

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 12:29, Jeff Cody wrote: > The following changes since commit 834eddf22ec762839b724538c7be1d1d3b2d9d3b: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2018-03-13 10:49:02 +) > > are available in the git repository at: > > git

Re: [Qemu-block] [PULL 00/41] Block layer patches

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 16:17, Kevin Wolf wrote: > The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804: > > Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into > staging (2018-03-13 11:42:45 +) > > are available in the git repository at: > > git:

Re: [Qemu-block] [PULL v2 00/44] Block layer patches

2018-03-16 Thread Peter Maydell
On 15 March 2018 at 17:18, Kevin Wolf wrote: > The following changes since commit 56e8698ffa8aba9f762f980bc21b5340b006f24b: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-travis-speedup-130318-1' into staging (2018-03-15 > 14:48:09 +) > > are available in the git repository

Re: [Qemu-block] [PULL v3 00/46] Block layer patches

2018-03-19 Thread Peter Maydell
On 19 March 2018 at 11:04, Kevin Wolf wrote: > The following changes since commit e1e44a9916b4318e943aecd669e096222cb3eaeb: > > Merge remote-tracking branch 'remotes/xtensa/tags/20180316-xtensa' into > staging (2018-03-17 14:15:03 +) > > are available in the git repository at: > > git://r

Re: [Qemu-block] [PATCH] qemu: include generated files with <> and not ""

2018-03-20 Thread Peter Maydell
On 20 March 2018 at 09:44, Daniel P. Berrangé wrote: > We can follow what autoconf does, and add a check to configure to see if > there are generated files left in the source dir, when configuring with > builddir != srcdir, and exit with error, telling user to clean their > src dir first. We alre

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 17:19, Max Filippov wrote: > Ok, I can add a fixup that changes #include to #include > "xtensa-isa.h". > Adding #include "qemu/osdep.h" there seems pointless to me. Every top level .c file must start with including osdep.h. Other headers that it might include rely on that. It

Re: [Qemu-block] [PATCH 4/4] Remove unnecessary variables for function return value

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 17:30, Eric Blake wrote: > I'm less certain of whether our Coccinelle scripts have easy ways to exclude > specific files. We already have scripts/cocci-macro-file.h to help > Coccinelle not choke on some our existing files, but I'm not sure if > Coccinelle has a config-file li

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 17:57, wrote: > Checking PATCH 4/4: Remove unnecessary variables for function return value... > ERROR: return is not a function, parentheses are not required > #251: FILE: target/mips/dsp_helper.c:3281: > +return (temp[1] << 63) | (temp[0] >> 1); This looks like a bug in

Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle

2018-03-22 Thread Peter Maydell
On 22 March 2018 at 19:12, Eric Blake wrote: > Or if we don't patch the false negative, you can bypass checkpatch with an > ugly hack: > > return 0 + (...) | (...); > > (I'm NOT going to do that bypass - it's too ugly for my taste) Yeah, that's definitely not something we should be doing. checkpa

Re: [Qemu-block] [Qemu-devel] [PULL 00/19] Block layer patches

2018-03-27 Thread Peter Maydell
On 26 March 2018 at 15:35, Kevin Wolf wrote: > The following changes since commit 7b1db0908d88f0c9cfac24e214ff72a860692e23: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180323' into staging (2018-03-25 > 13:51:33 +0100) > > are available in the git repository at:

Re: [Qemu-block] [PULL 0/4] Block patches for 2.12.0-rc1

2018-03-27 Thread Peter Maydell
On 26 March 2018 at 21:20, Max Reitz wrote: > The following changes since commit 7b93d78a04aa242d377ae213b79db6c319c71847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-03-26 15:17:25 +0100) > > are available in the Git repository at: > > git://gith

Re: [Qemu-block] [PULL 0/3] Block patches for 2.12-rc2

2018-04-04 Thread Peter Maydell
On 3 April 2018 at 17:13, Jeff Cody wrote: > The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 > 09:42:33 +0100) > > are available in the git repository at

Re: [Qemu-block] [PULL 0/9] Block layer patches for 2.12.0-rc2

2018-04-04 Thread Peter Maydell
On 3 April 2018 at 17:33, Kevin Wolf wrote: > The following changes since commit f184de7553272223d6af731d7d623a7cebf710b5: > > Merge remote-tracking branch > 'remotes/riscv/tags/riscv-qemu-2.12-critical-fixes' into staging (2018-03-31 > 09:42:33 +0100) > > are available in the git repository a

Re: [Qemu-block] [PULL for-2.12 0/1] Block patches

2018-04-04 Thread Peter Maydell
On 4 April 2018 at 17:10, Jeff Cody wrote: > The following changes since commit fd69ad866b62ca8ed4337ffee83b6d82a4e99282: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2018-04-04 14:00:07 +0100) > > are available in the git repository at: > > git://github.

Re: [Qemu-block] [PULL 0/7] Block layer patches for 2.12.0-rc3

2018-04-11 Thread Peter Maydell
On 10 April 2018 at 16:37, Kevin Wolf wrote: > The following changes since commit df6378eb0e6cfd58a22a1c3ff8fa4a9039f1eaa8: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180410-pull-request' > into staging (2018-04-10 14:04:27 +0100) > > are available in the git repository at: > >

Re: [Qemu-block] [PULL 0/2] Block patches for 2.12.0-rc4

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 13:38, Max Reitz wrote: > The following changes since commit ae2b1b4e1bb89ea949446597c8776255da0a79d3: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.12-pull-request' into staging (2018-04-16 > 10:11:17 +0100) > > are available in the Git repository at:

Re: [PULL 0/3] hw/nvme updates

2021-09-24 Thread Peter Maydell
On Fri, 24 Sept 2021 at 07:47, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi Peter, > > The following changes since commit 2c3e83f92d93fbab071b8a96b8ab769b01902475: > > Merge remote-tracking branch > 'remotes/alistair23/tags/pull-riscv-to-apply-20210921' into staging > (2021-09-21 10:57:4

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Peter Maydell
On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > We want to switch both from QemuOpts to the keyval parser in the future, > which results in some incompatibilities, mainly around list handling. > Mark the non-JSON version of both as unstable syntax so that management > tools switch to JSON and

Re: [PATCH 11/11] Deprecate stable non-JSON -device and -object

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 12:27, Kevin Wolf wrote: > > Am 27.09.2021 um 11:00 hat Peter Maydell geschrieben: > > On Fri, 24 Sept 2021 at 10:14, Kevin Wolf wrote: > > > > > > We want to switch both from QemuOpts to the keyval parser in the future, > > >

Re: [PATCH v2 2/5] hw/arm: Add Nuvoton SD module to board

2021-11-01 Thread Peter Maydell
On Fri, 8 Oct 2021 at 01:26, Hao Wu wrote: > > From: Shengtan Mao > > Signed-off-by: Shengtan Mao > Reviewed-by: Hao Wu > Reviewed-by: Chris Rauer > Reviewed-by: Tyrone Ting > Signed-off-by: Hao Wu Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 4/5] tests/qtest/libqos: add SDHCI commands

2021-11-01 Thread Peter Maydell
ts/qtest/libqos/sdhci-cmd.c | 116 + > tests/qtest/libqos/sdhci-cmd.h | 70 > 3 files changed, 187 insertions(+) > create mode 100644 tests/qtest/libqos/sdhci-cmd.c > create mode 100644 tests/qtest/libqos/sdhci-cmd.h Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 1/5] hw/sd: add nuvoton MMC

2021-11-01 Thread Peter Maydell
unsigned int size) > +{ > +NPCM7xxSDHCIState *s = opaque; > + > +switch (addr) { > +case NPCM7XX_BOOTTOCTRL: > +s->regs.boottoctrl = val; > +break; > +default: > + qemu_log_mask(LOG_GUEST_ERROR, "SDHCI write of nonexist reg: 0x%02" ditto Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 5/5] tests/qtest: add qtests for npcm7xx sdhci

2021-11-01 Thread Peter Maydell
On Fri, 8 Oct 2021 at 01:26, Hao Wu wrote: > > From: Shengtan Mao > > Signed-off-by: Shengtan Mao > Reviewed-by: Hao Wu > Reviewed-by: Chris Rauer > Reviewed-by: Tyrone Ting > Signed-off-by: Hao Wu Reviewed-by: Peter Maydell thanks -- PMM

does drive_get_next(IF_NONE) make sense?

2021-11-02 Thread Peter Maydell
Does it make sense for a device/board to do drive_get_next(IF_NONE) ? At the moment we have exactly one user of this, which is hw/misc/sifive_u_otp.c. This is a model of a one-time-programmable fuse, and the drive is providing the backing store for the fuse contents. Borrowing an IF_NONE for this

qemu-img.c possibly overflowing shifts by BDRV_SECTOR_BITS

2021-11-09 Thread Peter Maydell
Hi; Coverity is complaining about some of the places in qemu-img.c where it takes a 32-bit variable and shifts it left by BDRV_SECTOR_BITS to convert a sector count to a byte count, because it's doing the shift in 32-bits rather than 64 and so Coverity thinks there might be overflow (CID 1465221, 1

Re: qemu-img.c possibly overflowing shifts by BDRV_SECTOR_BITS

2021-11-10 Thread Peter Maydell
On Wed, 10 Nov 2021 at 11:36, Kevin Wolf wrote: > > Am 09.11.2021 um 20:07 hat Peter Maydell geschrieben: > > Hi; Coverity is complaining about some of the places in qemu-img.c > > where it takes a 32-bit variable and shifts it left by BDRV_SECTOR_BITS > > to convert

Re: does drive_get_next(IF_NONE) make sense?

2021-11-14 Thread Peter Maydell
On Fri, 12 Nov 2021 at 13:34, Markus Armbruster wrote: > > Thomas Huth writes: > > > On 03/11/2021 09.41, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> Does it make sense for a device/board to do drive_get_next(IF_NONE) ? > >

Re: does drive_get_next(IF_NONE) make sense?

2021-11-15 Thread Peter Maydell
On Mon, 15 Nov 2021 at 13:24, Kevin Wolf wrote: > Same question as for Hao Wu's series: Wouldn't the proper solution be to > add a drive property to the machine type? > > If you can't use -blockdev, it's not done right. Is there an example of "doing it right" for built-in-to-the-machine devices?

Re: [PATCH RFC 2/2] hw: Replace drive_get_next() by drive_get()

2021-11-15 Thread Peter Maydell
On Mon, 15 Nov 2021 at 12:55, Markus Armbruster wrote: > > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define unit numb

Re: [PATCH RFC 1/2] hw/sd/ssi-sd: Do not create SD card within controller's realize

2021-11-15 Thread Peter Maydell
On Mon, 15 Nov 2021 at 12:56, Markus Armbruster wrote: > > ssi_sd_realize() creates an "sd-card" device. This is inappropriate, > and marked FIXME. > > Move it to the boards that create these devices. Prior art: commit > eb4f566bbb for device "generic-sdhci", and commit 26c607b86b for > device "

Re: [PATCH RFC 0/2] Eliminate drive_get_next()

2021-11-15 Thread Peter Maydell
On Mon, 15 Nov 2021 at 12:55, Markus Armbruster wrote: > > This is RFC because I'm unsure about the removal of > > /* Reason: init() method uses drive_get_next() */ > dc->user_creatable = false; > > in PATCH 1. Both users appear to wire up some GPIO. If that's > necessary for the thing t

"make check" fails in a clang sanitizer build on "nbd-qemu-allocation" iotest

2021-11-15 Thread Peter Maydell
Hi; running a 'make check' on a clang sanitizer build one of the iotests falls over due to a NULL pointer being passed to memset(): TEST iotest-qcow2: nbd-qemu-allocation [fail] QEMU -- "/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/tests/qemu-iotests/../../qemu-system-a

Re: does drive_get_next(IF_NONE) make sense?

2021-11-18 Thread Peter Maydell
On Thu, 18 Nov 2021 at 13:04, Alistair Francis wrote: > > On Tue, Nov 16, 2021 at 2:10 AM Thomas Huth wrote: > > What kind of device is that OTP exactly? If it is some kind of non-serial > > flash device, maybe you could simply use IF_PFLASH instead? > > It just says "one time programmable memory

Re: [PATCH v2 04/13] hw/arm/versatilepb hw/arm/vexpress: Replace drive_get_next() by drive_get()

2021-11-29 Thread Peter Maydell
pb", > "vexpress-a9", "vexpress-a15") connect just one or two backends of a > type with drive_get_next(). Change them to use drive_get() directly. > This makes the unit numbers explicit in the code. > > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 05/13] hw/arm/imx25_pdk: Replace drive_get_next() by drive_get()

2021-11-29 Thread Peter Maydell
t; counting loop. Change it to use drive_get() directly. This makes the > unit numbers explicit in the code. > > Cc: Peter Maydell > Cc: Jean-Christophe Dubois > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 07/13] hw/arm/mcimx7d-sabre: Replace drive_get_next() by drive_get()

2021-11-29 Thread Peter Maydell
a > counting loop. Change it to use drive_get() directly. This makes the > unit numbers explicit in the code. > > Cc: Peter Maydell > Cc: Andrey Smirnov > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 06/13] hw/arm/mcimx6ul-evk: Replace drive_get_next() by drive_get()

2021-11-29 Thread Peter Maydell
a > counting loop. Change it to use drive_get() directly. This makes the > unit numbers explicit in the code. > > Cc: Peter Maydell > Cc: Jean-Christophe Dubois > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [RFC v2 1/4] tls: add macros for coroutine-safe TLS variables

2021-12-02 Thread Peter Maydell
On Thu, 2 Dec 2021 at 14:44, Peter Maydell wrote: > My compiler-developer colleagues present the following case where > 'noinline' is not sufficient for the compiler to definitely > use different values of the address-of-the-TLS-var across an > intervening function call

Re: [RFC v2 1/4] tls: add macros for coroutine-safe TLS variables

2021-12-02 Thread Peter Maydell
On Wed, 1 Dec 2021 at 17:19, Stefan Hajnoczi wrote: > > Compiler optimizations can cache TLS values across coroutine yield > points, resulting in stale values from the previous thread when a > coroutine is re-entered by a new thread. > > Serge Guelton developed an __attribute__((noinline)) wrapper

Re: [PATCH v2 01/13] hw/sd/ssi-sd: Do not create SD card within controller's realize

2021-12-06 Thread Peter Maydell
On Mon, 6 Dec 2021 at 12:35, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > I guess a already asked this once but don't remember now... What is the > > point of creating a SD card without drive? Is this due to the old design > > issue we hotplug the drive to the SD card and not the

Re: [RFC v3 0/4] tls: add macros for coroutine-safe TLS variables

2021-12-06 Thread Peter Maydell
On Mon, 6 Dec 2021 at 14:33, Stefan Hajnoczi wrote: > > v3: > - Added __attribute__((weak)) to get_ptr_*() [Florian] Do we really need it *only* on get_ptr_*() ? If we need to noinline the other two we probably also should use the same attribute weak to force no optimizations at all. -- PMM

Re: [RFC v3 0/4] tls: add macros for coroutine-safe TLS variables

2021-12-07 Thread Peter Maydell
On Tue, 7 Dec 2021 at 13:53, Stefan Hajnoczi wrote: > > On Mon, Dec 06, 2021 at 02:34:45PM +, Peter Maydell wrote: > > On Mon, 6 Dec 2021 at 14:33, Stefan Hajnoczi wrote: > > > > > > v3: > > > - Added __attribute__((weak)) to get_ptr_*() [Florian]

Re: [PULL 0/1] Block patches

2021-12-09 Thread Peter Maydell
On Thu, 9 Dec 2021 at 15:21, Stefan Hajnoczi wrote: > > The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0: > > Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800) > > are available in the Git repository at: > > https://gitlab.com/stefanha/qemu.git tags/b

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Peter Maydell
On Mon, 10 Jan 2022 at 13:14, Christian Schoenebeck wrote: > I'd suggest to use: > > #if !defined(MAC_OS_VERSION_12_0) || > (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_VERSION_12_0) > #define kAudioObjectPropertyElementMain kAudioObjectPropertyElementMaster > #endif This is also how we do this for

iotest 040, 041, intermittent failure in netbsd VM

2022-01-10 Thread Peter Maydell
Just saw this failure of iotests in a netbsd VM (the in-tree tests/vm stuff). Pretty sure it's an intermittent as the pulreq being tested has nothing io or block related. TEST iotest-qcow2: 036 TEST iotest-qcow2: 037 TEST iotest-qcow2: 038 [not run] TEST iotest-qcow2: 039 [not run

Re: [PULL 0/2] SD/MMC patches for 2022-01-08

2022-01-10 Thread Peter Maydell
On Sat, 8 Jan 2022 at 21:59, Philippe Mathieu-Daudé wrote: > > Hi Richard, > > This is the SD/MMC PR that ought to be sent previously. > > The following changes since commit b5a3d8bc9146ba22a25116cb748c97341bf99737: > > Merge tag 'pull-misc-20220103' of https://gitlab.com/rth7680/qemu into > st

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Peter Maydell
On Mon, 10 Jan 2022 at 19:01, Akihiko Odaki wrote: > Assuming the correctness of the use MAC_OS_X_VERSION_MAX_ALLOWED is > irrelevant with the nature of the identifier (constant or not), the same > problem is in ui/cocoa.m: > #ifndef MAC_OS_X_VERSION_10_13 > #define MAC_OS_X_VERSION_10_13 101300 >

Re: [PULL 0/2] SD/MMC patches for 2022-01-08

2022-01-11 Thread Peter Maydell
On Mon, 10 Jan 2022 at 19:20, Philippe Mathieu-Daudé wrote: > > On 1/10/22 17:02, Peter Maydell wrote: > > On Sat, 8 Jan 2022 at 21:59, Philippe Mathieu-Daudé wrote: > >> > >> Hi Richard, > >> > >> This is the SD/MMC PR that ought to be sent p

Re: [PULL 0/2] SD/MMC patches for 2022-01-08

2022-01-11 Thread Peter Maydell
On Sat, 8 Jan 2022 at 21:59, Philippe Mathieu-Daudé wrote: > > Hi Richard, > > This is the SD/MMC PR that ought to be sent previously. > > The following changes since commit b5a3d8bc9146ba22a25116cb748c97341bf99737: > > Merge tag 'pull-misc-20220103' of https://gitlab.com/rth7680/qemu into > st

Re: [PULL 0/4] Python patches

2022-01-12 Thread Peter Maydell
On Mon, 10 Jan 2022 at 23:25, John Snow wrote: > > The following changes since commit de3f5223fa4cf8bfc5e3fe1fd495ddf468edcdf7: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-7.0-pull-request' into staging (2022-01-10 > 14:43:03 +) > > are available in the Git repository

Re: [PULL 0/6] Block patches

2022-01-14 Thread Peter Maydell
lane ->handle_output() (2022-01-12 > 17:09:39 +) > > -------- > Pull request > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 00/16] Block layer patches

2022-01-15 Thread Peter Maydell
On Fri, 14 Jan 2022 at 13:52, Kevin Wolf wrote: > > The following changes since commit 67b6526cf042f22521feff5ea521a05d3dd2bf8f: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2022-01-13 13:59:56 +) > > are available in the Git repository at: > >

Re: iotest 040, 041, intermittent failure in netbsd VM

2022-01-17 Thread Peter Maydell
On Mon, 17 Jan 2022 at 20:35, John Snow wrote: > > On Mon, Jan 17, 2022 at 5:05 AM Kevin Wolf wrote: > > > > Am 10.01.2022 um 16:55 hat Peter Maydell geschrieben: > > > Just saw this failure of iotests in a netbsd VM > This trace says that we timed out while awa

Re: iotest 040, 041, intermittent failure in netbsd VM

2022-01-17 Thread Peter Maydell
On Mon, 17 Jan 2022 at 20:35, John Snow wrote: > Can you please try applying this temporary patch and running `./check > -qcow2 040 041` until you see a breakage and show me the output from > that? With this temporary patch the VM doesn't launch at all: peter.mayd...@hackbox2.linaro.org:~/qemu-

Re: iotest 040, 041, intermittent failure in netbsd VM

2022-01-18 Thread Peter Maydell
On Mon, 17 Jan 2022 at 23:09, John Snow wrote: > Well, today I learned that: > > (1) vm-build-XXX targets use your host system's QEMU to run that VM > (2) my QMP library cannot talk to QEMU 2.11. Whoops, I hadn't realised I was running with that ancient a QEMU. For the scripted runs I set the PAT

Re: iotest 040, 041, intermittent failure in netbsd VM

2022-01-18 Thread Peter Maydell
On Mon, 17 Jan 2022 at 20:35, John Snow wrote: > I do expect this to print more information on failure than it > currently is, though (bug somewhere in machine.py, I think). > Can you please try applying this temporary patch and running `./check > -qcow2 040 041` until you see a breakage and show

Re: [PULL 00/19] Memory API patches for 2022-01-18

2022-01-18 Thread Peter Maydell
On Tue, 18 Jan 2022 at 12:18, Philippe Mathieu-Daudé via wrote: > > The following changes since commit 6621441db50d5bae7e34dbd04bf3c57a27a71b32: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20220115' > into staging (2022-01-16 20:12:23 +) > > are available in the Gi

Re: [PULL 00/38] Migration 20220127 patches

2022-01-28 Thread Peter Maydell
nsferred_add() - (Edmondson) > - vmstate canary (dgilbert) > - minimum_version_id_old removal (peter maydell) > - postcopy cleanups (peter xu) > - more cleanups (Philippe) > - yet more cleanups (zheng) > - colo and cleanups (zhang) Hi; this fails because we hit this assert in the vm

[PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-01-28 Thread Peter Maydell
Coverity points out that we aren't checking the return value from curl_easy_setopt() for any of the calls to it we make in block/curl.c. Fixes: Coverity CID 1459336, 1459482, 1460331 Signed-off-by: Peter Maydell --- Big fat disclaimer: tested only with 'make check', which I sus

Re: [PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-01-28 Thread Peter Maydell
On Fri, 28 Jan 2022 at 17:50, Daniel P. Berrangé wrote: > > On Fri, Jan 28, 2022 at 04:55:35PM +, Peter Maydell wrote: > > Coverity points out that we aren't checking the return value > > from curl_easy_setopt() for any of the calls to it we make > > in block/cu

Re: [PULL 00/36] Migration 20220128 patches

2022-01-30 Thread Peter Maydell
On Fri, 28 Jan 2022 at 18:31, Juan Quintela wrote: > > The following changes since commit b367db48126d4ee14579af6cf5cdbffeb9496627: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20220127' into > staging (2022-01-28 11:05:29 +) > > are available in the Git repository at: >

Re: [PATCH 2/5] docs: Only mention iscsi in the man page when available

2022-01-31 Thread Peter Maydell
On Mon, 31 Jan 2022 at 17:33, Kevin Wolf wrote: > > If libiscsi is disabled in the build, the man page shouldn't contain > information on how to construct iscsi URLs etc. > > This patch is best viewed with whitespace changes ignored. > > Signed-off-by: Kevin Wolf > --- > -``iSCSI`` > - iSCSI s

iotests failure on netbsd VM, no useful errors logged

2022-02-01 Thread Peter Maydell
Hi; I see an iotests error running 'make vm-build-netbsd' (ie running a build and make check on a NetBSD VM), but there is no indication of what's actually failing. Same thing seems to happen on OpenBSD too. Full logfile at https://people.linaro.org/~peter.maydell/netbsd-log.txt ; here's the relev

Re: [PULL 00/24] Block patches

2022-02-01 Thread Peter Maydell
On Tue, 1 Feb 2022 at 14:42, Hanna Reitz wrote: > > The following changes since commit 804b30d25f8d70dc2dea951883ea92235274a50c: > > Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220130' into > staging (2022-01-31 11:10:08 +) > > are available in the Git repository at: > >

Re: [PULL 00/10] Block layer patches

2022-02-02 Thread Peter Maydell
On Tue, 1 Feb 2022 at 15:21, Kevin Wolf wrote: > > The following changes since commit 804b30d25f8d70dc2dea951883ea92235274a50c: > > Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220130' into > staging (2022-01-31 11:10:08 +) > > are available in the Git repository at: > >

Re: [PULL 0/4] Python patches

2022-02-03 Thread Peter Maydell
On Thu, 3 Feb 2022 at 01:59, John Snow wrote: > > The following changes since commit 47cc1a3655135b89fa75c2824fbddd29df874612: > > Merge remote-tracking branch 'remotes/kwolf-gitlab/tags/for-upstream' into > staging (2022-02-01 19:48:15 +) > > are available in the Git repository at: > > h

Re: [PULL 0/4] Python patches

2022-02-03 Thread Peter Maydell
On Thu, 3 Feb 2022 at 16:38, John Snow wrote: > On Thu, Feb 3, 2022, 11:20 AM Peter Maydell wrote: >> Summary of Failures: >> >> 1/1 qemu:block / qemu-iotests qcow2 ERROR 243.14s exit status 1 >> >> >> Ok: 0 >> E

<    1   2   3   4   5   6   7   8   9   10   >