Jamie Lokier wrote:
> Paolo Bonzini wrote:
> > On 10/15/2009 09:08 PM, Luiz Capitulino wrote:
> > >{ "error": { "code": 12
> > > "desc": "device already open",
> > > "data": { "bus": 0, "address": 12 } } }
> > >
> > > Note that this also can be reused by any bus, as the "
Paolo Bonzini wrote:
> On 10/15/2009 09:08 PM, Luiz Capitulino wrote:
> >{ "error": { "code": 12
> > "desc": "device already open",
> > "data": { "bus": 0, "address": 12 } } }
> >
> > Note that this also can be reused by any bus, as the "data" information
> >is built at e
Anthony Liguori wrote:
> holl...@linux.vnet.ibm.com wrote:
> >It's hard enough to keep localized strings updated for every release
> >within a single code tree. Beyond that, you expect that every *client*
> >will update its localized strings for every *server* release?
>
> What I meant by highly s
Edgar E. Iglesias wrote:
> Did you consider having the linux-user loader pass a qemu version of the
> x86_64 vdso to the guest through the auxvector? That version could probably
> implement the vsyscalls by translating them into syscalls with x86_64 code.
That seems like a good idea.
Note that on
Laurent Desnogues wrote:
> A recent compiler (gcc 4.4.0) produces this code for a statically
> compiled program:
>
> 005779e0 :
> 5779e0: 48 83 ec 08 sub$0x8,%rsp
> 5779e4: 48 c7 c0 00 04 60 ffmov$0xff600400,%rax
> 5779eb: ff d0
Hi Edgar,
On Sat, Oct 17, 2009 at 9:57 PM, Edgar E. Iglesias
wrote:
>
> It feels a bit strange to have the CPU model know about linux vsyscalls.
> Did you consider having the linux-user loader pass a qemu version of the
> x86_64 vdso to the guest through the auxvector? That version could probably
On Sat, Jul 11, 2009 at 05:14:47PM +0200, Laurent Desnogues wrote:
> Hello,
>
> the attached patch implements two of the three x86_64 vsyscall's.
> Also attached is a test that demonstrates the issue and hopefully
> the fix.
>
> Note there is a trick in there: since vsyscall functions are in hig
This patch fixes the mount call. GUEST_BASE shouldn't be added to a NULL
pointer on arg5 .
failing call:
mount("rootfs", "/", 0x47a78, MS_MGC_VAL|MS_REMOUNT, 0x1) = -1 EFAULT (Bad
address)
correct call:
mount("rootfs", "/", 0x37ab0, MS_MGC_VAL|MS_REMOUNT, NULL) = 0
Signed-off-by: Jan-Sim
Anthony Liguori wrote:
Paolo Bonzini wrote:
On 10/16/2009 11:37 PM, Anthony Liguori wrote:
I already am :-) Stay tuned, I should have a patch later this
afternoon.
Was it a race? (Seriously, sorry I didn't notice a couple of hours
ago).
This one is ~5% slower than the "Evil" one, but h
Edgar E. Iglesias wrote:
On Sat, Oct 17, 2009 at 08:36:03AM -0500, Anthony Liguori wrote:
Signed-off-by: Anthony Liguori
---
Makefile |2 +
check-qfloat.c | 81
Hello Anthony,
Shouldn't we put these tests under tes
Paolo Bonzini wrote:
On 10/17/2009 03:03 PM, Anthony Liguori wrote:
I think it makes more sense as an external entity.
Maybe... I just thought of it as a toString method that happens to
emit JSON.
json is one representation of the monitor protocol. I think we should
attempt to design thi
On Sat, Jul 11, 2009 at 5:14 PM, Laurent Desnogues
wrote:
> Hello,
>
> the attached patch implements two of the three x86_64 vsyscall's.
> Also attached is a test that demonstrates the issue and hopefully
> the fix.
>
> Note there is a trick in there: since vsyscall functions are in high
> memory
On Sat, Oct 17, 2009 at 08:36:03AM -0500, Anthony Liguori wrote:
> Signed-off-by: Anthony Liguori
> ---
> Makefile |2 +
> check-qfloat.c | 81
>
Hello Anthony,
Shouldn't we put these tests under tests/something/ ?
Cheers
On 10/17/2009 03:03 PM, Anthony Liguori wrote:
I think it makes more sense as an external entity.
Maybe... I just thought of it as a toString method that happens to emit
JSON.
Paolo
Signed-off-by: Anthony Liguori
---
check-qjson.c | 33 -
1 files changed, 32 insertions(+), 1 deletions(-)
diff --git a/check-qjson.c b/check-qjson.c
index 8760941..9be1448 100644
--- a/check-qjson.c
+++ b/check-qjson.c
@@ -551,11 +551,38 @@ START_TEST(simple_wh
%p lets you specify an already constructed qobject. It takes a weak reference.
Signed-off-by: Anthony Liguori
---
qjson.c | 25 +
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/qjson.c b/qjson.c
index 9279bfb..7bedaf3 100644
--- a/qjson.c
+++ b/qjson.c
Signed-off-by: Anthony Liguori
---
check-qjson.c | 21 +
1 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/check-qjson.c b/check-qjson.c
index 32aa33c..8760941 100644
--- a/check-qjson.c
+++ b/check-qjson.c
@@ -9,6 +9,7 @@
*
*/
#include
+#include
#inc
I've attempted to make this a very thorough unit test for the json parser. It
covers every rule and tries to test the corner cases of each rule.
There's some interesting things in this test case like a literal qobject
type. It may be worth extract that into common code.
Signed-off-by: Anthony L
Not a wonderful choice in conversion characters but nothing else seems better.
Signed-off-by: Anthony Liguori
---
qjson.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/qjson.c b/qjson.c
index ce2c942..9279bfb 100644
--- a/qjson.c
+++ b/qjson.c
@@ -339,6 +339,12 @@
We currently model as json bool as an int. This works fine on the server side
but it means we cannot send back proper bools to the client. Introducing a
proper QBool type fixes that.
Signed-off-by: Anthony Liguori
---
Makefile |2 +-
qbool.c | 76 ++
Instead of parsing true/false as QInt, parse them as QBool and update the
test suite accordingly.
Signed-off-by: Anthony Liguori
---
Makefile |2 +-
check-qjson.c | 19 ++-
qjson.c |5 +++--
3 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/Mak
This implements a json parser that generates qobjects. The intention is that
this all can be eventually moved to a shared library to form the basis of the
QMP client API. Unfortunately, qobject is currently GPL licensed so hopefully
Luiz will switch it to LGPL.
The parser is a pretty straight fo
Signed-off-by: Anthony Liguori
---
Makefile |2 +
check-qfloat.c | 81
configure |2 +-
3 files changed, 84 insertions(+), 1 deletions(-)
create mode 100644 check-qfloat.c
diff --git a/Makefile b/Makefile
index 929463
qfloat is a qobject wrapper for double precision floating points
Signed-off-by: Anthony Liguori
---
Makefile |3 +-
qfloat.c | 76 +
qfloat.h | 29 +++
qobject.h |1 +
4 files changed, 108 insertions(+
I fat-fingered the git send-email command the first time so here's the second
iteration.
This series introduces a json parsing framework. The parser is a recursive
decent parser and implements the full json spec except for the null keyword. We
need to decide how we want to model null in order to
This allows qstring to be used for dynamic string construction.
Signed-off-by: Anthony Liguori
---
qstring.c | 37 -
qstring.h |4
2 files changed, 40 insertions(+), 1 deletions(-)
diff --git a/qstring.c b/qstring.c
index 6d411da..441a9e6 100644
--
Paolo Bonzini wrote:
The JSON encoder is just a virtual method on QObject.
I think it makes more sense as an external entity.
Regards,
Anthony Liguori
Paolo Bonzini wrote:
qemu does not have a string buffer object, so I added this capability
to QString.
Cc: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
check-qstring.c | 79 -
qstring.c | 105
Paolo Bonzini wrote:
This gives more freedom to define prototypes without dragging in
the whole header files.
Cc: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qobject.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/qobject.h b/qobject.h
index 200644d..f5c78b2
On 2009-10-16 09:04:51 -0500, Anthony Liguori wrote:
> Kusanagi Kouichi wrote:
> >If I am using vga and serial which is stdio and hit C-c on
> >serial console, qemu terminates. That is annoying for me.
> >So make it configurable whether signal is generated when C-c is hit.
> >
> >Signed-off-by: Kus
On Fri, Oct 16, 2009 at 02:38:49PM +0200, Ulrich Hecht wrote:
> changes to configure and makefiles for S/390 host and target support,
> fixed as suggested by Juan Quintela
>
> adapted to most recent changes in build system
Basically looks ok, but it would be worth to split it into host and
target
Gerd Hoffmann wrote:
> This patch adds a loader-target.c file for target-specific
> rom loading functions. The rom_add_vga() and rom_add_option()
> macros are transformed into functions and sticked in there. They
> load the bios on TARGET_I386 and no nothing on other targets.
>
> With this in pl
On Fri, Oct 16, 2009 at 05:02:26PM +0300, riku.voi...@iki.fi wrote:
> From: Riku Voipio
>
> Long time no update... A set of relatively small patches for comment
> on the list before sending a pull request.
>
> Max Filippov (1):
> linux-user: fix ppc target_stat64 st_blocks layout
>
> Paul Bol
On Fri, Oct 16, 2009 at 05:52:21PM +0200, Aurelien Jarno wrote:
> On Fri, Oct 16, 2009 at 02:38:47PM +0200, Ulrich Hecht wrote:
> > sync allows concurrent accesses to locations in memory through different TCG
> > variables. This comes in handy when you are emulating CPU registers that can
> > be us
On Fri, Oct 16, 2009 at 11:55:45PM +0200, Jan-Simon Möller wrote:
> This patch fixes the mount call. GUEST_BASE shouldn't be added to a NULL
> pointer on arg5 .
> failing call:
> mount("rootfs", "/", 0x47a78, MS_MGC_VAL|MS_REMOUNT, 0x1) = -1 EFAULT
> (Bad
> address)
> correct call:
> mount
On 10/17/2009 03:50 AM, Anthony Liguori wrote:
Paolo Bonzini wrote:
On 10/16/2009 11:37 PM, Anthony Liguori wrote:
I already am :-) Stay tuned, I should have a patch later this afternoon.
Was it a race? (Seriously, sorry I didn't notice a couple of hours ago).
This one is ~5% slower than th
This patch adds a function to format a QDict according to a string
that is printf like but specifies how to navigate the QDict. All
parts are printed as JSON, but this is fine since this will auto-escape
strings and integers print naturally.
More sophisticated flags can be added later, e.g. %#{fo
The JSON encoder is just a virtual method on QObject.
Cc: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
Makefile |4 ++--
qdict.c | 32
qint.c| 16
qlist.c | 28
qobject.h | 10 ++
qst
And finally, a small testsuite using check as the rest of the QObject
framework.
Cc: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
Makefile |1 +
check-json.c | 123 ++
configure|2 +-
3 files changed, 125 insertions(+)
qemu does not have a string buffer object, so I added this capability
to QString.
Cc: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
check-qstring.c | 79 -
qstring.c | 105 +-
qstring.h
This gives more freedom to define prototypes without dragging in
the whole header files.
Cc: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qobject.h |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/qobject.h b/qobject.h
index 200644d..f5c78b2 100644
--- a/qobject.h
Cc: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qobject.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/qobject.h b/qobject.h
index 4cc9287..200644d 100644
--- a/qobject.h
+++ b/qobject.h
@@ -102,6 +102,8 @@ static inline void qobject_decref(QObject *obj)
*/
s
A nice-to-have utility function, it helps avoiding useless strlen+strdup
pairs.
Cc: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
qemu-common.h |1 +
qemu-malloc.c |8
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index 820dd37.
This patch adds to the QObject system a method to encode JSON
objects. It also adds printf-like capabilities where you can
write %{a.b} in a format string and the method will walk a
QDict to find the "a" first and "b" in a QDict inside that one
(and then print what's found).
Since QEMU does not h
44 matches
Mail list logo
