Re: [Qemu-devel] Re: [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Dustin Kirkland
On Wed, 2009-11-04 at 18:52 -0600, Anthony Liguori wrote: > I'd rather make the "default" network configurable via a global > configuration file. That way, if a distribution knew that it had a > bridge setup for its users, it could make -net bridge the default. Fair enough. :-Dustin signatur

Re: [Qemu-devel] Re: [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Anthony Liguori
Dustin Kirkland wrote: We address this problem by introducing a new network backend: -net bridge. This backend is less flexible than -net tap because it relies on a helper with elevated privileges to do the heavy lifting of allocating and attaching a tap device to a bridge. We use a special pur

[Qemu-devel] Re: [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Dustin Kirkland
On Tue, 2009-11-03 at 18:28 -0600, Anthony Liguori wrote: > This series solves a problem that I've been struggling with for a few years > now. > One of the best things about qemu is that it's possible to run guests as an > unprivileged user to improve security. However, if you want to have your

Re: [Qemu-devel] Inquiry:Solaris 8 installation on QEMU

2009-11-04 Thread Artyom Tarasenko
>> The kernels of Solaris 8 & 9 can be boot too, but then they flood >> about spurious irq 10. It seems that the earlier Solaris versions are >> also suffering from spurious interrupts, because the boot process >> takes very long: ~7 hours on e8...@2.66ghz . > > A bug in the system timer implementa

Re: [Qemu-devel] [PATCH] don't call reset functions on cpu initialization\

2009-11-04 Thread Glauber Costa
On Wed, Nov 04, 2009 at 02:51:08PM -0200, Marcelo Tosatti wrote: > On Tue, Nov 03, 2009 at 05:50:05PM -0200, Glauber Costa wrote: > > There is absolutely no need to call reset functions when initializing > > devices. Since we are already registering them, calling qemu_system_reset() > > should suff

Re: [Qemu-devel] [PATCH] Fix a parallel build failure.

2009-11-04 Thread Daniel Jacobowitz
On Wed, Nov 04, 2009 at 09:48:22PM +0100, Stefan Weil wrote: > Maybe a mix of your patch and my patch > (http://patchwork.ozlabs.org/patch/37446/) > would be the best fix for this problem. > > It should also be possible to apply both patches. Thanks, I didn't find your patch. I don't have any pr

Re: [Qemu-devel] [PATCH] Fix a parallel build failure.

2009-11-04 Thread Stefan Weil
Daniel Jacobowitz schrieb: > From: Daniel Jacobowitz > > With enough parallelism, make will run all the dependencies of > build-all at the same time: > > build-all: config-host.h config-all-devices.h $(DOCS) $(TOOLS) > > So some of the $(TOOLS) will build before config-host.h is finished. > The ob

Re: [Qemu-devel] Re: [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Anthony Liguori
Michael S. Tsirkin wrote: Well it doesn't really help with the issue of privileges which is what this series is really about. Regards, Anthony Liguori I note that by default you grant all users all access. If you do that, just give them net cap admin already? By default, I give no

[Qemu-devel] [PATCH] Fix a parallel build failure.

2009-11-04 Thread Daniel Jacobowitz
From: Daniel Jacobowitz With enough parallelism, make will run all the dependencies of build-all at the same time: build-all: config-host.h config-all-devices.h $(DOCS) $(TOOLS) So some of the $(TOOLS) will build before config-host.h is finished. The object files need to depend on it explicitly

Re: [Qemu-devel] Re: [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Michael S. Tsirkin
On Wed, Nov 04, 2009 at 01:48:01PM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> On Tue, Nov 03, 2009 at 06:28:01PM -0600, Anthony Liguori wrote: >> >>> This series solves a problem that I've been struggling with for a few years >>> now. >>> One of the best things about qemu is t

[Qemu-devel] [PATCH 8/8] monitor: do_info_balloon(): use QError

2009-11-04 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 0e6e21b..423c6b5 100644 --- a/monitor.c +++ b/monitor.c @@ -1717,10 +1717,11 @@ static void do_info_balloon(Monitor *mon, QObject **ret_data)

[Qemu-devel] [PATCH 7/8] qdev: Use QError for not found error

2009-11-04 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/qdev.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index c7884d0..db86cb2 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -29,6 +29,7 @@ #include "qdev.h" #include "sysemu.h" #include "monitor.h" +#include "

[Qemu-devel] [PATCH 6/8] monitor: QError support

2009-11-04 Thread Luiz Capitulino
This commit adds QError support in the Monitor. A QError member is added to the Monitor struct. This new member stores error information and is also used to check if an error has occurred when the called handlers returns. Additionally, a new macro called qemu_error_new() is introduced. It should

[Qemu-devel] [PATCH 5/8] Introduce QError

2009-11-04 Thread Luiz Capitulino
QError is a high-level data type which represents an exception, it stores the following error information: - name A generic error name (eg. "ServiceUnavailable") - descriptionA detailed error description, which may contain references to run-time error data - filename

[Qemu-devel] [PATCH 4/8] QString: Introduce qstring_append_int()

2009-11-04 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qstring.c |8 qstring.h |2 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/qstring.c b/qstring.c index e422bd9..ad17769 100644 --- a/qstring.c +++ b/qstring.c @@ -75,6 +75,14 @@ void qstring_append(QString *qstring, const cha

[Qemu-devel] [PATCH 3/8] Add qstring_append_chr() unit-test

2009-11-04 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- check-qstring.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/check-qstring.c b/check-qstring.c index ea4dfd0..412038a 100644 --- a/check-qstring.c +++ b/check-qstring.c @@ -55,6 +55,22 @@ START_TEST(qstring_get_str_te

[Qemu-devel] [PATCH 2/8] QString: Introduce qstring_append_chr()

2009-11-04 Thread Luiz Capitulino
It appends a C char to a QString. Signed-off-by: Luiz Capitulino --- qstring.c | 24 +++- qstring.h |1 + 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/qstring.c b/qstring.c index 441a9e6..e422bd9 100644 --- a/qstring.c +++ b/qstring.c @@ -53,25 +53,39

[Qemu-devel] [PATCH 1/8] QJSon: Introduce qobject_from_json_va()

2009-11-04 Thread Luiz Capitulino
Simple wrapper to parse_json() that accepts a va_list, will be used by QError. Signed-off-by: Luiz Capitulino --- qjson.c |5 + qjson.h |2 ++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qjson.c b/qjson.c index 5f92996..02fcd83 100644 --- a/qjson.c +++ b/qjson.c @@

[Qemu-devel] [RFC 0/8]: QError v2

2009-11-04 Thread Luiz Capitulino
Hi, I can't remember seeing updated versions of a RFC series, but this should prevent Anthony's scripts from merging these patches. This new QError version has two major changes: the static error table has been dropped and I'm using symbolic names instead of error codes. Now, a call to: mon

Re: [Qemu-devel] Re: [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Anthony Liguori
Michael S. Tsirkin wrote: On Tue, Nov 03, 2009 at 06:28:01PM -0600, Anthony Liguori wrote: This series solves a problem that I've been struggling with for a few years now. One of the best things about qemu is that it's possible to run guests as an unprivileged user to improve security. Howev

[Qemu-devel] Re: [PATCH] sparc32 fix carry flag handling (Solaris bootblk fix)

2009-11-04 Thread Blue Swirl
On Wed, Nov 4, 2009 at 1:58 AM, Artyom Tarasenko wrote: > The page 108 of the SPARC Version 8 Architecture Manual describes > that addcc and addxcc shall compute carry flag the same way. > The page 110 claims the same about subcc and subxcc instructions. > This patch fixes carry computation in cor

Re: [Qemu-devel] Inquiry:Solaris 8 installation on QEMU

2009-11-04 Thread Blue Swirl
On Wed, Nov 4, 2009 at 1:50 AM, Artyom Tarasenko wrote: > 2009/9/19 Blue Swirl : >>  Even Sparc32 can't boot Solaris for some mysterious reason. > > Not so mysterious anymore! Mitch Bradley found that subcc instruction > was not correctly setting carry flag in the case where both arguments > were

[Qemu-devel] Re: [PATCH V6 13/32] pci_host: consolidate pci config address access.

2009-11-04 Thread Aurelien Jarno
On Wed, Nov 04, 2009 at 05:37:13PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 04, 2009 at 04:17:46PM +0100, Aurelien Jarno wrote: > > On Wed, Nov 04, 2009 at 03:14:26PM +0900, Isaku Yamahata wrote: > > > On Tue, Nov 03, 2009 at 03:45:12PM +0200, Michael S. Tsirkin wrote: > > > > > --- a/hw/pci_

[Qemu-devel] Re: [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Michael S. Tsirkin
On Tue, Nov 03, 2009 at 06:28:01PM -0600, Anthony Liguori wrote: > This series solves a problem that I've been struggling with for a few years > now. > One of the best things about qemu is that it's possible to run guests as an > unprivileged user to improve security. However, if you want to have

Re: [Qemu-devel] [PATCH] don't call reset functions on cpu initialization\

2009-11-04 Thread Marcelo Tosatti
On Tue, Nov 03, 2009 at 05:50:05PM -0200, Glauber Costa wrote: > There is absolutely no need to call reset functions when initializing > devices. Since we are already registering them, calling qemu_system_reset() > should suffice. Actually, it is what happens when we reboot the machine, > and using

Re: [Qemu-devel] Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-04 Thread Anthony Liguori
Vincent Hanquez wrote: On Tue, Nov 03, 2009 at 11:38:18AM +0200, Avi Kivity wrote: On 11/03/2009 01:25 PM, Vincent Hanquez wrote: not sure if i'm missing the point here, but couldn't it be hypothetically extended to stuff 3d (or video& more 2d accel ?) commands too ? I can't imagine th

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-04 Thread Amit Shah
On (Wed) Nov 04 2009 [15:30:21], Jan Kiszka wrote: > > I've nothing against your patch, specifically as it removes an obviously > no longer needed workaround, not a feature. I just want to make sure > that the current behavior is not only there by chance. Sure; I understand that. I'll be looking

Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Anthony Liguori
Alexander Graf wrote: Well I'm not that familiar with the bridging stuff as I'm rather scared by it myself, but last time I tried if I # brctl addif br0 eth0 # ifconfig br0 up eth0 stopped working, so I had to stop network manager, assign an IP to br0 manually and hope network manager doesn't k

[Qemu-devel] Re: [PATCH V6 13/32] pci_host: consolidate pci config address access.

2009-11-04 Thread Michael S. Tsirkin
On Wed, Nov 04, 2009 at 04:17:46PM +0100, Aurelien Jarno wrote: > On Wed, Nov 04, 2009 at 03:14:26PM +0900, Isaku Yamahata wrote: > > On Tue, Nov 03, 2009 at 03:45:12PM +0200, Michael S. Tsirkin wrote: > > > > --- a/hw/pci_host.c > > > > +++ b/hw/pci_host.c > > > > @@ -32,6 +32,114 @@ do { printf("

[Qemu-devel] Re: [PATCH V6 13/32] pci_host: consolidate pci config address access.

2009-11-04 Thread Aurelien Jarno
On Wed, Nov 04, 2009 at 03:14:26PM +0900, Isaku Yamahata wrote: > On Tue, Nov 03, 2009 at 03:45:12PM +0200, Michael S. Tsirkin wrote: > > > --- a/hw/pci_host.c > > > +++ b/hw/pci_host.c > > > @@ -32,6 +32,114 @@ do { printf("pci_host_data: " fmt , ## __VA_ARGS__); > > > } while (0) > > > #define

[Qemu-devel] Re: [PATCH] ARM NEON shift emulation fix

2009-11-04 Thread Daniel Gutson
Hi, friendly reminder about this patch. Thanks, Daniel. Daniel Gutson wrote: Any update on this? Thanks, Daniel. Daniel Gutson wrote: Hi, the attached patch fixes a bug that caused some NEON shift operations to shift a wrong amount of bytes. The problem was that a variabl

Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Alexander Graf
Anthony Liguori wrote: > Alexander Graf wrote: >> Yeah. Worse than the "run as root" part is the "it's hard" part >> though. I hate how I feel when I try to explain someone how to use >> non-slirp networking :-(. >> >> The response to that is then usually "oh whatever, it's too >> complicated anywa

Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Anthony Liguori
Alexander Graf wrote: Yeah. Worse than the "run as root" part is the "it's hard" part though. I hate how I feel when I try to explain someone how to use non-slirp networking :-(. The response to that is then usually "oh whatever, it's too complicated anyways". I agree and it's a problem I w

RE: [Qemu-devel] [PATCH 2/4] Add access control support toqemu-bridge-helper

2009-11-04 Thread Krumme, Chris
Hello Anthony, > -Original Message- > From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Wednesday, November 04, 2009 8:23 AM > To: Krumme, Chris > Cc: qemu-devel@nongnu.org; Mark McLoughlin; Arnd Bergmann; > Michael Tsirkin; Juan Quintela; Dustin Kirkland > Subject: Re: [Qemu

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-04 Thread Jan Kiszka
Amit Shah wrote: > On (Wed) Nov 04 2009 [10:39:39], Jan Kiszka wrote: >> Amit Shah wrote: >>> On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: Amit Shah wrote: > On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: >> On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: >>> Amit Shah

Re: [Qemu-devel] [PATCH 4/4] Add support for -net bridge

2009-11-04 Thread Anthony Liguori
Krumme, Chris wrote: Do you need to mention the default name qemubr0 here? Good suggestion. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 2/4] Add access control support toqemu-bridge-helper

2009-11-04 Thread Anthony Liguori
Krumme, Chris wrote: Hello Anthony, Cool patch series. Thanks. +cmd = ptr; +arg = strchr(cmd, ' '); +if (arg == NULL) { +arg = strchr(cmd, '\t'); +} + +if (arg == NULL) { +fprintf(stderr, "Invalid config line:\n %s\n", line)

Re: [Qemu-devel] Re: [PATCH] Add VirtIO Frame Buffer Support

2009-11-04 Thread Vincent Hanquez
On Tue, Nov 03, 2009 at 11:38:18AM +0200, Avi Kivity wrote: > On 11/03/2009 01:25 PM, Vincent Hanquez wrote: >> not sure if i'm missing the point here, but couldn't it be hypothetically >> extended to stuff 3d (or video& more 2d accel ?) commands too ? I can't >> imagine the cirrus or stdvga drive

RE: [Qemu-devel] [PATCH 4/4] Add support for -net bridge

2009-11-04 Thread Krumme, Chris
Hello Anthony, Now that I have read the whole series I say again great patch. > -Original Message- > From: > qemu-devel-bounces+chris.krumme=windriver@nongnu.org > [mailto:qemu-devel-bounces+chris.krumme=windriver@nongnu.o > rg] On Behalf Of Anthony Liguori > Sent: Tuesday, Nov

RE: [Qemu-devel] [PATCH 2/4] Add access control support toqemu-bridge-helper

2009-11-04 Thread Krumme, Chris
Hello Anthony, Cool patch series. > -Original Message- > From: > qemu-devel-bounces+chris.krumme=windriver@nongnu.org > [mailto:qemu-devel-bounces+chris.krumme=windriver@nongnu.o > rg] On Behalf Of Anthony Liguori > Sent: Tuesday, November 03, 2009 6:28 PM > To: qemu-devel@non

[Qemu-devel][PATCH v2] Added read access to several e1000 hw registers

2009-11-04 Thread Kay Ackermann
The e1000 hardware allows read access to several registers which qemu doesn't allow yet. Signed-off-by: Kay Ackermann --- hw/e1000.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 028afd1..3987e70 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -7

Re: [Qemu-devel] Re: [PATCH V6 17/32] pci: 64bit bar support.

2009-11-04 Thread Michael S. Tsirkin
On Wed, Nov 04, 2009 at 03:20:02PM +0900, Isaku Yamahata wrote: > On Tue, Nov 03, 2009 at 04:09:16PM +0200, Michael S. Tsirkin wrote: > > > > Long term, we should fix all devices and *then* they can claim 64 bit > > > > support always. As a nice side effect, we'll be able to avoid > > > > rebuildi

Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu

2009-11-04 Thread Alexander Graf
On 04.11.2009, at 01:28, Anthony Liguori wrote: This series solves a problem that I've been struggling with for a few years now. One of the best things about qemu is that it's possible to run guests as an unprivileged user to improve security. However, if you want to have your guests comm

[Qemu-devel] Re: [PATCH V6 13/32] pci_host: consolidate pci config address access.

2009-11-04 Thread Alexander Graf
On 04.11.2009, at 07:14, Isaku Yamahata wrote: On Tue, Nov 03, 2009 at 03:45:12PM +0200, Michael S. Tsirkin wrote: --- a/hw/pci_host.c +++ b/hw/pci_host.c @@ -32,6 +32,114 @@ do { printf("pci_host_data: " fmt , ## __VA_ARGS__); } while (0) #define PCI_DPRINTF(fmt, ...) #endif +static void

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-04 Thread Amit Shah
On (Wed) Nov 04 2009 [10:39:39], Jan Kiszka wrote: > Amit Shah wrote: > > On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: > >> Amit Shah wrote: > >>> On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: > On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > > Amit Shah wrote: > >> The

[Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling

2009-11-04 Thread Jan Kiszka
Amit Shah wrote: > On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: >> Amit Shah wrote: >>> On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > Amit Shah wrote: >> The initial_reset sent to chardevs doesn't do much other than setting