Re: [Qemu-devel] [Bug 723460] [NEW] qemu on linux doesn't boot for winxp install via usb

2011-02-22 Thread Stefan Hajnoczi
On Tue, Feb 22, 2011 at 11:49 PM, dankoe <723...@bugs.launchpad.net> wrote: > Public bug reported: > > hi guys, > I try to install windows xp via qemu. I can only boot from usb and somehow it > is my problem. > I run a Winxp/xubuntu10.04 Dualboot-system with some virtual drives in > windows ( til

Re: [Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support

2011-02-22 Thread Paolo Bonzini
On 02/22/2011 09:35 PM, Anthony Liguori wrote: So why reinvent this instead of just using glib for thread support? Because Win32 thread support is one patch out of 21. Paolo

Re: [Qemu-devel] Building QEMU on PS3

2011-02-22 Thread Roy Tam
2011/2/23 陳韋任 : > Hi, all > > Is it possible to build qemu whose target is i386-linux-user on > a PS3 machine (Gentoo Linux/PowerPC). > > I am trying to do so, but it failed at compiling i386-linux-user/translate.o. > > Here is the system information: > --

[Qemu-devel] Building QEMU on PS3

2011-02-22 Thread 陳韋任
Hi, all Is it possible to build qemu whose target is i386-linux-user on a PS3 machine (Gentoo Linux/PowerPC). I am trying to do so, but it failed at compiling i386-linux-user/translate.o. Here is the system information: --

Re: [Qemu-devel] Re: QEMU regression problems - Update FPU

2011-02-22 Thread Gerhard Wiesinger
Any comments on this problem? Thnx. Ciao, Gerhard -- http://www.wiesinger.com/ On Fri, 18 Feb 2011, Gerhard Wiesinger wrote: Hello, Good news: Seems to be that 2 of 3 issues have been fixed with QEMU: :-) Summary of previous discussion: http://www.mail-archive.com/qemu-devel@nongnu.org/msg

Re: [Qemu-devel] Re: Network bridging without adding bridge with brctl, possible?

2011-02-22 Thread Gerhard Wiesinger
On Mon, 21 Feb 2011, Arnd Bergmann wrote: On Monday 21 February 2011, Jan Kiszka wrote: Now I think I tried all useful possible combinations: 1.) macvtap0 and macvlan0 in bridged and non bridge mode 2.) macvlan0 based on eth0 or based on macvtap0 3.) Using and ip address on macvlan0 or not (tri

Re: [Qemu-devel] Re: [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-02-22 Thread Yoshiaki Tamura
2011/2/23 ya su : > Yoshi: > >    thanks for your explaining. >    if you introduce a new stage as 3, I think stage 1 also need to change as > it will mark all pages dirty. >    looking forward to your new patch update. Unless there're strong comments from others, I won't put it in this series tho

[Qemu-devel] Re: virtio-serial semantics for binary data and guest agents

2011-02-22 Thread Amit Shah
On (Tue) 22 Feb 2011 [16:40:55], Michael Roth wrote: > If something in the guest is attempting to read/write from the > virtio-serial device, and nothing is connected to virtio-serial's > host character device (say, a socket) > > 1. writes will block until something connect()s, at which point the

[Qemu-devel] how to judge machine's state in user-level/kernel-level

2011-02-22 Thread Jianhui Yue
hi, All, I am wondering how to determine machine's state in user-level or kernel level from Operating System perspective. what's meaning of CPUState.exception_is_int? Thanks. Jianhui

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-22 Thread Chunqiang Tang
> In any case, the next step is to get down to specifics. Here is the > page with the current QCOW3 roadmap: > > http://wiki.qemu.org/Qcow3_Roadmap > > Please raise concrete requirements or features so they can be > discussed and captured. Now it turns into a more productive discussion, but it s

Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-22 Thread Isaku Yamahata
On Tue, Feb 22, 2011 at 06:36:20PM +0100, William Dauchy wrote: > `qdev_free` when unplug a pci device > It resolves a bug when detaching/attaching a network device > > # virsh detach-interface dom0 network --mac 52:54:00:f6:84:ba > Interface detached successfully > > # virsh attach-interfac

[Qemu-devel] [PATCH 14/22] migration: Remove get_status() accessor

2011-02-22 Thread Juan Quintela
It is only used inside migration.c, and fields on that struct are accessed all around the place on that file. Signed-off-by: Juan Quintela --- migration.c | 16 +--- migration.h |1 - 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/migration.c b/migration.c inde

Re: [Qemu-devel] Fwd: [PATCH v2] Guest OS hangs on usb_add

2011-02-22 Thread TJ
On 11/16/2010 02:55 PM, Anthony Liguori wrote: >> >> If you don't like the hack, you can just remove the 3 lines above and use the >> rest of the patch. I will just have to remember to manually patch mine every >> time I upgrade. >> >> Your thoughts? >> > > Yeah, that bit is a bit too gnarly f

[Qemu-devel] [PATCH 08/22] migration: Check that migration is active before cancel it

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index 397a0b9..55f58c8 100644 --- a/migration.c +++ b/migration.c @@ -138,7 +138,7 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict, QObject *

[Qemu-devel] [Bug 722425] Re: guest hangs when starting guest from qcow-images and physical-images

2011-02-22 Thread Yongjie Ren
The problem is solved. Some of our configurations have some errors. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/722425 Title: guest hangs when s

[Qemu-devel] [PATCH 21/22] migration: Export a function that tells if the migration has finished correctly

2011-02-22 Thread Juan Quintela
This will allows us to hide the status values. Signed-off-by: Juan Quintela --- migration.c |4 ++-- migration.h |2 +- ui/spice-core.c |4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index 312a029..383ebaf 100644 --- a/migrat

[Qemu-devel] [PATCH 19/22] migration: convert current_migration from pointer to struct

2011-02-22 Thread Juan Quintela
This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. Signed-off-by: Juan Quintela --- migration.c | 119 -- 1 files changed, 49 insertions(+), 70 deletions(-) diff --git a/migration.c b/migration

[Qemu-devel] [PATCH 18/22] migration: another case of global variable assigned to local one

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index accc6e4..4014330 100644 --- a/migration.c +++ b/migration.c @@ -136,9 +136,8 @@ void do_info_migrate(Monitor *mon, QObject **ret_data) QDic

[Qemu-devel] [PATCH 16/22] migration: Move exported functions to the end of the file

2011-02-22 Thread Juan Quintela
This means we can remove the two forward declarations. Signed-off-by: Juan Quintela --- migration.c | 188 +-- 1 files changed, 92 insertions(+), 96 deletions(-) diff --git a/migration.c b/migration.c index 92bff01..d7dfe1e 100644 --- a/m

[Qemu-devel] [PATCH 15/22] migration: Remove migration cancel() callback

2011-02-22 Thread Juan Quintela
It is used only in one place Signed-off-by: Juan Quintela --- migration.c |9 - migration.h |1 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index 2b873fa..92bff01 100644 --- a/migration.c +++ b/migration.c @@ -131,12 +131,12 @@ free_

[Qemu-devel] [PATCH 20/22] migration: Use bandwidth_limit directly

2011-02-22 Thread Juan Quintela
Now that current_migration is static, there is no reason for max_throotle variable. Signed-off-by: Juan Quintela --- migration.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/migration.c b/migration.c index 7b1e679..312a029 100644 --- a/migration.c +++ b

[Qemu-devel] [PATCH 11/22] migration: Introduce migrate_fd_completed() for consistenncy

2011-02-22 Thread Juan Quintela
This function is a bit different of the others that change the state, in the sense that if migrate_fd_cleanup() returns an error, it set the status to error, not completed. Signed-off-by: Juan Quintela --- migration.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH 13/22] migration: Our release callback was just free

2011-02-22 Thread Juan Quintela
We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we are just freeing the state from previous failed migration (it can't be a sucessful one, otherwise

[Qemu-devel] [PATCH 22/22] migration: Make state definitions local

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c |6 ++ migration.h |6 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index 383ebaf..90fc2a0 100644 --- a/migration.c +++ b/migration.c @@ -31,6 +31,12 @@ do { } while (0) #endif +#de

[Qemu-devel] [PATCH 10/22] migration: Refactor and simplify error checking in migrate_fd_put_ready

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/migration.c b/migration.c index f015e02..641df9f 100644 --- a/migration.c +++ b/migration.c @@ -361,28 +361,26 @@ static void migrate_fd_put_ready(void *opaqu

[Qemu-devel] [PATCH 17/22] migration: use global variable directly

2011-02-22 Thread Juan Quintela
We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu_file_set_rate_limit() function. Signed-off-by: Juan Quintela --- migration.c |6 ++ 1 files changed, 2 insertions(+)

[Qemu-devel] [PATCH 12/22] migration: Use migrate_fd_error() in last place that set status to ERROR

2011-02-22 Thread Juan Quintela
We are also calling to migrate_fd_cleanup(), but notice that it is the right thing to do. Signed-off-by: Juan Quintela --- migration.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/migration.c b/migration.c index ab98664..3983257 100644 --- a/migration.c +++ b/mig

[Qemu-devel] [PATCH 06/22] migration: Make all posible migration functions static

2011-02-22 Thread Juan Quintela
I have to move two functions postions to avoid forward declarations Signed-off-by: Juan Quintela --- migration.c | 72 +- migration.h | 12 - 2 files changed, 36 insertions(+), 48 deletions(-) diff --git a/migration.c b/migrati

[Qemu-devel] [PATCH 05/22] migration: Refactor MigrationState creation

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 16 +--- migration-fd.c | 16 +--- migration-tcp.c | 15 +-- migration-unix.c | 15 +-- migration.c | 29 + migration.h | 11 +++ 6 file

[Qemu-devel] [PATCH 07/22] migration: move migrate_create_state to do_migrate

2011-02-22 Thread Juan Quintela
Once there, remove all parameters that don't need to be passed to *start_outgoing_migration() functions Signed-off-by: Juan Quintela --- migration-exec.c | 19 +-- migration-fd.c | 22 ++ migration-tcp.c | 20 ++-- migration-unix.c |

[Qemu-devel] [PATCH 09/22] migration: Introduce MIG_STATE_NONE

2011-02-22 Thread Juan Quintela
Use MIG_STATE_ACTIVE only when migration has really started Signed-off-by: Juan Quintela --- migration.c |6 +- migration.h |3 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/migration.c b/migration.c index 55f58c8..f015e02 100644 --- a/migration.c +++ b/migration

[Qemu-devel] [PATCH 04/22] migration: Rename FdMigrationState MigrationState

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 10 +- migration-fd.c | 10 +- migration-tcp.c | 12 ++-- migration-unix.c | 12 ++-- migration.c | 34 +- migration.h | 38 +++-

[Qemu-devel] [PATCH 03/22] migration: Fold MigrationState into FdMigrationState

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c | 10 +- migration-fd.c | 10 +- migration-tcp.c | 10 +- migration-unix.c | 10 +- migration.c | 11 +-- migration.h | 23 +-- 6 files changed, 30 insertions(+),

[Qemu-devel] [PATCH 01/22] migration: Make *start_outgoing_migration return FdMigrationState

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-exec.c |4 ++-- migration-fd.c |4 ++-- migration-tcp.c |4 ++-- migration-unix.c |4 ++-- migration.c |4 ++-- migration.h |8 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/migration-exec.

[Qemu-devel] [PATCH 02/22] migration: Use FdMigrationState instead of MigrationState when possible

2011-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 31 ++- migration.h | 16 2 files changed, 22 insertions(+), 25 deletions(-) diff --git a/migration.c b/migration.c index f9aaadc..3a371a3 100644 --- a/migration.c +++ b/migration.c @@ -34,7 +34,7 @@

[Qemu-devel] [PATCH 00/22] Refactor and cleaup migration code

2011-02-22 Thread Juan Quintela
This series: - Fold MigrationState into FdMigrationState (and then rename) - Factorize migration statec creation in a single place - Make use of MIG_STATE_*, setup through helpers and make them local - remove relase & cancel callbacks (where used only one in same file than defined) - get_status()

[Qemu-devel] [Bug 723460] [NEW] qemu on linux doesn't boot for winxp install via usb

2011-02-22 Thread dankoe
Public bug reported: hi guys, I try to install windows xp via qemu. I can only boot from usb and somehow it is my problem. I run a Winxp/xubuntu10.04 Dualboot-system with some virtual drives in windows ( till letter f:? ). at qemu I created an image from 30Gigabytes and entered this command from

[Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-22 Thread Anthony Liguori
On 02/22/2011 05:09 PM, Marcelo Tosatti wrote: On Tue, Feb 22, 2011 at 03:11:06PM -0600, Anthony Liguori wrote: On 02/22/2011 03:07 PM, Marcelo Tosatti wrote: On Tue, Feb 22, 2011 at 02:50:09PM -0600, Anthony Liguori wrote: +static int write_commit_file(BdrvCopyState *s) +{ +

[Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-22 Thread Marcelo Tosatti
On Tue, Feb 22, 2011 at 03:11:06PM -0600, Anthony Liguori wrote: > On 02/22/2011 03:07 PM, Marcelo Tosatti wrote: > >On Tue, Feb 22, 2011 at 02:50:09PM -0600, Anthony Liguori wrote: > >>>+static int write_commit_file(BdrvCopyState *s) > >>>+{ > >>>+char commit_msg[1400]; > >>>+const char *b

[Qemu-devel] Re: virtio-serial semantics for binary data and guest agents

2011-02-22 Thread Anthony Liguori
My basic understanding here is--there's no way for a virtio-serial client (in-guest) to reliably reset a session such that if the client in the guest crashes, the protocol needs to have some recovery mechanism. This seems like a huge oversight in the design of virtio-serial. Are we missing so

[Qemu-devel] virtio-serial semantics for binary data and guest agents

2011-02-22 Thread Michael Roth
Hi everyone, As some of you are aware we've been working for a few months now towards creating a qemu-specific guest agent to implement bi-directional RPCs between the host and the guest to support certain operations like copy/paste, guest-initiated shutdown, and basic file transfer. Current

Re: [Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-22 Thread Anthony Liguori
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote: + +static void blkcopy_switch(BdrvCopyState *s) +{ +char src_filename[1024]; +int open_flags; + +strncpy(src_filename, s->src->filename, sizeof(src_filename)); +open_flags = s->src->open_flags; strncpy doesn't leave a NULL termi

[Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-22 Thread Anthony Liguori
On 02/22/2011 03:07 PM, Marcelo Tosatti wrote: On Tue, Feb 22, 2011 at 02:50:09PM -0600, Anthony Liguori wrote: +static int write_commit_file(BdrvCopyState *s) +{ +char commit_msg[1400]; +const char *buf = commit_msg; +int len, ret; + +sprintf(commit_msg, "commit QEMU block_c

[Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-22 Thread Marcelo Tosatti
On Tue, Feb 22, 2011 at 02:50:09PM -0600, Anthony Liguori wrote: > >+static int write_commit_file(BdrvCopyState *s) > >+{ > >+char commit_msg[1400]; > >+const char *buf = commit_msg; > >+int len, ret; > >+ > >+sprintf(commit_msg, "commit QEMU block_copy %s -> %s\n", > >s->src_devi

Re: [Qemu-devel] [PATCH 2/2 V1] Fixed EPROM for AMD driver compatibility under DOS with Netware driver

2011-02-22 Thread Gerhard Wiesinger
Hello, No comments? Can someone commit? Thnx. Ciao, Gerhard -- http://www.wiesinger.com/ On Sun, 20 Feb 2011, Gerhard Wiesinger wrote: Signed-off-by: Gerhard Wiesinger --- hw/pcnet.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/pcnet.c b/hw/pcnet.

[Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-22 Thread Anthony Liguori
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote: This patch is large and not properly inlined. Can it be split up into more reviewable chunks? Regards, Anthony Liguori

[Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-02-22 Thread Anthony Liguori
On 02/22/2011 11:00 AM, Marcelo Tosatti wrote: Support live image copy + switch. That is, copy an image backing a guest hard disk to a destination image (destination image must be created separately), and switch to this copy. Command syntax: block_copy device filename [commit_filename] [-i] --

Re: [Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support

2011-02-22 Thread Anthony Liguori
On 02/21/2011 02:43 AM, Paolo Bonzini wrote: After gathering the comments about the two series I sent separately, here is the full series for Win32 iothread support, ready to be applied to uq/master. Patches 1 to 5 are generic Win32 improvements, including the qemu-thread implementation. Becaus

Re: [Qemu-devel] Re: [PATCH 2/3] NBD library: add aio-compatible read/write function

2011-02-22 Thread Stefan Hajnoczi
On Tue, Feb 22, 2011 at 3:26 PM, Nicholas Thomas wrote: > On Mon, 2011-02-21 at 20:10 +, Stefan Hajnoczi wrote: >> On Mon, Feb 21, 2011 at 12:37 PM, Kevin Wolf wrote: >> > Am 18.02.2011 13:55, schrieb Nick Thomas: >> >> +retry: >> >> +    if (do_read) { >> >> +        ret = recvmsg(sockfd, &m

[Qemu-devel] [patch 2/3] Add support for live block copy

2011-02-22 Thread Marcelo Tosatti
Support live image copy + switch. That is, copy an image backing a guest hard disk to a destination image (destination image must be created separately), and switch to this copy. Command syntax: block_copy device filename [commit_filename] [-i] -- live block copy device to image o

[Qemu-devel] [patch 0/3] live block copy (v2)

2011-02-22 Thread Marcelo Tosatti
v2: - use reference counting to be safe against device hotplug / bdrv_truncate - add comment about usage of timer

[Qemu-devel] [patch 1/3] add migration_active function

2011-02-22 Thread Marcelo Tosatti
To query whether migration is active. Signed-off-by: Marcelo Tosatti Index: qemu/migration.c === --- qemu.orig/migration.c +++ qemu/migration.c @@ -480,3 +480,13 @@ int get_migration_state(void) return MIG_STATE_ERROR;

[Qemu-devel] [patch 3/3] do not allow migration if block copy in progress

2011-02-22 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti Index: qemu/migration.c === --- qemu.orig/migration.c +++ qemu/migration.c @@ -19,6 +19,7 @@ #include "block.h" #include "qemu_socket.h" #include "block-migration.h" +#include "block-copy.h" #includ

[Qemu-devel] Re: [PATCH v2 00/15] [uq/master] Patch queue, part IV (MCE edition)

2011-02-22 Thread Marcelo Tosatti
On Fri, Feb 18, 2011 at 11:11:11AM +0100, Jan Kiszka wrote: > Round 2 of this part, primarily addressing review comments: > - Reworked CPU_INTERRUPT_MCE -> exection translation >(now done in kvm_arch_process_async_events, indeed much cleaner) > - Add missing cpu_synchronize_state on pending M

Re: [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API

2011-02-22 Thread Anthony Liguori
On 02/22/2011 10:21 AM, Avi Kivity wrote: On 02/22/2011 05:00 PM, Anthony Liguori wrote: Drop the opaque, instead put the IOHandler in there (or maybe the CharDev?) and use container_of(). You know, I'm not there that this is automatically better. Why not? One less unsafe cast. It turn

[Qemu-devel] [PATCH] target-arm: Implement a minimal set of cp14 debug registers

2011-02-22 Thread Peter Maydell
Newer ARM kernels try to probe for whether the CPU has hardware breakpoint support. For this to work QEMU has to implement a minimal set of the cp14 debug registers. The architecture requires v7 cores to implement debug and so there is no defined way to report its absence; however in practice retur

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-22 Thread Anthony Liguori
On 02/22/2011 10:15 AM, Kevin Wolf wrote: Am 22.02.2011 16:57, schrieb Anthony Liguori: On 02/22/2011 02:56 AM, Kevin Wolf wrote: *sigh* It starts to get annoying, but if you really insist, I can repeat it once more: These features that you don't need (this is the correct description

Re: [Qemu-devel] KVM call minutes for Feb 22

2011-02-22 Thread Anthony Liguori
On 02/22/2011 11:32 AM, Alon Levy wrote: On Tue, Feb 22, 2011 at 06:06:22PM +0200, Michael S. Tsirkin wrote: Looks like Chris will send minutes too, so I didn't do much to polish this, I didn't realise he's doing it until I had this, so here's the braindump: hope it helps. 1. 0.14 postmorte

[Qemu-devel] [PATCH] `qdev_free` when unplug a pci device

2011-02-22 Thread William Dauchy
`qdev_free` when unplug a pci device It resolves a bug when detaching/attaching a network device # virsh detach-interface dom0 network --mac 52:54:00:f6:84:ba Interface detached successfully # virsh attach-interface dom0 network default --mac 52:54:00:f6:84:ba error: Failed to attach interf

Re: [Qemu-devel] KVM call minutes for Feb 22

2011-02-22 Thread Alon Levy
On Tue, Feb 22, 2011 at 06:06:22PM +0200, Michael S. Tsirkin wrote: > Looks like Chris will send minutes too, > so I didn't do much to polish this, > I didn't realise he's doing it until I had this, so > here's the braindump: hope it helps. > > 1. 0.14 postmortem > - what went well > wiki fo

[Qemu-devel] Re: [PATCH] For AIO return -ENOSPC on short write

2011-02-22 Thread Paolo Bonzini
On 02/22/2011 04:16 PM, Stefan Hajnoczi wrote: Yes it is. It doesn't explain it though. The code involved here is linux-aio.c and will be qcow2's bs->file. That ought to be a host_device and AFAIK that is not growable. So I wanted to figure out why we're even getting this far. I expected the

Re: [Qemu-devel] [PATCH 1/5] Add TPM 1.2 device interface

2011-02-22 Thread Stefan Berger
On 02/21/2011 12:03 PM, Andreas Niederl wrote: On 02/18/2011 09:27 PM, Stefan Berger wrote: On 02/18/2011 12:37 PM, Andreas Niederl wrote: [...] So I'm guessing that this library is not publicly available right now? Not via the fedora repository at least. So yum install does not work, yet. I

[Qemu-devel] KVM call minutes for Feb 22

2011-02-22 Thread Chris Wright
0.14 recap - keeping schedule on wiki was helpful - changelog was helpful - testing (could even more emphasis could be improved) - -rc cycles - -rc2 and final release just hours 0.15 - tentative date July 1st - qapi - qed features - virtagent? - depends on whether to terminate in qemu vs exter

Re: [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API

2011-02-22 Thread Avi Kivity
On 02/22/2011 05:00 PM, Anthony Liguori wrote: Drop the opaque, instead put the IOHandler in there (or maybe the CharDev?) and use container_of(). You know, I'm not there that this is automatically better. Why not? One less unsafe cast. + +int assign_iohandler(int fd, IOAllHandler *ha

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-22 Thread Kevin Wolf
Am 22.02.2011 16:57, schrieb Anthony Liguori: > On 02/22/2011 02:56 AM, Kevin Wolf wrote: >> >> *sigh* >> >> It starts to get annoying, but if you really insist, I can repeat it >> once more: These features that you don't need (this is the correct >> description for what you call "misfeatures") _ar

Re: [Qemu-devel] Re: [PATCH 3/3] block/nbd: Make the NBD block device use the AIO interface

2011-02-22 Thread MORITA Kazutaka
At Mon, 21 Feb 2011 17:48:49 +0100, Kevin Wolf wrote: > > Am 21.02.2011 17:31, schrieb Nicholas Thomas: > > Hi again, > > > > Thanks for looking through the patches. I'm just going through and > > making the suggested changes now. I've also got qemu-nbd and block/nbd.c > > working over IPv6 :) -

[Qemu-devel] KVM call minutes for Feb 22

2011-02-22 Thread Michael S. Tsirkin
Looks like Chris will send minutes too, so I didn't do much to polish this, I didn't realise he's doing it until I had this, so here's the braindump: hope it helps. 1. 0.14 postmortem - what went well wiki for planning testing - what can be improved rc - cycle could be long

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-02-22 Thread Anthony Liguori
On 02/07/2011 10:34 AM, Alon Levy wrote: +static int ccid_post_load(void *opaque, int version_id) +{ +USBCCIDState *s = opaque; + +// This must be done after usb_device_attach, which sets state to ATTACHED, +// while it must be DEFAULT in order to accept packets (like it is after +

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-22 Thread Anthony Liguori
On 02/22/2011 02:56 AM, Kevin Wolf wrote: *sigh* It starts to get annoying, but if you really insist, I can repeat it once more: These features that you don't need (this is the correct description for what you call "misfeatures") _are_ implemented in a way that they don't impact the "normal" ca

Re: [Qemu-devel] Re: [PATCH 2/3] NBD library: add aio-compatible read/write function

2011-02-22 Thread Nicholas Thomas
On Mon, 2011-02-21 at 20:10 +, Stefan Hajnoczi wrote: > On Mon, Feb 21, 2011 at 12:37 PM, Kevin Wolf wrote: > > Am 18.02.2011 13:55, schrieb Nick Thomas: > >> +retry: > >> +if (do_read) { > >> +ret = recvmsg(sockfd, &msg, 0); > >> +} else { > >> +ret = sendmsg(sockfd, &

Re: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write

2011-02-22 Thread Stefan Hajnoczi
On Tue, Feb 22, 2011 at 3:11 PM, Kevin Wolf wrote: > Am 22.02.2011 16:02, schrieb Stefan Hajnoczi: >> Why are we even allowing requests that extend beyond the end of the >> device?  Is the LVM volume marked growable in the QEMU block layer? > > Might well be a qcow2 on LVM case that Jes was debugg

Re: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write

2011-02-22 Thread Kevin Wolf
Am 22.02.2011 16:02, schrieb Stefan Hajnoczi: > On Tue, Feb 22, 2011 at 10:18 AM, wrote: >> +else if ((laiocb->type == QEMU_AIO_WRITE) && (ret >= 0) && >> + (ret < laiocb->nbytes)) >> +ret = -ENOSPC; > > Why is write special? I think we need the change reads,

Re: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write

2011-02-22 Thread Stefan Hajnoczi
On Tue, Feb 22, 2011 at 10:18 AM, wrote: > +        else if ((laiocb->type == QEMU_AIO_WRITE) && (ret >= 0) && > +                 (ret < laiocb->nbytes)) > +            ret = -ENOSPC; Why is write special? Why are we even allowing requests that extend beyond the end of the device? Is the LVM

[Qemu-devel] [PATCH 2/2] migration: add error handling to migrate_fd_put_notify().

2011-02-22 Thread Yoshiaki Tamura
Although migrate_fd_put_buffer() sets MIG_STATE_ERROR if it failed, since migrate_fd_put_notify() isn't checking error of underlying QEMUFile, those resources are kept open. This patch checks it and calls migrate_fd_error() in case of error. Signed-off-by: Yoshiaki Tamura --- migration.c |9

[Qemu-devel] [PATCH 1/2] savevm: avoid qemu_savevm_state_iteate() to return 1 when qemu file has error.

2011-02-22 Thread Yoshiaki Tamura
When qemu on the receiver gets killed during live migration, if debug is turned on, migrate_fd_put_ready() says, migration: done iterating and proceeds. The reason was qemu_savevm_state_iterate() returning 1 even when qemu file has error. This patch checks qemu_file_has_error() before returning

[Qemu-devel] [PATCH 0/2] Fix error handling in migration when the peer is killed.

2011-02-22 Thread Yoshiaki Tamura
Hi, During live migration, if the receiver side of qemu gets killed, the sender side seems to be handling the error incorrectly, like it passes the iterate phase (stage 2) and moves on to the complete state (stage 3). These patches fix the issue. Yoshiaki Tamura (2): savevm: avoid qemu_savevm_

Re: [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API

2011-02-22 Thread Anthony Liguori
On 02/22/2011 07:28 AM, Avi Kivity wrote: On 02/22/2011 12:18 PM, Amit Shah wrote: Introduce a new iohandler api that doesn't have multiple callbacks. Instead, a single callback and a mask of events that got set will be passed on to the handler. This will ease our transition to a poll() interfa

[Qemu-devel] Re: [PATCH 2/7] iohandlers: Introduce a new API

2011-02-22 Thread Anthony Liguori
On 02/22/2011 04:18 AM, Amit Shah wrote: Introduce a new iohandler api that doesn't have multiple callbacks. Instead, a single callback and a mask of events that got set will be passed on to the handler. This will ease our transition to a poll() interface instead of the current select() that hap

Re: [Qemu-devel] [PATCH 1/7] iohandlers: Mark current implementation as 'old'

2011-02-22 Thread Avi Kivity
On 02/22/2011 04:37 PM, Amit Shah wrote: On (Tue) 22 Feb 2011 [15:28:59], Avi Kivity wrote: > On 02/22/2011 01:17 PM, Amit Shah wrote: > >On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote: > >> On 02/22/2011 12:18 PM, Amit Shah wrote: > >> >Mark the current iohandler list as 'old'. In th

Re: [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API

2011-02-22 Thread Amit Shah
On (Tue) 22 Feb 2011 [15:28:02], Avi Kivity wrote: > On 02/22/2011 12:18 PM, Amit Shah wrote: > >Introduce a new iohandler api that doesn't have multiple callbacks. > >Instead, a single callback and a mask of events that got set will be > >passed on to the handler. This will ease our transition to

Re: [Qemu-devel] [PATCH 1/7] iohandlers: Mark current implementation as 'old'

2011-02-22 Thread Amit Shah
On (Tue) 22 Feb 2011 [15:28:59], Avi Kivity wrote: > On 02/22/2011 01:17 PM, Amit Shah wrote: > >On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote: > >> On 02/22/2011 12:18 PM, Amit Shah wrote: > >> >Mark the current iohandler list as 'old'. In the next commit we'll > >> >introduce a new iohand

Re: [Qemu-devel] General IO ports in pc386

2011-02-22 Thread Tomas Bures
Thank you. This is exactly what I was looking for. I've created the device, added the compilation of it to Makefile.target . Now, I'm wondering how to persuade QEMU to initialize it? I've registered it using the code below. The registration executes during QEMU launch, the the initialization d

[Qemu-devel] [PATCH] simpletrace: Make simpletrace.py a Python module

2011-02-22 Thread Stefan Hajnoczi
The simpletrace.py script pretty-prints a binary trace file. Most of the code can be reused by trace file analysis scripts, so turn it into a module. Here is an example script that uses the new simpletrace module: #!/usr/bin/env python # Print virtqueue elements that were never returned to t

Re: [Qemu-devel] Re: [PATCH] For AIO return -ENOSPC on short write

2011-02-22 Thread Avi Kivity
On 02/22/2011 01:45 PM, Jes Sorensen wrote: On 02/22/11 12:44, Kevin Wolf wrote: >> @@ -62,6 +63,9 @@ static void qemu_laio_process_completion(struct qemu_laio_state *s, >> if (ret != -ECANCELED) { >> if (ret == laiocb->nbytes) >> ret = 0; >> +else if ((la

Re: [Qemu-devel] Re: [PATCH 3/3] block/nbd: Make the NBD block device use the AIO interface

2011-02-22 Thread Stefan Hajnoczi
On Tue, Feb 22, 2011 at 11:48 AM, Nicholas Thomas wrote: > >> > + * Send I/O requests to the server. >> > + * >> > + * This function sends requests to the server, links the requests to >> > + * the outstanding_list in BDRVNBDState, and exits without waiting for >> > + * the response.  The response

Re: [Qemu-devel] [PATCH 1/7] iohandlers: Mark current implementation as 'old'

2011-02-22 Thread Avi Kivity
On 02/22/2011 01:17 PM, Amit Shah wrote: On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote: > On 02/22/2011 12:18 PM, Amit Shah wrote: > >Mark the current iohandler list as 'old'. In the next commit we'll > >introduce a new iohandler api that will replace the list name. > > > >The 'old' lis

Re: [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API

2011-02-22 Thread Avi Kivity
On 02/22/2011 12:18 PM, Amit Shah wrote: Introduce a new iohandler api that doesn't have multiple callbacks. Instead, a single callback and a mask of events that got set will be passed on to the handler. This will ease our transition to a poll() interface instead of the current select() that hap

Re: [Qemu-devel] KVM Agenda for Feb 22

2011-02-22 Thread Luiz Capitulino
On Mon, 21 Feb 2011 14:13:04 -0600 Anthony Liguori wrote: > On 02/21/2011 11:12 AM, Juan Quintela wrote: > > please send in any agenda items you are interested in covering. > > > > - 0.14.0 release is out, thanks to everyone that participated! Let's > discuss what worked well, what could

Re: [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API

2011-02-22 Thread Amit Shah
On (Tue) 22 Feb 2011 [14:39:03], Alon Levy wrote: > On Tue, Feb 22, 2011 at 03:48:31PM +0530, Amit Shah wrote: > > Introduce a new iohandler api that doesn't have multiple callbacks. > > Instead, a single callback and a mask of events that got set will be > > passed on to the handler. This will ea

[Qemu-devel] [PATCH] linux-user: Fix large seeks by 32 bit guest on 64 bit host

2011-02-22 Thread Peter Maydell
When emulating a 32 bit Linux user-mode program on a 64 bit target we implement the llseek syscall in terms of lseek. Correct a bug which meant we were silently casting the result of host lseek() to a 32 bit integer as it passed through get_errno() and thus throwing away the top half. We also don'

Re: [Qemu-devel] [PATCH 2/7] iohandlers: Introduce a new API

2011-02-22 Thread Alon Levy
On Tue, Feb 22, 2011 at 03:48:31PM +0530, Amit Shah wrote: > Introduce a new iohandler api that doesn't have multiple callbacks. > Instead, a single callback and a mask of events that got set will be > passed on to the handler. This will ease our transition to a poll() > interface instead of the c

Re: [Qemu-devel] [PATCH 4/5] target-arm: fix support for VRECPE.

2011-02-22 Thread Peter Maydell
On 21 February 2011 16:38, Christophe Lyon wrote: > Now use the same algorithm as described in the ARM ARM. > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 2/5] softfloat: add _set_sign(), _infinity and _half for 32 and 64 bits floats.

2011-02-22 Thread Peter Maydell
On 21 February 2011 16:38, Christophe Lyon wrote: > These constants and utility function are needed to implement some > helpers. Defining constants avoids the need to re-compute them at > runtime. > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 5/5] target-arm: fix support for VRSQRTE.

2011-02-22 Thread Peter Maydell
On 21 February 2011 16:38, Christophe Lyon wrote: > Now use the same algorithm as described in the ARM ARM. > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 3/5] target-arm: Introduce float64_256 and float64_512 constants.

2011-02-22 Thread Peter Maydell
On 21 February 2011 16:38, Christophe Lyon wrote: > These two constants will be used by helper functions such as recpe_f32 > and rsqrte_f32. > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 1/5] softfloat: move all default NaN definitions to softfloat.h.

2011-02-22 Thread Peter Maydell
On 21 February 2011 16:38, Christophe Lyon wrote: > These special values are needed to implement some helper functions, > which return/use these values in some cases. > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell PS: for patches which were reviewed OK in a previous round and ha

Re: [Qemu-devel] Re: [PATCH 3/3] block/nbd: Make the NBD block device use the AIO interface

2011-02-22 Thread Nicholas Thomas
> > + * Send I/O requests to the server. > > + * > > + * This function sends requests to the server, links the requests to > > + * the outstanding_list in BDRVNBDState, and exits without waiting for > > + * the response. The responses are received in the `aio_read_response' > > + * function which

[Qemu-devel] Re: [PATCH] For AIO return -ENOSPC on short write

2011-02-22 Thread Jes Sorensen
On 02/22/11 12:44, Kevin Wolf wrote: >> @@ -62,6 +63,9 @@ static void qemu_laio_process_completion(struct >> qemu_laio_state *s, >> if (ret != -ECANCELED) { >> if (ret == laiocb->nbytes) >> ret = 0; >> +else if ((laiocb->type == QEMU_AIO_WRITE) && (ret >= 0) && >

[Qemu-devel] Re: [PATCH] For AIO return -ENOSPC on short write

2011-02-22 Thread Kevin Wolf
Am 22.02.2011 11:18, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > linux-aio.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/linux-aio.c b/linux-aio.c > index 68f4b3d..d9c0225 100644 > --- a/linux-aio.c > +++ b

Re: [Qemu-devel] [PATCH 1/7] iohandlers: Mark current implementation as 'old'

2011-02-22 Thread Amit Shah
On (Tue) 22 Feb 2011 [13:09:34], Avi Kivity wrote: > On 02/22/2011 12:18 PM, Amit Shah wrote: > >Mark the current iohandler list as 'old'. In the next commit we'll > >introduce a new iohandler api that will replace the list name. > > > >The 'old' list will eventually be completely replaced by the

  1   2   >