Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-02 Thread Bhushan Bharat-R65777
> -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, August 15, 2012 6:59 AM > To: Bhushan Bharat-R65777 > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; ag...@suse.de; Bhushan Bharat- > R65777 > Subject: Re: [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller > > O

Re: [Qemu-devel] [PATCH] qapi: Fix potential NULL pointer segfault

2012-09-02 Thread Paolo Bonzini
Il 01/09/2012 09:30, Stefan Weil ha scritto: > Report from smatch: > > qapi-visit.c:1640 visit_type_BlockdevAction(8) error: > we previously assumed 'obj' could be null (see line 1639) > qapi-visit.c:2432 visit_type_NetClientOptions(8) error: > we previously assumed 'obj' could be null (see line

[Qemu-devel] [Qemu-ppc][PATCH v10 1/1] Add USB option in machine options

2012-09-02 Thread Li Zhang
When -usb option is used, global varible usb_enabled is set. And all the plaform will create one USB controller according to this variable. In fact, global varibles make code hard to read. So this patch is to remove global variable usb_enabled and add USB option in machine options. All the plaform

[Qemu-devel] [PATCH-v2 spice 1/2] Set a8 capability in the QXL device if supported by the client

2012-09-02 Thread Søren Sandmann Pedersen
--- server/red_worker.c | 2 ++ spice-common| 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 843f559..23f3464 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -10377,6 +10377,8 @@ static void handle_new_displ

Re: [Qemu-devel] Detecting context switch in QEMU

2012-09-02 Thread Mulyadi Santosa
Hi Xin Tong.. On Mon, Sep 3, 2012 at 4:48 AM, Xin Tong wrote: > BTW, if a thread makes a system call, when the kernel is servicing the > syscall. is it still accessing the thread's memory using the threads > page table (i.e. the kernel is using virtual address ?). how about AIO > kernel threads

[Qemu-devel] [PATCH-v2 spice-protocol 2/2] Add new client_present and client capabilities fields to QXLRom

2012-09-02 Thread Søren Sandmann Pedersen
The client_present field is a byte that is set of non-zero when a client is connected and to zero when no client is connected. The client_capabilities[58] array contains 464 bits that indicate the capabilities of the client. Each bit corresponds to a SPICE_DISPLAY_CAP_* capability. In particular,

[Qemu-devel] [PATCH-v2 spice 2/2] Bump spice.h version number to 0.11.4

2012-09-02 Thread Søren Sandmann Pedersen
No new symbols are added, but there is an addition to QXLInterface: void (*set_client_capabilities)(QXLInstance *qin, uint8_t client_present, uint8_t caps[58]); --- server/spice.h | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH-v2 qemu] qxl: Add set_client_capabilities() interface to QXLInterface

2012-09-02 Thread Søren Sandmann Pedersen
This new interface lets spice server inform the guest whether (a) a client is connected (b) what capabilities the client has There is a fixed number (464) of bits reserved for capabilities, and when the capabilities bits change, the QXL_INTERRUPT_CLIENT interrupt is generated. Signed-off-by: Sor

[Qemu-devel] [PATCH-v2 spice-gtk] Advertise SPICE_DISPLAY_CAP_A8_SURFACE

2012-09-02 Thread Søren Sandmann Pedersen
--- gtk/channel-display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index 99fe9c9..326ad22 100644 --- a/gtk/channel-display.c +++ b/gtk/channel-display.c @@ -682,6 +682,7 @@ static void spice_display_channel_reset_capabilities(SpiceChannel *

[Qemu-devel] New patches to add capabilities to spice and qxl

2012-09-02 Thread Søren Sandmann Pedersen
Hi, Here are new revisions of the capabilities patches. Also included here is a new SPICE_DISPLAY_CAP_A8_SURFACE capability since this is logically distinct from the composite command. Thanks, Soren

[Qemu-devel] [PATCH-v2 spice-protocol 1/2] Add A8 surface capability

2012-09-02 Thread Søren Sandmann Pedersen
Even though the ability to handle a8 surfaces was added at the same time as the composite command, they are logically separate, so add a capability bit to indicate the presence of a8 surfaces. --- spice/protocol.h | 1 + 1 file changed, 1 insertion(+) diff --git a/spice/protocol.h b/spice/protoco

[Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-02 Thread Matthew Ogilvie
Although I haven't found any specs that say so, on real hardware I have a test program that shows if you mask off the slave interrupt (say IRQ14) in the IMR after it has already been raised, the master (IRQ2) gets canceled (that is, IRQ2 acts like it is level triggered). Without this patch, qemu d

[Qemu-devel] [PATCH v4 3/5] qemu-options.hx: mention retrace= VGA option

2012-09-02 Thread Matthew Ogilvie
The feature was added in commit cb5a7aa8c32141bb Sep 2008. My description is based on "Better VGA retrace emulation (needed for some DOS games/demos)" from http://www.boblycat.org/~malc/code/patches/qemu/index.html Signed-off-by: Matthew Ogilvie --- qemu-options.hx | 8 +++- 1 file changed,

[Qemu-devel] [PATCH v4 4/5] vga: add some optional CGA compatibility hacks

2012-09-02 Thread Matthew Ogilvie
This patch adds some optional compatibility hacks (default disabled) to allow Microport UNIX to function under qemu. I've tried to structure it to be easy to add more hacks for other old CGA programs, if anyone ever needs them. Microport UNIX System V/386 v 2.1 (ca 1987) tries to program the CGA

[Qemu-devel] [PATCH v4 1/5] fix some debug printf format strings

2012-09-02 Thread Matthew Ogilvie
These are normally ifdefed out and don't matter. But if you enable them, they ought to be correct. Signed-off-by: Matthew Ogilvie --- Changes since v2: The v3 tweak (adding back a dropped "02") has been squashed in. hw/cirrus_vga.c | 4 ++-- hw/i8259.c | 3 ++- hw/ide/cmd646.c | 5 +++--

[Qemu-devel] [PATCH v4 2/5] vl: fix -hdachs/-hda argument order parsing issues

2012-09-02 Thread Matthew Ogilvie
Without this patch, the -hdachs argument had to occur either BEFORE the corresponding "-hda" option, or AFTER the plain disk image name (if neither -hda nor -drive is used). Otherwise it would effectively be ignored. Option -hdachs still has no effect on -drive, but that seems best. Signed-off-b

[Qemu-devel] [PATCH v4 0/5] Running Microport UNIX (ca 1987)

2012-09-02 Thread Matthew Ogilvie
This series is fixing issues I found when getting qemu to run "Micoport UNIX System V/386, v 2.1" (ca 1987), although most of the patches are completely independent of each other. Changes since v2 and v3: - Drop the -no-spurious-interrupts patch. (It might still be useful as an end-user

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-09-02 Thread Li Zhang
On Sun, Sep 2, 2012 at 10:45 PM, Alexander Graf wrote: > > > On 02.09.2012, at 09:50, Li Zhang wrote: > >> On Tue, Aug 28, 2012 at 2:08 AM, Blue Swirl wrote: >>> On Mon, Aug 27, 2012 at 1:59 AM, Alexander Graf wrote: On 26.08.2012, at 10:34, Blue Swirl wrote: > On Sat,

[Qemu-devel] [PATCH] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-09-02 Thread David Gibson
cpu_physical_memory_write_rom(), despite the name, can also be used to write images into RAM - and will often be used that way if the machine uses load_image_targphys() into RAM addresses. However, cpu_physical_memory_write_rom(), unlike cpu_physical_memory_rw() doesn't invalidate any cached TBs w

[Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register().

2012-09-02 Thread Don Slutz
Send it to stderr before free of the details. Signed-off-by: Don Slutz --- v2: Change __FUNCTION__ to __func__ target-i386/cpu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 57c064f..760cca4 100644 --- a/target-i386/cpu.c +

Re: [Qemu-devel] [PATCH 16/21] target-arm: switch to AREG0 free mode

2012-09-02 Thread Peter Maydell
On 3 September 2012 01:01, Peter Maydell wrote: > On 2 September 2012 18:33, Blue Swirl wrote: >> Add an explicit CPUState parameter instead of relying on AREG0 >> and switch to AREG0 free mode. >> >> Signed-off-by: Blue Swirl >> --- >> configure|2 +- >> target-arm/Makefile

Re: [Qemu-devel] [PATCH 16/21] target-arm: switch to AREG0 free mode

2012-09-02 Thread Peter Maydell
On 2 September 2012 18:33, Blue Swirl wrote: > Add an explicit CPUState parameter instead of relying on AREG0 > and switch to AREG0 free mode. > > Signed-off-by: Blue Swirl > --- > configure|2 +- > target-arm/Makefile.objs |2 - > target-arm/cpu.h | 10 ++- > t

Re: [Qemu-devel] [PATCH 19/21] target-sh4: switch to AREG0 free mode

2012-09-02 Thread Aurelien Jarno
On Sun, Sep 02, 2012 at 05:33:48PM +, Blue Swirl wrote: > Add an explicit CPUState parameter instead of relying on AREG0 > and switch to AREG0 free mode. > > Signed-off-by: Blue Swirl > --- > configure|2 +- > target-sh4/Makefile.objs |2 - > target-sh4/helper.h

Re: [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().

2012-09-02 Thread Don Slutz
Blue Swirl wrote: On Sat, Sep 1, 2012 at 8:47 PM, Don Slutz wrote: Send it to stderr before free of the details. Signed-off-by: Don Slutz --- target-i386/cpu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 57c064f..5c0

[Qemu-devel] [PATCH v2 1/4] CHECKPATCH: Add --debug adv_dcs

2012-09-02 Thread Don Slutz
Add debug options to find this issue. They were not listed in the help because the are not simple to understand the output of. Signed-off-by: Don Slutz --- scripts/checkpatch.pl |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch

[Qemu-devel] [PATCH v2 3/4] CHECKPATCH: Add --debug adv_apw

2012-09-02 Thread Don Slutz
Add debug options to find this issue. They were not listed in the help because the are not simple to understand the output of. Signed-off-by: Don Slutz --- scripts/checkpatch.pl | 51 ++-- 1 files changed, 32 insertions(+), 19 deletions(-) diff --g

[Qemu-devel] [PATCH v2 2/4] CHECKPATCH: Add --debug adv_checking

2012-09-02 Thread Don Slutz
Add debug options to find this issue. They were not listed in the help because the are not simple to understand the output of. Signed-off-by: Don Slutz --- scripts/checkpatch.pl |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatc

[Qemu-devel] [PATCH v2 4/4] CHECKPATCH: Add warning for single else statement.

2012-09-02 Thread Don Slutz
For an example: WARNING: braces {} are necessary even for single statement blocks +} else +return env->regs[R_EAX]; total: 0 errors, 1 warnings, 41 lines checked Signed-off-by: Don Slutz --- scripts/checkpatch.pl | 16 ++-- 1 files changed, 10 insertions(+), 6 deletion

[Qemu-devel] [PATCH v2 0/4] CHECKPATCH: Add warning for single else statement.

2012-09-02 Thread Don Slutz
Also add more debug options to find this issue. They were not listed in the help because the are not simple to understand the output of. Using: rm zz; for k in 0 1 2 3; do for i in 0 1 2 3 4 5 6 7 8 9; do for j in 0 1 2 3 4 5 6 7 8 9; do echo $k$i$j; git show HEAD~$k$i$j >/t

Re: [Qemu-devel] boot device order has no effect for virtio-scsi devices

2012-09-02 Thread ching
On 08/30/2012 07:31 PM, ching wrote: > My host is Gentoo x64, kernel 3.5.2, qemu-kvm 1.1.1-r1, libvirt 0.9.13, > seabios 1.7.0 > > i try to set the boot order with scsi cd-rom first, then scsi harddisk > > but the virtual machine will always boot with first scsi device only > (unit='0', the scsi

Re: [Qemu-devel] Detecting context switch in QEMU

2012-09-02 Thread Xin Tong
On Sun, Sep 2, 2012 at 8:52 AM, Xin Tong wrote: > On Sat, Sep 1, 2012 at 10:52 PM, Mulyadi Santosa > wrote: >> On Sun, Sep 2, 2012 at 2:33 AM, Xin Tong wrote: >>> I want to detect context switches in QEMU x86_64-softmmu. one of the >>> ideas i have is to track the write to CR3. is this valid on

[Qemu-devel] Howto add emulated i2c device

2012-09-02 Thread Peter Hüwe
Hi, I'd like to add an emulated i2c device to one of the qemu arm platforms, so I can use this emulated device to devel a linux kernel driver using this dummy as my test target. What would be the best way to add such a device? Is there a simple device available which I can use as a reference?

Re: [Qemu-devel] [PATCH] ioh3420: Remove unreachable code

2012-09-02 Thread Juan Quintela
Stefan Weil wrote: > Report from smatch: > hw/ioh3420.c:128 ioh3420_initfn(35) info: ignoring unreachable code. > > Signed-off-by: Stefan Weil Reviewed-by: Juan Quintela

[Qemu-devel] [PATCH 07/21] target-s390x: avoid AREG0 for FPU helpers

2012-09-02 Thread Blue Swirl
Make FPU helpers take a parameter for CPUState instead of relying on global env. Introduce temporary wrappers for FPU load and store ops. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |1 - target-s390x/cc_helper.c |4 +- target-s390x/cpu.h | 14 +++- target-s390x

[Qemu-devel] [PATCH 04/21] target-s390x: split integer helpers

2012-09-02 Thread Blue Swirl
Move integer helpers to int_helper.c. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |3 +- target-s390x/int_helper.c | 201 target-s390x/op_helper.c | 170 - 3 files changed, 203 insertions(+), 1

[Qemu-devel] [PATCH 09/21] target-s390x: avoid AREG0 for condition code helpers

2012-09-02 Thread Blue Swirl
Make condition code helpers take a parameter for CPUState instead of relying on global env. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |1 - target-s390x/cc_helper.c | 11 +-- target-s390x/helper.h | 10 +- target-s390x/translate.c | 16 --

[Qemu-devel] [PATCH 13/21] target-lm32: switch to AREG0 free mode

2012-09-02 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure |2 +- target-lm32/Makefile.objs |2 -- target-lm32/helper.h | 20 ++-- target-lm32/op_helper.c | 29 ++

[Qemu-devel] [PATCH 08/21] target-s390x: avoid AREG0 for integer helpers

2012-09-02 Thread Blue Swirl
Make integer helpers take a parameter for CPUState instead of relying on global env. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |1 - target-s390x/helper.h | 10 +- target-s390x/int_helper.c | 12 ++-- target-s390x/translate.c | 16

[Qemu-devel] [PATCH 14/21] target-m68k: switch to AREG0 free mode

2012-09-02 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure |2 +- target-m68k/Makefile.objs |2 - target-m68k/helpers.h |2 +- target-m68k/op_helper.c | 68 -

[Qemu-devel] [PATCH 15/21] target-unicore32: switch to AREG0 free mode

2012-09-02 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure |2 +- target-unicore32/Makefile.objs |2 - target-unicore32/helper.h | 26 target-unicore32/op_helper.c |

[Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode

2012-09-02 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure |2 +- target-cris/Makefile.objs |2 - target-cris/helper.c|4 +- target-cris/helper.h| 34 tar

[Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-02 Thread Blue Swirl
Move floating point instructions to fpu_helper.c. While exporting some condition code helpers, avoid duplicate identifier conflict with translate.c. Remove unused set_cc_nz_f64() in translate.c. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |2 + target-s390x/cpu.h |

[Qemu-devel] [PATCH 10/21] target-s390x: avoid AREG0 for misc helpers

2012-09-02 Thread Blue Swirl
Make misc helpers take a parameter for CPUState instead of relying on global env. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |1 - target-s390x/helper.h | 26 ++-- target-s390x/mem_helper.c |2 +- target-s390x/misc_helper.c | 55 +++

[Qemu-devel] [PATCH 17/21] target-microblaze: switch to AREG0 free mode

2012-09-02 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure |2 +- target-microblaze/Makefile.objs |2 - target-microblaze/helper.h | 48 target-microblaze/op_helper.c

[Qemu-devel] [PATCH 1/2] configure: fix detection for cURL libs when static linking

2012-09-02 Thread Yann E. MORIN
Currently, to check for cURL, configure uses either pkg-config (the default), or curl-config (as a fallback). But curl-config and pkg-config do not have the same set of options: - to check for shared libs, both use the option: --libs - to check for static libs: - pkg-config uses: --static

[Qemu-devel] [PATCH 2/2] configure: fix detection for SDL libs when static linking

2012-09-02 Thread Yann E. MORIN
Currently, configure checks for SDL libs either with pkg-config (the default), or with sdl-config (as a fallback). But sdl-config does not have the same set of options as pkg-config: - to check for shared libs, both use the option: --libs - to check for static libs: - pkg-config uses: --st

[Qemu-devel] [PATCH 0/2 v3] Fix static linking for cURL and SDL

2012-09-02 Thread Yann E. MORIN
Hello All! Currently, configure checks for cURL and SDL with either pkg-config (the default), or with {curl,sdl}-config (as a fallback). But pkg-config and {curl,sdl}-config do not have the same set of options: - to check for shared libs, both use the option: --libs - to check for static libs

[Qemu-devel] [PATCH 16/21] target-arm: switch to AREG0 free mode

2012-09-02 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure|2 +- target-arm/Makefile.objs |2 - target-arm/cpu.h | 10 ++- target-arm/helper.c |8 +- target-arm/helper.h |

[Qemu-devel] [PATCH 03/21] target-s390x: split condition code helpers

2012-09-02 Thread Blue Swirl
Move condition code helpers to cc_helper.c. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |3 +- target-s390x/cc_helper.c | 551 target-s390x/cpu.h |3 + target-s390x/op_helper.c | 522 +

[Qemu-devel] [PATCH 19/21] target-sh4: switch to AREG0 free mode

2012-09-02 Thread Blue Swirl
Add an explicit CPUState parameter instead of relying on AREG0 and switch to AREG0 free mode. Signed-off-by: Blue Swirl --- configure|2 +- target-sh4/Makefile.objs |2 - target-sh4/helper.h | 84 +++--- target-sh4/op_helper.c | 182 +

[Qemu-devel] [PATCH 06/21] target-s390x: rename op_helper.c to misc_helper.c

2012-09-02 Thread Blue Swirl
Now op_helper.c contains miscellaneous helpers, rename it to misc_helper.c. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |6 +- target-s390x/cpu.h |2 +- target-s390x/misc_helper.c | 431 target-s390x/op_helper.c | 431

[Qemu-devel] [PATCH 12/21] target-s390x: split helper.c

2012-09-02 Thread Blue Swirl
Move CPU init to cpu.c and the rest of helper.c to misc_helper.c. Signed-off-by: Blue Swirl --- target-s390x/Makefile.objs |2 +- target-s390x/cpu.c | 18 ++ target-s390x/helper.c | 619 target-s390x/misc_helper.c | 570 ++

[Qemu-devel] [PATCH 00/21] AREG0 patches, final round

2012-09-02 Thread Blue Swirl
Convert remaining targets to AREG0 free mode. I decided after s390x to not split the remaining op_helper.c files to for example fpu_helper.c, int_helper.c etc. It may still make sense especially for MIPS with 3442 lines in op_helper.c. This can be done later. After this series, whole of QEMU can

Re: [Qemu-devel] Detecting context switch in QEMU

2012-09-02 Thread Mulyadi Santosa
Hi.. On Sun, Sep 2, 2012 at 10:52 PM, Xin Tong wrote: > Ok, i do not know this. but it seems tracking CR3 is no good. any ideas ? from the Linux kernel source: http://lxr.free-electrons.com/source/kernel/sched/core.c#L3456: /* 2042 * context_switch - switch to the new MM and the new 2043

Re: [Qemu-devel] Detecting context switch in QEMU

2012-09-02 Thread Xin Tong
On Sat, Sep 1, 2012 at 10:52 PM, Mulyadi Santosa wrote: > On Sun, Sep 2, 2012 at 2:33 AM, Xin Tong wrote: >> I want to detect context switches in QEMU x86_64-softmmu. one of the >> ideas i have is to track the write to CR3. is this valid on QEMU ( >> i.e. are their any cases in which the assumpt

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-09-02 Thread Alexander Graf
On 02.09.2012, at 09:50, Li Zhang wrote: > On Tue, Aug 28, 2012 at 2:08 AM, Blue Swirl wrote: >> On Mon, Aug 27, 2012 at 1:59 AM, Alexander Graf wrote: >>> >>> >>> On 26.08.2012, at 10:34, Blue Swirl wrote: >>> On Sat, Aug 25, 2012 at 2:27 PM, Alexander Graf wrote: > > >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-09-02 Thread Li Zhang
On Tue, Aug 28, 2012 at 2:08 AM, Blue Swirl wrote: > On Mon, Aug 27, 2012 at 1:59 AM, Alexander Graf wrote: >> >> >> On 26.08.2012, at 10:34, Blue Swirl wrote: >> >>> On Sat, Aug 25, 2012 at 2:27 PM, Alexander Graf wrote: On 25.08.2012, at 00:43, Blue Swirl wrote: > On

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-09-02 Thread Li Zhang
On Sat, Aug 25, 2012 at 3:43 PM, Blue Swirl wrote: > On Wed, Aug 22, 2012 at 10:31 AM, Li Zhang wrote: >> When -usb option is used, global varible usb_enabled is set. >> And all the plafrom will create one USB controller according >> to this variable. In fact, global varibles make code hard >> to

Re: [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().

2012-09-02 Thread Blue Swirl
On Sat, Sep 1, 2012 at 8:47 PM, Don Slutz wrote: > Send it to stderr before free of the details. > > Signed-off-by: Don Slutz > --- > target-i386/cpu.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 57c064f..5c0fef1 100

Re: [Qemu-devel] [PATCH] CHECKPATCH: Add warning for single else statement.

2012-09-02 Thread Blue Swirl
On Sat, Sep 1, 2012 at 3:57 PM, Don Slutz wrote: > Also add more debug options to find this issue. They were not listed > in the help because the are not simple to understand the output of. These should form another patch, now it's not easy to see what was the fix for 'else'. > > For an example

Re: [Qemu-devel] [PATCH] CHECKPATCH

2012-09-02 Thread Blue Swirl
On Sat, Sep 1, 2012 at 3:57 PM, Don Slutz wrote: > I took my best guess as to how to handle tabs and long lines in > checkpatch.pl itself. Right, it was taken from Linux without much change. > > So I get: > ... > total: 0 errors, 7 warnings, 131 lines checked > > I also did not figure out how to