Cleanup patch is ok with me.
Acked-by: Edgar E. Iglesias
---
Sent from my phone
On Feb 15, 2013 12:24 AM, "Andreas Färber" wrote:
>
> Am 14.02.2013 22:42, schrieb Blue Swirl:
> > On Thu, Feb 14, 2013 at 3:46 PM, Andreas Färber
wrote:
> >> Am 27.01.2013 14:32, schrieb Andreas Färber:
> >>> Signe
This patch will hide all symbols except those marked with
QEMU_DLL_PUBLIC in .lo files. Because vsclient linked some
function in qemu, so export them as well. All symbols
in libcacard.syms are marked as public.
Signed-off-by: Wenchao Xia
---
configure | 18 +
Now libqblock can be packaged and installed by
"sudo make install-libqblock'.
Signed-off-by: Wenchao Xia
---
libqblock/Makefile | 34 +-
libqblock/libqblock.pc.in | 13 +
2 files changed, 42 insertions(+), 5 deletions(-)
create mode 1
Now libqblock.la can be built with neccessary object files,
and can be automatically cleaned by make clean in root directory.
make libqblock-clean also clean it. -fvisibility=hidden was used
to hide symbols, and a special macro was introduced to export
symbols that marked as public.
Signed-off-b
Rule for libqblock.la will be included if it is enabled, and
will be added to 'all' to be automatically built.
Only support Linux now, to save trouble in building on windows.
Signed-off-by: Wenchao Xia
---
Makefile |3 +++
configure | 32 +
libqblock need to use it.
Signed-off-by: Wenchao Xia
---
block.c |2 +-
include/block/block.h |2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index 50dab8e..0736cce 100644
--- a/block.c
+++ b/block.c
@@ -195,7 +195,7 @@ static void
Eric Johnson writes:
> On 02/15/2013 03:41 PM, Anthony Liguori wrote:
>> Happy hacking!
>>
>> Regards,
>>
>> Anthony Liguori
>
> We might want to update the planning section of
> http://wiki.qemu.org/Contribute/StartHere to link to 1.4 and 1.5.
Thanks for pointing that out. I've fixed it.
>
>
This patch contains implemention for APIs. Basically it is a layer
above qemu block general layer now.
qb_image_new() will try do init for this library.
Signed-off-by: Wenchao Xia
---
libqblock/libqblock-error.c | 49 +++
libqblock/libqblock.c | 983 +
In this example, first it will create some qcow2 images, then try get
information including backing file relationship, then it will do sync IO on
the image.
Signed-off-by: Wenchao Xia
---
tests/Makefile|2 +
tests/check-libqblock-qcow2.c | 385 +
Public API design header files: libqblock.h, libqblock-error.h.
Public type define header files: libqblock-types.h. Private internal used
header files: libqblock-internal. For ABI some reserved bytes are used in
structure defines. Macro QEMU_DLL_PUBLIC is used to mark exported function.
Importan
Libtool will be used for final link, the rules do nothing if
libqblock was disabled. Temp directory was used to store image
created in test, which will be deleted in clean.
Signed-off-by: Wenchao Xia
---
tests/Makefile |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --
This command will package the clean operations in tests,
to make it easy to be extended. Now root Makefile simply calls
the command and do not care the details of it any more.
Signed-off-by: Wenchao Xia
---
Makefile |1 -
tests/Makefile |8 +++-
2 files changed, 7 insertions(
These patches introduce libqblock API, make subdir-libqblock and make
check-libqblock could build this library.
Functionalities:
1 create a new image.
2 sync access of an image.
3 basic image information retrieving such as backing file.
4 detect if a sector is allocated in an image.
Supported
On 02/15/2013 03:41 PM, Anthony Liguori wrote:
Happy hacking!
Regards,
Anthony Liguori
We might want to update the planning section of
http://wiki.qemu.org/Contribute/StartHere to link to 1.4 and 1.5.
I don't think I have a Wiki account otherwise I would just fix it myself.
-Eric
On 02/15/13 21:57, David Woodhouse wrote:
> On Fri, 2013-02-15 at 19:54 +0100, Laszlo Ersek wrote:
>> Same infinite loop, alas...
>>
>> (i) What is your host kernel exactly?
>
> 3.7.5-201.fc18.x86_64 (booted from EFI on a MacBookPro 8,3).
- host CPU: Xeon W3550 (family/model/stepping = 6/26/5)
-
Happy hacking!
Regards,
Anthony Liguori
Hi,
On behalf of the QEMU Team, I'd like to announce the availability of the
QEMU 1.4 release!
http://wiki.qemu.org/download/qemu-1.4.0.tar.bz2
Even though this was our shortest release cycle in the history of the
project, this release contains almost 1400 changesets from 116 unique
authors.
Ma
On Wed, Feb 13, 2013 at 02:22:07PM +0100, Kevin Wolf wrote:
> +static bool qcow2_drain(BlockDriverState *bs)
I don't like this function name. This function is a bool query but
normal drain() means flush requests (i.e. do something that modified
state).
> +{
> +BDRVQcowState *s = bs->opaque;
On 15/02/13 13:11, Alexander Graf wrote:
Yes, I see the same thing on PPC hosts. So far I assumed it was due to my
ancient pixman version, but maybe it's not related to that after all.
Does it work with SDL?
Yes - it looks as if SDL is fine, and it's just VNC that is broken. A
session with
Il 15/02/2013 15:35, Peter Lieven ha scritto:
> this patch adds iscsi_truncate which effectively allows for online
> resizing of iscsi volumes. for this to work you have to resize
> the volume on your storage and then call block_resize command
> in qemu which will issue a readcapacity16 to update t
Skipping the bdrv_flush() in update_cluster_refcount() gives a huge
speed-up from over 3 minutes down to <1 second. I think Kevin already
discovered this in the past.
Now we need to figure out how to safely perform the updates without
flushing after each L2 table refcount increment.
--
You rece
Hi Stefan,
[...]
On Fri, Feb 15, 2013 at 10:16 PM, Stefan Weil wrote:
>
> earlier versions of QEMU provided an implementation of ffs()
> because it was needed for w32 compilations without optimisation.
>
> Later w32 used libiberty.a which provides ffs(). w64 never needed
> the ffs() implementati
On Fri, Feb 15, 2013 at 11:24:29AM +0100, Stefan Hajnoczi wrote:
> On Thu, Feb 14, 2013 at 07:21:57PM +0100, Luigi Rizzo wrote:
>
> CCed Michael Tsirkin
>
> > virtio-style network devices (where the producer and consumer chase
> > each other through a shared memory block) can enter into a
> > bad
Am 15.02.2013 22:16, schrieb Stefan Weil:
> Am 15.02.2013 20:40, schrieb Andreas Färber:
>> Am 15.02.2013 19:29, schrieb Jacob Kroon:
>>> On Fri, Feb 15, 2013 at 7:03 PM, Andreas Färber wrote:
Am 06.02.2013 14:12, schrieb Jacob Kroon:
> I'm trying to cross-build qemu for win64 on a Fedora
It is in QEMU 1.2.0.
commit 9aa0ff0bf9588f86846d1045662f5d75b91552cb
Author: Jan Kiszka
Date: Wed Jul 4 19:49:54 2012 +0200
vga: Implement blinking of text cursor
Let the text cursor blink at 1.875 Hz, the original VGA cursor
frequency. No timer is used, instead we rely on the
This enables interrupts to work pre-boot for assigned devices.
I had self nak'd and resent a v2 patch for 2/2, but there were never
any comments, so resending the whole series as v2. Thanks,
Alex
---
Alex Williamson (2):
seabios q35: Enable all PIRQn IRQs at startup
seabios q35: Ad
You are welcome.
Credit info you need: Cesson Vincent
Thank you for fixing it!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1079080
Title:
ARM instruction "srs" wrong behaviour
Status in QEMU:
On Fri, 2013-02-15 at 19:54 +0100, Laszlo Ersek wrote:
> Same infinite loop, alas...
>
> (i) What is your host kernel exactly?
3.7.5-201.fc18.x86_64 (booted from EFI on a MacBookPro 8,3).
> (ii) And when you say you did a "legacy boot", does that mean you installed
> the guest OS as a traditiona
Am 15.02.2013 20:40, schrieb Andreas Färber:
> Am 15.02.2013 19:29, schrieb Jacob Kroon:
>> On Fri, Feb 15, 2013 at 7:03 PM, Andreas Färber wrote:
>>> Am 06.02.2013 14:12, schrieb Jacob Kroon:
I'm trying to cross-build qemu for win64 on a Fedora 18/x86_64 system,
using all the necessary
q35/ich9 doesn't use the same interrupt mapping function as
i440fx/piix. PIRQA:D and PIRQE:H are programmed identically, but we
start at index 0, not index -1. Slots 25 through 31 are also
programmed independently.
When running qemu w/o this patch, a device at address 0:6.0 will have
its PCI int
We seem to use the IRQEN bit of the PIRQn registers interchangeably
to select APIC mode or to disable an IRQ. I can't decide if we're
intending to disable the IRQ or select APIC mode here, but in either
case it prevents PIC mode assigned devices from working. When seabios
writes IRQEN to these re
From: root
The following series of patches adds TPM (Trusted Platform Module) support
to QEMU. An emulator for the TIS (TPM Interface Spec) interface is
added that provides the basis for accessing a 'backend' implementing the actual
TPM functionality. The TIS emulator serves as a 'frontend' enabl
This patch adds support for cancelling an executing TPM command.
In Linux for example a user can cancel a command through the TPM's
sysfs 'cancel' entry using
echo "1" > /sysfs/class/misc/tpm0/device/cancel
This patch propagates the cancellation of a command inside a VM
to the host TPM's sysfs en
This patch uses the possibility to add a vendor-specific register and
adds a debug register useful for dumping the TIS's internal state. This
register is only active in a debug build (#define DEBUG_TIS).
Signed-off-by: Stefan Berger
Reviewed-by: Corey Bryant
---
tpm/tpm_tis.c | 70 +
This patch adds support for TPM command line options.
The command line options supported here are
./qemu-... -tpmdev passthrough,path=,id=
-device tpm-tis,tpmdev=
and
./qemu-... -tpmdev help
where the latter works similar to -soundhw ? and shows a list of
available TPM backends (for
Signed-off-by: Stefan Berger
Reviewed-by: Corey Bryant
---
configure | 17 +
1 file changed, 17 insertions(+)
diff --git a/configure b/configure
index b7359aa..b4f0a82 100755
--- a/configure
+++ b/configure
@@ -227,6 +227,7 @@ seccomp=""
glusterfs=""
virtio_blk_data_plane=""
On 02/15/2013 02:39 PM, Stefan Berger wrote:
This patch adds support for TPM command line options.
The command line options supported here are
./qemu-... -tpmdev passthrough,path=,id=
-device tpm-tis,tpmdev=
and
./qemu-... -tpmdev help
where the latter works similar to -soundhw
>From Andreas Niederl's original posting with adaptations where necessary:
This patch is based of off version 9 of Stefan Berger's patch series
"QEMU Trusted Platform Module (TPM) integration"
and adds a new backend driver for it.
This patch adds a passthrough backend driver for passing command
Build the TPM frontend code that has been added so far.
Signed-off-by: Stefan Berger
Reviewed-by: Corey Bryant
---
configure | 11 +++
tpm/Makefile.objs | 1 +
2 files changed, 12 insertions(+)
diff --git a/configure b/configure
index 8789324..b7359aa 100755
--- a/configure
++
This patch adds the main code of the TPM frontend driver, the TPM TIS
interface, to QEMU. The code is largely based on the previous implementation
for Xen but has been significantly extended to meet the standard's
requirements, such as the support for changing of localities and all the
functionalit
Am 15.02.2013 19:29, schrieb Jacob Kroon:
> On Fri, Feb 15, 2013 at 7:03 PM, Andreas Färber wrote:
>> Am 06.02.2013 14:12, schrieb Jacob Kroon:
>>> I'm trying to cross-build qemu for win64 on a Fedora 18/x86_64 system,
>>> using all the necessary mingw64 packages from Fedora. Using latest
>>> qemu
This is what exec_close does. Move this to the underlying QEMUFile.
Signed-off-by: Paolo Bonzini
---
migration-exec.c |4
savevm.c |3 +++
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/migration-exec.c b/migration-exec.c
index 5dc7313..a2b5f8d 100644
--- a/
From: Juan Quintela
This is consistent once that we have moved everything to migration.c
Signed-off-by: Juan Quintela
---
migration.c | 32
1 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/migration.c b/migration.c
index 1f6fbdc..bfe6be1 10064
Force a flush when qemu_ftell is called. This simplifies the buffer magic
(it also breaks qemu_ftell for input QEMUFiles, but we never use it).
Signed-off-by: Paolo Bonzini
---
savevm.c | 20
1 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/savevm.c b/savev
I really need it implemented!!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1019467
Title:
Text mode cursor doesn't blink
Status in QEMU:
New
Bug description:
Sorry for doing this, but QEMU
Signed-off-by: Paolo Bonzini
---
migration.c | 14 ++
1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/migration.c b/migration.c
index b32dfc1..8fb2d2e 100644
--- a/migration.c
+++ b/migration.c
@@ -273,10 +273,10 @@ static void migrate_fd_cleanup(void *opaque)
Some state is shared between the block migration code and its AIO
callbacks. Once block migration will run outside the iothread,
the block migration code and the AIO callbacks will be able to
run concurrently. Protect the critical sections with a separate
lock. Do the same for completed_sectors,
Signed-off-by: Paolo Bonzini
---
migration.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration.c b/migration.c
index 3de7cbf..8d35af5 100644
--- a/migration.c
+++ b/migration.c
@@ -616,7 +616,7 @@ static void *migration_thread(void *opaque)
int64_t cur
Signed-off-by: Paolo Bonzini
---
include/migration/qemu-file.h |2 --
savevm.c |4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h
index 5e0c287..46fc11d 100644
--- a/include/migration/q
This makes it possible to do blocking writes directly to the socket,
with no buffer in the middle. For RAM, only the migration_bitmap_sync()
call needs the iothread lock. For block migration, it is needed by
the block layer (including bdrv_drain_all and dirty bitmap access),
but because some code
There is no reason for outgoing exec migration to do popen manually
anymore (the reason used to be that we needed the FILE* to make it
non-blocking). Use qemu_popen_cmd.
Signed-off-by: Paolo Bonzini
---
include/migration/qemu-file.h |1 -
migration-exec.c | 10 --
sav
As a start, use QEMUFile to store the destination and close it.
qemu_get_fd gets a file descriptor that will be used by the write
callbacks.
Signed-off-by: Paolo Bonzini
---
include/migration/migration.h |7 ---
migration-exec.c | 21 ++---
migration-fd.c
Second, drop the file descriptor indirection, and write directly to the
QEMUFile.
Signed-off-by: Paolo Bonzini
---
include/migration/migration.h |4 ---
migration-exec.c | 12 ---
migration-fd.c| 12 ---
migration-tcp.c | 12 --
Always use qemu_file_get_error to detect errors, since that is how
QEMUFile itself drops I/O after an error occurs. There is no need
to propagate and check return values all the time.
Also remove the "complete" member, since we know that it is set (via
migrate_fd_cleanup) only when the state chan
This is useful, because it lets us keep the cancellation callbacks
inside the big lock while pushing the others out.
Signed-off-by: Paolo Bonzini
---
savevm.c | 15 ---
1 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/savevm.c b/savevm.c
index a8a53ef..4302903 100644
Unify the goto around the loop, with the exit condition at the end of it.
Both can be expressed as "while (ret >= 0)".
Signed-off-by: Paolo Bonzini
---
migration.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/migration.c b/migration.c
index b1ebb01..5414060
Perform final cleanup in a bottom half, and add joining the thread to
the series of cleanup actions.
Signed-off-by: Paolo Bonzini
---
include/migration/migration.h |1 +
migration.c | 37 +++--
2 files changed, 20 insertions(+), 18 deletion
Completion of migration is currently done with a "nested" loop that
invokes buffered_flush: migrate_fd_completed is called by
buffered_file_thread, which calls migrate_fd_cleanup, which calls
buffered_close (via qemu_fclose), which flushes the buffer.
Simplify this, by reusing the buffered_flush c
Remove the return value of buffered_flush, pass it via the error code
of s->file. Once this is done, the error can be retrieved simply
via migrate_fd_close's call to qemu_fclose.
Signed-off-by: Paolo Bonzini
---
migration.c | 22 ++
1 files changed, 6 insertions(+), 16 del
Signed-off-by: Paolo Bonzini
---
include/migration/qemu-file.h |2 +-
migration-tcp.c |2 +-
migration-unix.c |2 +-
savevm.c | 33 +++--
util/osdep.c |6 +-
5 files changed, 39 inse
On 02/14/13 23:24, David Woodhouse wrote:
> On Thu, 2013-02-14 at 21:41 +0100, Laszlo Ersek wrote:
>> I noticed that under OVMF + SeaBIOS CSM + your related patches for both,
>> reset requested by the guest doesn't work as expected. The behavior is
>> an infinite loop, with the following debug frag
With this patch, the migration_file is not needed anymore.
Signed-off-by: Paolo Bonzini
---
migration.c | 17 +++--
1 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/migration.c b/migration.c
index 7c1671f..c9a5978 100644
--- a/migration.c
+++ b/migration.c
@@ -271,6
Right now, migration cannot entirely rely on QEMUFile's automatic
drop of I/O after an error, because it does its "real" I/O outside
the put_buffer callback. To fix this until buffering is gone, expose
qemu_file_set_error which we will use in buffered_flush.
Similarly, buffered_flush is not a com
On 15 February 2013 16:18, Paolo Bonzini wrote:
> Il 15/02/2013 17:17, Peter Maydell ha scritto:
>> But these memory regions belong to this device -- we own them and
>> they won't go away until the device is destroyed [which is never,
>> as it happens, for this device.] More generally, if it's val
Buffering was needed because blocking writes could take a long time
and starve other threads seeking to grab the big QEMU mutex.
Now that all writes (except within _complete callbacks) are done
outside the big QEMU mutex, we do not need buffering at all.
Signed-off-by: Paolo Bonzini
---
include
Hi Andreas,
On Fri, Feb 15, 2013 at 7:03 PM, Andreas Färber wrote:
> Hi Jacob,
>
> Am 06.02.2013 14:12, schrieb Jacob Kroon:
>> I'm trying to cross-build qemu for win64 on a Fedora 18/x86_64 system,
>> using all the necessary mingw64 packages from Fedora. Using latest
>> qemu from git (5f876756c5
This is done by almost all callers of qemu_fflush, move the code
directly to qemu_fflush.
Signed-off-by: Paolo Bonzini
---
savevm.c | 25 -
1 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/savevm.c b/savevm.c
index 4302903..a681177 100644
--- a/savevm.c
Including data that resided in the QEMUFile's own buffer.
Signed-off-by: Paolo Bonzini
---
migration.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/migration.c b/migration.c
index 0f3cb5d..609bd7c 100644
--- a/migration.c
+++ b/migration.c
@@ -525,6 +525,8 @@ static
Signed-off-by: Paolo Bonzini
---
block-migration.c | 13 -
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index e6c917d..e72f322 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -50,7 +50,6 @@ typedef struct BlkMigDevSt
Only the migration_bitmap_sync() call needs the iothread lock.
Signed-off-by: Paolo Bonzini
---
arch_init.c | 10 ++
block-migration.c |2 ++
include/migration/vmstate.h |2 +-
migration.c |2 --
savevm.c|3 +
Signed-off-by: Paolo Bonzini
---
migration.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/migration.c b/migration.c
index 5e2077e..63ecab5 100644
--- a/migration.c
+++ b/migration.c
@@ -644,6 +644,10 @@ static void *migration_thread(void *opaque)
Now that the cancel callback is called consistently for all errors,
we can avoid doing its work in the other callbacks.
Signed-off-by: Paolo Bonzini
---
block-migration.c | 26 --
1 files changed, 8 insertions(+), 18 deletions(-)
diff --git a/block-migration.c b/block-
Hi Jacob,
Am 06.02.2013 14:12, schrieb Jacob Kroon:
> I'm trying to cross-build qemu for win64 on a Fedora 18/x86_64 system,
> using all the necessary mingw64 packages from Fedora. Using latest
> qemu from git (5f876756c57c15f5e14d4136fc432b74f05f082b), I get an
> error when linking "qemu-img.exe"
This patch extracts a few small changes from the next patch, which
are unrelated to adding generic rate-limiting functionality to
QEMUFile. Make migration_set_rate_limit a simple accessor, and
use qemu_file_set_rate_limit consistently. Also fix a typo where
INT_MAX should have been SIZE_MAX.
Sig
vm_stop_force_state does:
if (runstate_is_running()) {
vm_stop(state);
} else {
runstate_set(state);
}
migration.c does:
if (runstate_is_running()) {
vm_stop(state);
} else {
vm_stop_force_state(state);
}
The code run is the same even if w
This groups together the callbacks that later will have similar
locking rules.
Signed-off-by: Paolo Bonzini
---
include/migration/vmstate.h |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index f27276c..622
Some small changes that will simplify the positioning of lock/unlock
primitives
Signed-off-by: Paolo Bonzini
---
block-migration.c | 26 +++---
1 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index e72f322..fe3c040 10064
Accessing s->state outside the big QEMU lock will simplify a bit the
locking/unlocking of the iothread lock.
Signed-off-by: Paolo Bonzini
---
migration.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/migration.c b/migration.c
index b0b5578..a7f619b
Signed-off-by: Paolo Bonzini
---
block-migration.c | 23 ++-
1 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index fe3c040..21842b2 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -43,18 +43,24 @@
#endif
typ
The indirection is useless now. Backends can open s->file directly.
Signed-off-by: Paolo Bonzini
---
include/migration/migration.h |2 -
migration-exec.c |4 +-
migration-fd.c|2 +-
migration-tcp.c |4 +-
migration-unix.c |
Signed-off-by: Paolo Bonzini
---
include/sysemu/sysemu.h |6 +++---
savevm.c| 44 ++--
2 files changed, 21 insertions(+), 29 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 1d9599e..28a9221 100644
---
Prepare for when s->bytes_xfer will be removed.
Signed-off-by: Paolo Bonzini
---
migration.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index 68d47cd..d636c59 100644
--- a/migration.c
+++ b/migration.c
@@ -575,6 +575,7 @@ static void *mi
This is what fd_close does. Prepare for switching to a QEMUFile.
Signed-off-by: Paolo Bonzini
---
savevm.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/savevm.c b/savevm.c
index d7c2559..261d17a 100644
--- a/savevm.c
+++ b/savevm.c
@@ -256,6 +256,24
Rate limiting is now simply a byte counter; client call
qemu_file_rate_limit() manually to determine if they have to exit.
So it is possible and simple to move the functionality to QEMUFile.
This makes the remaining functionality of s->file redundant;
in the next patch we can remove it and write d
We will go around the loop exactly once after setting last_round.
Eliminate the variable altogether.
Signed-off-by: Paolo Bonzini
---
migration.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index bfe6be1..5e2077e 100644
--- a/migra
migration_put_buffer is never called if there has been an error.
Signed-off-by: Paolo Bonzini
---
migration.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index 63ecab5..3de7cbf 100644
--- a/migration.c
+++ b/migration.c
@@ -512,12 +512,
The next patch will add more cases where qemu_savevm_state_cancel
needs to be called; prepare for that already, the function can be
called twice with no ill effect.
Signed-off-by: Paolo Bonzini
---
migration.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git
This series does many of the improvements that the migration thread
promised. It removes buffering, lets a large amount of code run outside
the big QEMU lock, and removes some duplication between incoming and
outgoing migration.
Patches 1 to 7 are simple cleanups.
Patches 8 to 14 simplify the li
On 15.02.2013, at 18:44, Andreas Färber wrote:
> Alex,
>
> Am 02.02.2013 12:57, schrieb Andreas Färber:
>> It was never implemented.
>>
>> Signed-off-by: Andreas Färber
>
> Too late for 1.4 now obviously. ;)
>
> Do you want to queue this on s390-next (i.e.,do you plan an early pull)?
> Or sh
Alex,
Am 02.02.2013 12:57, schrieb Andreas Färber:
> It was never implemented.
>
> Signed-off-by: Andreas Färber
Too late for 1.4 now obviously. ;)
Do you want to queue this on s390-next (i.e.,do you plan an early pull)?
Or should I put it in qom-cpu-next?
The remainder of the series is waiti
Am 15.02.2013 17:44, schrieb Alexander Graf:
>
> On 15.02.2013, at 16:49, Andreas Färber wrote:
>
>> The helper functions all access ppc-specific fields only so don't bother
>> to change arguments to PowerPCCPU and use env_ptr instead.
>>
>> No functional change.
>>
>> Signed-off-by: Andreas Färb
Am 15.02.2013 18:04, schrieb Alexander Graf:
>
> On 15.02.2013, at 17:58, Andreas Färber wrote:
>
>> Am 15.02.2013 17:54, schrieb Alexander Graf:
>>>
>>> On 15.02.2013, at 17:51, Andreas Färber wrote:
>>>
Potentially env could be NULL whereas cpu would still be valid and
correspond to a
Am 15.02.2013 17:45, schrieb Alexander Graf:
>
> On 15.02.2013, at 15:35, Andreas Färber wrote:
>
>> Am 15.02.2013 15:29, schrieb Alexander Graf:
>>>
>>> On 15.02.2013, at 15:25, Andreas Färber wrote:
>>>
Since we still need env for ppc-specific fields, obtain it via the new
env_ptr fie
Public bug reported:
Something fishy is going on with qcow2 internal snapshot creation times.
I don't know if this is a regression because I haven't used internal
snapshots in the past.
QEMU 1.4-rc2:
$ qemu-img create -f qcow2 test.qcow2 -o size=50G,preallocation=metadata
$ time qemu-img snapshot
when debugging with qemu(user mode), qemu waits in infinite loop to read a
signal from gdb (when it waits on breakpoint for example).
I added sleeps to reduce the cpu usage from 100% to about ~0%.
qemu-busy-wait.patch
Description: Binary data
Am 14.02.2013 18:49, schrieb Andreas Färber:
> Am 01.02.2013 13:38, schrieb Andreas Färber:
>> Hello,
>>
>> This series moves more fields from CPU_COMMON / CPU*State to CPUState,
>> allowing access from target-independent code.
>>
>> The final patch in this series will help solve some issues (in pa
On 15.02.2013, at 17:58, Andreas Färber wrote:
> Am 15.02.2013 17:54, schrieb Alexander Graf:
>>
>> On 15.02.2013, at 17:51, Andreas Färber wrote:
>>
>>> Potentially env could be NULL whereas cpu would still be valid and
>>> correspond to a previous env.
>>>
>>> Wrapping this in qemu_get_cpu()
Am 15.02.2013 17:54, schrieb Alexander Graf:
>
> On 15.02.2013, at 17:51, Andreas Färber wrote:
>
>> Potentially env could be NULL whereas cpu would still be valid and
>> correspond to a previous env.
>>
>> Wrapping this in qemu_get_cpu(), env is no longer needed, so simplify
>> code that existed
On 15.02.2013, at 15:35, Andreas Färber wrote:
> Am 15.02.2013 15:29, schrieb Alexander Graf:
>>
>> On 15.02.2013, at 15:25, Andreas Färber wrote:
>>
>>> Since we still need env for ppc-specific fields, obtain it via the new
>>> env_ptr fields to avoid "cpu" name conflicts between CPUState and
On 15.02.2013, at 17:51, Andreas Färber wrote:
> Potentially env could be NULL whereas cpu would still be valid and
> correspond to a previous env.
>
> Wrapping this in qemu_get_cpu(), env is no longer needed, so simplify
> code that existed before 55e5c2850293547203874098f7cec148ffd12dfa.
>
>
1 - 100 of 191 matches
Mail list logo
