Re: [Qemu-devel] [PATCH] spapr-pci: enable adding PHB via -device

2014-01-20 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 01/21/2014 02:27 AM, Markus Armbruster wrote: >> Alexey Kardashevskiy writes: >> >>> Recent changes introduced cannot_instantiate_with_device_add_yet >>> and removed capability of adding yet another PCI host bridge via >>> command line for SPAPR platform (POWER

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2014-01-20 Thread Gerd Hoffmann
> > > My laptop has it reserved in a \_SB\PCI0\LPC\SIO device instead: > > > > > > Device (LPC) > > > { > > > Name (_ADR, 0x001F) // _ADR: Address > > > Name (_S3D, 0x03) // _S3D: S3 Device State > > > Name (RID, 0x00) >

Re: [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-01-20 Thread Chen Fan
On Mon, 2014-01-20 at 13:29 +0100, Igor Mammedov wrote: > On Fri, 17 Jan 2014 17:13:55 -0200 > Eduardo Habkost wrote: > > > On Wed, Jan 15, 2014 at 03:37:04PM +0100, Igor Mammedov wrote: > > > On Wed, 15 Jan 2014 20:24:01 +0800 > > > Chen Fan wrote: > > > > On Tue, 2014-01-14 at 11:40 +0100, Igo

[Qemu-devel] [PATCH] vmdk: Check for overhead when opening

2014-01-20 Thread Fam Zheng
Report an error if file size is even smaller than metadata. Signed-off-by: Fam Zheng --- block/vmdk.c | 7 +++ tests/qemu-iotests/059 | 6 ++ tests/qemu-iotests/059.out | 5 + 3 files changed, 18 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index c6b60b4.

Re: [Qemu-devel] [PATCH v1 3/3] qcow2: check for NULL l2meta

2014-01-20 Thread Hu Tao
On Tue, Jan 21, 2014 at 11:33:18AM +0800, Hu Tao wrote: > On Mon, Jan 20, 2014 at 04:17:16PM +0100, Kevin Wolf wrote: > > Am 20.01.2014 um 04:04 hat Hu Tao geschrieben: > > > On Sun, Jan 19, 2014 at 05:18:05PM +0100, Max Reitz wrote: > > > > On 30.12.2013 06:29, Hu Tao wrote: > > > > >In case of do

[Qemu-devel] [PATCH v4 1/1] qtest: Fix "make check" failing for "--disable-vnc"

2014-01-20 Thread Kewei Yu
When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. Signed-off-by: Kewei Yu Reviewed-by: Paolo Bonzini Signed-off-by: Kevin

Re: [Qemu-devel] [RFC PATCH] elf loader: exit if incompatible architecture is detected

2014-01-20 Thread Alexey Kardashevskiy
On 01/21/2014 02:11 AM, Alexander Graf wrote: > > On 07.01.2014, at 05:35, Alexey Kardashevskiy wrote: > >> If we know for sure that the image in "-kernel" is an ELF and we know its >> architecture and it is not supported by the current QEMU, there is no >> point to continue trying booting this

Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2014-01-20 Thread Fam Zheng
On Thu, 12/12 16:33, Benoît Canet wrote: > v5: > block empty node names [Kevin] > factorize setting of node-name option [Kevin] > NULL terminate node_name on removal [Kevin] > make query-named-block-nodes return BlockDeviceInfo structure [Eric] > Change some doc in query-named-b

Re: [Qemu-devel] [PATCH V5 7/7] qmp: Allow to take external snapshots on bs graphs node.

2014-01-20 Thread Fam Zheng
On Thu, 12/12 16:34, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > blockdev.c | 55 --- > hmp.c| 4 +++- > qapi-schema.json | 13 ++--- > qmp-commands.hx | 11 ++- > 4 files changed, 71 insertions(

Re: [Qemu-devel] [PATCH V5 6/7] qmp: Allow block_resize to manipulate bs graph nodes.

2014-01-20 Thread Fam Zheng
On Thu, 12/12 16:33, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > blockdev.c | 18 ++ > hmp.c| 2 +- > qapi-schema.json | 10 -- > qmp-commands.hx | 3 ++- > 4 files changed, 25 insertions(+), 8 deletions(-) > > diff --git a/blockdev.c b/

Re: [Qemu-devel] [PATCH V5 5/7] block: Create authorizations mechanism for external snapshot and resize.

2014-01-20 Thread Fam Zheng
On Thu, 12/12 16:33, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block.c | 65 > --- > block/blkverify.c | 2 +- > blockdev.c| 2 +- > include/block/block.h | 20 +++ > include/b

Re: [Qemu-devel] [PATCH v1 3/3] qcow2: check for NULL l2meta

2014-01-20 Thread Hu Tao
On Mon, Jan 20, 2014 at 04:17:16PM +0100, Kevin Wolf wrote: > Am 20.01.2014 um 04:04 hat Hu Tao geschrieben: > > On Sun, Jan 19, 2014 at 05:18:05PM +0100, Max Reitz wrote: > > > On 30.12.2013 06:29, Hu Tao wrote: > > > >In case of do preallocating metadata with a large cluster size, > > > >qcow2_al

[Qemu-devel] [PATCH] qcow2: fix wrong value of L1E_OFFSET_MASK, L2E_OFFSET_MASK and REFT_OFFSET_MASK

2014-01-20 Thread Hu Tao
Accoring to qcow spec, the offset fields in l1e, l2e and ref table entry start at bit 9. The offset is cluster offset, and the smallest possible cluster size is 512 bytes. Signed-off-by: Hu Tao --- block/qcow2.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/qcow

Re: [Qemu-devel] [PATCH V5 4/7] qmp: Allow to change password on named block driver states.

2014-01-20 Thread Fam Zheng
On Thu, 12/12 16:33, Benoît Canet wrote: > There was two candidate ways to implement named node manipulation: > > 1) > { 'command': 'block_passwd', 'data': {'*device': 'str', > '*node-name': 'str', 'password': 'str'} > } > > 2) > > { 'command': 'block_passwd

Re: [Qemu-devel] [PATCH V5 3/7] qmp: Add a command to list the named BlockDriverState nodes.

2014-01-20 Thread Fam Zheng
I think it's worth to at least mention the name of the command in the commit message. On Thu, 12/12 16:33, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block.c | 18 + > block/qapi.c | 109 > +- > block

Re: [Qemu-devel] [PATCH V5 2/7] block: Allow the user to define "node-name" option.

2014-01-20 Thread Fam Zheng
On Thu, 12/12 16:33, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block.c | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/block.c b/block.c > index 481d566..1c57f0d 100644 > --- a/block.c > +++ b/block.c > @@ -735,6 +735,39 @@ static

Re: [Qemu-devel] [PATCH V5 1/7] block: Add bs->node_name to hold the name of a bs node of the bs graph.

2014-01-20 Thread Fam Zheng
On Thu, 12/12 16:33, Benoît Canet wrote: > Add the minimum of code to prepare for the following patches. > > Signed-off-by: Benoit Canet > --- > block.c | 57 > +++ > include/block/block.h | 1 + > include/block/block_int.h | 9

Re: [Qemu-devel] [PATCH v2] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries

2014-01-20 Thread Hu Tao
On Mon, Jan 20, 2014 at 10:10:22AM +0100, Kevin Wolf wrote: > Am 17.01.2014 um 08:40 hat Stefan Hajnoczi geschrieben: > > On Mon, Dec 30, 2013 at 04:00:17PM +0800, Hu Tao wrote: > > > Fix incorrect bits of offsets in refcount table entry, l1 table > > > entry and l2 table entry. See REFT_OFFSET_MAS

Re: [Qemu-devel] [PATCH] spapr-pci: enable adding PHB via -device

2014-01-20 Thread Alexey Kardashevskiy
On 01/21/2014 02:27 AM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> Recent changes introduced cannot_instantiate_with_device_add_yet >> and removed capability of adding yet another PCI host bridge via >> command line for SPAPR platform (POWERPC64 server). > > Specifically: > >

Re: [Qemu-devel] [PATCH 0/7 RESEND] target-i386: Simplify kvm_cpu_fill_host() and kvm_check_features_against_host()

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 10:07:47PM +0100, Andreas Färber wrote: > Am 20.01.2014 21:39, schrieb Michael S. Tsirkin: > > On Mon, Jan 20, 2014 at 04:36:56PM -0200, Eduardo Habkost wrote: > >> On Mon, Jan 20, 2014 at 02:41:07PM -0200, Eduardo Habkost wrote: > >>> Resend of series submitted on 24 Novemb

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-20 Thread Andreas Färber
Am 20.01.2014 17:50, schrieb Eduardo Habkost: > On Mon, Jan 20, 2014 at 05:27:18PM +0100, Andreas Färber wrote: >> Am 20.01.2014 15:36, schrieb Eduardo Habkost: >>> v1 was sent in September 2013: >>> Message-Id: <1379704517-19177-1-git-send-email-ehabk...@redhat.com> >>> http://article.gmane.or

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-20 Thread Andreas Färber
Am 20.01.2014 15:36, schrieb Eduardo Habkost: > This enables x2apic on the following CPU models: Conroe, Penryn, > Nehalem, Westmere, Opteron_G[12345]. > > Normally we try to keep the CPU model definitions as close as the real > CPUs as possible, but x2apic can be emulated by KVM without host CPU

Re: [Qemu-devel] [PATCH] ifname=xxx for -netdev bridge

2014-01-20 Thread Alexandre Kandalintsev
Hi William, I was worried that the amount of changes would turn the maintainers away from the patch. Another problem is that I think there is little demand for this patch. But let's try to push it once again. Give me a week or two and I'll submit a new version. -- best regards, Alexandre > Hi

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Gabriel L. Somlo
On Mon, Jan 20, 2014 at 10:31:56PM +0200, Michael S. Tsirkin wrote: > > And later: > > > > Device (HPET) { > > ... > > Method (_STA, 0, NotSerialized) { > > If (LGreaterEqual (OSYS, 0x07D1)) { > >

Re: [Qemu-devel] [PATCH 4/7] target-i386: kvm_cpu_fill_host(): No need to check xlevel2

2014-01-20 Thread Andreas Färber
Am 20.01.2014 17:41, schrieb Eduardo Habkost: > There's no need to check CPU xlevel2 before calling > kvm_arch_get_supported_cpuid(s, 0xC001, 0, R_EDX), because: > > * The kernel won't return any entry for 0xC000 if host CPU vendor >is not Centaur (See kvm_dev_ioctl_get_supported_cpui

Re: [Qemu-devel] [PATCH 4/8] target-i386: kvm_cpu_fill_host(): No need to check xlevel2

2014-01-20 Thread Andreas Färber
Am 24.11.2013 20:55, schrieb Eduardo Habkost: > There's no need to check CPU xlevel2 before calling > kvm_arch_get_supported_cpuid(s, 0xC001, 0, R_EDX), because: > > * The kernel won't return any entry for 0xC000 if host CPU vendor >is not Centaur (See kvm_dev_ioctl_get_supported_cpui

Re: [Qemu-devel] [PATCH 0/7 RESEND] target-i386: Simplify kvm_cpu_fill_host() and kvm_check_features_against_host()

2014-01-20 Thread Andreas Färber
Am 20.01.2014 21:39, schrieb Michael S. Tsirkin: > On Mon, Jan 20, 2014 at 04:36:56PM -0200, Eduardo Habkost wrote: >> On Mon, Jan 20, 2014 at 02:41:07PM -0200, Eduardo Habkost wrote: >>> Resend of series submitted on 24 November 2013, that didn't get any reply. >>> Only >>> change is a trivial co

Re: [Qemu-devel] [PATCH 0/7 RESEND] target-i386: Simplify kvm_cpu_fill_host() and kvm_check_features_against_host()

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 04:36:56PM -0200, Eduardo Habkost wrote: > On Mon, Jan 20, 2014 at 02:41:07PM -0200, Eduardo Habkost wrote: > > Resend of series submitted on 24 November 2013, that didn't get any reply. > > Only > > change is a trivial conflict on patch 7/7. > > Question: which tree is th

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 10:16:01AM -0700, Alex Williamson wrote: > On Mon, 2014-01-20 at 19:04 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 20, 2014 at 09:45:25AM -0700, Alex Williamson wrote: > > > On Mon, 2014-01-20 at 11:20 -0500, Mike Day wrote: > > > > Do you know which device is writing t

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 01:54:15PM -0500, Gabriel L. Somlo wrote: > On Mon, Jan 20, 2014 at 01:16:02PM +0100, Paolo Bonzini wrote: > > Il 20/01/2014 13:08, Michael S. Tsirkin ha scritto: > > >>> > > I think the hack looking for the SMC device is safer than _OSI: > > >>> > > OSPMs > > >>> > > are k

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 01:16:02PM +0100, Paolo Bonzini wrote: > Il 20/01/2014 13:08, Michael S. Tsirkin ha scritto: > >>> > > > >>> > > I think the hack looking for the SMC device is safer than _OSI: OSPMs > >>> > > are known to do crazy things when they see _OSI, such as assuming they > >>> > >

[Qemu-devel] [PATCH v3] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-20 Thread Thomas Falcon
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of any registers if the MSR:LE value is set. Signed-off-by: Thomas Falcon --- Differences from v2:

[Qemu-devel] [PULL v4 06/12] target-lm32: kill cpu_abort() calls

2014-01-20 Thread Michael Walle
Instead of killing QEMU, translate instructions which are not available on the CPU model as a noop and issue a log message at translation time. On the real hardware CPU unknown opcodes results in undefined behaviour. These changes prepare the removal of CPULM32State from DisasContext. Signed-off

[Qemu-devel] [PULL v4 05/12] milkymist-vgafb: swap pixel data in source buffer

2014-01-20 Thread Michael Walle
In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, swap the bytes if we are building for a little-endian host. Cc: Paolo Bonzini Signed-off-by: Michael Walle --

[Qemu-devel] [PULL v4 07/12] target-lm32: move model features to LM32CPU

2014-01-20 Thread Michael Walle
This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Reviewed-by: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/cpu-qom.h |6 ++ target-lm32/cpu.c | 187 ++- t

[Qemu-devel] [PATCH 1/3 v2] s390-sclp: Define New SCLP Codes

2014-01-20 Thread Jason J. Herne
From: "Jason J. Herne" Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c | 2 +- include/hw/s390x/sclp.h | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 86d6ae0..cb035

[Qemu-devel] [PATCH 3/3 v2] s390-sclp: SCLP Event integration

2014-01-20 Thread Jason J. Herne
From: "Jason J. Herne" Add an sclp event for "cpu was hot plugged". This allows Qemu to deliver an SCLP interrupt to the guest stating that the requested cpu hotplug was completed. Signed-off-by: Jason J. Herne --- hw/s390x/Makefile.objs| 1 + hw/s390x/event-facility.c |

[Qemu-devel] [PATCH 2/3 v2] s390-sclp: SCLP CPU Info

2014-01-20 Thread Jason J. Herne
From: "Jason J. Herne" Implement the CPU data in SCLP "Read SCP Info". And implement "Read CPU Info" SCLP command. This data will be used by the guest to get information about hot plugged cpus. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c | 51

[Qemu-devel] [PATCH 0/3 v2] S390 SCLP improvements for CPU Hotplug

2014-01-20 Thread Jason J. Herne
From: "Jason J. Herne" Improvements to SCLP, mainly the Read SCP/CPU Info subcommands, to support future cpu hotplug operations on the s390 target. Jason J. Herne (3): s390-sclp: Define New SCLP Codes s390-sclp: SCLP CPU Info s390-sclp: SCLP Event integration hw/s390x/Makefile.objs

[Qemu-devel] [PULL 1/1] gtk: Support keyboard translation for hosts running Windows

2014-01-20 Thread Stefan Weil
GTK uses different hardware keycodes on Windows hosts, so some special handling is needed to get the QEMU keycode. Signed-off-by: Stefan Weil --- ui/gtk.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 6316f5b..a633d89 100644 -

[Qemu-devel] [PULL 0/1] MinGW patch

2014-01-20 Thread Stefan Weil
The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at: git://qemu.weilnetz.de/qemu.git tags/for_anthony for you to fetch changes up to 2777ccc55bfe90bfa813b01faf

[Qemu-devel] [PULL v4 01/12] lm32_sys: increase test case name length limit

2014-01-20 Thread Michael Walle
The new MMU tests use longer names. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 9bdb781..8176cdb 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -42,7 +42,

[Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-01-20 Thread Michael Walle
Do not use qemu_log(). Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 8176cdb..6af0cca 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -80,7 +80,7 @@ static void

[Qemu-devel] [PULL v4 11/12] target-lm32: stop VM on illegal or unknown instruction

2014-01-20 Thread Michael Walle
Instead of translating the instruction to a no-op, pause the VM and display a message to the user. As a side effect, this also works for instructions where the operands are only known at runtime. Signed-off-by: Michael Walle --- target-lm32/helper.h|1 + target-lm32/op_helper.c | 17 +

[Qemu-devel] [PULL v4 10/12] lm32_sys: dump cpu state if test case fails

2014-01-20 Thread Michael Walle
This will ease debugging the test cases. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 6af0cca..1fd69ff 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -81,6 +81,9 @@ static

[Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support

2014-01-20 Thread Michael Walle
This patch adds in-target breakpoint and watchpoint support. Signed-off-by: Michael Walle --- target-lm32/TODO|2 -- target-lm32/cpu.c |1 + target-lm32/cpu.h | 27 -- target-lm32/helper.c| 89 +++ target

[Qemu-devel] [PULL v4 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all()

2014-01-20 Thread Michael Walle
qemu_chr_fe_write() may return EAGAIN. Therefore, use qemu_chr_fe_write_all(). Signed-off-by: Michael Walle --- hw/char/lm32_juart.c |2 +- hw/char/lm32_uart.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/lm32_juart.c b/hw/char/lm32_juart.c index 252fe46

[Qemu-devel] [PULL v4 00/12] target-lm32 updates

2014-01-20 Thread Michael Walle
0b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at: git://github.com/mwalle/qemu tags/lm32-fixes/20140120 for you to fetch changes up to b77202ef2d93722a2c0f6ee467f3664515e2cc21: hw/lm32: print error if

[Qemu-devel] [PULL v4 12/12] hw/lm32: print error if cpu model is not found

2014-01-20 Thread Michael Walle
QEMU crashed if a the given cpu_model is not found. Signed-off-by: Michael Walle --- hw/lm32/lm32_boards.c | 10 ++ hw/lm32/milkymist.c |5 + 2 files changed, 15 insertions(+) diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c index c032bb8..5e22e9b 100644 --- a/hw/l

[Qemu-devel] [PULL v4 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2014-01-20 Thread Michael Walle
From: Antony Pavlov qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael Walle

[Qemu-devel] [PULL v4 02/12] tests: lm32: new rule for single test cases

2014-01-20 Thread Michael Walle
Introduce new target "check_%" to run indiviudal test caes, eg. make check_mmu Signed-off-by: Michael Walle --- tests/tcg/lm32/Makefile |3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/tcg/lm32/Makefile b/tests/tcg/lm32/Makefile index 9a00ef7..19e0664 100644 --- a/tests/tcg/lm32

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-20 Thread Christoffer Dall
On Mon, Jan 20, 2014 at 03:22:11PM +0100, Alexander Graf wrote: > > On 17.01.2014, at 19:52, Peter Maydell wrote: > > > On 17 January 2014 17:53, Peter Maydell wrote: > >> Specifically, the KVM API says "here's a uint8_t[] byte > >> array and a length", and the current QEMU code treats that > >

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Gabriel L. Somlo
On Mon, Jan 20, 2014 at 01:16:02PM +0100, Paolo Bonzini wrote: > Il 20/01/2014 13:08, Michael S. Tsirkin ha scritto: > >>> > > I think the hack looking for the SMC device is safer than _OSI: OSPMs > >>> > > are known to do crazy things when they see _OSI, such as assuming they > >>> > > need to try

Re: [Qemu-devel] [PATCH v2 01/14] spapr: populate DRC entries for root dt node

2014-01-20 Thread Michael Roth
Quoting Mike Day (2014-01-20 11:59:28) > On Mon, Jan 20, 2014 at 12:24 PM, Michael Roth > wrote: > > Quoting Alexey Kardashevskiy (2014-01-19 20:58:20) > > > > Would need to look at it a bit more closely to say for certain, but after > > discussing it a bit Tyrel/Mike, I think the main considerati

Re: [Qemu-devel] [PATCH v3] target-ppc: gdbstub allow byte swapping for, reading/writing registers

2014-01-20 Thread Alexander Graf
On 20.01.2014, at 18:49, Thomas Falcon wrote: > On 01/20/2014 08:33 AM, Alexander Graf wrote: >> On 17.01.2014, at 22:02, Thomas Falcon wrote: >> >>> This patch allows registers to be properly read from and written to >>> when using the gdbstub to debug a ppc guest running in little >>> endian

Re: [Qemu-devel] [PATCH 0/7 RESEND] target-i386: Simplify kvm_cpu_fill_host() and kvm_check_features_against_host()

2014-01-20 Thread Eduardo Habkost
On Mon, Jan 20, 2014 at 02:41:07PM -0200, Eduardo Habkost wrote: > Resend of series submitted on 24 November 2013, that didn't get any reply. > Only > change is a trivial conflict on patch 7/7. Question: which tree is the most appropriate to get this in? qom-cpu? kvm? > > This series simplifie

Re: [Qemu-devel] [PATCH v2 01/14] spapr: populate DRC entries for root dt node

2014-01-20 Thread Mike Day
On Mon, Jan 20, 2014 at 12:24 PM, Michael Roth wrote: > Quoting Alexey Kardashevskiy (2014-01-19 20:58:20) > > Would need to look at it a bit more closely to say for certain, but after > discussing it a bit Tyrel/Mike, I think the main considerations would be: > > 1) PHB hotplug/unplug would need

Re: [Qemu-devel] [PATCH v3] target-ppc: gdbstub allow byte swapping for, reading/writing registers

2014-01-20 Thread Thomas Falcon
On 01/20/2014 08:33 AM, Alexander Graf wrote: On 17.01.2014, at 22:02, Thomas Falcon wrote: This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of a

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 09:45:25AM -0700, Alex Williamson wrote: > On Mon, 2014-01-20 at 11:20 -0500, Mike Day wrote: > > Do you know which device is writing to the BAR below? From the trace > > it appears it should be restoring the memory address to the BAR after > > writing all 1s to the BAR and

Re: [Qemu-devel] [PATCH v2 01/14] spapr: populate DRC entries for root dt node

2014-01-20 Thread Michael Roth
Quoting Alexey Kardashevskiy (2014-01-19 20:58:20) > On 01/17/2014 07:51 AM, Michael Roth wrote: > > Quoting Alexey Kardashevskiy (2013-12-15 22:54:42) > >> On 12/16/2013 01:59 PM, Alexey Kardashevskiy wrote: > >>> On 12/06/2013 09:32 AM, Michael Roth wrote: > From: Nathan Fontenot > > >

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-20 Thread Eduardo Habkost
On Mon, Jan 20, 2014 at 05:27:18PM +0100, Andreas Färber wrote: > Am 20.01.2014 15:36, schrieb Eduardo Habkost: > > This enables x2apic on the following CPU models: Conroe, Penryn, > > Nehalem, Westmere, Opteron_G[12345]. > > > > Normally we try to keep the CPU model definitions as close as the re

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-20 Thread Alex Williamson
On Mon, 2014-01-20 at 19:04 +0200, Michael S. Tsirkin wrote: > On Mon, Jan 20, 2014 at 09:45:25AM -0700, Alex Williamson wrote: > > On Mon, 2014-01-20 at 11:20 -0500, Mike Day wrote: > > > Do you know which device is writing to the BAR below? From the trace > > > it appears it should be restoring t

Re: [Qemu-devel] [PATCH 3/3] s390-sclp: SCLP Event integration

2014-01-20 Thread Andreas Färber
Hi, Thanks for splitting these off. Am 20.01.2014 17:56, schrieb Jason J. Herne: > From: "Jason J. Herne" > > Add an sclp event for "cpu was hot plugged". This allows Qemu to deliver an > SCLP interrupt to the guest stating that the requested cpu hotplug was > completed. > > Signed-off-by: Ja

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2014-01-20 Thread Igor Mammedov
On Mon, 20 Jan 2014 17:51:47 +0200 "Michael S. Tsirkin" wrote: > On Mon, Jan 20, 2014 at 04:36:57PM +0100, Gerd Hoffmann wrote: > > > 4.1.2. > > > MCFG Table Description > > > > > > > > > ... > > > > > > If the operating system does not natively comprehend reserving the MMCFG > > > region, th

[Qemu-devel] [PATCH v3 5/5] net: add offloading support to netmap backend

2014-01-20 Thread Vincenzo Maffione
Whit this patch, the netmap backend supports TSO/UFO/CSUM offloadings, and accepts the virtio-net header, similarly to what happens with TAP. The offloading callbacks in the NetClientInfo interface have been implemented. Signed-off-by: Vincenzo Maffione --- net/netmap.c | 68

[Qemu-devel] [PATCH v3 3/5] net: TAP uses NetClientInfo offloading callbacks

2014-01-20 Thread Vincenzo Maffione
The TAP NetClientInfo structure is inizialized with the TAP-specific functions that manipulates offloading features. Signed-off-by: Vincenzo Maffione --- net/tap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/tap.c b/net/tap.c index c805f3c..d34ec88 100644 --- a/net/tap.c +++ b/

[Qemu-devel] [PATCH v3 2/5] net: extend NetClientInfo for offloading

2014-01-20 Thread Vincenzo Maffione
Some new callbacks have been added to generalize the operations done by virtio-net and vmxnet3 frontends to manipulate TAP offloadings. Signed-off-by: Vincenzo Maffione --- include/net/net.h | 19 +++ net/net.c | 55 +++

[Qemu-devel] [PATCH v3 1/5] net: change vnet-hdr TAP prototypes

2014-01-20 Thread Vincenzo Maffione
The tap_has_vnet_hdr() and tap_has_vnet_hdr_len() functions used to return int, even though they only return true/false values. This patch changes the prototypes to return bool. Signed-off-by: Vincenzo Maffione --- include/net/tap.h | 4 ++-- net/tap-win32.c | 8 net/tap.c | 6

[Qemu-devel] [PATCH v3 4/5] net: virtio-net and vmxnet3 use offloading API

2014-01-20 Thread Vincenzo Maffione
With this patch, virtio-net and vmxnet3 frontends make use of the qemu_peer_* API for backend offloadings manipulations, instead of calling TAP-specific functions directly. We also remove the existing checks which prevent those frontends from using offloadings with backends different from TAP (e.g.

[Qemu-devel] [PATCH v3 0/5] Add netmap backend offloadings support

2014-01-20 Thread Vincenzo Maffione
The purpose of this patch series is to add offloadings support (TSO/UFO/CSUM) to the netmap network backend, and make it possible for the paravirtual network frontends (virtio-net and vmxnet3) to use it. In order to achieve this, these patches extend the existing net.h interface to add abstract ope

[Qemu-devel] [PATCH 2/3] s390-sclp: SCLP CPU Info

2014-01-20 Thread Jason J. Herne
From: "Jason J. Herne" Implement the CPU data in SCLP "Read SCP Info". And implement "Read CPU Info" SCLP command. This data will be used by the guest to get information about hot plugged cpus. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c | 51

[Qemu-devel] [PATCH v4] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Alon Levy
Several small signedness / overflow corrections to qxl_create_guest_primary: 1. use 64 bit unsigned for size to avoid overflow possible from two 32 bit multiplicants. 2. correct sign for requested_height 3. add a more verbose error message when setting guest bug state (which causes a complete guess

[Qemu-devel] [PATCH 0/3] S390 SCLP improvements for CPU Hotplug

2014-01-20 Thread Jason J. Herne
From: "Jason J. Herne" Improvements to SCLP, mainly the Read SCP/CPU Info subcommands, to support future cpu hotplug operations on the s390 target. Jason J. Herne (3): s390-sclp: Define New SCLP Codes s390-sclp: SCLP CPU Info s390-sclp: SCLP Event integration hw/s390x/Makefile.objs

[Qemu-devel] [PATCH 1/3] s390-sclp: Define New SCLP Codes

2014-01-20 Thread Jason J. Herne
From: "Jason J. Herne" Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c | 2 +- include/hw/s390x/sclp.h | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 86d6ae0..cb035

[Qemu-devel] [PATCH 3/3] s390-sclp: SCLP Event integration

2014-01-20 Thread Jason J. Herne
From: "Jason J. Herne" Add an sclp event for "cpu was hot plugged". This allows Qemu to deliver an SCLP interrupt to the guest stating that the requested cpu hotplug was completed. Signed-off-by: Jason J. Herne --- hw/s390x/Makefile.objs| 1 + hw/s390x/event-facility.c |

Re: [Qemu-devel] [PATCH] piix4: disable bridge acpi hotplug for 1.7 and older

2014-01-20 Thread Igor Mammedov
On Mon, 20 Jan 2014 18:35:17 +0200 "Michael S. Tsirkin" wrote: > Patch was written before 1.7 was out, forgot to update. > > Signed-off-by: Michael S. Tsirkin > --- > > I moved for_anthony tag to include this patch > as well, no reason to make people suffer until > next pull request. Reviewed-

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-20 Thread Alex Williamson
On Mon, 2014-01-20 at 11:20 -0500, Mike Day wrote: > Do you know which device is writing to the BAR below? From the trace > it appears it should be restoring the memory address to the BAR after > writing all 1s to the BAR and reading back the contents. (the protocol > for finding the length of the

[Qemu-devel] [PATCH 6/7] target-i386: kvm_cpu_fill_host(): Fill feature words in a loop

2014-01-20 Thread Eduardo Habkost
Now that the kvm_cpu_fill_host() code is simplified, we can simply set the feature word array using a simple loop. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu

[Qemu-devel] [PATCH 7/7 v2] target-i386: kvm_check_features_against_host(): Kill feature word array

2014-01-20 Thread Eduardo Habkost
We don't need the ft[] array on kvm_check_features_against_host() anymore, as we can simply use the feature_word_info[] array, that has everything we need. Signed-off-by: Eduardo Habkost --- Change v2: * Rebase and solve simple conflict with recent changes in the check/enforce code --- target-

[Qemu-devel] [PATCH 3/7] target-i386: kvm_cpu_fill_host(): No need to check CPU vendor

2014-01-20 Thread Eduardo Habkost
There's no need to check CPU vendor before calling kvm_arch_get_supported_cpuid(s, 0xC000, 0, R_EAX), because: * The kernel won't return any entry for 0xC000 if host CPU vendor is not Centaur (See kvm_dev_ioctl_get_supported_cpuid() on the kernel code); * kvm_arch_get_supported_cpu

[Qemu-devel] [PATCH 4/7] target-i386: kvm_cpu_fill_host(): No need to check xlevel2

2014-01-20 Thread Eduardo Habkost
There's no need to check CPU xlevel2 before calling kvm_arch_get_supported_cpuid(s, 0xC001, 0, R_EDX), because: * The kernel won't return any entry for 0xC000 if host CPU vendor is not Centaur (See kvm_dev_ioctl_get_supported_cpuid() on the kernel code) * Similarly, the kernel won'

[Qemu-devel] [PATCH 5/7] target-i386: kvm_cpu_fill_host(): Set all feature words at end of function

2014-01-20 Thread Eduardo Habkost
Reorder the code so all the code that sets x86_cpu_def->features is at the end of the function. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 8bc72c2..

[Qemu-devel] [PATCH 1/7] target-i386: kvm_cpu_fill_host(): Kill unused code

2014-01-20 Thread Eduardo Habkost
Those host_cpuid() calls are useless. They are leftovers from when the old code using host_cpuid() was removed. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 0eea8c7..6f27273 100644 --- a/targ

[Qemu-devel] [PATCH 0/7 RESEND] target-i386: Simplify kvm_cpu_fill_host() and kvm_check_features_against_host()

2014-01-20 Thread Eduardo Habkost
Resend of series submitted on 24 November 2013, that didn't get any reply. Only change is a trivial conflict on patch 7/7. This series simplifies kvm_cpu_fill_host() and kvm_check_features_against_host() to simply use FeatureWord & feature_word_info loops to fill/check feature words. The initial

[Qemu-devel] [PATCH 2/7] target-i386: kvm_cpu_fill_host(): No need to check level

2014-01-20 Thread Eduardo Habkost
There's no need to check level (CPUID[0].EAX) before calling kvm_arch_get_supported_cpuid(s, 0x7, 0, R_EBX), because: * The kernel won't return any entry for CPUID 7 if CPUID[0].EAX is < 7 (See kvm_dev_ioctl_get_supported_cpuid() on the kernel code); * kvm_arch_get_supported_cpuid() will retu

[Qemu-devel] [PATCH] piix4: disable bridge acpi hotplug for 1.7 and older

2014-01-20 Thread Michael S. Tsirkin
Patch was written before 1.7 was out, forgot to update. Signed-off-by: Michael S. Tsirkin --- I moved for_anthony tag to include this patch as well, no reason to make people suffer until next pull request. hw/i386/pc_piix.c| 4 include/hw/i386/pc.h | 13 - 2 files changed

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-20 Thread Andreas Färber
Am 20.01.2014 15:36, schrieb Eduardo Habkost: > This enables x2apic on the following CPU models: Conroe, Penryn, > Nehalem, Westmere, Opteron_G[12345]. > > Normally we try to keep the CPU model definitions as close as the real > CPUs as possible, but x2apic can be emulated by KVM without host CPU

Re: [Qemu-devel] [PULL 19/29] piix4: add acpi pci hotplug support

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 06:16:59PM +0200, Michael S. Tsirkin wrote: > On Mon, Jan 20, 2014 at 04:10:25PM +0200, Michael S. Tsirkin wrote: > > Add support for acpi pci hotplug using the > > new infrastructure. > > PIIX4 legacy interface is maintained as is for > > machine types 1.6 and older. > > A

Re: [Qemu-devel] [PATCH] spapr: reset @kvm_vcpu_dirty before starting CPU

2014-01-20 Thread Andreas Färber
Am 15.01.2014 05:57, schrieb Alexey Kardashevskiy: > Normally QEMU kvm_arch_get_registers() reads registers and sets a dirty > flag which prevents further registers reading from KVM till > kvm_arch_put_registers() executes and resets the flag. > > However if we run QEMU with "-S" ("suspended"), th

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-20 Thread Mike Day
Do you know which device is writing to the BAR below? From the trace it appears it should be restoring the memory address to the BAR after writing all 1s to the BAR and reading back the contents. (the protocol for finding the length of the bar memory.) On Thu, Jan 9, 2014 at 12:24 PM, Alex William

Re: [Qemu-devel] [PULL 19/29] piix4: add acpi pci hotplug support

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 04:10:25PM +0200, Michael S. Tsirkin wrote: > Add support for acpi pci hotplug using the > new infrastructure. > PIIX4 legacy interface is maintained as is for > machine types 1.6 and older. Actually that's wrong of course, should be off for 1.7 and older. I'll send v2. >

[Qemu-devel] [PULL 02/29] Add DSDT node for AppleSMC

2014-01-20 Thread Michael S. Tsirkin
From: "Gabriel L. Somlo" AppleSMC (-device isa-applesmc) is required to boot OS X guests. OS X expects a SMC node to be present in the ACPI DSDT. This patch adds a SMC node to the DSDT, and dynamically patches the return value of SMC._STA to either 0x0B if the chip is present, or otherwise to 0x0

[Qemu-devel] [v19 16/25] sheepdog.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
sheepdog.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/sheepdog.c | 101 +- 1 files changed, 47 insertions(+), 54 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c i

[Qemu-devel] [PULL 15/29] acpi unit-test: do not fail on asl mismatch

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The asl comparison will break every time the ACPI tables are updated. This may break the git bisect. Instead of failing print a warning on stderr including the retained asl files, so they can be compared offline. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsi

[Qemu-devel] [PULL 29/29] acpi-test: update expected AML since recent changes

2014-01-20 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 4407 -> 4582 bytes tests/acpi-test-data/pc/SSDT | Bin 2104 -> 2200 bytes tests/acpi-test-data/q35/DSDT | Bin 7344 -> 7438 bytes tests/acpi-test-data/q35/SSDT | Bin 2104 -> 475 bytes 4 files changed, 0 insertions(+), 0

[Qemu-devel] [PULL 21/29] acpi: factor out common cpu hotplug code for PIIX4/Q35

2014-01-20 Thread Michael S. Tsirkin
From: Igor Mammedov .. so it could be used for adding CPU hotplug to Q35 machine Add an additional header with that will be shared between C and ASL code: include/hw/acpi/cpu_hotplug_defs.h Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- in

[Qemu-devel] [v19 17/25] ssh.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
ssh.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/ssh.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index aa63c9d..8fd2175 100644 --- a/block/ss

Re: [Qemu-devel] [v19 02/25] qapi: output def_value_str when query command line options

2014-01-20 Thread Eric Blake
On 01/20/2014 07:19 AM, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when query > command line options. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > +++ b/qapi-schema.json > @@ -3891,12 +3891,16 @@ > # > # @help: #optional human r

[Qemu-devel] [PULL 28/29] pc: ACPI: update acpi-dsdt.hex.generated q35-acpi-dsdt.hex.generated

2014-01-20 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-dsdt.hex.generated | 217 +--- hw/i386/q35-acpi-dsdt.hex.generated | 74 ++-- hw/i386/ssdt-pcihp.hex.generated|

[Qemu-devel] [v19 24/25] cleanup QEMUOptionParameter

2014-01-20 Thread Chunyan Liu
Now all places using QEMUOptionParameter could use QemuOpts too, remove QEMUOptionParameter related code. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c | 147 ++- block/cow.c |2 +- block/qcow.c |2 +-

  1   2   3   >