Michael Roth writes:
> Quoting Markus Armbruster (2014-04-28 15:27:41)
>> Signed-off-by: Markus Armbruster
>> Reviewed-by: Eric Blake
>> ---
>> qga/commands-posix.c | 209
>> ++-
>> qga/commands-win32.c | 115 ++--
>> qga
Michael Roth writes:
> Quoting Markus Armbruster (2014-04-28 15:27:42)
>> Signed-off-by: Markus Armbruster
>> Reviewed-by: Eric Blake
>> ---
>> qga/commands-posix.c | 10 +-
>> qga/commands-win32.c | 10 +-
>> 2 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git
Eric Blake writes:
> On 04/29/2014 02:20 PM, Lluís Vilanova wrote:
>> Markus Armbruster writes:
>>
>>> Lluís Vilanova writes:
Use an explicit input file on the command-line instead of reading
from standard input
>>
>>> Please limit commit message line length to 70 characters.
>>
>>>
29.04.2014 10:29, Paolo Bonzini wrote:
[]
> What about this instead, does it do the same?
>
> diff --git a/rules.mak b/rules.mak
> index 5c454d8..7038576 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -228,6 +228,7 @@ endef
> define unnest-vars
> $(eval obj := $1)
> $(eval nested-vars := $2)
>
On 04/29/2014 09:17 AM, Max Reitz wrote:
> As the length of a mirror block job no longer directly depends on the
> size of the block device, drop those checks from this test. Instead,
> just check whether the final offset equals the block job length.
>
> As 041 uses the wait_until_completed functi
On 04/29/2014 09:17 AM, Max Reitz wrote:
> Add a test for qemu-img commit on backing chains with more than two
> images. This test also checks whether the images above the base image
> are emptied and does therefore not work for qed and vmdk which requires
> it to be separate from 020.
>
> Signed-
On Tue, 04/29 18:39, Jeff Cody wrote:
> This is an initial, simple live migration test from one
> running VM to another, using monitor commands.
>
> This is also an example of using the new common.qemu functions
> for controlling multiple running qemu instances, for tests that
> need a live qemu v
On Tue, 04/29 18:39, Jeff Cody wrote:
> The new functionality of common.qemu implements the QEMU control
> and communication functionality that was originally in test 085.
>
> This removes that now-duplicate functionality, and uses the
> common.qemu functions.
>
> The QEMU commandline changes sli
On 04/29/2014 08:06 PM, Fam Zheng wrote:
+
+if [ "${BASH_VERSINFO[0]}" -ge "4" ] && [ "${BASH_VERSINFO[1]}" -ge
"1" ]
>>>
>>> This condition will be false for 5.0.
>>>
>>
>> Oops, yup.
>
> Question of ignorance, is there a Bash 5.0 already?
Nope; bash 4.3 is barely more than
On 04/29/2014 09:07 AM, Max Reitz wrote:
> qemu-img should use QMP commands whenever possible in order to ensure
> feature completeness of both online and offline image operations. As
> qemu-img itself has no access to QMP (since this would basically require
> just everything being linked into qemu
On Tue, 04/29 18:39, Jeff Cody wrote:
> This creates some common functions for bash language qemu-iotests
> to control, and communicate with, a running QEMU process.
>
> 4 functions are introduced:
>
> 1. _launch_qemu()
> This launches the QEMU process(es), and sets up the file
>
On Tue, 04/29 10:11, Jeff Cody wrote:
> On Tue, Apr 29, 2014 at 03:26:55PM +0200, Kevin Wolf wrote:
> > Am 10.04.2014 um 22:47 hat Jeff Cody geschrieben:
> > > This creates some common functions for bash language qemu-iotests
> > > to control, and communicate with, a running QEMU process.
> > >
>
On 04/29/2014 09:07 AM, Max Reitz wrote:
> Instead of taking the total length of the block device as the block
> job's length, use the number of dirty sectors. The progress is now the
> number of sectors mirrored to the target block device. Note that this
> may result in the job's length increasing
On 04/29/2014 03:10 AM, Chunyan Liu wrote:
> Change block layer to support both QemuOpts and QEMUOptionParameter.
> After this patch, it will change backend drivers one by one. At the end,
> QEMUOptionParameter will be removed and only QemuOpts is kept.
>
> Signed-off-by: Dong Xu Wang
> Signed-of
On Tue, 04/29 18:46, Paolo Bonzini wrote:
> No need to save/restore obj-y, we can just build all-obj-y incrementally.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Fam Zheng
> ---
> Makefile.target | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/Makefile.
On Mon, Apr 28, 2014 at 05:11:47PM -0700, Peter Crosthwaite wrote:
>
> Hi Edgar,
>
> Small mixed bag of Microblaze patches that are in my tree.
Hi,
I've taken patch nr 2.
I already had #1 and #3 in my tree. For #3 I have a different version though,
the version you posted breaks raw cpio loadin
On Tue, Apr 29, 2014 at 06:17:17PM -0300, Eduardo Habkost wrote:
> KVM never supported the MONITOR flag so it doesn't make sense to have it
> enabled by default when KVM is enabled.
>
> The rationale here is similar to the cases where it makes sense to have
> a feature enabled by default on all CP
On 04/13/2014 12:38 AM, Alexey Kardashevskiy wrote:
> On 03/27/2014 08:01 PM, Markus Armbruster wrote:
>> Adding Juan.
>
>
> Ping?
Ping?
>
>>
>> Alexey Kardashevskiy writes:
>>
>>> The existing timeout is 30ms which on 100MB/s (1Gbit) gives us
>>> 3MB/s rate maximum. If we put some load on
Check vmsd for unmigratable field, allowing migratibility status
to be modified after vmstate_register.
Signed-off-by: Marcelo Tosatti
diff --git a/savevm.c b/savevm.c
index da8aa24..c578e42 100644
--- a/savevm.c
+++ b/savevm.c
@@ -232,7 +232,6 @@ typedef struct SaveStateEntry {
const VMSta
On 04/30/14 01:25, Eric Blake wrote:
> On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
>> Signed-off-by: Laszlo Ersek
>> ---
>> hw/i386/kvm/pci-assign.c | 26 ++
>> 1 file changed, 10 insertions(+), 16 deletions(-)
>>
>
> Reviewed-by: Eric Blake
>
Your (surprisingly lenien
On 04/30/14 00:41, Eric Blake wrote:
> On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
>> Among the callers, only assigned_initfn() should set the monitor's stored
>
> unintentional double space
Yep, my mistake in paragraph refilling.
>
>> error. Other callers may run in contexts where the monitor
On Mon, Apr 28, 2014 at 02:55:03AM +, Gonglei (Arei) wrote:
> Hi,
>
> > Il 26/04/2014 10:56, Gonglei (Arei) ha scritto:
> > > Public bug reported:
> > >
> > > I want to repeated hot-plug/unplug the virtio-net in the latest qemu
> > upstream
> > > (commit 839a5547574e57cce62f49bfc50fe1f04b00589
Changes from v3:
Patch 1: - Make bash version check work with >= 5 as well (Thanks Kevin)
- Suppress error message if killing non-existent PID
- Close QEMU fifo in/out file descriptors on cleanup (Thanks Kevin)
- Remove extra newline at the end of the file (Thank
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek
> ---
> hw/i386/kvm/pci-assign.c | 26 ++
> 1 file changed, 10 insertions(+), 16 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualizatio
The new functionality of common.qemu implements the QEMU control
and communication functionality that was originally in test 085.
This removes that now-duplicate functionality, and uses the
common.qemu functions.
The QEMU commandline changes slightly due to this; in addition to
monitor and qmp i/
On Tue, Apr 29, 2014 at 06:51:12PM +0200, Paolo Bonzini wrote:
> I'm not including Avi since he has already removed himself from the
> KVM entry. I'm not going to commit my patches without review.
>
> Signed-off-by: Paolo Bonzini
Acked-by: Edgar E. Iglesias
> ---
> MAINTAINERS | 10
On 04/29/2014 02:20 PM, Lluís Vilanova wrote:
> Markus Armbruster writes:
>
>> Lluís Vilanova writes:
>>> Use an explicit input file on the command-line instead of reading from
>>> standard input
>
>> Please limit commit message line length to 70 characters.
>
>> Worth mentioning that this com
On 04/29/2014 04:24 PM, Eric Blake wrote:
> On 04/29/2014 09:07 AM, Max Reitz wrote:
>> bdrv_make_empty() is currently only called if the current image
>> represents an external snapshot that has been committed to its base
>> image; it is therefore unlikely to have internal snapshots. In this
>> ca
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Among the callers, only assigned_initfn() should set the monitor's stored
unintentional double space
> error. Other callers may run in contexts where the monitor's stored error
> makes no sense. For example:
>
> assigned_dev_pci_write_config()
> a
This is an initial, simple live migration test from one
running VM to another, using monitor commands.
This is also an example of using the new common.qemu functions
for controlling multiple running qemu instances, for tests that
need a live qemu vm.
Signed-off-by: Jeff Cody
---
tests/qemu-iote
This creates some common functions for bash language qemu-iotests
to control, and communicate with, a running QEMU process.
4 functions are introduced:
1. _launch_qemu()
This launches the QEMU process(es), and sets up the file
descriptors and fifos for communication. You can
On 04/29/2014 09:07 AM, Max Reitz wrote:
> bdrv_make_empty() is currently only called if the current image
> represents an external snapshot that has been committed to its base
> image; it is therefore unlikely to have internal snapshots. In this
> case, bdrv_make_empty() can be greatly sped up by
Quoting Markus Armbruster (2014-04-28 15:27:51)
> acquire_privilege(), execute_async() and check_suspend_mode() do
> nothing when called with an error set. Callers shouldn't do that, and
> no caller does. Drop the superfluous tests.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
Quoting Markus Armbruster (2014-04-28 15:27:50)
> Using error_is_set(ERRP) to find out whether a function failed is
> either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
> may be null, because errors go undetected when it is. It's fragile
> when proving ERRP non-null involves a n
Quoting Markus Armbruster (2014-04-28 15:27:49)
> Using error_is_set(ERRP) to find out whether a function failed is
> either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
> may be null, because errors go undetected when it is. It's fragile
> when proving ERRP non-null involves a n
Quoting Markus Armbruster (2014-04-28 15:27:48)
> visit_type_TestStruct() does nothing when called with an error set.
> Callers shouldn't do that, and no caller does. Drop the superfluous
> test.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
Reviewed-by: Michael Roth
> ---
>
Quoting Markus Armbruster (2014-04-28 15:27:47)
> do_qmp_dispatch()'s test for qmp_dispatch_check_obj() failure examines
> both the return value and the error object. The latter part is
> unclean; it works only when do_qmp_dispatch()'s caller passes a
> non-null errp argument. That's the case, bu
Quoting Markus Armbruster (2014-04-28 15:27:45)
> Using error_is_set(errp) to check whether a function call failed is
> fragile: it breaks when errp is null. ga_get_fd_handle() and
> guest_file_handle_add() don't return a useful value when they fail,
> but that's just stupid. Fix that, and check
Quoting Markus Armbruster (2014-04-28 15:27:42)
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
> ---
> qga/commands-posix.c | 10 +-
> qga/commands-win32.c | 10 +-
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/qga/commands-posix.c b/qga/com
KVM never supported the MONITOR flag so it doesn't make sense to have it
enabled by default when KVM is enabled.
The rationale here is similar to the cases where it makes sense to have
a feature enabled by default on all CPU models when on KVM mode (e.g.
x2apic). In this case we are having a featu
Quoting Markus Armbruster (2014-04-28 15:27:41)
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
> ---
> qga/commands-posix.c | 209
> ++-
> qga/commands-win32.c | 115 ++--
> qga/commands.c | 4 +-
> qg
Instead of manually calling cpu_x86_set_cpl() when the CPL changes,
check for CPL changes on calls to cpu_x86_load_seg_cache(R_CS). Every
location that called cpu_x86_set_cpl() also called
cpu_x86_load_seg_cache(R_CS), so cpu_x86_set_cpl() is no longer
required.
This fixes the SMM handler code as
The cpu_x86_load_seg_cache() function inspects cr0 and eflags, so make
sure all changes to eflags and cr0 are done prior to loading the
segment caches.
Signed-off-by: Kevin O'Connor
---
target-i386/smm_helper.c | 34 +-
1 file changed, 17 insertions(+), 17 deletio
The cpu_x86_load_seg_cache() function inspects eflags, so make sure
all changes to eflags are done prior to loading the segment caches.
Signed-off-by: Kevin O'Connor
---
target-i386/seg_helper.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff
The svm_load_seg_cache() function calls cpu_x86_load_seg_cache() which
inspects env->eflags. So, make sure all changes to eflags are done
prior to loading the segment cache.
Signed-off-by: Kevin O'Connor
---
target-i386/svm_helper.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
This patch series is an update to the patch I sent at:
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04028.html
The goal of the patch series is to fix the SMM handler so that it runs
with the proper cpl. I've broken the series up based on the feedback
from Paolo.
As with the previous
Luiz Capitulino writes:
> On Tue, 29 Apr 2014 21:50:10 +0200
> Markus Armbruster wrote:
>> Luiz Capitulino writes:
>>
>> > On Fri, 25 Apr 2014 17:09:49 +0200
>> > Markus Armbruster wrote:
>> >
>> >> Luiz Capitulino writes:
>> >>
>> >> > On Sun, 13 Apr 2014 21:07:53 +0200
>> >> > Lluís Vilan
Markus Armbruster writes:
> Lluís Vilanova writes:
>> Use an explicit input file on the command-line instead of reading from
>> standard input
> Please limit commit message line length to 70 characters.
> Worth mentioning that this commit improves error messages!
> :123: Borked
> becomes
Markus Armbruster writes:
> Lluís Vilanova writes:
>> The primitive uses JSON syntax, and include paths are relative to the file
>> using the directive:
>>
>> { 'include': 'path/to/file.json' }
>>
>> Signed-off-by: Lluís Vilanova
>> ---
>> docs/qapi-code-gen.txt | 11 +++
On Tue, 29 Apr 2014 21:50:10 +0200
Markus Armbruster wrote:
> Luiz Capitulino writes:
>
> > On Fri, 25 Apr 2014 17:09:49 +0200
> > Markus Armbruster wrote:
> >
> >> Luiz Capitulino writes:
> >>
> >> > On Sun, 13 Apr 2014 21:07:53 +0200
> >> > Lluís Vilanova wrote:
> >> >
> >> >> Adds an inc
On Tue, 29 Apr 2014 09:02:13 -0600
Eric Blake wrote:
> On 04/29/2014 08:53 AM, Natanael Copa wrote:
> > On Tue, 29 Apr 2014 08:28:29 -0600
> > Eric Blake wrote:
> >
> >> On 04/29/2014 08:17 AM, Natanael Copa wrote:
> >>> The __SIGRTMIN and __SIGRTMAX are glibc internals and are not available
>
Luiz Capitulino writes:
> On Fri, 25 Apr 2014 17:09:49 +0200
> Markus Armbruster wrote:
>
>> Luiz Capitulino writes:
>>
>> > On Sun, 13 Apr 2014 21:07:53 +0200
>> > Lluís Vilanova wrote:
>> >
>> >> Adds an include primitive to the syntax of QAPI schema files,
>> >> allowing these to
>> >> be
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek
> ---
> hw/i386/kvm/pci-assign.c | 23 +--
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> @@ -423,13 +424,13 @@ static int assigned_dev_register_regions(PCIRegion
> *io_regions,
>
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Also, change the return type to "void"; the function is static (with a
> sole caller) and the negative errno values are not distinguished from each
> other.
>
> Signed-off-by: Laszlo Ersek
> ---
> hw/i386/kvm/pci-assign.c | 29 +++
Only show the scrollbar if the content doesn't fit on the visible space.
Signed-off-by: Cole Robinson
---
This applies on top of Gerd's series 'gtk: cleanups continued'
ui/gtk.c | 42 --
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/ui/gt
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> The return type is also changed from "int" to "void", because it was used
> in a success vs. failure sense only (the caller didn't distinguish error
> codes from each other, and even assigned_dev_register_msix_mmio() masked
> mmap()'s errno values with
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek
> ---
> hw/i386/kvm/pci-assign.c | 45 +++--
> 1 file changed, 19 insertions(+), 26 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Li
On 04/29/2014 09:07 AM, Max Reitz wrote:
> Implement this function by making all clusters in the image file fall
> through to the backing file (by using the recently extended discard).
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2.c | 27 +++
> 1 file changed, 27 inser
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek
> ---
> hw/i386/kvm/pci-assign.c | 40
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> again:
> r = read(dev->config_fd, pci_dev->dev.config,
> pci_conf
On 04/29/2014 11:51 AM, Laszlo Ersek wrote:
> On 04/29/14 19:41, Eric Blake wrote:
>> On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
>>> ... and rebase pci_add_capability() to it.
>>>
>>> Signed-off-by: Laszlo Ersek
>>> ---
>>> +int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,
>>> +
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> assigned_initfn()
> get_real_device()
> read()
>
> Signed-off-by: Laszlo Ersek
> ---
> hw/i386/kvm/pci-assign.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assi
On 04/29/2014 11:21 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> ui/gtk.c | 45 ++---
> 1 file changed, 26 insertions(+), 19 deletions(-)
>
Reviewed-by: Cole Robinson
Tested-by: Cole Robinson
- Cole
On 04/29/2014 11:21 AM, Gerd Hoffmann wrote:
> The vte tabs simply get the size of the vga tab then, with whatever
> cols and lines are fitting in. I find this bahavior more useful than
> resizing the qemu window all day long.
>
> YMMV. Comments are welcome.
>
> Signed-off-by: Gerd Hoffmann
M
On 04/29/2014 11:21 AM, Gerd Hoffmann wrote:
> The vte widget implements the scrollable interface, placing it into
> a scrolled window is pointless and creates a bunch of strange effects.
> Zap it.
>
> Signed-off-by: Gerd Hoffmann
> ---
> ui/gtk.c | 19 ++-
> 1 file changed, 2 in
On Tue, Apr 29, 2014 at 04:03:24PM +0100, Matthew Booth wrote:
> [PATCH 1/8] curl: Fix long line
> [PATCH 2/8] curl: Remove unnecessary use of goto
> [PATCH 3/8] curl: Fix return from curl_read_cb with invalid state
> [PATCH 4/8] curl: Remove erroneous sleep waiting for curl completion
> [PATCH 5/8
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Propagate any errors while adding PCI capabilities to
> assigned_device_pci_cap_init(). We'll continue the propagation upwards
> when assigned_device_pci_cap_init() becomes a leaf itself (when none of
> its callees will report errors internally any long
On 04/29/2014 10:33 AM, Stefan Weil wrote:
> I'm still investigating whether it's necessary to set tci_tb_ptr to 0
> (as you suggested). Up to now, the TCI code did never invalidate
> tci_tb_ptr, but there was no obvious indication of problems caused by
> this behaviour.
Oh, I mis-read this bit be
On 04/29/2014 10:33 AM, Stefan Weil wrote:
> I'm still investigating whether it's necessary to set tci_tb_ptr to 0
> (as you suggested). Up to now, the TCI code did never invalidate
> tci_tb_ptr, but there was no obvious indication of problems caused by
> this behaviour.
It should be exactly 6 lin
Am 29.04.2014 19:03, schrieb Max Reitz:
> Currently, if an error occurs during the part of vdi_create() which
> actually writes the image, the function stores -errno, but continues
> anyway.
>
> Instead of trying to write data which (if it can be written at all) does
> not make any sense without t
On 04/29/14 19:41, Eric Blake wrote:
> On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
>> ... and rebase pci_add_capability() to it.
>>
>> Signed-off-by: Laszlo Ersek
>> ---
>> include/hw/pci/pci.h | 4
>> hw/pci/pci.c | 32 ++--
>> 2 files changed, 30 insert
Lluís Vilanova writes:
> The primitive uses JSON syntax, and include paths are relative to the file
> using the directive:
>
> { 'include': 'path/to/file.json' }
>
> Signed-off-by: Lluís Vilanova
> ---
> docs/qapi-code-gen.txt | 11 +
> scripts/qapi.py
Am 29.04.2014 19:03, schrieb Max Reitz:
> Instead of blindly relying on a normal integer having a width of 32 bits
> (which is a pretty good assumption, but we should not rely on it if
> there is no need), use the correct format string macros.
>
The old code would only fail on platforms with size
On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> ... and rebase pci_add_capability() to it.
>
> Signed-off-by: Laszlo Ersek
> ---
> include/hw/pci/pci.h | 4
> hw/pci/pci.c | 32 ++--
> 2 files changed, 30 insertions(+), 6 deletions(-)
>
> @@ -306,10 +307
Am 29.04.2014 17:20, schrieb Richard Henderson:
> On 04/28/2014 10:57 PM, Stefan Weil wrote:
>> -static tcg_target_ulong tci_reg[TCG_TARGET_NB_REGS];
>> +static inline void save_tb_ptr(void *tb_ptr)
>> +{
>> +#ifdef CONFIG_SOFTMMU
>> +tci_tb_ptr = (uintptr_t)tb_ptr;
>> +#endif
>> +}
>>
>
> W
On 26.04.2014 [00:16:38 +1000], Alexey Kardashevskiy wrote:
> On 04/23/2014 05:04 AM, Nishanth Aravamudan wrote:
> > On 22.04.2014 [19:27:51 +1000], Benjamin Herrenschmidt wrote:
> >> On Tue, 2014-04-22 at 19:12 +1000, Alexey Kardashevskiy wrote:
> >>> I already have in plan to fix non-power-of-two
There are several goals at play here:
(1) We never actually use calls with a truly dynamic target. Which,
honestly, is a good thing, because on select hosts means we can
always use a direct branch.
Rather than spend effort splitting and then recombining call
targets, wh
Signed-off-by: Richard Henderson
---
tcg/ppc/tcg-target.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c
index 32f600c..9062898 100644
--- a/tcg/ppc/tcg-target.c
+++ b/tcg/ppc/tcg-target.c
@@ -501,7 +501,7 @@ static void
Public bug reported:
The monitor 'screendump' command returns stale data for VMs using qxl +
spice. If you perform multiple screendumps, screendump #N will show
roughly the display from the time screendump #N-1 was taken. This
affects 'virsh screenshot' and libvirt screenshot APIs by association.
Lluís Vilanova writes:
> Use an explicit input file on the command-line instead of reading from
> standard input
Please limit commit message line length to 70 characters.
Worth mentioning that this commit improves error messages!
:123: Borked
becomes
qapi-schema.json:123: Borked
wh
On 04/29/2014 03:38 AM, Alex Bennée wrote:
>> next:
>> > -if (search_pc >= 0 && search_pc < s->code_ptr - gen_code_buf) {
>> > +if (search_pc >= 0
>> > +&& search_pc < (intptr_t)s->code_ptr -
>> > (intptr_t)gen_code_buf) {
>> > return op_index;
>> >
Currently, seek_to_sector() returns -1 both for errors and unallocated
sectors, resulting in silent errors. As 0 is an invalid offset of data
clusters (bitmap_offset is greater than 0 because s->data_offset is
greater than 0), just return 0 for unallocated sectors and -errno in
case of error. This
The call to bdrv_getlength() from qcow2_check_refcounts() may result in
an error. Check this and abort if necessary.
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index e6fc30e..76da3ab
Instead of blindly relying on a normal integer having a width of 32 bits
(which is a pretty good assumption, but we should not rely on it if
there is no need), use the correct format string macros.
This does not touch DEBUG output.
Signed-off-by: Max Reitz
---
block/cow.c | 2 +-
block/dm
Currently, if an error occurs during the part of vdi_create() which
actually writes the image, the function stores -errno, but continues
anyway.
Instead of trying to write data which (if it can be written at all) does
not make any sense without the operations before succeeding (e.g.,
writing the i
alloc_clusters_noref() stores the cluster index in a uint64_t. However,
offsets are often represented as int64_t (as for example the return
value of alloc_clusters_noref() itself demonstrates). Therefore, we
should make sure all offsets in the allocated range of clusters are
representable using int
First, new_l1_size is an int64_t, whereas min_size is a uint64_t.
Therefore, during the loop which adjusts new_l1_size until it equals or
exceeds min_size, new_l1_size might overflow and become negative. The
comparison in the loop condition however will take it as an unsigned
value (because min_siz
Max Reitz (6):
qcow2: Avoid overflow in alloc_clusters_noref()
block: Use correct width in format strings
qcow2: Catch bdrv_getlength() error
qcow2: Check min_size in qcow2_grow_l1_table()
block/bochs: Fix error handling for seek_to_sector()
block/vdi: Error out immediately in vdi_creat
The INDEX_op_call case has just been obsoleted; the mov and movi
cases have not been reachable for years. Attempt to document this
both in each tcg_out_op switch, and via TCG_OPF_NOT_PRESENT.
Because of the TCG_OPF_NOT_PRESENT change, this must be done for
all targets in a single commit.
Signed-
On 04/29/2014 09:07 AM, Max Reitz wrote:
> Normally, discarded sectors should read back as zero. However, there are
> cases in which a sector (or rather cluster) should be discarded as if
> they were never written in the first place, that is, reading them should
> fall through to the backing file a
Avoid allocating a tcg temporary to hold the constant address,
and instead place it directly into the op_call arguments.
At the same time, convert to the newly introduced tcg_out_call
backend function, rather than invoking tcg_out_op for the call.
Signed-off-by: Richard Henderson
---
tcg/optimi
Signed-off-by: Richard Henderson
---
tcg/mips/tcg-target.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c
index eaf1745..65acc86 100644
--- a/tcg/mips/tcg-target.c
+++ b/tcg/mips/tcg-target.c
@@ -153,11 +153,6
Rename the existing tcg_out_calli to tcg_out_call_nodelay.
Signed-off-by: Richard Henderson
---
tcg/sparc/tcg-target.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c
index 22a98fb..4f8de1e 100644
--- a/t
The move opcodes are special in that their constraints must cover
all available registers. So instead of checking the constraints,
just use the available registers.
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --
On 04/29/2014 08:41 AM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> On 04/29/2014 04:25 AM, Alex Bennée wrote:
+static void reloc_pc24(tcg_insn_unit *pc, tcg_insn_unit *target)
{
-*(uint32_t *)pc = (*(uint32_t *)pc & ~0x3fc)
-| reloc_pc24_val(pc, ta
Signed-off-by: Richard Henderson
---
tcg/s390/tcg-target.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
index ae1be1c..0ae40e1 100644
--- a/tcg/s390/tcg-target.c
+++ b/tcg/s390/tcg-target.c
@@ -1269,7 +1269,7 @@ static v
Merge the existing tcg_out_call into tcg_out_op.
Signed-off-by: Richard Henderson
---
tcg/ppc64/tcg-target.c | 37 -
1 file changed, 16 insertions(+), 21 deletions(-)
diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
index 4a0b7db..d80f2d9 100644
-
Signed-off-by: Richard Henderson
---
tcg/tci/tcg-target.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c
index 6123f9f..7425e73 100644
--- a/tcg/tci/tcg-target.c
+++ b/tcg/tci/tcg-target.c
@@ -549,6 +549,11 @@ static void tcg_out_movi(TCGConte
Signed-off-by: Richard Henderson
---
tcg/i386/tcg-target.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
index eb8d2a1..48a95f8 100644
--- a/tcg/i386/tcg-target.c
+++ b/tcg/i386/tcg-target.c
@@ -1113,7 +1113,7 @@ static voi
I'm not including Avi since he has already removed himself from the
KVM entry. I'm not going to commit my patches without review.
Signed-off-by: Paolo Bonzini
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 96299dd..8913e1a 100644
On 29.04.14 17:11, Cornelia Huck wrote:
Here's the next version of the kvm capability helpers, again on
https://github.com/cohuck/qemu.git kvm-cap-helpers
Changes v1->v2:
- add cap.flags parameter
- function word ordering
Reviewed-by: Alexander Graf
Alex
1 - 100 of 384 matches
Mail list logo
