On Wed, Aug 06, 2014 at 08:05:46AM +0200, Markus Armbruster wrote:
> "Gonglei (Arei)" writes:
>
> > Hi,
> >
> >> >
> >> > $WHATEVER: don't use 'Yoda conditions'
> >> >
> >> > 'Yoda conditions' are not part of idiomatic QEMU coding
> >> > style, so rewrite them in the more usual order.
> >>
> >>
Implement a pci host bridge specific to passthrough. Actually
this just inherits the standard one.
This is based on http://patchwork.ozlabs.org/patch/363810/.
Signed-off-by: Tiejun Chen
---
hw/pci-host/piix.c | 39 +++
include/hw/i386/pc.h | 2 ++
2 files
We need to use this index to reuse this macro later
Signed-off-by: Tiejun Chen
---
hw/pci-host/piix.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
v4:
* New patch to extend I440FX_PCI_DEVICE
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0cd82b8..4330599 100644
Pass types to configure pc_init1().
Signed-off-by: Tiejun Chen
---
hw/i386/pc_piix.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
v4:
* New patch to work for patch #1
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index bf26550..2bf8046 100644
--- a/hw/i386/pc_
Now we can introduce a new machine, xenigd, specific to IGD
passthrough. This can avoid involving other common codes.
Signed-off-by: Tiejun Chen
---
hw/i386/pc_piix.c | 43 +++
1 file changed, 43 insertions(+)
v4:
* Rebase
v3:
* Rebase
v2:
* Unify pr
v4:
* Rebase on latest tree
* Drop patch #2
* Regenerate patches after Michael introduce patch #1
* We need to use this pci_type as a index to reuse I440FX_PCI_DEVICE()
* Test: boot with a preinstalled winxp
./i386-softmmu/qemu-system-i386 -hda winxp-32.img -m 2560 -boot c -machine pc
v3:
* Dr
From: "Michael S. Tsirkin"
Xen wants to supply a different pci and host devices,
inheriting i440fx devices. Make types configurable.
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Tiejun Chen
---
hw/i386/pc_piix.c| 4 +++-
hw/pci-host/piix.c | 9 -
include/hw/i386/pc.h | 6 +++
Thanks Richard :)
On Sat, Aug 2, 2014 at 4:47 AM, Richard W.M. Jones
wrote:
> On Fri, Aug 01, 2014 at 11:15:29AM +0800, Gareth wrote:
> > Hi all
> >
> > What does '-enable-kvm' option mean? I have heard two versions of
> answers:
>
> It's a shortcut for:
>
> $qemu -machine accel=kvm
>
> > a)
Public bug reported:
qemu (kvm) 2.1.0 (built from sources) fails to start if number of cores
is greater than 1.
relevant part of commandline arguments:
/usr/bin/qemu-system-x86_64 -name test3 -S -machine pc-
i440fx-2.1,accel=kvm,usb=off -cpu Westmere -m 4096 -realtime mlock=off
-smp 1,maxcpus=4,
On 2014/8/4 21:51, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 08:09:30PM +0800, Tiejun Chen wrote:
v3:
* Drop patch #4
* Add one patch #1 from Michael
* Rebase
You added my patch but don't use it, so most of
my comment weren't addressed.
I guess I should cover those comments and post
On 2014/8/4 21:50, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 08:09:33PM +0800, Tiejun Chen wrote:
Implement a pci host bridge specific to passthrough. Actually
this just inherits the standard one.
This is based on http://patchwork.ozlabs.org/patch/363810/.
Signed-off-by: Tiejun Chen
-
On 2014/8/4 21:48, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 08:09:31PM +0800, Tiejun Chen wrote:
Xen wants to supply a different pci and host devices,
inheriting i440fx devices. Make types configurable.
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Tiejun Chen
You should have a
"Zhang Haoyu" writes:
>> The output is on qemu's stderr. You are in control of what that
> stderr is.
>
> I don't get why we can configure
> -D /path/to/unique/file/name.log
>
> but we also have to redirect stderr (I didn't checked if the daemonize
> option was cl
v1 -> v2:
-ivshmem: modified the log message according to reviewing suggestion of Michael
zhanghailiang (4):
l2cap: fix access freed memory
monitor: fix access freed memory
virtio-blk: fix reference a pointer which might be freed
ivshmem: check the value returned by fstat()
hw/block/virt
On 2014/8/4 21:48, Michael S. Tsirkin wrote:
On Thu, Jul 31, 2014 at 08:09:32PM +0800, Tiejun Chen wrote:
We'd like to split pc_init1 and then we can share something
with other stuff.
Signed-off-by: Tiejun Chen
With patch 1 in place, this should not be
necessary - just propage the correct ty
In function virtio_blk_handle_request, it may freed memory pointed by req,
So do not access member of req after calling this function.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: zhanghailiang
---
hw/block/virtio-blk.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/
William Dauchy writes:
> On Tue, Aug 5, 2014 at 8:57 PM, Dr. David Alan Gilbert
> wrote:
>> Can you confirm this is on the final 2.1 release (there was a fix that
>> went in just around rc5).
>
> for the receiver, I'm using 2.1
> # qemu-system-x86_64 --version
> QEMU emulator version 2.1.0, Copy
The function fstat() may fail, so check its return value.
Signed-off-by: zhanghailiang
---
hw/misc/ivshmem.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 768e528..5d939d2 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.
The function monitor_fdset_dup_fd_find_remove() references member of 'mon_fdset'
which may be freed in function monitor_fdset_cleanup()
Signed-off-by: zhanghailiang
---
monitor.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/monitor.c b/monitor.c
index 5bc70a6..41e46a6 1
Pointer 'ch' will be used in function 'l2cap_channel_open_req_msg' after
it was previously freed in 'l2cap_channel_open'.
Assigned it to NULL after it is freed.
Reviewed-by: Alex Bennée
Signed-off-by: zhanghailiang
---
hw/bt/l2cap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
"Gonglei (Arei)" writes:
> Hi,
>
>> >
>> > $WHATEVER: don't use 'Yoda conditions'
>> >
>> > 'Yoda conditions' are not part of idiomatic QEMU coding
>> > style, so rewrite them in the more usual order.
>>
>>
>> OK but why stop at these files? How about this
>> instead?
>>
> I just search c file
When using monitor command object_add to add a memory backend whose
size is way too big to allocate memory for it, qemu just exits. In
the case we'd better give an error message and keep guest running.
The problem can be reproduced as follows:
1. run qemu
2. (monitor)object_add memory-backend-ram
Add parameter errp to memory_region_init_ram_ptr and update all call
sites to pass in &error_abort.
Signed-off-by: Hu Tao
---
hw/display/g364fb.c | 2 +-
hw/i386/kvm/pci-assign.c | 3 ++-
hw/misc/ivshmem.c| 5 +++--
hw/misc/vfio.c | 3 ++-
hw/ppc/spapr.c | 2 +-
Add parameter errp to memory_region_init_ram and update all call sites
to pass in &error_abort.
Signed-off-by: Hu Tao
---
backends/hostmem-ram.c | 2 +-
hw/alpha/typhoon.c | 3 ++-
hw/arm/armv7m.c | 7 ---
hw/arm/cubieboard.
Add parameter errp to qemu_ram_alloc and qemu_ram_alloc_from_ptr so that
we can handler errors.
Signed-off-by: Hu Tao
---
exec.c | 32 +++-
include/exec/ram_addr.h | 4 ++--
memory.c| 6 +++---
3 files changed, 28 insertions(+), 14 d
Add parameter errp to memory_region_init_rom_device and update all call
sites to pass in &error_abort.
Signed-off-by: Hu Tao
---
hw/block/pflash_cfi01.c | 2 +-
hw/block/pflash_cfi02.c | 2 +-
include/exec/memory.h | 4 +++-
memory.c| 5 +++--
4 files changed, 8 insertions(+),
This implements the core part of dataplane feature of virtio-scsi.
A few fields are added in VirtIOSCSICommon to maintain the dataplane
status. These fields are managed by a new source file:
virtio-scsi-dataplane.c.
Most code in this file will run on an iothread, unless otherwise
commented as in
This series includes two parts:
1. part 1 includes patches 1-4, which improves error handling of
memory_region_init_ram, memory_region_init_ram_ptr and
memory_region_init_rom_device
2. part 2 includes patches 5-6, each fixes a bug of memory backend.
changes to v4:
- don't introd
This patch fixes two problems of memory-backend-file:
1. If user adds a memory-backend-file object using object_add command,
specifying a non-existing directory for property mem-path, qemu
will core dump with message:
/nonexistingdir: No such file or directory
Bad ram offset f
Move VirtIOSCSIReq to header and add one field "vring" as a wrapper
structure of Vring, VirtIOSCSIVring.
This is necessary for coming dataplane code that runs uses vring on
iothread.
Signed-off-by: Fam Zheng
---
include/hw/virtio/virtio-scsi.h | 14 ++
1 file changed, 14 insertions(
This enables the virtio-scsi-dataplane code by setting the iothread
in virtio-scsi device, and makes any function that is called by
back from dataplane to cooperate with the caller: they need to be
vring/iothread aware when handling the requests and using scsi devices
on the bus.
Signed-off-by: Fa
Similar to this property in virtio-blk for dataplane, add it as a QOM
link in virtio-scsi and an alias in virtio-scsi-pci, in order to assign
an iothread to the device.
Other bus types can be added later.
Signed-off-by: Fam Zheng
---
hw/scsi/virtio-scsi.c | 11 +++
hw/virtio/v
To share with datplane code later.
Signed-off-by: Fam Zheng
---
hw/scsi/virtio-scsi.c | 2 +-
include/hw/virtio/virtio-scsi.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index cb2745d..4a65653 100644
--- a/hw/scsi/v
Later this will be called by dataplane code.
Signed-off-by: Fam Zheng
---
hw/scsi/virtio-scsi.c | 4 ++--
include/hw/virtio/virtio-scsi.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index c5a6b63..8fa9bec 100644
-
To share with dataplane code later.
Signed-off-by: Fam Zheng
---
hw/scsi/virtio-scsi.c | 2 +-
include/hw/virtio/virtio-scsi.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 4a65653..c5a6b63 100644
--- a/hw/scsi/
Hi all,
This series adds "iothread" property to virtio-scsi in a way just similar to
virtio-blk, and turns all scsi devices to run on top of it.
Example:
-object iothread,id=iothread-1 \
-device virtio-scsi-pci,id=virtio-scsi-bus-0,iothread=iothread-1 \
-drive file=guest.img,id=scs
Because virtio-scsi dataplane will also use it.
Signed-off-by: Fam Zheng
---
hw/virtio/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/Makefile.objs b/hw/virtio/Makefile.objs
index ec9e855..a92582f 100644
--- a/hw/virtio/Makefile.objs
+++ b/hw/virtio/M
This is the "common part" to handle one cmd request. Refactor out for
later usage of dataplane iothread code.
Signed-off-by: Fam Zheng
---
hw/scsi/virtio-scsi.c | 107
include/hw/virtio/virtio-scsi.h | 26 ++
2 files changed, 69 inserti
To share with dataplane code.
Signed-off-by: Fam Zheng
---
hw/scsi/virtio-scsi.c | 60 ++---
include/hw/virtio/virtio-scsi.h | 1 +
2 files changed, 34 insertions(+), 27 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index
Hi Kevin,
On Tue, Aug 5, 2014 at 10:47 PM, Kevin Wolf wrote:
> Am 05.08.2014 um 15:48 hat Stefan Hajnoczi geschrieben:
>> On Tue, Aug 05, 2014 at 06:00:22PM +0800, Ming Lei wrote:
>> > On Tue, Aug 5, 2014 at 5:48 PM, Kevin Wolf wrote:
>> > > Am 05.08.2014 um 05:33 hat Ming Lei geschrieben:
>> >
> The output is on qemu's stderr. You are in control of what that stderr
> is.
I don't get why we can configure
-D /path/to/unique/file/name.log
but we also have to redirect stderr (I didn't checked if the daemonize
option was closing it). What's the purpose
On Wed, Aug 6, 2014 at 11:23 AM, Zhang Haoyu wrote:
The output is on qemu's stderr. You are in control of what that stderr is.
>>>
>>> I don't get why we can configure
>>> -D /path/to/unique/file/name.log
>>>
>>> but we also have to redirect stderr (I didn't checked if the daemonize
>>> opti
On Tue, Aug 5, 2014 at 8:30 PM, Eric Blake wrote:
> On 08/04/2014 09:33 PM, Ming Lei wrote:
>> g_slice_new(VirtIOBlockReq), its free pair and access the instance
>
> Took me a while to read this. Maybe:
>
> Calling g_slice_new(VirtIOBlockReq) and its free pair, and accessing the
> instance, are a
On Tue, Aug 5, 2014 at 7:55 PM, Eric Blake wrote:
> On 08/04/2014 09:33 PM, Ming Lei wrote:
>> This patch introduces object allocation pool for speeding up
>> object allocation in fast path.
>>
>> Signed-off-by: Ming Lei
>> ---
>> include/qemu/obj_pool.h | 64
>> ++
Hi,
> > >
> > >> > Yoda conditions lack readability, and QEMU has a
> > >> > strict compiler configuration for checking a common
> > >> > mistake like "if (dev = NULL)". Make it a written rule.
> >
> > >>
> > >> I know this is my suggested text, but now that I'm re-reading it, I'd
> > >> recommen
Replace "init/destroy" with "realize/unrealize" in SCSIDeviceClass,
which has errp as a parameter. So all the implementations now use
error_setg instead of error_report for reporting error.
Also in lsi53c895a, report the error when initializing the if=scsi
devices, before dropping it, because in t
This allows us to pass error information to caller.
Signed-off-by: Fam Zheng
---
hw/block/block.c | 18 +-
hw/block/virtio-blk.c| 7 +++
hw/ide/qdev.c| 11 ---
hw/scsi/scsi-disk.c | 11 ---
include/hw/block/block.h | 6 --
5
v2: Fix two typos in commit message in patch 2.
DeviceClass->init is the old interface, let's convert scsi devices to the new
->realize API.
A user visible change is the error message shown in qemu-iotests reference
output, but I don't know what's the best way to retain it. So please review if
an
On 08/05/2014 08:02 AM, Michael S. Tsirkin wrote:
> On Fri, Aug 01, 2014 at 03:46:08PM +0800, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> $WHATEVER: don't use 'Yoda conditions'
>>
>> 'Yoda conditions' are not part of idiomatic QEMU coding
>> style, so rewrite them in the more usual order
Hi,
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual order.
>
>
> OK but why stop at these files? How about this
> instead?
>
I just search c files by using key words like "NULL ==" etc.
On Tue, 08/05 12:44, Milos Vyletel wrote:
> On Tue, Aug 5, 2014 at 1:27 AM, Fam Zheng wrote:
> > Does putting a monolithicSparse into the OVA work in this case?
>
> It does not. I did not try to import it to OVM but ESXi server
> complained about the format of vmdk in OVA archive (don't have exac
On Tue, Aug 05, 2014 at 05:47:03AM -0600, Eric Blake wrote:
> On 08/04/2014 11:56 PM, Hu Tao wrote:
> > These two are almost the same as memory_region_init_ram() and
> > memory_region_init_ram_ptr() except that they have an extra errp
> > parameter to let callers handle error. The purpose is to fix
Hi,
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual order.
> >
> > v4:
> > - trivial typo for patch 1/8 suggested by Eric, thanks.
>
> Series: Reviewed-by: Eric Blake
>
> Adding qemu-tri
>>> The output is on qemu's stderr. You are in control of what that stderr is.
>>
>> I don't get why we can configure
>> -D /path/to/unique/file/name.log
>>
>> but we also have to redirect stderr (I didn't checked if the daemonize
>> option was closing it). What's the purpose of this logfile optio
Reviewed-by: Wenchao Xia
A future patch will be using a 'name':{dictionary} entry in the
QAPI schema to specify a default value for an optional argument;
but existing use of inline substructs conflicts with that goal.
This patch fixes the testsuite to avoid nested subtypes, by
breaking the nesting into explicit types.
* t
A future patch will be using a 'name':{dictionary} entry in the
QAPI schema to specify a default value for an optional argument;
but existing use of inline substructs conflicts with that goal.
This patch fixes one of only two commands relying on nested
subtypes, by breaking the nesting into an expl
A future patch will be using a 'name':{dictionary} entry in the
QAPI schema to specify a default value for an optional argument;
but existing use of inline substructs conflicts with that goal.
This patch fixes one of only two commands relying on nested
subtypes, by breaking the nesting into an expl
In the testsuite, UserDefTwo and UserDefNested were identical
types other than the member names. Reduce code duplication by
having just one type, and choose names that also favor reuse.
This will also make it easier for a later patch to get rid of
nested inline subtypes in QAPI.
Ensure that 'make
After an in-tree build and run of 'make check-{qapi-schema,unit}',
I noticed some leftover files.
* tests/.gitignore: Ignore more testsuite droppings.
Signed-off-by: Eric Blake
---
tests/.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index
Demonstrate that the qapi generator doesn't deal well with
expressions that aren't up to par. Later patches will improve
the expected results as the generator is made stricter.
* tests/qapi-schema/missing-type.*: New files.
* tests/qapi-schema/double-type.*: Likewise.
* tests/Makefile (check-qapi-
Add a helper function for use in a later patch that will
validate that a 'data':... or 'returns':... member of an
expression evaluates to a valid type.
* scripts/qapi.py (check_type): New function.
(check_exprs): Use it.
Signed-off-by: Eric Blake
---
scripts/qapi.py |
A future patch will be using a 'name':{dictionary} entry in the
QAPI schema to specify a default value for an optional argument;
but existing use of inline substructs conflicts with that goal.
Now that all commands have been fixed to avoid inline substructs,
nuke support for them, and turn it into
Demonstrate that the qapi generator silently parses confusing
types, which may cause other errors later on. Later patches
will update the expected results as the generator is made stricter.
* tests/qapi-schema/data-array-empty.*: New files.
* tests/qapi-schema/data-array-unknown.*: Likewise.
* tes
Now that we know every expression has a known meta-type, we
can add a helper function that retrieves the name of an
arbitrary expression, for use in future error messages.
* scripts/qapi.py (expr_name): New function.
Signed-off-by: Eric Blake
---
scripts/qapi.py | 13 +
1 file chang
The previous patch demonstrated that the generator could get
confused if an expression had conflicting meta-types, and
silently ignored expressions that lacked a known meta-type.
Fix both cases to give a sane error message.
* scripts/qapi.py (check_exprs): Require a valid meta-type for
every expre
This file had a mix of TAB vs. 8-space indentation; given that
it is a Makefile, TAB is more idiomatic even though in these
particular cases the choice of whitespace didn't matter.
* tests/Makefile (check-qapi-schema-y, GENERATED_HEADERS)
(test-qapi-obj-y): Consistent tab indentation.
Signed-off-
According to this email:
https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00708.html
we want to repurpose 'data': { 'name': {dict...} } in qapi files
for future use of designating default values of optional parameters.
But to do that, we must first nuke existing use of that syntax for
decla
Demonstrate that the qapi generator doesn't deal well with enums
that aren't up to par. Later patches will update the expected
results as the generator is made stricter.
* tests/qapi-schema/enum-empty.*: New files.
* tests/qapi-schema/enum-missing-data.*: Likewise.
* tests/qapi-schema/enum-wrong-d
The previous commit demonstrated that the generator choked if an
enum forgot 'data', and silently ignored an enum where 'data'
was the wrong type. Fix both cases to give a sane error message.
* scripts/qapi.py (parse_schema): Avoid bad deref.
(check_exprs): Check for array on enums.
* tests/qapi-
On 08/05/2014 04:38 PM, Eric Blake wrote:
> According to this email:
> https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00708.html
> we want to repurpose 'data': { 'name': {dict...} } in qapi files
> for future use of designating default values of optional parameters.
> But to do that, we m
Reviewed-by: Wenchao Xia
在 2014-8-6 6:38, Eric Blake 写道:
After an in-tree build and run of 'make check-{qapi-schema,unit}',
I noticed some leftover files.
* tests/.gitignore: Ignore more testsuite droppings.
Signed-off-by: Eric Blake
---
tests/.gitignore | 3 +++
1 file changed, 3 inserti
On 08/05/2014 05:08 PM, Peter Maydell wrote:
> On 5 August 2014 23:41, Eric Blake wrote:
>> From: "Edgar E. Iglesias"
>>
>> Reviewed-by: Greg Bellows
>> Signed-off-by: Edgar E. Iglesias
>> Reviewed-by: Alex Bennée
>> Message-id: 1402994746-8328-7-git-send-email-edgar.igles...@gmail.com
>> Sign
Hi Jan,
2014-08-06 1:08 GMT+08:00 Jan Kiszka :
> On 2014-08-05 14:55, Le Tan wrote:
>> Hi,
>> I am now adding features to the VT-d emulation for q35 chipset. I
>> think it is good to know what features q35 chipset supports exactly.
>> However I can't find materials about this. Does anyone know thi
On 5 August 2014 23:41, Eric Blake wrote:
> From: "Edgar E. Iglesias"
>
> Reviewed-by: Greg Bellows
> Signed-off-by: Edgar E. Iglesias
> Reviewed-by: Alex Bennée
> Message-id: 1402994746-8328-7-git-send-email-edgar.igles...@gmail.com
> Signed-off-by: Peter Maydell
Hi Eric; why are you retran
On Tue, Aug 5, 2014 at 7:32 PM, Fabian Aggeler wrote:
> This adds a device model for the PrimeXsys System Controller (SP810)
> which is present in the Versatile Express motherboards. It is
> so far read-only but allows to set the SCCTRL register.
>
> Signed-off-by: Fabian Aggeler
> ---
> default
From: Alex Bennée
According to the ARM ARM we weren't correctly flushing the TLB entries
where bits 63:56 didn't match bit 55 of the virtual address. This
exposed a problem when we switched QEMU's internal TARGET_PAGE_BITS to
12 for aarch64.
Signed-off-by: Alex Bennée
Reviewed-by: Peter Maydell
From: Stefan Weil
Static code analyzers complain about a dubious & operation used for a
boolean value. The code does not test the PSTATE_SP bit as it should.
Cc: Peter Maydell
Signed-off-by: Stefan Weil
Message-id: 1406359601-25583-1-git-send-email...@weilnetz.de
Signed-off-by: Peter Maydell
From: "Edgar E. Iglesias"
Reviewed-by: Greg Bellows
Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alex Bennée
Message-id: 1402994746-8328-7-git-send-email-edgar.igles...@gmail.com
Signed-off-by: Peter Maydell
---
target-arm/cpu.h| 2 +-
target-arm/helper.c | 6 ++
2 files changed, 7
In the testsuite, UserDefTwo and UserDefNested were identical
types other than the member names. Reduce code duplication by
having just one type, and choose names that also favor reuse.
This will also make it easier for a later patch to get rid of
nested inline subtypes in QAPI.
Ensure that 'make
Demonstrate that the qapi generator silently parses confusing
types, which may cause other errors later on. Later patches
will update the expected results as the generator is made stricter.
* tests/qapi-schema/data-array-empty.*: New files.
* tests/qapi-schema/data-array-unknown.*: Likewise.
* tes
From: Alex Bennée
Otherwise we break quickly when we change TARGET_PAGE_SIZE.
Signed-off-by: Alex Bennée
Message-id: 1406733627-24255-2-git-send-email-alex.ben...@linaro.org
Signed-off-by: Peter Maydell
---
target-arm/helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
On Wed, Aug 6, 2014 at 6:48 AM, William Dauchy wrote:
> On Tue, Jul 29, 2014 at 9:51 PM, Eric Blake wrote:
>> The output is on qemu's stderr. You are in control of what that stderr is.
>
> I don't get why we can configure
> -D /path/to/unique/file/name.log
>
> but we also have to redirect stderr
After an in-tree build and run of 'make check-{qapi-schema,unit}',
I noticed some leftover files.
* tests/.gitignore: Ignore more testsuite droppings.
Signed-off-by: Eric Blake
---
tests/.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index
Add a helper function for use in a later patch that will
validate that a 'data':... or 'returns':... member of an
expression evaluates to a valid type.
* scripts/qapi.py (check_type): New function.
(check_exprs): Use it.
Signed-off-by: Eric Blake
---
scripts/qapi.py |
Demonstrate that the qapi generator doesn't deal well with
expressions that aren't up to par. Later patches will improve
the expected results as the generator is made stricter.
* tests/qapi-schema/missing-type.*: New files.
* tests/qapi-schema/double-type.*: Likewise.
* tests/Makefile (check-qapi-
The previous commit demonstrated that the generator choked if an
enum forgot 'data', and silently ignored an enum where 'data'
was the wrong type. Fix both cases to give a sane error message.
* scripts/qapi.py (parse_schema): Avoid bad deref.
(check_exprs): Check for array on enums.
* tests/qapi-
The previous patch demonstrated that the generator could get
confused if an expression had conflicting meta-types, and
silently ignored expressions that lacked a known meta-type.
Fix both cases to give a sane error message.
* scripts/qapi.py (check_exprs): Require a valid meta-type for
every expre
This file had a mix of TAB vs. 8-space indentation; given that
it is a Makefile, TAB is more idiomatic even though in these
particular cases the choice of whitespace didn't matter.
* tests/Makefile (check-qapi-schema-y, GENERATED_HEADERS)
(test-qapi-obj-y): Consistent tab indentation.
Signed-off-
Demonstrate that the qapi generator doesn't deal well with enums
that aren't up to par. Later patches will update the expected
results as the generator is made stricter.
* tests/qapi-schema/enum-empty.*: New files.
* tests/qapi-schema/enum-missing-data.*: Likewise.
* tests/qapi-schema/enum-wrong-d
Now that we know every expression has a known meta-type, we
can add a helper function that retrieves the name of an
arbitrary expression, for use in future error messages.
* scripts/qapi.py (expr_name): New function.
Signed-off-by: Eric Blake
---
scripts/qapi.py | 13 +
1 file chang
According to this email:
https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00708.html
we want to repurpose 'data': { 'name': {dict...} } in qapi files
for future use of designating default values of optional parameters.
But to do that, we must first nuke existing use of that syntax for
decla
On Tue, Aug 5, 2014 at 5:05 PM, Hu Tao wrote:
> On Tue, Aug 05, 2014 at 04:42:37PM +1000, Peter Crosthwaite wrote:
>> On Tue, Aug 5, 2014 at 3:56 PM, Hu Tao wrote:
>> > Signed-off-by: Hu Tao
>> > ---
>> > hw/alpha/typhoon.c | 2 +-
>> > hw/arm/armv7m.c
On 08/05/2014 04:30 AM, Kevin Wolf wrote:
Am 01.08.2014 um 22:10 hat John Snow geschrieben:
On 06/12/2014 05:03 AM, Markus Armbruster wrote:
-drive mixes up configuration of backend and frontend (a.k.a. device
model), as follows:
1. It always defines a backend. "info block" shows them.
As a workaround use the 'host' cpu type so the proper bits are enabled:
-cpu host,+xsave
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1285708
Title:
FreeBSD Guest crash on boot due to xsave instr
On Tue, Jul 29, 2014 at 9:51 PM, Eric Blake wrote:
> The output is on qemu's stderr. You are in control of what that stderr is.
I don't get why we can configure
-D /path/to/unique/file/name.log
but we also have to redirect stderr (I didn't checked if the daemonize
option was closing it). What's
The combination of a newer kernel and newer qemu make qemu work with
-smp 2 . Rather than go figure out what got fixed let's just be happy
it did.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is su
Hi,
I'm running qemu 1.4.2 (soon planning on moving to 1.7). I'm running two
instances of qemu with a virtio-serial channel each, exposed on the host via
unix stream sockets.
I've got an app that tries to connect() to both of them in turn. The connect()
to the first socket fails with EAGAIN
Commit 40509f7f added a test to avoid updating KVM MSI routes when the
MSIMessage is unchanged and f4d45d47 switched to relying on this
rather than doing our own comparison. Our cached msg is effectively
unused now. Remove it.
Signed-off-by: Alex Williamson
---
hw/misc/vfio.c |8 ++--
If we make use of OVMF for the BIOS then we can use GPUs without VGA
space access, but we still need this quirk. Disassociate it from the
x-vga option and enable it on all NVIDIA VGA display class devices.
Signed-off-by: Alex Williamson
---
hw/misc/vfio.c |8 ++--
1 file changed, 6 ins
1 - 100 of 220 matches
Mail list logo
