Re: [Qemu-devel] [PATCH v5 0/8] e1000: Various fixes and registers' implementation

2015-11-11 Thread Leonid Bloch
On Wed, Nov 11, 2015 at 5:22 AM, Jason Wang wrote: > > > On 11/10/2015 09:19 PM, Leonid Bloch wrote: >> On Tue, Nov 10, 2015 at 3:01 PM, Jason Wang wrote: >>> >>> On 11/10/2015 07:39 PM, Leonid Bloch wrote: On Tue, Nov 10, 2015 at 8:21 AM, Jason Wang wrote: > On 11/09/2015 10:59 PM, Leo

Re: [Qemu-devel] [PATCH 00/13] Mac OS 9 compatibility improvements (upstream rework)

2015-11-11 Thread Mark Cave-Ayland
On 11/11/15 06:52, David Gibson wrote: > On Wed, Nov 11, 2015 at 06:29:09AM +, Mark Cave-Ayland wrote: >> On 11/11/15 02:11, David Gibson wrote: >> >>> On Wed, Nov 04, 2015 at 11:32:02PM +, Mark Cave-Ayland wrote: On 04/11/15 03:44, David Gibson wrote: > On Fri, Oct 30, 2015

Re: [Qemu-devel] [PATCH v3] seccomp: add cacheflush to whitelist

2015-11-11 Thread Eduardo Otubo
On Mon, Nov 09, 2015 at 04=47=53PM -0500, Andrew Jones wrote: > On Mon, Nov 02, 2015 at 11:53:26PM +0100, Andrew Jones wrote: > > cacheflush is an arm-specific syscall that qemu built for arm > > uses. Add it to the whitelist, but only if we're linking with > > a recent enough libseccomp. > > > >

Re: [Qemu-devel] [PULL 04/05] seccomp: add setuid, setgid, chroot and setgroups to whitelist

2015-11-11 Thread Eduardo Otubo
On Mon, Nov 02, 2015 at 08=51=26AM +0100, Paolo Bonzini wrote: > > > On 30/10/2015 14:44, Eduardo Otubo wrote: > > From: Namsun Ch'o > > > > The seccomp sandbox doesn't whitelist setuid, setgid, or setgroups, which > > are > > needed for -runas to work. It also doesn't whitelist chroot, which

Re: [Qemu-devel] [PATCH v2 0/8] Add system_powerdown support on ARM for ACPI and DT

2015-11-11 Thread Peter Maydell
On 11 November 2015 at 01:29, Shannon Zhao wrote: > On 2015/11/11 4:56, Wei Huang wrote: >> I found this was caused by the change of "_HID" name for GPIO device. It >> was changed from "LNRO0009" (v1) to "ARMH0061" (v2), which doesn't match >> with my stock guest kernel PL061 driver. After changin

[Qemu-devel] ARM NEON function call tracing

2015-11-11 Thread Junaid Shuja
Hi, I am working on ARM/NEON instructions. I want to know which neon helper function corresponds to the neon instructions. As a test case, I have a source file with loads of vadd.i32 instructions. I want to trace which neon helper functions is called. I used a very crude approach: printf in neon_ad

Re: [Qemu-devel] [PATCH v2 7/8] hw/arm/virt: Add QEMU powerdown notifier and hook it to GPIO Pin 3

2015-11-11 Thread Peter Maydell
On 11 November 2015 at 06:57, Wei Huang wrote: > > > On 10/29/2015 09:27 AM, Shannon Zhao wrote: >> Currently mach-virt model doesn't support powerdown request. Guest VM >> doesn't react to system_powerdown from monitor console (or QMP) because >> there is no communication mechanism for such reque

Re: [Qemu-devel] [PATCH] include/hw: field 'offset' in struct Property should be ptrdiff_t as int causes overflow

2015-11-11 Thread Markus Armbruster
Peter Maydell writes: > On 25 August 2015 at 15:17, Markus Armbruster wrote: >> Stumbled over this while throwing away old mail. Andreas, what do you >> think? > > Seems right to me -- I suspect the original properties code was > written with the assumption that the property field would be > in

Re: [Qemu-devel] ARM NEON function call tracing

2015-11-11 Thread Peter Maydell
On 11 November 2015 at 07:51, Junaid Shuja wrote: > Hi, > I am working on ARM/NEON instructions. I want to know which neon helper > function corresponds to the neon instructions. As a test case, I have a > source file with loads of vadd.i32 instructions. I want to trace which neon > helper functio

Re: [Qemu-devel] [PATCH v2 0/8] Add system_powerdown support on ARM for ACPI and DT

2015-11-11 Thread Shannon Zhao
On 2015/11/11 16:36, Peter Maydell wrote: > On 11 November 2015 at 01:29, Shannon Zhao wrote: >> On 2015/11/11 4:56, Wei Huang wrote: >>> I found this was caused by the change of "_HID" name for GPIO device. It >>> was changed from "LNRO0009" (v1) to "ARMH0061" (v2), which doesn't match >>> with

Re: [Qemu-devel] [POC]colo-proxy in qemu

2015-11-11 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 11/10/2015 05:41 PM, Dr. David Alan Gilbert wrote: > > * Jason Wang (jasow...@redhat.com) wrote: > >> > >> On 11/10/2015 01:26 PM, Tkid wrote: > >>> Hi,all > >>> > >>> We are planning to reimplement colo proxy in userspace (Here is in > >>> qemu)

Re: [Qemu-devel] [PATCH v2 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

2015-11-11 Thread Paolo Bonzini
On 11/11/2015 10:09, Andrey Smetanin wrote: >> >> I would prefer to put this in kvm_arch_init_vcpu, if possible. >> > Ok. I think the kvm_arch_init_vcpu() is called after migration restores > cpu->env->msr_hv_synic_* values, so unconditional initialization of > cpu->env->msr_hv_synic_* values can

Re: [Qemu-devel] [PULL 0/2] VFIO updates 2015-11-10

2015-11-11 Thread Peter Maydell
On 10 November 2015 at 20:08, Alex Williamson wrote: > The following changes since commit a1a88589dc982f9f8b6c717c2ac98dd71dd4353d: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20151110' into staging (2015-11-10 > 13:55:07 +) > > are available in the git reposi

Re: [Qemu-devel] [PATCH v2 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

2015-11-11 Thread Andrey Smetanin
On 11/11/2015 12:17 PM, Paolo Bonzini wrote: On 11/11/2015 10:09, Andrey Smetanin wrote: I would prefer to put this in kvm_arch_init_vcpu, if possible. Ok. I think the kvm_arch_init_vcpu() is called after migration restores cpu->env->msr_hv_synic_* values, so unconditional initialization

Re: [Qemu-devel] [PATCH v2 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

2015-11-11 Thread Andrey Smetanin
On 11/10/2015 04:14 PM, Paolo Bonzini wrote: On 10/11/2015 13:52, Andrey Smetanin wrote: This patch does Hyper-V Synthetic interrupt controller(Hyper-V SynIC) MSR's support and migration. Hyper-V SynIC is enabled by cpu's 'hv-synic' option. This patch does not allow cpu creation if 'hv-syni

Re: [Qemu-devel] SMM error in 2.4 changelog

2015-11-11 Thread Paolo Bonzini
On 10/11/2015 21:32, William Dauchy wrote: > On Tue, Nov 3, 2015 at 10:01 AM, Paolo Bonzini wrote: >> Yes, this is correct. Thanks! > > The mistake seems to be still present in changelog. Fixed now, thanks for reminding. Paolo

Re: [Qemu-devel] [PATCH v10 23/30] qapi: Check for qapi collisions of flat union branches

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > On 11/09/2015 10:16 PM, Eric Blake wrote: > >>> We have tests covering attempts to do the former >>> (struct-cycle-direct.json, struct-cycle-indirect.json). As far as I can >>> see, we don't have tests covering the latter. Do we catch it? >> >> Yes, at least by virtue of t

Re: [Qemu-devel] [PATCH v2 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

2015-11-11 Thread Paolo Bonzini
On 11/11/2015 10:25, Andrey Smetanin wrote: > In this case I'll remove migration of msr_hv_synic_version and make > first time initialization inside kvm_arch_init_vcpu() - inside section > where SynIC availability cpuid bit is set. Thanks! Paolo

[Qemu-devel] [PATCH v3 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

2015-11-11 Thread Andrey Smetanin
This patch does Hyper-V Synthetic interrupt controller(Hyper-V SynIC) MSR's support and migration. Hyper-V SynIC is enabled by cpu's 'hv-synic' option. This patch does not allow cpu creation if 'hv-synic' option specified but kernel doesn't support Hyper-V SynIC. Changes v3: * removed 'msr_hv_syn

Re: [Qemu-devel] [PATCH v10 29/30] cpu: Convert CpuInfo into flat union

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > On 11/09/2015 08:22 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> When qapi type CpuInfo was originally created for 0.14, we had >>> no notion of a flat union, and instead just listed a bunch of >>> optional fields with documentation about the mutually-exclusive

Re: [Qemu-devel] [PATCH qemu v4] monitor/target-ppc: Define target_get_monitor_def

2015-11-11 Thread Paolo Bonzini
On 11/11/2015 03:27, David Gibson wrote: > Meaning one which adds the hook to the monitor, and another which > implements it for ppc? Maybe. > > I'd like to take this, but I'm not sure whether it's reasonable for > the small generic monitor change to go through the ppc tree. Peter, > Paolo, op

[Qemu-devel] [PATCH v13 01/13] vfio: extract vfio_get_hot_reset_info as a single function

2015-11-11 Thread Cao jin
From: Chen Fan the function is used to get affected devices by bus reset. so here extract it, and can used for aer soon. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 66 +++ 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v13 02/13] vfio: squeeze out vfio_pci_do_hot_reset for support bus reset

2015-11-11 Thread Cao jin
From: Chen Fan squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 75 +++ 1 file changed, 44 insertions(+), 31 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c ind

[Qemu-devel] [PATCH v13 00/13] vfio-pci: pass the aer error to guest

2015-11-11 Thread Cao jin
From: Chen Fan For now, for vfio pci passthough devices when qemu receives an error from host aer report, currentlly just terminate the guest, but usually user want to know what error occurred but stopping the guest, so this patches add aer capability support for vfio device, and pass the error t

[Qemu-devel] [PATCH v13 09/13] add check reset mechanism when hotplug vfio device

2015-11-11 Thread Cao jin
From: Chen Fan Since we support multi-function hotplug. the function 0 indicate the closure of the slot, so we have the chance to do the check. Signed-off-by: Chen Fan --- hw/pci/pci.c | 29 + hw/vfio/pci.c| 19 +++ hw/vfio/pc

[Qemu-devel] [PATCH v13 03/13] pcie: modify the capability size assert

2015-11-11 Thread Cao jin
From: Chen Fan Device's Offset and size can reach PCIE_CONFIG_SPACE_SIZE, fix the corresponding assert. Signed-off-by: Chen Fan Reviewed-by: Marcel Apfelbaum --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 0eab29d..8f

[Qemu-devel] [PATCH v13 05/13] vfio: add pcie extanded capability support

2015-11-11 Thread Cao jin
From: Chen Fan For vfio pcie device, we could expose the extended capability on PCIE bus. in order to avoid config space broken, we introduce a copy config for parsing extended caps. and rebuild the pcie extended config space. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 70

[Qemu-devel] [PATCH v13 04/13] vfio: make the 4 bytes aligned for capability size

2015-11-11 Thread Cao jin
From: Chen Fan this function search the capability from the end, the last size should 0x100 - pos, not 0xff - pos. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index f333dfc..e305cda 100644 --- a/h

[Qemu-devel] [PATCH v13 06/13] aer: impove pcie_aer_init to support vfio device

2015-11-11 Thread Cao jin
From: Chen Fan pcie_aer_init was used to emulate an aer capability for pcie device, but for vfio device, the aer config space size is mutable and is not always equal to PCI_ERR_SIZEOF(0x48). it depends on where the TLP Prefix register required, so here we add a size argument. Signed-off-by: Chen

[Qemu-devel] [PATCH v13 12/13] vfio-pci: pass the aer error to guest

2015-11-11 Thread Cao jin
From: Chen Fan when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting invoked. this patch is to pass the error to guest and have the guest driver recover from the

[Qemu-devel] [PATCH v13 08/13] vfio: add check host bus reset is support or not

2015-11-11 Thread Cao jin
From: Chen Fan when init vfio devices done, we should test all the devices supported aer whether conflict with others. For each one, get the hot reset info for the affected device list. For each affected device, all should attach to the VM and on/below the same bus. also, we should test all of t

[Qemu-devel] [PATCH v13 07/13] vfio: add aer support for vfio device

2015-11-11 Thread Cao jin
From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 82 --- hw/vfio/pci.h | 3 +++ 2 fil

[Qemu-devel] [PATCH v13 13/13] vfio: add 'aer' property to expose aercap

2015-11-11 Thread Cao jin
From: Chen Fan add 'aer' property to let user able to decide whether expose the aer capability. by default we should disable aer feature, because it needs configuration restrictions. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio/pci.c b

[Qemu-devel] [PATCH v13 11/13] pcie_aer: expose pcie_aer_msg() interface

2015-11-11 Thread Cao jin
From: Chen Fan For vfio device, we need to propagate the aer error to Guest OS. we use the pcie_aer_msg() to send aer error to guest. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 2 +- include/hw/pci/pcie_aer.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PATCH v13 10/13] pci: add pci device pre-post reset callbacks for host bus reset

2015-11-11 Thread Cao jin
From: Chen Fan Particularly, For vfio devices, Once need to recovery devices by bus reset such as AER, we always need to reset the host bus to recovery the devices under the bus, so we need to add pci device callbacks to specify to do host bus reset. Signed-off-by: Chen Fan --- hw/pci/pci.c

Re: [Qemu-devel] [PULL v3 00/18] Record/replay core for 2.5-rc1

2015-11-11 Thread Markus Armbruster
Peter Maydell writes: > On 6 November 2015 at 09:37, Paolo Bonzini wrote: >> The following changes since commit 6c5f30cad290c745f910481d0e890b3f4fad1f00: >> >> Merge remote-tracking branch >> 'remotes/juanquintela/tags/migration/20151104' into staging >> (2015-11-05 10:10:57 +) >> >> are a

Re: [Qemu-devel] [PATCH v5 0/8] e1000: Various fixes and registers' implementation

2015-11-11 Thread Jason Wang
On 11/11/2015 04:06 PM, Leonid Bloch wrote: > On Wed, Nov 11, 2015 at 5:22 AM, Jason Wang wrote: >> > >> > >> > On 11/10/2015 09:19 PM, Leonid Bloch wrote: >>> >> On Tue, Nov 10, 2015 at 3:01 PM, Jason Wang wrote: >>> >>> On 11/10/2015 07:39 PM, Leonid Bloch wrote: > On Tue,

Re: [Qemu-devel] [PATCH V3 3/6] KVM: add support for any length io eventfd

2015-11-11 Thread Paolo Bonzini
On 06/11/2015 09:02, Jason Wang wrote: > Signed-off-by: Jason Wang > --- > include/sysemu/kvm.h | 8 > kvm-all.c| 4 > kvm-stub.c | 1 + > 3 files changed, 13 insertions(+) > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 4ac6176..b31f325

Re: [Qemu-devel] ARM NEON function call tracing

2015-11-11 Thread Alex Bennée
Peter Maydell writes: > On 11 November 2015 at 07:51, Junaid Shuja > wrote: >> Hi, >> I am working on ARM/NEON instructions. I want to know which neon helper >> function corresponds to the neon instructions. As a test case, I have a >> source file with loads of vadd.i32 instructions. I want to

Re: [Qemu-devel] [PULL 33/44] block: New option to define the intervals for collecting I/O statistics

2015-11-11 Thread Alberto Garcia
On Tue 10 Nov 2015 06:23:36 PM CET, Eric Blake wrote: >> +# @stats-intervals: #optional colon-separated list of intervals for >> +# collecting I/O statistics, in seconds (default: none) >> +# (Since 2.5) > > Eww. Sorry for not noticing this sooner, but can we p

Re: [Qemu-devel] [PULL 0/4] ppc-next queue 20151111

2015-11-11 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-next-2015 > > for you to fetch changes up to b41d320fef705289d2b73f4949731eb2e189161d: > > spapr: Handle failure of KVM_PPC_ALLOCATE_HTAB ioctl (2015-11-11 13:29:04 > +1100) > > A hand

Re: [Qemu-devel] [PATCH v3 2/5] target-i386/kvm: Hyper-V SynIC MSR's support

2015-11-11 Thread Paolo Bonzini
On 11/11/2015 11:18, Andrey Smetanin wrote: > This patch does Hyper-V Synthetic interrupt > controller(Hyper-V SynIC) MSR's support and > migration. Hyper-V SynIC is enabled by cpu's > 'hv-synic' option. > > This patch does not allow cpu creation if > 'hv-synic' option specified but kernel > doe

Re: [Qemu-devel] [PULL v2 00/15] Tracing patches

2015-11-11 Thread Peter Maydell
On 11 November 2015 at 07:34, Stefan Hajnoczi wrote: > v2: > * Fixed missing log.py file when merging "trace: convert stderr backend to > log" [Peter] > > The following changes since commit a77067f6ac9b17beefea506ce5f514072fe3fcf4: > > Merge remote-tracking branch 'remotes/juanquintela/tags/mi

Re: [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous return statements

2015-11-11 Thread Cornelia Huck
On Tue, 10 Nov 2015 21:16:10 +0100 Thomas Huth wrote: > The "return;" statements at the end of functions do not make > much sense, so let's remove them. > > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Alexander Graf > Cc: Richard Henderson > Signed-off-by: Thomas Huth > --- > hw/s3

Re: [Qemu-devel] [PULL v2 for-2.5] Block pull request

2015-11-11 Thread Peter Maydell
On 10 November 2015 at 15:06, Stefan Hajnoczi wrote: > v2: > * Rebase onto Kevin's block pull request > > The following changes since commit c400bddb916268394e352f82809eb4728424a5b1: > > Merge remote-tracking branch 'mreitz/tags/pull-block-for-kevin-2015-11-10' > into queue-block (2015-11-10 1

Re: [Qemu-devel] [PATCH for-2.5 00/15] s390x patches for 2.5

2015-11-11 Thread Christian Borntraeger
Am 09.11.2015 um 16:56 schrieb Cornelia Huck: > Hopefully last big batch of s390x patches, including: > - bugfixes for LE host and for pci translation > - MAINTAINERS update > - hugetlbfs enablement (kernel patches pending) > - boot from El Torito iso images on virtio-blk > (boot from scsi pendin

Re: [Qemu-devel] [kvm-unit-tests PATCHv5 3/3] arm: pmu: Add CPI checking

2015-11-11 Thread Christopher Covington
On 11/10/2015 09:05 PM, Andrew Jones wrote: > On Mon, Nov 02, 2015 at 09:58:14AM -0600, Andrew Jones wrote: >> On Fri, Oct 30, 2015 at 03:32:43PM -0400, Christopher Covington wrote: >>> Hi Drew, >>> >>> On 10/30/2015 09:00 AM, Andrew Jones wrote: On Wed, Oct 28, 2015 at 03:12:55PM -0400, Chris

[Qemu-devel] [PATCH] block: make 'stats-intervals' a list of integers

2015-11-11 Thread Alberto Garcia
This is the natural JSON representation and prevents us from having to decode the list manually. Signed-off-by: Alberto Garcia --- blockdev.c | 64 ++ qapi/block-core.json | 7 +++--- tests/qemu-iotests/136 | 2 +- 3 files changed,

[Qemu-devel] [PATCH v4 3/5] vhost: introduce vhost_set/get_protocol_features callbacks

2015-11-11 Thread Yuanhan Liu
Signed-off-by: Yuanhan Liu --- hw/virtio/vhost-user.c| 7 +++ include/hw/virtio/vhost-backend.h | 6 ++ 2 files changed, 13 insertions(+) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 4766f98..2d8bdbd 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vh

[Qemu-devel] [PATCH v4 2/5] vhost: reset vhost net when virtio_net_reset happens

2015-11-11 Thread Yuanhan Liu
When a virtio net driver is unloaded (unbind), virtio_net_reset happens. For vhost net, we should also send a message (RESET_OWNER) to the backend to do some proper reset settings. Signed-off-by: Yuanhan Liu --- hw/net/vhost_net.c | 20 ++-- hw/net/virtio-net.c | 14

[Qemu-devel] [PATCH v4 1/5] vhost: rename RESET_DEVICE backto RESET_OWNER

2015-11-11 Thread Yuanhan Liu
This patch basically reverts commit d1f8b30e. It turned out that it breaks stuff, so revert it: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg00949.html CC: "Michael S. Tsirkin" Reported-by: Paolo Bonzini Signed-off-by: Yuanhan Liu --- docs/specs/vhost-user.txt | 4 ++-- hw

[Qemu-devel] [PATCH v4 0/5] handle vhost reset/start/stop correctly

2015-11-11 Thread Yuanhan Liu
Patch 1 rename RESET_DEVICE back to RESET_OWNER Patch 2 introduced a new function: vhost_net_reset(), which is invoked when reset happens, say, driver is unloaded (unbinded). Michael suggested to do that only when MQ is not negotiated. However, reset happens no matter MQ

[Qemu-devel] [PATCH v4 4/5] vhost: send SET_PROTOCOL_FEATURES at start

2015-11-11 Thread Yuanhan Liu
So that the backend can restore the protocol features after a reset. Signed-off-by: Yuanhan Liu --- hw/virtio/vhost.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index de29968..be48511 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@

[Qemu-devel] [PATCH v4 5/5] vhost: send SET_VRING_ENABLE at start/stop

2015-11-11 Thread Yuanhan Liu
Send SET_VRING_ENABLE at start/stop, to give the backend an explicit sign of our state. Signed-off-by: Yuanhan Liu --- hw/virtio/vhost.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index be48511..0e956b5 100644 --- a/hw/virtio/vhost.c +++ b/

Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

2015-11-11 Thread Andreas Färber
Am 11.11.2015 um 07:51 schrieb Eric Blake: > A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in > since c6bd8c706. Nuke them. > > Signed-off-by: Eric Blake [...] > diff --git a/qom/object.c b/qom/object.c > index fc6e161..c0decb6 100644 > --- a/qom/object.c > +++ b/qom/object.c > @

Re: [Qemu-devel] [PATCH 3/4] hw/s390x: Remove superfluous return statements

2015-11-11 Thread Thomas Huth
On 11/11/15 12:25, Cornelia Huck wrote: > On Tue, 10 Nov 2015 21:16:10 +0100 > Thomas Huth wrote: > >> The "return;" statements at the end of functions do not make >> much sense, so let's remove them. >> >> Cc: Cornelia Huck >> Cc: Christian Borntraeger >> Cc: Alexander Graf >> Cc: Richard Hen

Re: [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-11 Thread Andreas Färber
Am 11.11.2015 um 07:51 schrieb Eric Blake: > When munging enum values, the fact that we were passing the entire > prefix + value through camel_to_upper() meant that enum values > spelled with CamelCase could be turned into CAMEL_CASE. However, > this provides a potential collision (both OneTwo and

Re: [Qemu-devel] [PATCH v11 11/28] qapi: Check for qapi collisions of flat union branches

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > Right now, our ad hoc parser ensures that we cannot have a > flat union that introduces any qapi member names that would > conflict with the non-variant qapi members already present > from the union's base type (see flat-union-clash-member.json). > We want QAPISchemaObjectTyp

[Qemu-devel] [PATCH v6 0/9] e1000: Various fixes and registers' implementation

2015-11-11 Thread Leonid Bloch
This series fixes issues with packet/octet counting in e1000's Statistic registers, fixes a bug in the packet address filtering procedure, and implements many MAC registers that were absent before, some Statistic counters among them. Besides this, the series introduces a parameter which, if set to

[Qemu-devel] [PATCH v6 3/9] e1000: Introduced an array to control the access to the MAC registers

2015-11-11 Thread Leonid Bloch
The array of uint8_t's which is introduced here, contains access metadata about the MAC registers: if a register is accessible, but partly implemented, or if a register requires a certain compatibility flag in order to be accessed. Currently, 6 hypothetical flags are supported (3 exist for e1000 so

[Qemu-devel] [PATCH v6 7/9] e1000: Fixing the packet address filtering procedure

2015-11-11 Thread Leonid Bloch
Previously, if promiscuous unicast was enabled, a packet was received straight away, even if it was a multicast or a broadcast packet. This patch fixes that behavior, while making the filtering procedure a bit more human-readable. Signed-off-by: Leonid Bloch Signed-off-by: Dmitry Fleytman --- h

[Qemu-devel] [PATCH v6 2/9] e1000: Add support for migrating the entire MAC registers' array

2015-11-11 Thread Leonid Bloch
This patch makes the migration of the entire array of MAC registers possible during live migration. The entire array is just 128 KB long, so practically no penalty should be felt when transmitting it, additionally to the previously transmitted individual registers. The advantage here is eliminating

[Qemu-devel] [PATCH v6 8/9] e1000: Implementing various counters

2015-11-11 Thread Leonid Bloch
This implements the following Statistic registers (various counters) according to Intel's specs: TSCTC GOTCL GOTCH GORCL GORCH MPRC BPRC RUCROC BPTC MPTC PTC... PRC... PLEASE NOTE: these registers will not be active, nor will migrate, until a compatibility flag will be set (in th

[Qemu-devel] [PATCH v6 4/9] e1000: Trivial implementation of various MAC registers

2015-11-11 Thread Leonid Bloch
These registers appear in Intel's specs, but were not implemented. These registers are now implemented trivially, i.e. they are initiated with zero values, and if they are RW, they can be written or read by the driver, or read only if they are R (essentially retaining their zero values). For these

Re: [Qemu-devel] [PATCH v11 13/28] qapi: Hoist tag collision check to Variants.check()

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > Checking that a given QAPISchemaObjectTypeVariant.name is a > member of the corresponding QAPISchemaEnumType of the owning > QAPISchemaObjectTypeVariants.tag_member ensures that there are > no collisions in the generated C union for those tag values > (since the enum itself s

[Qemu-devel] [PATCH v6 1/9] e1000: Cosmetic and alignment fixes

2015-11-11 Thread Leonid Bloch
This fixes some alignment and cosmetic issues. The changes are made in order that the following patches in this series will look like integral parts of the code surrounding them, while conforming to the coding style. Although some changes in unrelated areas are also made. Signed-off-by: Leonid Blo

[Qemu-devel] [PATCH v6 5/9] e1000: Fixing the received/transmitted packets' counters

2015-11-11 Thread Leonid Bloch
According to Intel's specs, these counters (as the other Statistic registers) stick at 0x when this maximal value is reached. Previously, they would reset after the max. value. Signed-off-by: Leonid Bloch Signed-off-by: Dmitry Fleytman --- hw/net/e1000.c | 16 1 file ch

[Qemu-devel] [PATCH v6 6/9] e1000: Fixing the received/transmitted octets' counters

2015-11-11 Thread Leonid Bloch
Previously, these 64-bit registers did not stick at their maximal values when (and if) they reached them, as they should do, according to the specs. This patch introduces a function that takes care of such registers, avoiding code duplication, making the relevant parts more compatible with the QEM

[Qemu-devel] [PATCH v6 9/9] e1000: Introducing backward compatibility command line parameter

2015-11-11 Thread Leonid Bloch
This follows the previous patches, where support for migrating the entire MAC registers' array, and some new MAC registers were introduced. This patch introduces the e1000-specific boolean parameter "extra_mac_registers", which is on by default. Setting it to off will enable migration to older ver

Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-11 Thread Michael Roth
Quoting Paolo Bonzini (2015-11-10 11:59:18) > > > On 10/11/2015 16:40, Michael Roth wrote: > > > > I hit an issue testing this though, this does fix the append > > case, but a+, ab+, a+b all imply append+read, while > > FILE_APPEND_DATA only grants append access. > > > > FILE_APPEND_DATA|GENERI

[Qemu-devel] [PATCH 0/3] Postcopy minor fixes

2015-11-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, These are three small fixes for the postcopy code; the first two coming from Bharata's testing on Power, and the last one being a text fixup that Eric asked for. The first only affects setups with another iterable device (e.g. Power's htab and block migration

[Qemu-devel] [PATCH 3/3] migrate-start-postcopy: Improve text

2015-11-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Improve the text in both the qapi-schema and hmp help to point out you need to set the postcopy-ram capability prior to issuing migrate-start-postcopy. Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 4 +++- qapi-schema.json | 3 ++- 2 files changed,

[Qemu-devel] [PATCH 1/3] Finish non-postcopiable iterative devices before package

2015-11-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Where we have iterable, but non-postcopiable devices (e.g. htab or block migration), complete them before forming the 'package' but with the CPUs stopped. This stops them filling up the package. Signed-off-by: Dr. David Alan Gilbert --- include/sysemu/sysemu.h |

[Qemu-devel] [PATCH 2/3] Postcopy: Fix TP!=HP zero case

2015-11-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Where the target page size is different from the host page we special case it, but I messed up on the zero case check. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/

Re: [Qemu-devel] [PATCH v11 17/28] cpu: Convert CpuInfo into flat union

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > The CpuInfo struct is used only by the 'query-cpus' output > command, so we are free to modify it by adding fields (clients > are already supposed to ignore unknown output fields), or by > changing optional members to mandatory, while still keeping > QMP wire compatibility wi

Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add a subsection for migrating vcpu's TSC rate

2015-11-11 Thread Eduardo Habkost
On Mon, Nov 02, 2015 at 05:26:41PM +0800, Haozhong Zhang wrote: > A new subsection 'vmstate_tsc_khz' is added to migrate vcpu's TSC > rate. For the backwards compatibility, this subsection is not migrated > on pc-*-2.4 and older machine types. > > Signed-off-by: Haozhong Zhang > --- > hw/i386/pc

Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in > since c6bd8c706. Nuke them. Doesn't really belong to this series, but that's okay. > Signed-off-by: Eric Blake > > --- > v11: new patch > --- > block.c | 3 +-- > docs/writing-qmp-c

Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage

2015-11-11 Thread Andreas Färber
Am 11.11.2015 um 15:21 schrieb Markus Armbruster: > Eric Blake writes: > >> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in >> since c6bd8c706. Nuke them. > > Doesn't really belong to this series, but that's okay. It seemed to avoid a GENERIC_ERROR -> GENERICERROR change in th

[Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Victor Kaplansky
Unlike the kernel, vhost-user application accesses log table by mmaping it to its user space. This change adds two new fields to VhostUserMsg payload: mmap_size, and mmap_offset and make QEMU to pass the to vhost-user application in VHOST_USER_SET_LOG_BASE request. Signed-off-by: Victor Kaplansky

Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add a subsection for migrating vcpu's TSC rate

2015-11-11 Thread Haozhong Zhang
On 11/11/15 12:16, Eduardo Habkost wrote: > On Mon, Nov 02, 2015 at 05:26:41PM +0800, Haozhong Zhang wrote: > > A new subsection 'vmstate_tsc_khz' is added to migrate vcpu's TSC > > rate. For the backwards compatibility, this subsection is not migrated > > on pc-*-2.4 and older machine types. > >

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Marc-André Lureau
Hi - Original Message - > Unlike the kernel, vhost-user application accesses log table by > mmaping it to its user space. This change adds two new fields to > VhostUserMsg payload: mmap_size, and mmap_offset and make QEMU to > pass the to vhost-user application in VHOST_USER_SET_LOG_BASE >

Re: [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > When munging enum values, the fact that we were passing the entire > prefix + value through camel_to_upper() meant that enum values > spelled with CamelCase could be turned into CAMEL_CASE. However, > this provides a potential collision (both OneTwo and One-Two would > munge

Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-11 Thread Paolo Bonzini
On 11/11/2015 15:02, Michael Roth wrote: >> GENERIC_READ for files >> = FILE_READ_DATA >> + FILE_READ_ATTRIBUTES >> + FILE_READ_EA >> + SYNCHRONIZE >> + STANDARD_RIGHTS_READ (which is READ_CONTROL) >> >> GENERIC_WRITE for files >> = FILE_APPEND_DATA

Re: [Qemu-devel] [PATCH v11 20/28] qapi: Forbid case-insensitive clashes

2015-11-11 Thread Markus Armbruster
Eric Blake writes: > In general, designing user interfaces that rely on case > distinction is poor practice. Another benefit of enforcing > a restriction against case-insensitive clashes is that we > no longer have to worry about the situation of enum values > that could be distinguished by case

Re: [Qemu-devel] [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

2015-11-11 Thread Eduardo Habkost
On Tue, Nov 10, 2015 at 09:08:58AM +0800, Haozhong Zhang wrote: > On 11/09/15 14:01, Eduardo Habkost wrote: > > On Mon, Nov 09, 2015 at 08:33:55AM +0800, haozhong.zh...@intel.com wrote: > > > On 11/06/15 13:12, Eduardo Habkost wrote: > > > > On Fri, Nov 06, 2015 at 10:32:24AM +0800, haozhong.zh...@

Re: [Qemu-devel] [PATCH 3/3] migrate-start-postcopy: Improve text

2015-11-11 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Improve the text in both the qapi-schema and hmp help to point out > you need to set the postcopy-ram capability prior to issuing > migrate-start-postcopy. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quin

Re: [Qemu-devel] [PATCH 2/3] Postcopy: Fix TP!=HP zero case

2015-11-11 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Where the target page size is different from the host page > we special case it, but I messed up on the zero case check. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela And people wonder why multip

Re: [Qemu-devel] [PATCH 1/3] Finish non-postcopiable iterative devices before package

2015-11-11 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Where we have iterable, but non-postcopiable devices (e.g. htab > or block migration), complete them before forming the 'package' > but with the CPUs stopped. This stops them filling up the package. > > Signed-off-by: Dr.

[Qemu-devel] CUDA has problems with Mac OS 10.4

2015-11-11 Thread Programmingkid
I built Cormac O'Brien's QEMU repo for Mac OS 9 and tried to boot my Mac OS 10.4 boot cd. Mac OS 10.4's kernel panics because of a CUDA problem. I did use the mac99 target. Here is the error message: panic(cpu 0 caller 0x16E786CC): CUDA - TODO CHECK FOR TRANSACTION TYPE AND ERROR This is the c

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Michael S. Tsirkin
On Wed, Nov 11, 2015 at 09:32:17AM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > Unlike the kernel, vhost-user application accesses log table by > > mmaping it to its user space. This change adds two new fields to > > VhostUserMsg payload: mmap_size, and mmap_offset and

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Marc-André Lureau
Hi On Wed, Nov 11, 2015 at 4:17 PM, Michael S. Tsirkin wrote: > Remote doesn't know the size though, and offset is only there > in the current implementation. It can compute the size based on the mem tables. But it could be more future-proof to add these informations. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

2015-11-11 Thread Eduardo Habkost
On Wed, Nov 11, 2015 at 12:57:44AM +0800, Haozhong Zhang wrote: > On 11/09/15 14:01, Eduardo Habkost wrote: > > On Mon, Nov 09, 2015 at 08:33:55AM +0800, haozhong.zh...@intel.com wrote: > > > On 11/06/15 13:12, Eduardo Habkost wrote: > > > > On Fri, Nov 06, 2015 at 10:32:24AM +0800, haozhong.zh...@

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Michael S. Tsirkin
On Wed, Nov 11, 2015 at 04:23:33PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Nov 11, 2015 at 4:17 PM, Michael S. Tsirkin wrote: > > Remote doesn't know the size though, and offset is only there > > in the current implementation. > > It can compute the size based on the mem tables. But it

Re: [Qemu-devel] [PATCH] tests/vhost-user-bridge: implement logging of dirty pages

2015-11-11 Thread Michael S. Tsirkin
On Wed, Nov 11, 2015 at 09:03:16AM +0200, Victor Kaplansky wrote: > During migration devices continue writing to the guest's memory. > These writes have to be reported to QEMU. The change implements > minimal support in vhost-user-bridge required for successful > migration of a guest with virtio-ne

Re: [Qemu-devel] [PATCH for-2.5] block: make 'stats-intervals' a list of integers

2015-11-11 Thread Eric Blake
On 11/11/2015 06:17 AM, Alberto Garcia wrote: > This is the natural JSON representation and prevents us from having to > decode the list manually. > > Signed-off-by: Alberto Garcia > --- > blockdev.c | 64 > ++ > qapi/block-core.json

Re: [Qemu-devel] [PATCH] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-11 Thread Marc-André Lureau
Hi On Wed, Nov 11, 2015 at 3:26 PM, Victor Kaplansky wrote: > > - Sets the logging base address. > + Sets logging shared memory space. > + When slave has VHOST_USER_PROTOCOL_F_LOG_SHMFD protocol > + feature, the log memory fd is provided in the ancillary data of > + VHOST

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/8] block: Add blk_next_inserted()

2015-11-11 Thread Alberto Garcia
On Tue 10 Nov 2015 04:27:43 AM CET, Max Reitz wrote: > This function skips to the next BlockBackend for which blk_is_inserted() > is true. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

2015-11-11 Thread Haozhong Zhang
On 11/11/15 13:23, Eduardo Habkost wrote: > On Wed, Nov 11, 2015 at 12:57:44AM +0800, Haozhong Zhang wrote: > > On 11/09/15 14:01, Eduardo Habkost wrote: > > > On Mon, Nov 09, 2015 at 08:33:55AM +0800, haozhong.zh...@intel.com wrote: > > > > On 11/06/15 13:12, Eduardo Habkost wrote: > > > > > On Fr

Re: [Qemu-devel] [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

2015-11-11 Thread Haozhong Zhang
On 11/11/15 12:54, Eduardo Habkost wrote: > On Tue, Nov 10, 2015 at 09:08:58AM +0800, Haozhong Zhang wrote: > > On 11/09/15 14:01, Eduardo Habkost wrote: > > > On Mon, Nov 09, 2015 at 08:33:55AM +0800, haozhong.zh...@intel.com wrote: > > > > On 11/06/15 13:12, Eduardo Habkost wrote: > > > > > On Fr

Re: [Qemu-devel] [PULL v2 00/40] Block layer patches

2015-11-11 Thread Kevin Wolf
Am 10.11.2015 um 18:10 hat Peter Maydell geschrieben: > On 10 November 2015 at 14:09, Kevin Wolf wrote: > > The following changes since commit a8b4f9585a0bf5186fca793ce2c5d754cd8ec49a: > > > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-11-10' > > into staging (2015-11-10 0

  1   2   3   >