On Thu, 30 Jun 2016 20:23:08 +0300
"Michael S. Tsirkin" wrote:
> I'm not sure what was I thinking when I applied this:
> it changes load without changing save - how can this work?
The ordering implications are easy to miss :(
> I am inclined to revert 1f8828ef573c83365b4a87a776daf8bcef1caa21 an
> > +if (s->stats_vq_elem == NULL) {
> > +virtqueue_push(s->svq, &elem, 0);
> > +virtio_notify(vdev, s->svq);
> > +return;
> > +}
> > virtqueue_push(s->svq, s->stats_vq_elem, s->stats_vq_offset);
> > virtio_notify(vdev, s->svq);
> > g_free(s->stats_vq_
Hi
On Thu, Jun 30, 2016 at 5:31 PM, Cornelia Huck wrote:
> The host notifier rework tried both to unify host notifiers across
> transports and plug a possible hole during host notifier
> re-assignment. Unfortunately, this meant a change in semantics that
> breaks vhost and iSCSI+dataplane.
>
> As
On 01.07.2016 11:12, Kevin Wolf wrote:
Am 30.06.2016 um 19:23 hat Denis V. Lunev geschrieben:
On 06/30/2016 07:40 PM, John Snow wrote:
On 06/30/2016 05:12 AM, Denis V. Lunev wrote:
On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote:
After loading bitmap from image and setting IN_USE f
I can reasonably assume that this solved my problem. I've live migrated
41 VM's 5 times between 2 hypervisors without the 100% cpu problem
appearing.
My production servers run 2.0.0+dfsg-2ubuntu1.22, and still observe the
same problem.
Attached is the patch that I created with quilt in debian/pa
Hi Tom,
Yeh it's just vmstate_register_with_alias_id printing vmsd->name at entry,
and then after the char *id = printing that as well (that's what I
labelled as the dev/id case).
Then just before the assert I was printing the se->compat and se->instance_id
values.
I noticed this bug bec
On Do, 2016-06-30 at 17:37 +0100, Peter Maydell wrote:
> On 30 June 2016 at 17:21, Gerd Hoffmann wrote:
> > Hi,
> >
> >> Hi. I'm afraid this fails 'make check':
> >> TEST: tests/vmxnet3-test... (pid=19181)
> >> qemu-system-i386: -device vmxnet3: failed to find romfile "efi-vmxnet3.rom"
> >> Brok
On 07/01/2016 10:02 AM, Peter Maydell wrote:
> On 1 July 2016 at 07:11, Cédric Le Goater wrote:
>> On 06/30/2016 08:24 PM, Peter Maydell wrote:
>>> On 30 June 2016 at 16:50, Cédric Le Goater wrote:
These strap registers are complex enough, let's not mix them.
Signed-off-by: Cédric
On Thu, 30 Jun 2016 20:47:33 +0300
"Michael S. Tsirkin" wrote:
Thanks for review,
I'll fix up patch according to your comments and post v3 shortly
> On Thu, Jun 30, 2016 at 02:23:06PM +0200, Igor Mammedov wrote:
> > fixes long standing issue where Linux kernel would assing
>
> assign?
>
> >
Am 30.06.2016 um 19:23 hat Denis V. Lunev geschrieben:
> On 06/30/2016 07:40 PM, John Snow wrote:
> >
> >On 06/30/2016 05:12 AM, Denis V. Lunev wrote:
> >>On 06/30/2016 10:34 AM, Vladimir Sementsov-Ogievskiy wrote:
> >>>After loading bitmap from image and setting IN_USE flag in it's header,
> >>>co
On 1 July 2016 at 07:11, Cédric Le Goater wrote:
> On 06/30/2016 08:24 PM, Peter Maydell wrote:
>> On 30 June 2016 at 16:50, Cédric Le Goater wrote:
>>> These strap registers are complex enough, let's not mix them.
>>>
>>> Signed-off-by: Cédric Le Goater
>>
>> Was there a cover letter for this p
commit 08109fd4360d ('ppc: Add proper real mode translation support')
introduced VRMA support for which SLB entries need to be created. But
it did not take into account the changes in ppc_slb_t and missed the
setting of the segment page size attribute.
However, gcc spotted it :
target-ppc/mmu-has
The page shift parameter is never used. Let's remove it.
Signed-off-by: Cédric Le Goater
---
target-ppc/mmu-hash64.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c
index fdaff9e874ba..7ef45ee53bf5 100644
--- a/targ
Here is a little serie with API cleanups and fixes for large page and
VRMA. Previous patches which added the support did not take into
account the segment page size attribute.
Cédric Le Goater (4):
ppc: simplify ppc_hash64_hpte_page_shift_noslb()
ppc: fix large page support
ppc: simplify ppc
A regression was introduced by commit 53df75a59bcf ('ppc: Fix 64K
pages support in full emulation'). ppc_hash64_hpte_page_shift_noslb()
should be used to compute the page size.
Signed-off-by: Cédric Le Goater
---
target-ppc/mmu-hash64.c | 24 +---
1 file changed, 1 insertion(
From: Benjamin Herrenschmidt
The "ICP" is a different object than the "XICS". For historical reasons,
we have a number of places where we name a variable "icp" while it contains
a XICSState pointer. There *is* an ICPState structure too so this makes
the code really confusing.
This is a mechanica
The segment page shift parameter is never used. Let's remove it.
Signed-off-by: Cédric Le Goater
---
hw/ppc/spapr_hcall.c| 4 ++--
target-ppc/mmu-hash64.c | 6 +-
target-ppc/mmu-hash64.h | 3 +--
3 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc
From: Benjamin Herrenschmidt
Leave the core ICP/ICS logic in xics.c and move the top level
class wrapper, hypercall and RTAS handlers to xics_spapr.c
Signed-off-by: Benjamin Herrenschmidt
[add cpu.h in xics_spapr.c, move set_nr_irqs and set_nr_servers to
xics_spapr.c]
Signed-off-by: Nikunj A D
From: Benjamin Herrenschmidt
We were always advertising only 4K & 16M. Additionally the code wasn't
properly matching the page size with the PTE content, which meant we
could potentially hit an incorrect PTE if the guest used multiple sizes.
Finally, honor the CPU capabilities when decoding the
From: Benjamin Herrenschmidt
We don't give them a KVM reg number yet as no current KVM version
supports HV mode.
Signed-off-by: Benjamin Herrenschmidt
[clg: SPRs AMOR,DAWR,DARWX were already included in commit f401dd32cb8e9]
Signed-off-by: Cédric Le Goater
Signed-off-by: David Gibson
---
tar
From: Benjamin Herrenschmidt
The common class doesn't change, the KVM one is sPAPR specific. Rename
variables and functions to xics_spapr.
Retain the type name as "xics" to preserve migration for existing sPAPR
guests.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Nikunj A Dadhania
Sig
On 07/01/2016 08:11 AM, Cédric Le Goater wrote:
> On 06/30/2016 08:24 PM, Peter Maydell wrote:
>> On 30 June 2016 at 16:50, Cédric Le Goater wrote:
>>> These strap registers are complex enough, let's not mix them.
>>>
>>> Signed-off-by: Cédric Le Goater
>>
>> Was there a cover letter for this pat
From: Benjamin Herrenschmidt
The current behaviour isn't completely right, as for the DEC, we
don't properly re-arm when wrapping around, but I will fix this
in a separate patch.
Signed-off-by: Benjamin Herrenschmidt
[clg: fixed checkpatch.pl errors ]
Signed-off-by: Cédric Le Goater
Signed-off
From: Aaron Larson
Call gen_pause for all "or rx,rx,rx" encodings other nop. This
provides a reasonable implementation for yield, and a better
approximation for mdoio, mdoom, and miso. The choice to pause for all
encodings !=0 leverages the PowerISA admonition that the reserved
encodings might
From: Benjamin Herrenschmidt
None of the other presenter functions directly mucks with the
internal state, so don't do it there either.
Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Nikunj A Dadhania
Reviewed-by: David Gibson
Signed-off-by: David Gibson
---
hw/intc/xics.c| 8
201 - 225 of 225 matches
Mail list logo
