[Qemu-devel] [PATCH v3 14/20] sheepdog: Switch to .bdrv_co_block_status()

2017-09-14 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the sheepdog driver accordingly. Signed-off-by: Eric Blake --- v2: rebase to mapping flag --- block/sheepdog.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/blo

[Qemu-devel] [PATCH v3 01/20] block: Add .bdrv_co_block_status() callback

2017-09-14 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Now that the block layer exposes byte-based allocation, it's time to tackle the drivers. Add a new callback that operates on as small as byte boundaries. Subsequent patches will then update individual drivers, then fina

[Qemu-devel] [PATCH v3 13/20] raw: Switch to .bdrv_co_block_status()

2017-09-14 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the raw driver accordingly. Signed-off-by: Eric Blake --- v2: rebase to mapping --- block/raw-format.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/block/raw-format.c

[Qemu-devel] [PATCH v3 10/20] qcow: Switch to .bdrv_co_block_status()

2017-09-14 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow driver accordingly. There is no intent to optimize based on the mapping flag for this format. Signed-off-by: Eric Blake --- v3: rebase to master v2: rebase to mapping flag --- block/qcow.c | 25

[Qemu-devel] [PATCH v3 03/20] file-posix: Switch to .bdrv_co_block_status()

2017-09-14 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the file protocol driver accordingly. In mapping mode, note that the entire file is reported as allocated, so we can take a shortcut and skip lseek(). Signed-off-by: Eric Blake --- v2: tweak comment, add mapp

Re: [Qemu-devel] [PATCH 2/7] trace: Add event "guest_inst_before"

2017-09-14 Thread Lluís Vilanova
Richard Henderson writes: > On 09/10/2017 09:19 AM, Lluís Vilanova wrote: >> while (true) { >> +target_ulong pc_insn = db->pc_next; > Why not just "pc"? >> + db-> num_insns++; ops-> insn_start(db, cpu); >> tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */ >> @@ -96,6 +98,7

[Qemu-devel] [PATCH v3 00/20] add byte-based block_status driver callbacks

2017-09-14 Thread Eric Blake
There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a byt

[Qemu-devel] [PATCH v3 07/20] iscsi: Switch to .bdrv_co_block_status()

2017-09-14 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the iscsi driver accordingly. In this case, it is handy to teach iscsi_co_block_status() to handle a NULL file parameter, even though the block layer passes a non-NULL value, because we also call the function di

[Qemu-devel] [PATCH v3 05/20] iscsi: Switch cluster_sectors to byte-based

2017-09-14 Thread Eric Blake
We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the cluster size in sectors, along with adding assertions that we are not dividing by zero. Signed-off-by: Eric Blake --- v2: no change --- block/iscsi.c | 56 +++

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Greg Kurz
On Thu, 14 Sep 2017 13:27:49 +0200 Greg Kurz wrote: > On Thu, 14 Sep 2017 13:17:48 +0200 > Thomas Huth wrote: > > > On 14.09.2017 12:48, Greg Kurz wrote: > > > If the host has both KVM PR and KVM HV loaded and we pass: > > > > > > -machine pseries,accel=kvm,kvm-type=PR > > > > > > the kvm

Re: [Qemu-devel] [RFC 0/6] initial plugin support

2017-09-14 Thread Peter Maydell
On 6 September 2017 at 21:28, Emilio G. Cota wrote: > Related threads: > [PATCH 00/13] instrument: Add basic event instrumentation > Date: Mon, 24 Jul 2017 20:02:24 +0300 > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg07419.html > and > [PATCH v4 00/20] instrument: Add basic ev

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-14 Thread Tomasz Nowicki
Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: Hi Eric, On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote: memory_region_iommu_replay() is used for VFIO integration. However its default implementation is not adapted to SMMUv3 IOMMU memory region. Indeed the input address range is t

Re: [Qemu-devel] MIPS 'move' insn emulation

2017-09-14 Thread Peter Maydell
On 14 September 2017 at 15:23, Yongbok Kim wrote: > The reason why your modification is failed is because you passed wrong > argument. Remember that you are not just calling the helper function from > translate.c but you are generating some code to let call the helper > function on run time. You h

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-14 Thread Cornelia Huck
On Wed, 13 Sep 2017 15:27:51 +0200 Halil Pasic wrote: > Add a fake device meant for testing the correctness of our css emulation. > > What we currently have is writing a Fibonacci sequence of uint32_t to the > device via ccw write. The write is going to fail if it ain't a Fibonacci > and indicat

Re: [Qemu-devel] MIPS 'move' insn emulation

2017-09-14 Thread Yongbok Kim
On 14/09/2017 15:16, Sergey Smolov wrote: > > On 14.09.2017 16:58, Peter Maydell wrote: >> At translate time it is generating some extra code which at runtime >> will call the helper_trace_reg_access() function, passing it the >> values in the registers at this point. This will result in poor >>

Re: [Qemu-devel] [PATCH 1/7] trace: Add event "guest_bbl_before"

2017-09-14 Thread Lluís Vilanova
Richard Henderson writes: > On 09/10/2017 09:15 AM, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> accel/tcg/translator.c |6 ++ >> trace-events | 11 +++ >> 2 files changed, 17 insertions(+) >> >> diff --git a/accel/tcg/translator.c b/accel/tcg/transl

Re: [Qemu-devel] [PATCH v2 0/4] add CCW indirect data access support

2017-09-14 Thread Cornelia Huck
On Wed, 13 Sep 2017 13:50:25 +0200 Halil Pasic wrote: > Abstract > > > The objective of this series is introducing CCW IDA (indirect data > access) support to our virtual channel subsystem implementation. Briefly > CCW IDA can be thought of as a kind of a scatter gather support for a >

[Qemu-devel] [PATCH v2 1/2] checkpatch: add hwaddr to @typeList

2017-09-14 Thread Greg Kurz
The script doesn't know about all possible types and learn them as it parses the code. If it reaches a line with a type cast but the type isn't known yet, it is misinterpreted as an identifier. For example the following line: foo = (hwaddr) -1; results in the following false-positive to be r

Re: [Qemu-devel] MIPS 'move' insn emulation

2017-09-14 Thread Sergey Smolov
On 14.09.2017 16:58, Peter Maydell wrote: At translate time it is generating some extra code which at runtime will call the helper_trace_reg_access() function, passing it the values in the registers at this point. This will result in poor performance if you do it for frequently executed instruct

[Qemu-devel] [PATCH v2 2/2] spapr_pci: make index property mandatory

2017-09-14 Thread Greg Kurz
Creating several PHBs without index property confuses the DRC code and causes issues: - only the first index-less PHB is functional, the other ones will silently ignore hotplugging of PCI devices - QEMU will even terminate if these PHBs have cold-plugged devices qemu-system-ppc64: -device virtio

[Qemu-devel] [PATCH v2 0/2] spapr_pci: make index property mandatory

2017-09-14 Thread Greg Kurz
Patch 1 is a proposal to silence patchew when it parses patch 2 :) -- Greg --- Greg Kurz (2): checkpatch: add hwaddr to @typeList spapr_pci: make index property mandatory hw/ppc/spapr_pci.c| 53 ++--- scripts/checkpatch.pl |1 +

Re: [Qemu-devel] MIPS 'move' insn emulation

2017-09-14 Thread Peter Maydell
On 14 September 2017 at 14:49, Sergey Smolov wrote: > I've implemented the code you've written. Now I receive values are written > into MIPS registers. > > Could you explain some aspects about the code you propose? > > First, what is the helper function itself? Peter said that it is impossible > t

Re: [Qemu-devel] [PATCH v2] Discover openpty(3) dynamically in configure

2017-09-14 Thread Peter Maydell
On 11 September 2017 at 18:16, Kamil Rytarowski wrote: > openpty(3) might: > - exists in libc (OSX) > - exists in libutil (GNU, BSD) > - does not exist (SmartOS) > > Add a function to discover this function in the ./configure script. > Add new config types: CONFIG_OPENPTY_LIBC and CONFIG_OPENPT

[Qemu-devel] [PATCH v2] osdep: Fix ROUND_UP(64-bit, 32-bit)

2017-09-14 Thread Eric Blake
When using bit-wise operations that exploit the power-of-two nature of the second argument of ROUND_UP(), we still need to ensure that the mask is as wide as the first argument (done by using a ternary to force proper arithmetic promotion). Unpatched, ROUND_UP(2ULL*1024*1024*1024*1024, 512U) produc

Re: [Qemu-devel] MIPS 'move' insn emulation

2017-09-14 Thread Sergey Smolov
On 13.09.2017 17:20, Yongbok Kim wrote: (Especially while implementing new instructions), I tended to add couple of helper functions for tracing temporally. op_helper.c: void helper_trace_reg_access(CPUMIPSState *env, target_ulong val) { printf("reg = "TARGET_FMT_lx"\n", val); } helper.h:

Re: [Qemu-devel] [PATCH] sparc: Fix typedef clash

2017-09-14 Thread Philippe Mathieu-Daudé
On 09/14/2017 09:36 AM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Older compilers (rhel6) don't like redefinition of typedefs Newer neither (clang-5) fatal error: redefinition of typedef [-Wtypedef-redefinition] d61d1b20610 Fixes: 12a6c15ef31c98ecefa63e91ac36

Re: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory

2017-09-14 Thread Greg Kurz
On Thu, 14 Sep 2017 22:31:26 +1000 David Gibson wrote: > On Thu, Sep 14, 2017 at 09:03:15AM +0200, Greg Kurz wrote: > > Creating several PHBs without index property confuses the DRC code > > and causes issues: > > - only the first index-less PHB is functional, the other ones will > > silently i

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

2017-09-14 Thread Halil Pasic
On 09/14/2017 12:36 PM, Thomas Huth wrote: > libseccomp supports s390x since version 2.3.0, and I was able to start > a VM with "-sandbox on" without any obvious problems by using this patch, > so it should be safe to allow --enable-seccomp on s390x nowadays, too. > > Signed-off-by: Thomas Huth

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

2017-09-14 Thread Peter Maydell
On 14 September 2017 at 05:36, Philippe Mathieu-Daudé wrote: > On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: >> +static uint64_t msf2_sysreg_read(void *opaque, hwaddr offset, >> +unsigned size) >> +{ >> +MSF2SysregState *s = opaque; >> +uint32_t ret = 0; >> + >> +offset >>= 2; >

Re: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory

2017-09-14 Thread David Gibson
On Thu, Sep 14, 2017 at 09:03:15AM +0200, Greg Kurz wrote: > Creating several PHBs without index property confuses the DRC code > and causes issues: > - only the first index-less PHB is functional, the other ones will > silently ignore hotplugging of PCI devices > - QEMU will even terminate if th

Re: [Qemu-devel] [PATCH v2 3/6] aarch64-softmmu.mak: Use an ARM specific config

2017-09-14 Thread Peter Maydell
On 1 September 2017 at 22:00, Alistair Francis wrote: > In preperation for having an ARM and MicroBlaze ZynqMP machine let's > split out the current ARM specific config options. > > Signed-off-by: Alistair Francis Acked-by: Peter Maydell I'm assuming this series is going be reviewed and go int

Re: [Qemu-devel] [libvirt] QEMU -M nvdimm=on and hotplug

2017-09-14 Thread Igor Mammedov
On Thu, 14 Sep 2017 13:51:45 +0200 Michal Privoznik wrote: > On 09/14/2017 02:33 AM, Haozhong Zhang wrote: > > On 09/13/17 17:28 +0200, Michal Privoznik wrote: > >> > >> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on > >> and guest migrated happily. So looks like guest

[Qemu-devel] host doesn't support requested feature: CPUID.01H:EDX.ds [bit 21] Does this warn affect virtual machine performance or use?

2017-09-14 Thread Paul Schlacter
this is my stackoverflow question: https://stackoverflow.com/questions/46219552/host-doesnt-support-requested-feature-cpuid-01hedx-ds-bit-21-does-this-warn I found a lot of warning from the VM qemu log, Does this warn affect virtual machine performance or use? , is my libvirt.xml file problem? Or

Re: [Qemu-devel] [PATCH] target/arm: Avoid an extra temporary for store_exclusive

2017-09-14 Thread Peter Maydell
On 8 September 2017 at 18:46, Alistair Francis wrote: > On Fri, Sep 8, 2017 at 9:38 AM, Richard Henderson > wrote: >> Instead of copying addr to a local temp, reuse the value (which we >> have just compared as equal) already saved in cpu_exclusive_addr. >> >> Signed-off-by: Richard Henderson > >

Re: [Qemu-devel] [PULL 0/6] Vga 20170913 patches

2017-09-14 Thread Peter Maydell
On 13 September 2017 at 08:41, Gerd Hoffmann wrote: > The following changes since commit 223cd0e13f2e46078d7b573f0b8402bfbee339be: > > Merge remote-tracking branch 'remotes/elmarco/tags/tidy-pull-request' into > staging (2017-08-31 15:52:43 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-14 Thread Daniel P. Berrange
On Thu, Sep 14, 2017 at 12:58:26PM +0100, Peter Maydell wrote: > On 14 September 2017 at 12:55, Gerd Hoffmann wrote: > > Hi, > > > >> I think a better approach is to have something in rules.mak > >> that ensures the submodule is checked out correctly (only > >> when building from GIT, not dist),

[Qemu-devel] [PATCH] sparc: Fix typedef clash

2017-09-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Older compilers (rhel6) don't like redefinition of typedefs Fixes: 12a6c15ef31c98ecefa63e91ac36955383038384 Signed-off-by: Dr. David Alan Gilbert --- target/sparc/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/sparc/cpu.h b/

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/1] AArch64: Fix single stepping of ERET instruction

2017-09-14 Thread Peter Maydell
On 8 September 2017 at 17:58, Richard Henderson wrote: > On 09/08/2017 04:02 AM, Jaroslaw Pelczar wrote: >> Previously when single stepping through ERET instruction via GDB >> would result in debugger entering the "next" PC after ERET instruction. >> When debugging in kernel mode, this will also c

Re: [Qemu-devel] [PATCH Resend v2 0/5] Expose the secure and virt properties to the

2017-09-14 Thread Peter Maydell
On 7 September 2017 at 22:44, Alistair Francis wrote: > On Thu, Sep 7, 2017 at 2:35 PM, Edgar E. Iglesias > wrote: >> On Thu, Sep 07, 2017 at 08:56:55AM -0700, Alistair Francis wrote: >>> >>> The EL2 and EL3 work is working well now and interanlly we now have >>> tests that expect to start in EL3

Re: [Qemu-devel] [PATCH v11 6/6] fsdev: hmp interface for throttling

2017-09-14 Thread Alberto Garcia
On Thu 14 Sep 2017 12:40:10 PM CEST, Pradeep Jagadeesh wrote: > This patch introduces hmp interfaces for the fsdev > devices. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

2017-09-14 Thread Eduardo Otubo
On Thu, Sep 14, 2017 at 01:55:46PM +0200, Christian Borntraeger wrote: > On 09/14/2017 12:36 PM, Thomas Huth wrote: > > libseccomp supports s390x since version 2.3.0, and I was able to start > > a VM with "-sandbox on" without any obvious problems by using this patch, > > so it should be safe to al

Re: [Qemu-devel] [PATCH] osdep: Fix ROUND_UP(64-bit, 32-bit)

2017-09-14 Thread Eric Blake
On 09/14/2017 03:44 AM, Laszlo Ersek wrote: > On 09/13/17 23:03, Eric Blake wrote: >> When using bit-wise operations that exploit the power-of-two >> nature of the second argument of ROUND_UP(), we still need to >> ensure that the mask is as wide as the first argument (done >> by using addition of

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-14 Thread Peter Maydell
On 14 September 2017 at 12:55, Gerd Hoffmann wrote: > Hi, > >> I think a better approach is to have something in rules.mak >> that ensures the submodule is checked out correctly (only >> when building from GIT, not dist), and then have the rules >> which generate the keymap files depend on this.

Re: [Qemu-devel] [PATCH v7 11/20] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

2017-09-14 Thread Eric Blake
On 09/13/2017 07:15 PM, John Snow wrote: > > > On 09/12/2017 04:31 PM, Eric Blake wrote: >> Thanks to recent cleanups, most callers were scaling a return value >> of sectors into bytes (the exception, in qcow2-bitmap, will be >> converted to byte-based iteration later). Update the interface to >

Re: [Qemu-devel] [PATCH v7 05/20] dirty-bitmap: Check for size query failure during truncate

2017-09-14 Thread Eric Blake
On 09/13/2017 06:27 PM, John Snow wrote: > > > On 09/12/2017 04:31 PM, Eric Blake wrote: >> We've previously fixed several places where we failed to account >> for possible errors from bdrv_nb_sectors(). Fix another one by >> making bdrv_dirty_bitmap_truncate() report the error rather then >> si

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

2017-09-14 Thread Christian Borntraeger
On 09/14/2017 12:36 PM, Thomas Huth wrote: > libseccomp supports s390x since version 2.3.0, and I was able to start > a VM with "-sandbox on" without any obvious problems by using this patch, > so it should be safe to allow --enable-seccomp on s390x nowadays, too. Seems to work fine on s390x. Acke

Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

2017-09-14 Thread Gerd Hoffmann
Hi, > I think a better approach is to have something in rules.mak > that ensures the submodule is checked out correctly (only > when building from GIT, not dist), and then have the rules > which generate the keymap files depend on this. Care sending a patch doing that for dtc? cheers, Gerd

Re: [Qemu-devel] [libvirt] QEMU -M nvdimm=on and hotplug

2017-09-14 Thread Michal Privoznik
On 09/14/2017 02:33 AM, Haozhong Zhang wrote: > On 09/13/17 17:28 +0200, Michal Privoznik wrote: >> >> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on >> and guest migrated happily. So looks like guest ABI is stable (or at >> least stable enough not to crash). But since ACPI

[Qemu-devel] [PATCH v2 2/2] Add --firmwarepath to configure

2017-09-14 Thread Gerd Hoffmann
Add a firmware path config option to configure. Multiple directories are accepted, with the usual colon as separator. Default value is ${prefix}/share/qemu-firmware. The path is searched in addition to the current search path (typically ${prefix}/share/qemu). This prepares qemu for the planned

[Qemu-devel] [PATCH v2 0/2] Add --firmwarepath to configure

2017-09-14 Thread Gerd Hoffmann
Patch #1 is a cleanup to factor out code and simplify patch #2 a bit. Patch #2 is the actual change, see patch commit log for details. v2: use G_SEARCHPATH_SEPARATOR_S (paolo) Gerd Hoffmann (2): add qemu_add_data_dir() Add --firmwarepath to configure configure | 6 ++ vl.c

[Qemu-devel] [PATCH v2 1/2] add qemu_add_data_dir()

2017-09-14 Thread Gerd Hoffmann
Add helper function to add a directory to the qemu search path, so we don't duplicate the checks. Add a check for duplicate entries, so we stop trying to open files twice. Signed-off-by: Gerd Hoffmann --- vl.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletio

Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/

2017-09-14 Thread Paolo Bonzini
On 14/09/2017 05:30, Stefan Weil wrote: > Am 14.09.2017 um 00:11 schrieb Philippe Mathieu-Daudé: >> Suggested-by: Paolo Bonzini >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Makefile.target | 1 - >> hax-stub.c => accel/stubs/hax-stub.c | 0 >> accel/stubs/Makefile.objs

Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure

2017-09-14 Thread Paolo Bonzini
On 14/09/2017 10:36, Gerd Hoffmann wrote: > Hi, > >>> + --firmwarepath=PATH search PATH for firmware files >> >> Maybe --firmwaredir or --with-firmwaredir (because firmwaredir is not >> one of the "standard" directories)? > > I've intentionally named this "path" because it can actually ha

Re: [Qemu-devel] question:a question about throttle and hot-unplug

2017-09-14 Thread Alberto Garcia
On Thu 14 Sep 2017 11:41:40 AM CEST, WangJie (Captain) wrote: > the patch you commited: > https://github.com/qemu/qemu/commit/7ca7f0f6db1fedd28d490795d778cf23979a2aa7#diff-ea36ba0f79150cc299732696a069caba > > remove blk_io_limits_disable from blk_remove_bs > > Then, if a disk which configured qos

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread David Gibson
On Thu, Sep 14, 2017 at 12:48:04PM +0200, Greg Kurz wrote: > If the host has both KVM PR and KVM HV loaded and we pass: > > -machine pseries,accel=kvm,kvm-type=PR > > the kvmppc_is_pr() returns false instead of true. Since the helper > is mostly used as fallback, it doesn't have any real im

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Greg Kurz
On Thu, 14 Sep 2017 13:17:48 +0200 Thomas Huth wrote: > On 14.09.2017 12:48, Greg Kurz wrote: > > If the host has both KVM PR and KVM HV loaded and we pass: > > > > -machine pseries,accel=kvm,kvm-type=PR > > > > the kvmppc_is_pr() returns false instead of true. Since the helper > > is mostl

Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

2017-09-14 Thread Eduardo Otubo
On Thu, Sep 14, 2017 at 12:36:03PM +0200, Thomas Huth wrote: > libseccomp supports s390x since version 2.3.0, and I was able to start > a VM with "-sandbox on" without any obvious problems by using this patch, > so it should be safe to allow --enable-seccomp on s390x nowadays, too. > I don't have

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-14 Thread Pradeep Jagadeesh
On 9/14/2017 1:19 PM, Greg Kurz wrote: On Thu, 14 Sep 2017 06:40:06 -0400 Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Greg Kurz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Reviewed-by: Mar

Re: [Qemu-devel] [PATCH v11 3/6] qmp: factor out throttle code to reuse code

2017-09-14 Thread Greg Kurz
On Thu, 14 Sep 2017 06:40:07 -0400 Pradeep Jagadeesh wrote: > This patch reuses the code to set throttle limits. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Alberto Garcia > Reviewed-by: Greg Kurz > --- > blockdev.c | 53 +++-- Same rem

Re: [Qemu-devel] [PATCH v2 0/4] add CCW indirect data access support

2017-09-14 Thread Cornelia Huck
On Thu, 14 Sep 2017 13:02:51 +0200 Halil Pasic wrote: > About the r-b's I think the guys in cc are the most likely > candidates. Pierre should be back starting next week. Dong > Jia I haven't seen in a while, but I don't know about anything. Let's see what comes in, although I don't want to dela

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-14 Thread Greg Kurz
On Thu, 14 Sep 2017 06:40:06 -0400 Pradeep Jagadeesh wrote: > This patch factors out code to use the ThrottleLimits > strurcture. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Greg Kurz > Reviewed-by: Eric Blake > Reviewed-by: Alberto Garcia > Reviewed-by: Markus Armbruster > --- > q

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Thomas Huth
On 14.09.2017 12:48, Greg Kurz wrote: > If the host has both KVM PR and KVM HV loaded and we pass: > > -machine pseries,accel=kvm,kvm-type=PR > > the kvmppc_is_pr() returns false instead of true. Since the helper > is mostly used as fallback, it doesn't have any real impact with > recent ke

Re: [Qemu-devel] [PATCH 1/1] virtio-ccw: remove stale comments on endiannes

2017-09-14 Thread Cornelia Huck
On Thu, 14 Sep 2017 12:55:35 +0200 Halil Pasic wrote: > We have two stale comments suggesting one should think about virtio > config space endiannes a bit longer. We have just done that, and came to > the conclusion we are fine as is: it's the responsibility of the virtio > device and not of the

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-14 Thread Marc-André Lureau
Hi On Thu, Sep 14, 2017 at 9:50 AM, Peter Xu wrote: > This series was born from this one: > > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04310.html > > The design comes from Markus, and also the whole-bunch-of discussions > in previous thread. My heartful thanks to Markus, Daniel

Re: [Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

2017-09-14 Thread Greg Kurz
On Thu, 14 Sep 2017 06:40:05 -0400 Pradeep Jagadeesh wrote: > This patch factors out the duplicate throttle code that was still > present in block and fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Alberto Garcia > Reviewed-by: Greg Kurz I see you took my remarks into acc

Re: [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command

2017-09-14 Thread Dr. David Alan Gilbert
* Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: > I think I made a typo here. It should be: > > +# @plugged-memory: size *of* memory that can be hot-unplugged. This field > +# is omitted if target does *not* support memory hotplug > +# (i.e. CONFIG_MEM_H

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Thomas Huth
On 14.09.2017 12:48, Greg Kurz wrote: > If the host has both KVM PR and KVM HV loaded and we pass: > > -machine pseries,accel=kvm,kvm-type=PR > > the kvmppc_is_pr() returns false instead of true. Since the helper > is mostly used as fallback, it doesn't have any real impact with > recent ke

Re: [Qemu-devel] [PATCH v2 0/4] add CCW indirect data access support

2017-09-14 Thread Halil Pasic
On 09/14/2017 11:15 AM, Cornelia Huck wrote: > On Wed, 13 Sep 2017 13:50:25 +0200 > Halil Pasic wrote: > >> Abstract >> >> >> The objective of this series is introducing CCW IDA (indirect data >> access) support to our virtual channel subsystem implementation. Briefly >> CCW IDA can be

[Qemu-devel] [PATCH 1/1] virtio-ccw: remove stale comments on endiannes

2017-09-14 Thread Halil Pasic
We have two stale comments suggesting one should think about virtio config space endiannes a bit longer. We have just done that, and came to the conclusion we are fine as is: it's the responsibility of the virtio device and not of the transport (and that is how it works now). Putting the responsibi

[Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Greg Kurz
If the host has both KVM PR and KVM HV loaded and we pass: -machine pseries,accel=kvm,kvm-type=PR the kvmppc_is_pr() returns false instead of true. Since the helper is mostly used as fallback, it doesn't have any real impact with recent kernels. A notable exception is the workaround to al

[Qemu-devel] [PATCH v11 4/6] hmp: create a throttle initialization function for code reuse

2017-09-14 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Alberto Garcia Reviewed-by: Greg Kurz Acked-by: Dr. David Alan Gilbert --- hmp.c | 20 ++-- 1 file changed

[Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

2017-09-14 Thread Pradeep Jagadeesh
This patch factors out the duplicate throttle code that was still present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Alberto Garcia Reviewed-by: Greg Kurz Reviewed-by: Eric Blake --- blockdev.c | 44 +- fsdev/

[Qemu-devel] [PATCH v11 0/6] fsdev: qmp interface for io throttling

2017-09-14 Thread Pradeep Jagadeesh
These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. also, it provides an interface to set the io throttle parameters of a fsdev to a required value. Some of the patches also remove the duplicate code that was present in block

[Qemu-devel] [PATCH v11 5/6] fsdev: QMP interface for throttling

2017-09-14 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Dr. David Alan Gilbert --- Makefile

[Qemu-devel] [PATCH v11 6/6] fsdev: hmp interface for throttling

2017-09-14 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Dr. David Alan Gilbert --- hmp-commands-info.hx | 18 hmp-commands.hx | 19 + hmp.c| 59 +++

[Qemu-devel] [PATCH v11 3/6] qmp: factor out throttle code to reuse code

2017-09-14 Thread Pradeep Jagadeesh
This patch reuses the code to set throttle limits. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Alberto Garcia Reviewed-by: Greg Kurz --- blockdev.c | 53 +++-- 1 file changed, 3 insertions(+), 50 deletions(-) diff --git a/blockdev.c b/blockdev

[Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-14 Thread Pradeep Jagadeesh
This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Greg Kurz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Reviewed-by: Markus Armbruster --- qapi/block-core.json | 78 +++- 1 f

[Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too

2017-09-14 Thread Thomas Huth
libseccomp supports s390x since version 2.3.0, and I was able to start a VM with "-sandbox on" without any obvious problems by using this patch, so it should be safe to allow --enable-seccomp on s390x nowadays, too. Signed-off-by: Thomas Huth --- configure | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command

2017-09-14 Thread Vadim Galitsyn
I think I made a typo here. It should be: +# @plugged-memory: size *of* memory that can be hot-unplugged. This field +# is omitted if target does *not* support memory hotplug +# (i.e. CONFIG_MEM_HOTPLUG not defined on build time). On Thu, Sep 14, 2017 at 12:26

Re: [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command

2017-09-14 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Tue, 29 Aug 2017 17:30:21 +0200 > Vadim Galitsyn wrote: > > > Add a new query-memory-size-summary command which provides the > > following memory information in bytes: > > > > * base-memory - size of "base" memory specified with command line op

Re: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates

2017-09-14 Thread Vadim Galitsyn
Igor, David, Thank you! Best regards, Vadim On Thu, Sep 14, 2017 at 12:09 PM, Dr. David Alan Gilbert < dgilb...@redhat.com> wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Thu, 14 Sep 2017 11:35:36 +0200 > > Vadim Galitsyn wrote: > > > > > Hi Guys, > > > > > > Could you please let

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-09-14 Thread Bharata B Rao
On Thu, Sep 14, 2017 at 10:59:05AM +0200, Igor Mammedov wrote: > On Thu, 14 Sep 2017 13:48:26 +0530 > Bharata B Rao wrote: > > > On Thu, Sep 14, 2017 at 10:00:11AM +0200, Igor Mammedov wrote: > > > On Thu, 14 Sep 2017 12:31:18 +0530 > > > Bharata B Rao wrote: > > > > > > > Hi, > > > > > > >

Re: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates

2017-09-14 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 14 Sep 2017 11:35:36 +0200 > Vadim Galitsyn wrote: > > > Hi Guys, > > > > Could you please let me know if you have an update on this topic? > Series looks good to me. > so with comments I've made fixed up OK, I can fix those comment comment

Re: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates

2017-09-14 Thread Igor Mammedov
On Thu, 14 Sep 2017 11:35:36 +0200 Vadim Galitsyn wrote: > Hi Guys, > > Could you please let me know if you have an update on this topic? Series looks good to me. so with comments I've made fixed up Reviewed-by: Igor Mammedov > > Thank you, > Vadim > > On Tue, Aug 29, 2017 at 5:30 PM, Vadim

Re: [Qemu-devel] [PATCH v7 3/3] hmp: introduce 'info memory_size_summary' command

2017-09-14 Thread Igor Mammedov
On Tue, 29 Aug 2017 17:30:22 +0200 Vadim Galitsyn wrote: > Add 'info memory_size_summary' command which is a sibling > of QMP command query-memory-size-summary. It provides the > following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option

Re: [Qemu-devel] [PATCH v7 2/3] qmp: introduce query-memory-size-summary command

2017-09-14 Thread Igor Mammedov
On Tue, 29 Aug 2017 17:30:21 +0200 Vadim Galitsyn wrote: > Add a new query-memory-size-summary command which provides the > following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * plugged-memory - amount of memory that wa

Re: [Qemu-devel] [PATCH v4 0/4] hmp: fix "dump-quest-memory" segfault

2017-09-14 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > Fix aarch64 and ppc when dump-guest-memory is > used with none machine type and no CPU. > > The other machine types don't have the problem. > > Update test-hmp, to test none machine type > with (2 MB) and without memory, and add a test > to test dump

Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent guest memory

2017-09-14 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > On 13/09/2017 16:27, Cornelia Huck wrote: > > On Wed, 13 Sep 2017 16:20:35 +0200 > > Laurent Vivier wrote: > > > >> From: Cornelia Huck > >> > >> It does not really make sense to dump memory that is not there. > >> > >> Moreover, that fixes a segmen

[Qemu-devel] question:a question about throttle and hot-unplug

2017-09-14 Thread WangJie (Captain)
Hi, Kevin the patch you commited: https://github.com/qemu/qemu/commit/7ca7f0f6db1fedd28d490795d778cf23979a2aa7#diff-ea36ba0f79150cc299732696a069caba remove blk_io_limits_disable from blk_remove_bs Then, if a disk which configured qos hot-unplug from VM, the backend of the disk reminds in throt

Re: [Qemu-devel] [PATCH v7 0/3] hmp, qmp: 'info memory_size_summary', 'query-memory-size-summary', 'info numa' updates

2017-09-14 Thread Vadim Galitsyn
Hi Guys, Could you please let me know if you have an update on this topic? Thank you, Vadim On Tue, Aug 29, 2017 at 5:30 PM, Vadim Galitsyn < vadim.galit...@profitbricks.com> wrote: > Hi Guys, > > Sorry for the delay. This is continuation of > http://lists.nongnu.org/archive/html/qemu-devel/2

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-14 Thread Linu Cherian
Hi Eric, On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote: > memory_region_iommu_replay() is used for VFIO integration. > > However its default implementation is not adapted to SMMUv3 > IOMMU memory region. Indeed the input address range is too > huge and its execution is too slow as it

Re: [Qemu-devel] [RFC v2 30/32] vhost: Merge neighbouring hugepage regions where appropriate

2017-09-14 Thread Igor Mammedov
On Thu, 24 Aug 2017 20:27:28 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Where two regions are created with a gap such that when aligned > to hugepage boundaries, the two regions overlap, merge them. why only hugepage boundaries, it should be applicable any

Re: [Qemu-devel] [PATCH v2 0/4] add CCW indirect data access support

2017-09-14 Thread Cornelia Huck
On Wed, 13 Sep 2017 13:50:25 +0200 Halil Pasic wrote: > Abstract > > > The objective of this series is introducing CCW IDA (indirect data > access) support to our virtual channel subsystem implementation. Briefly > CCW IDA can be thought of as a kind of a scatter gather support for a >

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-14 Thread Cornelia Huck
On Wed, 13 Sep 2017 13:50:29 +0200 Halil Pasic wrote: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does no bother with any kind of s/no/not/ > prefetching. We simply step trough the IDAL on demand. s/trough/through/ > > Signed-off-by:

[Qemu-devel] [PATCH] checkpatch: add hwaddr to @typeList

2017-09-14 Thread Greg Kurz
The script doesn't know about all possible types and learn them as it parses the code. If it reaches a line with a type cast but the type isn't known yet, it is misinterpreted as an identifier. For example the following line: foo = (hwaddr) -1; results in the following false-positive to be r

Re: [Qemu-devel] [PATCH v2 1/4] s390x/css: introduce css data stream

2017-09-14 Thread Cornelia Huck
On Wed, 13 Sep 2017 13:50:26 +0200 Halil Pasic wrote: > This is a preparation for introducing handling for indirect data > addressing and modified indirect data addressing (CCW). Here we introduce > an interface which should make the addressing scheme transparent for the > client code. Here we im

Re: [Qemu-devel] [PATCH] throttle: Assert that bkt->max is valid in throttle_compute_wait()

2017-09-14 Thread Alberto Garcia
On Wed 13 Sep 2017 06:31:58 PM CEST, Philippe Mathieu-Daudé wrote: >> If bkt->max == 0 and bkt->burst_length > 1 then we could have a >> division by 0 in throttle_do_compute_wait(). That configuration is >> however not permitted and is already detected by throttle_is_valid(), >> but let's assert i

Re: [Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-09-14 Thread Igor Mammedov
On Thu, 14 Sep 2017 13:48:26 +0530 Bharata B Rao wrote: > On Thu, Sep 14, 2017 at 10:00:11AM +0200, Igor Mammedov wrote: > > On Thu, 14 Sep 2017 12:31:18 +0530 > > Bharata B Rao wrote: > > > > > Hi, > > > > > > QEMU hits the below assert > > > > > > qemu-system-ppc64: used ring relocated fo

Re: [Qemu-devel] [PATCH v2 3/4] virtio-ccw: use ccw data stream

2017-09-14 Thread Cornelia Huck
On Wed, 13 Sep 2017 13:50:28 +0200 Halil Pasic wrote: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic > @@ -488,7 +446,7 @@ static int virtio_ccw

Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390

2017-09-14 Thread Gerd Hoffmann
Hi, > Do you have a list of CONFIG options that need to be enabled there? > Are there also any patches to the guest kernel driver required? guest kernel driver should be fine, it works for ppc64 (big endian) guests. cheers, Gerd

<    1   2   3   4   >