Re: [Qemu-devel] [PATCH 3/3] iothread: delay the context release to finalize

On Mon, 09/25 13:50, Peter Xu wrote: > On Mon, Sep 25, 2017 at 01:30:02PM +0800, Fam Zheng wrote: > > On Mon, 09/25 13:23, Peter Xu wrote: > > > On Fri, Sep 22, 2017 at 09:09:22PM +0800, Fam Zheng wrote: > > > > On Fri, 09/22 16:56, Peter Xu wrote: > > > > > When gcontext is used with iothread,

Re: [Qemu-devel] [PATCH 3/3] iothread: delay the context release to finalize

On Mon, Sep 25, 2017 at 01:30:02PM +0800, Fam Zheng wrote: > On Mon, 09/25 13:23, Peter Xu wrote: > > On Fri, Sep 22, 2017 at 09:09:22PM +0800, Fam Zheng wrote: > > > On Fri, 09/22 16:56, Peter Xu wrote: > > > > When gcontext is used with iothread, the context will be destroyed > > > > during

Re: [Qemu-devel] [PATCH 34/34] misc: drop old i386 dependency

On 22.09.2017 18:01, Philippe Mathieu-Daudé wrote: > while here, add an entry for wdt_ib700 in MAINTAINERS > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/char/debugcon.c | 1 - > hw/intc/lm32_pic.c | 1 - > hw/moxie/moxiesim.c | 1 - > hw/sparc/sun4m.c

Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency

On 22.09.2017 18:01, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/alpha/alpha_sys.h | 2 -- > hw/alpha/pci.c | 2 ++ > hw/alpha/typhoon.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/alpha/alpha_sys.h

Re: [Qemu-devel] [PATCH 31/34] hw/net/rtl8139: use TYPE_PCI_RTL8139

On 22.09.2017 18:01, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/net/pci.h| 1 + > hw/arm/realview.c | 3 ++- > hw/arm/versatilepb.c| 3 ++- > hw/mips/mips_fulong2e.c | 3 ++- > hw/net/rtl8139.c| 7 +++ >

Re: [Qemu-devel] [PATCH 29/34] hw/net/e1000e: use TYPE_PCI_E1000E

On 22.09.2017 18:01, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/net/pci.h | 1 + > hw/net/e1000e.c | 6 +++--- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/hw/net/pci.h b/include/hw/net/pci.h >

Re: [Qemu-devel] [PATCH 3/3] iothread: delay the context release to finalize

On Mon, 09/25 13:23, Peter Xu wrote: > On Fri, Sep 22, 2017 at 09:09:22PM +0800, Fam Zheng wrote: > > On Fri, 09/22 16:56, Peter Xu wrote: > > > When gcontext is used with iothread, the context will be destroyed > > > during iothread_stop(). That's not good since sometimes we would like > > > to

Re: [Qemu-devel] [PATCH 3/3] iothread: delay the context release to finalize

On Fri, Sep 22, 2017 at 09:09:22PM +0800, Fam Zheng wrote: > On Fri, 09/22 16:56, Peter Xu wrote: > > When gcontext is used with iothread, the context will be destroyed > > during iothread_stop(). That's not good since sometimes we would like > > to keep the resources until iothread is destroyed,

Re: [Qemu-devel] [PATCH 17/34] hw/virtio-balloon: remove old i386 dependency

On 22.09.2017 17:39, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/virtio/virtio-balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > index

Re: [Qemu-devel] [PATCH 18/34] hw/unicore32: restrict hw addr defines to source file

On 22.09.2017 17:39, Philippe Mathieu-Daudé wrote: > and drop unused #includes > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/unicore32/puv3.h | 10 -- > hw/unicore32/puv3.c | 16 ++-- > 2 files changed, 10 insertions(+), 16

Re: [Qemu-devel] [PATCH 15/34] hw/i2c: remove old i386 dependency

On 22.09.2017 17:39, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i2c/pm_smbus.c | 1 - > hw/i2c/smbus_ich9.c | 1 - > 2 files changed, 2 deletions(-) > Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH 11/34] i386/pc: use TYPE_PORT92

On 22.09.2017 17:39, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 05985d4927..f116cede91 100644 > --- a/hw/i386/pc.c > +++

Re: [Qemu-devel] [PATCH 12/34] misc: remove old i386 dependency

On 22.09.2017 17:39, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/audio/pcspk.c| 1 - > hw/i386/kvm/pci-assign.c| 1 - > hw/i386/pci-assign-load-rom.c | 1 - > hw/i386/xen/xen_platform.c | 1 - >

Re: [Qemu-devel] [PATCH 10/34] amd_iommu: avoid needless includes in header file

On 22.09.2017 17:39, Philippe Mathieu-Daudé wrote: > instead move them to the source file > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/amd_iommu.h | 5 - > hw/i386/amd_iommu.c | 5 - > 2 files changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Thomas

[Qemu-devel] [Bug 1681439] Re: qemu-system-x86_64: hw/ide/core.c:685: ide_cancel_dma_sync: Assertion `s->bus->dma->aiocb == NULL' failed.

I cannot reproduce this any more with QEMU 2.9.0. As I do not really have time right now to determine which commit fixed this, feel free to close this bug. I will reopen it in case the issue resurfaces. Thanks for your assistance. -- You received this bug notification because you are a member

Re: [Qemu-devel] [PATCH 2/3] iothread: export iothread_stop()

On Fri, Sep 22, 2017 at 09:06:26PM +0800, Fam Zheng wrote: > On Fri, 09/22 16:56, Peter Xu wrote: > > So that internal iothread users can explicitly stop one iothread without > > destroying it. > > > > Since at it, fix iothread_stop() to allow re-entrance. Before this > > I don't think there is

Re: [Qemu-devel] [PATCH v4 5/5] s390x/css: support ccw IDA

* Halil Pasic [2017-09-21 20:08:41 +0200]: > Let's add indirect data addressing support for our virtual channel > subsystem. This implementation does not bother with any kind of > prefetching. We simply step through the IDAL on demand. > > Signed-off-by: Halil Pasic

Re: [Qemu-devel] [PATCH v2] docker: add installation to build tests

On Fri, 09/22 17:49, Paolo Bonzini wrote: > diff --git a/tests/docker/common.rc b/tests/docker/common.rc > index 6865689..1522aab 100755 > --- a/tests/docker/common.rc > +++ b/tests/docker/common.rc > @@ -36,3 +36,11 @@ build_qemu() > $QEMU_SRC/configure $config_opts > make $MAKEFLAGS >

Re: [Qemu-devel] [PATCH v4 4/5] 390x/css: introduce maximum data address checking

* Halil Pasic [2017-09-21 20:08:40 +0200]: > The architecture mandates the addresses to be accessed on the first > indirection level (that is, the data addresses without IDA, and the > (M)IDAW addresses with (M)IDA) to be checked against an CCW format > dependent limit

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"

On Fri, 09/22 16:02, Eric Blake wrote: > On 09/21/2017 10:30 PM, Fam Zheng wrote: > > >>> Build and test automation > >>> - > >>> +Build and test automation > >> > >> Would it make sense to use something more specific here? Like "Travis > >> and Docker" or so? ... in

Re: [Qemu-devel] [PATCH v3 1/3] block: add bdrv_co_drain_end callback

On Sat, 09/23 14:14, Manos Pitsidianakis wrote: > BlockDriverState has a bdrv_co_drain() callback but no equivalent for > the end of the drain. The throttle driver (block/throttle.c) needs a way > to mark the end of the drain in order to toggle io_limits_disabled > correctly, thus

Re: [Qemu-devel] [PATCH v7 8/8] tpm: Added support for TPM emulator

On 09/24/2017 02:52 PM, Marc-André Lureau wrote: Hi Thanks for the nice update, removing the exec() code, using chardev and a private socketpair. Some comments below: On Fri, Sep 22, 2017 at 2:33 PM, Amarnath Valluri wrote: This change introduces a new TPM backend

[Qemu-devel] [PULL 09/31] MAINTAINERS: add missing PCI entries

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marcel Apfelbaum Acked-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- MAINTAINERS | 2 ++ 1 file changed, 2

[Qemu-devel] [PULL 27/31] nbd-client: Use correct macro parenthesization

From: Eric Blake If 'bs' is a complex expression, we were only casting the front half rather than the full expression. Luckily, none of the callers were passing bad arguments, but it's better to be robust up front. Signed-off-by: Eric Blake Reviewed-by:

Re: [Qemu-devel] [PATCH v11 0/5] Add support for Smartfusion2 SoC

Thanks Peter, Philippe and Alistair :) Sundeep On Thu, Sep 21, 2017 at 10:03 PM, Peter Maydell wrote: > On 20 September 2017 at 21:17, Philippe Mathieu-Daudé > wrote: > > Hi Peter, > > > > Now than Igor's patch landed, I respin Sundeep's series

[Qemu-devel] [PATCH v2] hw/pci-bridge/pcie_pci_bridge: properly handle MSI unavailability case

QEMU with the pcie-pci-bridge device crashes if the guest board doesn't support MSI, e.g. 'qemu-system-ppc64 -M prep -device pcie-pci-bridge'. This is caused by wrong pcie-pci-bridge instantiation error handling. This patch fixes this issue by falling back to legacy INTx if MSI is not available.

[Qemu-devel] [PULL 20/31] hw/display/xenfb.c: Add trace_xenfb_key_event

From: Liang Yan It may be better to add a trace event to monitor the last moment of a key event from QEMU to guest VM Signed-off-by: Liang Yan Signed-off-by: Michael Tokarev --- hw/display/trace-events | 1 + hw/display/xenfb.c | 1 + 2

[Qemu-devel] [PULL 19/31] aux-to-i2c-bridge: don't allow user to create one

From: KONRAD Frederic This device is private and is created once per aux-bus. So don't allow the user to create one from command-line. Reported-by: Thomas Huth Signed-off-by: KONRAD Frederic Reviewed-by: Thomas Huth

[Qemu-devel] [PULL 29/31] tests/boot-sector: Increase timeout to 600 seconds

From: Thomas Huth If QEMU has been compiled with the flags --enable-tcg-interpreter and --enable-debug, the guest is running incredibly slow. The pxe boot test can take up to 400 seconds when testing the pseries ppc64 machine. While we should still look for ways to speed up the

[Qemu-devel] [PULL 31/31] hw/isa/pc87312: Mark the device with user_creatable = false

From: Thomas Huth QEMU currently aborts if you try to use the device at the command line: $ ppc64-softmmu/qemu-system-ppc64 -S -machine prep -device pc87312 Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: qemu-system-ppc64: -device pc87312: Device 'parallel0'

[Qemu-devel] [PULL 22/31] chardev/baum: fix baum that releases brlapi twice

From: Liang Yan Error process of baum_chr_open needs to set brlapi null, so it won't get released twice in char_braille_finalize, which will cause "/usr/bin/qemu-system-x86_64: double free or corruption (!prev)" Signed-off-by: Liang Yan Reviewed-by: Marc-André

[Qemu-devel] [PULL 30/31] Drop gld linker usage on SunOS

From: Kamil Rytarowski This is required to be removed on SmartOS (Illumos). As of now there are no alternative supported SunOS distributions. Signed-off-by: Kamil Rytarowski Signed-off-by: Michael Tokarev --- configure | 1 - 1 file changed, 1

[Qemu-devel] [PULL 08/31] MAINTAINERS: add missing qcow2 entry

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PULL 13/31] MAINTAINERS: add missing entry for Generic Loader

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

[Qemu-devel] [PULL 15/31] MAINTAINERS: update docs/devel/ entries

From: Philippe Mathieu-Daudé moved in commit ac06724a7158 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5

[Qemu-devel] [PULL 23/31] trivial: Add missing "-m" parameter in docs/memory-hotplug.txt

From: Thomas Huth The example obviously lacks the "-m" parameter. Signed-off-by: Thomas Huth Reviewed-by: Igor Mammedov Signed-off-by: Michael Tokarev --- docs/memory-hotplug.txt | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 18/31] util/qemu-thread-posix.c: Replace OS ifdefs with CONFIG_HAVE_SEM_TIMEDWAIT

From: Peter Maydell In qemu-thread-posix.c we have two implementations of the various qemu_sem_* functions, one of which uses native POSIX sem_* and the other of which emulates them with pthread conditions. This is necessary because not all our host OSes support

[Qemu-devel] [PULL 05/31] MAINTAINERS: add missing entry for vhost

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

[Qemu-devel] [PULL 03/31] MAINTAINERS: add missing ARM entries

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- MAINTAINERS | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PULL 24/31] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

From: Alistair Francis Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. This is technically a change of behaviour as MEMTXATTRS_UNSPECIFIED sets the unspecified field to 1,

[Qemu-devel] [PULL 28/31] dma/i82374: avoid double creation of i82374 device

From: Eduardo Otubo QEMU fails when used with the following command line: ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed. Aborted (core

[Qemu-devel] [PULL 11/31] MAINTAINERS: add missing entries for throttling infra

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Signed-off-by: Michael Tokarev --- MAINTAINERS | 4 +++- 1 file changed, 3

[Qemu-devel] [PULL 14/31] MAINTAINERS: add missing Cryptography entry

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Daniel P. Berrange Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

[Qemu-devel] [PULL 25/31] osdep: Fix ROUND_UP(64-bit, 32-bit)

From: Eric Blake When using bit-wise operations that exploit the power-of-two nature of the second argument of ROUND_UP(), we still need to ensure that the mask is as wide as the first argument (done by using a ternary to force proper arithmetic promotion). Unpatched,

[Qemu-devel] [PULL 21/31] remove trailing whitespace from qemu-options.hx

Remove trailing whitespace in qemu-options documentation, as it causes reproducibility issues depending on the echo implementation used by the Makefile. Reported-By: Vagrant Cascadian Signed-off-by: Michael Tokarev --- qemu-options.hx | 4 ++-- 1 file

[Qemu-devel] [PULL 12/31] MAINTAINERS: add missing AIO entry

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)

[Qemu-devel] [PULL 16/31] MAINTAINERS: update docs/interop/ entries

From: Philippe Mathieu-Daudé moved in commit 7746cf8aab68 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Acked-by: John Snow Signed-off-by: Michael Tokarev --- MAINTAINERS | 4 ++-- 1 file

[Qemu-devel] [PULL 26/31] hw/display/virtio-gpu: Put the virtio-gpu-device into the display category

From: Thomas Huth The virtio-gpu-pci device is already in the display category, so the virtio-gpu-device should be there, too. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/display/virtio-gpu.c | 1 + 1 file changed, 1

[Qemu-devel] [PULL 17/31] filter-mirror: segfault when specifying non existent device

From: Eduardo Otubo When using filter-mirror like the example below where the interface 'ndev0' does not exist on the host, QEMU crashes into segmentation fault. $ qemu-system-x86_64 -S -machine pc -netdev user,id=ndev0 -object filter-mirror,id=test-object,netdev=ndev0 This

[Qemu-devel] [PULL 10/31] MAINTAINERS: add missing SSI entries

From: Philippe Mathieu-Daudé Alistair Francis volunteered :) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Signed-off-by: Michael Tokarev --- MAINTAINERS | 3 +++ 1 file changed, 3

[Qemu-devel] [PULL 00/31] Trivial patches for 2017-09-25

This is a collection of trivial stuff collected for quite some time. It includes various stuff, and just one series from Philippe Mathieu-Daudé (MAINTAINERS update), - other his series are in the works. Thanks, /mjt The following changes since commit 460b6c8e581aa06b86f59eebd9e52edfe7adf417:

[Qemu-devel] [PULL 01/31] configure: Remove unused code (found by shellcheck)

From: Stefan Weil smartcard_cflags is no longer needed since commit 0b22ef0f57a8910d849602bef0940edcd0553d2c. Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- configure | 1

[Qemu-devel] [PULL 02/31] Replace round_page() with TARGET_PAGE_ALIGN()

From: Kamil Rytarowski This change fixes conflict with the DragonFly BSD headers. Signed-off-by: Kamil Rytarowski Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/ppc/mac_newworld.c | 11 +++

[Qemu-devel] [PULL 04/31] MAINTAINERS: add missing STM32 entry

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1

[Qemu-devel] [PULL 07/31] MAINTAINERS: add missing Guest Agent entries

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Roth Signed-off-by: Michael Tokarev --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS

[Qemu-devel] [PULL 06/31] MAINTAINERS: add missing VMWare entry

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Dmitry Fleytman Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1

Re: [Qemu-devel] [PATCH] vmxcap: Fix output formatting

Please excuse me for the long delay with this patch. 20.07.2017 11:14, Stefan Fritsch wrote: > From: Stefan Fritsch > > One string is longer than 40 chars. Set the field width to 50. The string is this one, I guess: Miscellaneous data Hex: 0x100401e5

Re: [Qemu-devel] [PATCH] hw/isa/pc87312: Mark the device with user_creatable = false

13.09.2017 12:07, Thomas Huth wrote: > QEMU currently aborts if you try to use the device at the command > line: > > $ ppc64-softmmu/qemu-system-ppc64 -S -machine prep -device pc87312 > Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: > qemu-system-ppc64: -device pc87312: Device

Re: [Qemu-devel] [PATCH] Drop gld linker usage on SunOS

11.09.2017 23:50, Kamil Rytarowski wrote: > This is required to be removed on SmartOS (Illumos). I take this as granted - I haven't verified this. > As of now there are no alternative supported SunOS distributions. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

22.09.2017 06:06, Thomas Huth wrote: > If QEMU has been compiled with the flags --enable-tcg-interpreter and > --enable-debug, the guest is running incredibly slow. The pxe boot test > can take up to 400 seconds when testing the pseries ppc64 machine. While > we should still look for ways to speed

Re: [Qemu-devel] [[PATCH] dma/i82374: avoid double creation of i82374 device

15.09.2017 12:06, Eduardo Otubo wrote: > QEMU fails when used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion > `!bus->dma[0] && !bus->dma[1]' failed. > Aborted

Re: [Qemu-devel] [PATCH] nbd-client: Use correct macro parenthesization

19.09.2017 00:46, Eric Blake wrote: > If 'bs' is a complex expression, we were only casting the front half > rather than the full expression. Luckily, none of the callers were > passing bad arguments, but it's better to be robust up front. Applied to -trivial. /mjt

Re: [Qemu-devel] [PATCH] hw/display/virtio-gpu: Put the virtio-gpu-device into the display category

15.09.2017 11:46, Thomas Huth wrote: > The virtio-gpu-pci device is already in the display category, so the > virtio-gpu-device should be there, too. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2] osdep: Fix ROUND_UP(64-bit, 32-bit)

14.09.2017 16:49, Eric Blake wrote: > When using bit-wise operations that exploit the power-of-two > nature of the second argument of ROUND_UP(), we still need to > ensure that the mask is as wide as the first argument (done > by using a ternary to force proper arithmetic promotion). > Unpatched,

Re: [Qemu-devel] [PATCH v2 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

16.09.2017 00:56, Alistair Francis wrote: > Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes > let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. > > This is technically a change of behaviour as MEMTXATTRS_UNSPECIFIED sets > the unspecified field to 1, but

Re: [Qemu-devel] [PATCH] trivial: Add missing "-m" parameter in docs/memory-hotplug.txt

19.09.2017 12:02, Thomas Huth wrote: > The example obviously lacks the "-m" parameter. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH] chardev/baum: fix baum that releases brlapi twice

23.09.2017 01:55, Liang Yan wrote: > Error process of baum_chr_open needs to set brlapi null, so it won't > get released twice in char_braille_finalize, which will cause > "/usr/bin/qemu-system-x86_64: double free or corruption (!prev)" Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v7 8/8] tpm: Added support for TPM emulator

Hi Thanks for the nice update, removing the exec() code, using chardev and a private socketpair. Some comments below: On Fri, Sep 22, 2017 at 2:33 PM, Amarnath Valluri wrote: > This change introduces a new TPM backend driver that can communicate with > swtpm(software

Re: [Qemu-devel] [PULL 0/3] slirp updates

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170924180848.19168-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PULL 0/3] slirp updates === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [PULL 3/3] slirp: Add a special case for the NULL socket

From: Kevin Cernekee NULL sockets are used for NDP, BOOTP, and other critical operations. If the topmost mbuf in a NULL session is blocked pending resolution, it may cause problems if it blocks other packets with a NULL socket. So do not add mbufs with a NULL socket field

[Qemu-devel] [PULL 1/3] slirp: Add explanation for hostfwd parsing failure

From: "Dr. David Alan Gilbert" e.g. ./x86_64-softmmu/qemu-system-x86_64 -nographic -netdev 'user,id=vnet,hostfwd=:555.0.0.0:0-:22' qemu-system-x86_64: -netdev user,id=vnet,hostfwd=:555.0.0.0:0-:22: Invalid host forwarding rule ':555.0.0.0:0-:22' (Bad host address)

[Qemu-devel] [PULL 2/3] slirp: Fix intermittent send queue hangs on a socket

From: Kevin Cernekee if_output() originally sent one mbuf per call and used the slirp->next_m variable to keep track of where it left off. But nowadays it tries to send all of the mbufs from the fastq, and one mbuf from each session on the batchq. The next_m variable is

[Qemu-devel] [PULL 0/3] slirp updates

warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ The following changes since commit 460b6c8e581aa06b86f59eebd9e52edfe7adf417: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-09-23 12:55:40 +0100) are available in the git repository

Re: [Qemu-devel] [PATCH 2/2] slirp: Add a special case for the NULL socket

Kevin Cernekee, on mer. 20 sept. 2017 13:42:05 -0700, wrote: > NULL sockets are used for NDP, BOOTP, and other critical operations. > If the topmost mbuf in a NULL session is blocked pending resolution, > it may cause problems if it blocks other packets with a NULL socket. > So do not add mbufs

Re: [Qemu-devel] [PATCH 1/2] slirp: Fix intermittent send queue hangs on a socket

Hello, Kevin Cernekee, on mer. 20 sept. 2017 13:42:04 -0700, wrote: > if_output() originally sent one mbuf per call and used the slirp->next_m > variable to keep track of where it left off. But nowadays it tries to > send all of the mbufs from the fastq, and one mbuf from each session on > the

Re: [Qemu-devel] [PATCH] chardev/baum: fix baum that releases brlapi twice

- Original Message - > Error process of baum_chr_open needs to set brlapi null, so it won't > get released twice in char_braille_finalize, which will cause > "/usr/bin/qemu-system-x86_64: double free or corruption (!prev)" > > Signed-off-by: Liang Yan Reviewed-by:

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

On 24/09/17 16:43, Marcel Apfelbaum wrote: > Hi Mark, > >>> Based on the commit message, I assume this change is guest-visible. If >>> so, should it be made dependent on a compat property, so that it doesn't >>> cause problems with migration? >> >> In order to enable 32-bit IO accesses the PCI

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

On 23/09/2017 11:23, Mark Cave-Ayland wrote: On 22/09/17 23:18, Laszlo Ersek wrote: On 09/22/17 14:18, Mark Cave-Ayland wrote: Whilst the underlying PCI bridge implementation supports 32-bit PCI IO accesses, unfortunately they are truncated at the legacy 64K limit. Signed-off-by: Mark

[Qemu-devel] [PATCH 5/7] macio: use object link between MACIO_IDE and MAC_DBDMA object

Using a standard QOM object link we can pass a reference to the MAC_DBDMA controller to the MACIO_IDE object which removes the last external parameter to macio_ide_register_dma(). Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c|9 ++---

[Qemu-devel] [PATCH 7/7] mac_dbdma: change DBDMA_kick to a MAC_DBDMA type method

With this we can now remove the last external method used to interface between macio and DBDMA. Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c |3 ++- hw/misc/macio/mac_dbdma.c | 19 ++- include/hw/ppc/mac_dbdma.h |4 +---

[Qemu-devel] [PATCH 3/7] mac_dbdma: remove DBDMA_init() function

Instead we can now instantiate the MAC_DBDMA object directly within the macio device. We also add the DBDMA device as a child property so that it is possible to retrieve later. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/mac_dbdma.c | 14 --

[Qemu-devel] [PATCH 6/7] mac_dbdma: change DBDMA_register_channel to a MAC_DBDMA type method

Using this we can change the MACIO_IDE instance to register the channel itself via a type method instead of requiring a separate DBDMA_register_channel() function. As a consequence of this it is now possible to remove the old external macio_ide_register_dma() function. Signed-off-by: Mark

[Qemu-devel] [PATCH 2/7] mac_dbdma: QOMify

Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/mac_dbdma.c | 59 include/hw/ppc/mac_dbdma.h |6 + 2 files changed, 55 insertions(+), 10 deletions(-) diff --git a/hw/misc/macio/mac_dbdma.c

[Qemu-devel] [PATCH 4/7] macio: pass channel into MACIOIDEState via qdev property

One of the reasons macio_ide_register_dma() needs to exist is because the channel id isn't passed into the MACIO_IDE object. Pass in the channel id using a qdev property to remove this requirement. Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c| 10

[Qemu-devel] [PATCH 1/7] mac_dbdma: remove unused IO fields from DBDMAState

These fields were used to manually handle IO requests that weren't aligned to a sector boundary before this feature was supported by the block API. Once the block API changed to support byte-aligned IO requests, the macio controller was switched over to use it in commit be1e343 but these fields

[Qemu-devel] [PATCH 0/7] mac_dbdma: tidy-up and QOMify

Whilst looking at implementing another DBDMA device for the Mac machines I noticed a couple of things: firstly there were some unused fields still in DBDMAState, and secondly the existing code still used global functions to register DMA channels and handle the relationship between macio IDE and

Re: [Qemu-devel] [PATCH] docker: add installation to build tests

- Original Message - > From: "Fam Zheng" > To: "Paolo Bonzini" > Cc: "alex bennee" , qemu-devel@nongnu.org > Sent: Sunday, September 24, 2017 4:54:39 AM > Subject: Re: [Qemu-devel] [PATCH] docker: add installation to build

Re: [Qemu-devel] [PATCH] qemu.py: Call logging.basicConfig() automatically

Dne 22.9.2017 v 11:40 Kevin Wolf napsal(a): > Am 22.09.2017 um 10:37 hat Lukáš Doktor geschrieben: >> But we should focus on fixing all the entry points (either initialize >> from all of them, or force-create the root logger based on the >> entry-point requirements). Kevin, could you please share

Re: [Qemu-devel] xen/disk: don't leak stack data via response ring

23.09.2017 19:05, Michael Tokarev wrote: > 28.06.2017 01:04, Stefano Stabellini wrote: >> Rather than constructing a local structure instance on the stack, fill >> the fields directly on the shared ring, just like other (Linux) >> backends do. Build on the fact that all response structure flavors