Re: [Qemu-devel] [PATCH for-2.12] sam460ex: Fix timer frequency and clock multipliers

2018-04-06 Thread David Gibson
On Fri, Apr 06, 2018 at 12:42:48AM +0200, BALATON Zoltan wrote: > We only emulate timer running at CPU frequency which is what most > guests expect so set the frequency to match real hardware. This also > allows setting clock multipliers which caused slowdown previously due > to wrong timer

Re: [Qemu-devel] some ROMs questions

2018-04-06 Thread David Gibson
On Fri, Apr 06, 2018 at 01:59:03PM +0200, BALATON Zoltan wrote: > On Fri, 6 Apr 2018, Michael Tokarev wrote: > > 02.04.2018 17:30, BALATON Zoltan wrote: > > > On Mon, 2 Apr 2018, Michael Tokarev wrote: > > > > roms/u-boot-sam460ex/tools/updater/stubs.c - > > > > it is some strange symlink pointing

[Qemu-devel] [qemu RFC] qapi: add "firmware.json"

2018-04-06 Thread Laszlo Ersek
Add a schema that describes the properties of virtual machine firmware. Each firmware executable installed on a host system should come with a JSON file that conforms to this schema, and informs the management applications about the firmware's properties. In addition, a configuration directory

[Qemu-devel] block-stream/commit and mixing internal and external snapshots

2018-04-06 Thread Eric Blake
Perhaps others have already known this, but I just realized that if you mix internal and external snapshots, you can set yourself up for massive failures when trying to use block-stream or block-commit to consolidate data across the external backing chain, without also thinking about the internal

[Qemu-devel] [Bug 1191326] Re: QNX 4 doesn't boot on qemu >= 1.3

2018-04-06 Thread Lukas Jirkovsky
I wonder - would be a record using rr of any help? I can create record for QEMU 1.2.0 where it works and on current QEMU. Also, I did a bit of debugging myself around the DMA code as per comment #3 it was introduced in a commit that changed some of the DMA. What I did was that I added some debug

[Qemu-devel] [PATCH] xen/pt: use address_space_memory object for memory region hooks

2018-04-06 Thread Igor Druzhinin
Commit 99605175c (xen-pt: Fix PCI devices re-attach failed) introduced a subtle bug. As soon as the guest switches off Bus Mastering on the device it immediately causes all the BARs be unmapped due to the DMA address space of the device being changed. This is undesired behavior because the guest

Re: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1523038800-2494-1-git-send-email-c...@braap.org Subject: [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets === TEST

Re: [Qemu-devel] [RfC PATCH] Add udmabuf misc device

2018-04-06 Thread Dongwon Kim
On Fri, Apr 06, 2018 at 03:36:03PM +0300, Oleksandr Andrushchenko wrote: > On 04/06/2018 02:57 PM, Gerd Hoffmann wrote: > > Hi, > > > >>>I fail to see any common ground for xen-zcopy and udmabuf ... > >>Does the above mean you can assume that xen-zcopy and udmabuf > >>can co-exist as two

Re: [Qemu-devel] -icount changes physical address assignments in QEMU 2.10/2.11

2018-04-06 Thread alarson
"Mark Cave-Ayland" wrote on 04/06/2018 09:14:14 AM: > From: "Mark Cave-Ayland" > To: alar...@ddci.com, "Peter Maydell" > Cc: "Stefan Weil" , "QEMU Developers" >

Re: [Qemu-devel] -icount changes physical address assignments in QEMU 2.10/2.11

2018-04-06 Thread alarson
"Peter Maydell" wrote on 04/06/2018 12:21:37 PM: > On 6 April 2018 at 18:06, wrote: > > > > FWIW, the compile had some anomalous behavior: > > > > .../qemu-2.12.0-rc2/scripts/feature_to_c.sh: line 71: /usr/bin/sed: > > Invalid argument > > > > line

[Qemu-devel] [PATCH 1/1] Make qemu-bridge-helper work in macOS and FreeBSD

2018-04-06 Thread Nikhil Balachandra
Add macOS and FreeBSD support to the qemu-bridge-helper. Differences when compared to linux version. 1) Does no drop privileges at the start of the process and run as root throughout the lifetime of the process there by increasing the risk incase of security vulnerability. 2) Does not

[Qemu-devel] [PATCH v2 for-2.12] tap: set vhostfd passed from qemu cli to non-blocking

2018-04-06 Thread Brijesh Singh
A guest boot hangs while probing the network interface when iommu_platform=on is used. The following qemu cli hangs without this patch: # $QEMU \ -netdev tap,fd=3,id=hostnet0,vhost=on,vhostfd=4 3<>/dev/tap67 4<>/dev/host-net \ -device

Re: [Qemu-devel] [PATCH for-2.12] vfio-ccw: fix memory leak in vfio_ccw_realize()

2018-04-06 Thread Greg Kurz
On Fri, 6 Apr 2018 18:54:13 +0200 Cornelia Huck wrote: > On Fri, 06 Apr 2018 17:14:19 +0200 > Greg Kurz wrote: > > > The vfio_ccw_realize() function currently leaks vcdev->vdev.name if > > the subchannel is already attached or if vfio_get_device() fails. > >

[Qemu-devel] [PATCH v2 07/17] target/mips: convert to DisasContextBase

2018-04-06 Thread Emilio G. Cota
Reviewed-by: Philippe Mathieu-Daudé Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 346 1 file changed, 175

Re: [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-04-06 Thread Laszlo Ersek
On 04/06/18 20:10, Eric Blake wrote: > On 04/06/2018 12:28 PM, Laszlo Ersek wrote: > >> I've created an RFC-level "qapi/firmware.json" schema file, based on >> this discussion. It "builds", and the generated documentation looks >> acceptable, superficially speaking. >> >> Before I post

[Qemu-devel] [PATCH v2 11/17] target/s390x: convert to DisasContextBase

2018-04-06 Thread Emilio G. Cota
Notes: - Did not convert {num,max}_insns and is_jmp, since the corresponding code will go away in the next patch. - Avoided a checkpatch error in use_exit_tb. - As suggested by David, (1) Drop ctx.pc and use ctx.base.pc_next instead, and (2) Rename ctx.next_pc to ctx.pc_tmp and add a

[Qemu-devel] [PATCH v2 10/17] target/s390x: convert to DisasJumpType

2018-04-06 Thread Emilio G. Cota
The only non-trivial modification is the use of DISAS_TOO_MANY in the same way is used by the generic translation loop. Acked-by: Cornelia Huck Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Cc: David Hildenbrand

[Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType

2018-04-06 Thread Emilio G. Cota
Reviewed-by: Philippe Mathieu-Daudé Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 186 +++- 1 file changed, 91

[Qemu-devel] [PATCH v2 13/17] target/openrisc: convert to DisasContextBase

2018-04-06 Thread Emilio G. Cota
While at it, set is_jmp to DISAS_NORETURN when generating an exception. Cc: Stafford Horne Signed-off-by: Emilio G. Cota --- target/openrisc/translate.c | 93 ++--- 1 file changed, 46 insertions(+), 47 deletions(-) diff

[Qemu-devel] [PATCH v2 12/17] target/s390x: convert to TranslatorOps

2018-04-06 Thread Emilio G. Cota
Note: I looked into dropping dc->do_debug. However, I don't see an easy way to do it given that TOO_MANY is also valid when we just translate more than max_insns. Thus, the check for do_debug in "case DISAS_PC_CC_UPDATED" would still need additional state to know whether or not we came from

[Qemu-devel] [PATCH v2 08/17] target/mips: use *ctx for DisasContext

2018-04-06 Thread Emilio G. Cota
No changes to the logic here; this is just to make the diff that follows easier to read. While at it, remove the unnecessary 'struct' in 'struct TranslationBlock'. Note that checkpatch complains with a false positive: ERROR: space prohibited after that '&' (ctx:WxW) #75: FILE:

[Qemu-devel] [PATCH v2 15/17] target/riscv: convert to DisasJumpType

2018-04-06 Thread Emilio G. Cota
Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Emilio G. Cota --- target/riscv/translate.c | 72

[Qemu-devel] [PATCH v2 16/17] target/riscv: convert to DisasContextBase

2018-04-06 Thread Emilio G. Cota
Notes: - Did not convert {num,max}_insns, since the corresponding code will go away in the next patch. - ctx->pc becomes ctx->base.pc_next, and ctx->next_pc becomes ctx->pc_tmp. While at it, convert the remaining tb->cflags readers to tb_cflags(). Cc: Michael Clark Cc:

[Qemu-devel] [PATCH v2 14/17] target/openrisc: convert to TranslatorOps

2018-04-06 Thread Emilio G. Cota
Notes: - Changed the num_insns test in insn_start to check for dc->base.num_insns > 1, since when tb_start is first called in a TB, base.num_insns is already set to 1. - Removed DISAS_NEXT from the switch in tb_stop; use DISAS_TOO_MANY instead. - Added an assert_not_reached on tb_stop for

[Qemu-devel] [PATCH v2 17/17] target/riscv: convert to TranslatorOps

2018-04-06 Thread Emilio G. Cota
Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Emilio G. Cota --- target/riscv/translate.c | 158

[Qemu-devel] [PATCH v2 01/17] translator: merge max_insns into DisasContextBase

2018-04-06 Thread Emilio G. Cota
While at it, use int for both num_insns and max_insns to make sure we have same-type comparisons. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota --- include/exec/translator.h | 8 accel/tcg/translator.c | 21

[Qemu-devel] [PATCH v2 04/17] target/sparc: convert to DisasContextBase

2018-04-06 Thread Emilio G. Cota
Notes: - pc and npc are left unmodified, since they can point to out-of-TB jump targets. - Got rid of last_pc in gen_intermediate_code(), using base.pc_next instead. Only update pc_next (1) on a breakpoint (so that tb->size includes the insn), and (2) after reading the current instruction

[Qemu-devel] [PATCH v2 02/17] target/sh4: convert to TranslatorOps

2018-04-06 Thread Emilio G. Cota
This was fairly straightforward since it had already been converted to DisasContextBase; just had to add TARGET_TOO_MANY to the switch in tb_stop. Reviewed-by: Richard Henderson Cc: Aurelien Jarno Signed-off-by: Emilio G. Cota

[Qemu-devel] [PATCH v2 05/17] target/sparc: convert to TranslatorOps

2018-04-06 Thread Emilio G. Cota
Notes: - Moved the cross-page check from the end of translate_insn to init_disas_context. Tested-by: Mark Cave-Ayland Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Signed-off-by: Emilio G. Cota

[Qemu-devel] [PATCH v2 03/17] target/sparc: convert to DisasJumpType

2018-04-06 Thread Emilio G. Cota
Reviewed-by: Richard Henderson Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Signed-off-by: Emilio G. Cota --- target/sparc/translate.c | 27 +++ 1 file changed, 15

[Qemu-devel] [PATCH v2 09/17] target/mips: convert to TranslatorOps

2018-04-06 Thread Emilio G. Cota
Notes: - DISAS_TOO_MANY replaces the former "break" in the translation loop. However, care must be taken not to overwrite a previous condition in is_jmp; that's why in translate_insn we first check is_jmp and return if it's != DISAS_NEXT. - Added an assert in translate_insn, before exiting

[Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets

2018-04-06 Thread Emilio G. Cota
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg00445.html Changes since v1: - Rebase onto master - Add R-b's - Add riscv conversion - s390x: + fix comment in s390x_tr_breakpoint_check You can fetch this series from: https://github.com/cota/qemu/tree/trloop-conv-v2 Thanks,

Re: [Qemu-devel] [PULL 10/25] aarch64-linux-user: Add support for SVE signal frame records

2018-04-06 Thread Peter Maydell
On 6 April 2018 at 19:12, Peter Maydell wrote: > On 9 March 2018 at 17:26, Peter Maydell wrote: >> From: Richard Henderson >> >> Depending on the currently selected size of the SVE vector registers, >> we can

Re: [Qemu-devel] [PULL for-2.12 0/3] Qcrypto next patches

2018-04-06 Thread Peter Maydell
On 6 April 2018 at 14:30, Daniel P. Berrangé wrote: > The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: > > Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PULL 10/25] aarch64-linux-user: Add support for SVE signal frame records

2018-04-06 Thread Peter Maydell
On 9 March 2018 at 17:26, Peter Maydell wrote: > From: Richard Henderson > > Depending on the currently selected size of the SVE vector registers, > we can either store the data within the "standard" allocation, or we > may beedn to

Re: [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-04-06 Thread Eric Blake
On 04/06/2018 12:28 PM, Laszlo Ersek wrote: > I've created an RFC-level "qapi/firmware.json" schema file, based on > this discussion. It "builds", and the generated documentation looks > acceptable, superficially speaking. > > Before I post "qapi/firmware.json" for getting comments, I'd like to

[Qemu-devel] [Bug 1761535] Re: qemu-aarch64-static docker arm64v8/openjdk coredump

2018-04-06 Thread Peter Maydell
I realized I had a javac lying around from last time somebody wanted me to debug a java problem, and I'm also seeing SEGVs with simpler programs like ls (!), so I'll have a look at those and hopefully that will be the same cause as what you're seeing. -- You received this bug notification

Re: [Qemu-devel] [PULL 01/20] sys_membarrier: fix up include directives

2018-04-06 Thread Eric Blake
On 04/06/2018 12:11 PM, Paolo Bonzini wrote: > From: Bruce Rogers > > Our rule right now is to use <> for external headers only. > util/sys_membarrier.c violates that. Fix it up. > > Signed-off-by: Bruce Rogers > Message-Id:

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 3/3] target/arm: Add the XML dynamic generation

2018-04-06 Thread Abdallah Bouassida
Hi Alex, First of all, thanks for the review! >> +static int arm_gdb_get_sysreg(CPUARMState *env, uint8_t *buf, int reg) >> +{ >> +ARMCPU *cpu = arm_env_get_cpu(env); >> +const ARMCPRegInfo *ri; >> +uint32_t key; >> + >> +key = cpu->dyn_xml.cpregs_keys[reg]; >> +ri =

Re: [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

2018-04-06 Thread Laszlo Ersek
On 03/08/18 11:17, Daniel P. Berrangé wrote: > On Thu, Mar 08, 2018 at 08:52:45AM +0100, Gerd Hoffmann wrote: >> Hi, >> [*] Open question: Who, between QEMU and libvirt, should define the said firmware metadata format and file? >>> >>> IMHO QEMU should be defining the format, because

[Qemu-devel] [PULL 20/20] Add missing bit for SSE instr in VEX decoding

2018-04-06 Thread Paolo Bonzini
From: Eugene Minibaev The 2-byte VEX prefix imples a leading 0Fh opcode byte. Signed-off-by: Eugene Minibaev Signed-off-by: Paolo Bonzini --- target/i386/translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 18/20] dump: Fix build with newer gcc

2018-04-06 Thread Paolo Bonzini
From: Eric Blake gcc 8 on rawhide is picky enough to complain: /home/dummy/qemu/dump.c: In function 'create_header32': /home/dummy/qemu/dump.c:817:5: error: 'strncpy' output truncated before terminating nul copying 8 bytes from a string of the same length

[Qemu-devel] [PULL 15/20] qemu-pr-helper: Daemonize before dropping privileges

2018-04-06 Thread Paolo Bonzini
From: Michal Privoznik After we've dropped privileges it might be not possible to write pidfile. For instance, if this binary is run as root (because user wants it to write pidfile to some privileged location) writing pidfile fails because privileges are dropped before we

[Qemu-devel] [PULL 17/20] device-crash-test: Remove fixed isa-fdc entry

2018-04-06 Thread Paolo Bonzini
From: Thomas Huth Fixed by commit b3da551 ("fdc: Exit if ISA controller does not support DMA", 2018-03-16). Signed-off-by: Thomas Huth Signed-off-by: Paolo Bonzini --- scripts/device-crash-test | 1 - 1 file changed, 1 deletion(-)

[Qemu-devel] [PULL 14/20] virtio-serial: fix heapover-flow

2018-04-06 Thread Paolo Bonzini
From: linzhecheng Check device having the feature of VIRTIO_CONSOLE_F_EMERG_WRITE before get config->emerg_wr. It is neccessary because sizeof(virtio_console_config) is 8 byte if VirtIOSerial doesn't have the feature of VIRTIO_CONSOLE_F_EMERG_WRITE(see

[Qemu-devel] [PULL 19/20] maint: Add .mailmap entries for patches claiming list authorship

2018-04-06 Thread Paolo Bonzini
From: Eric Blake The list did not author any patches, but it does rewrite the 'From:' header of messages sent from any domain with restrictive SPF policies that would otherwise prevent the message from reaching all list recipients. If a maintainer is not careful to undo the

[Qemu-devel] [PULL 16/20] qemu-pr-helper: Write pidfile more often

2018-04-06 Thread Paolo Bonzini
From: Michal Privoznik Let's write pidfile even if user did not request --daemon but they requested just --pidfile. Libvirt will use exactly this. Signed-off-by: Michal Privoznik Signed-off-by: Paolo Bonzini ---

Re: [Qemu-devel] -icount changes physical address assignments in QEMU 2.10/2.11

2018-04-06 Thread Peter Maydell
On 6 April 2018 at 18:06, wrote: > "Peter Maydell" wrote on 04/06/2018 09:51:55 > AM: > >> I've now done this, and can reproduce the problem. So the >> issue is generic to 32-bit hosts. > > Supporting evidence: I compiled Cygwin/MINGW with x86_64 and

[Qemu-devel] [PULL 07/20] i386/hyperv: error out if features requested but unsupported

2018-04-06 Thread Paolo Bonzini
From: Roman Kagan In order to guarantee compatibility on migration, QEMU should have complete control over the features it announces to the guest via CPUID. However, for a number of Hyper-V-related cpu properties, if the corresponding feature is not supported by the

[Qemu-devel] [PULL 12/20] hw/dma/i82374: Avoid double creation of the 82374 controller

2018-04-06 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé QEMU fails when used with the following command line: ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p -device i82374 qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed. The 40p machine

[Qemu-devel] [PULL 11/20] hw/scsi: support SCSI-2 passthrough without PI

2018-04-06 Thread Paolo Bonzini
From: Daniel Henrique Barboza QEMU SCSI code makes assumptions about how the PROTECT and BYTCHK works in the protocol, denying support for PI (Protection Information) in case the guest OS requests it. However, in SCSI versions 2 and older, there is no PI concept in

[Qemu-devel] [PULL 10/20] scsi-disk: allow customizing the SCSI version

2018-04-06 Thread Paolo Bonzini
We would like to have different behavior for passthrough devices depending on the SCSI version they expose. To prepare for that, allow the user of emulated devices to specify the desired SCSI level, and adjust the emulation according to the property value. The next patch will set the level for

[Qemu-devel] [PULL 09/20] scsi-disk: Don't enlarge min_io_size to max_io_size

2018-04-06 Thread Paolo Bonzini
From: Fam Zheng Some backends report big max_io_sectors. Making min_io_size the same value in this case will make it impossible for guest to align memory, therefore the disk may not be usable at all. Do not enlarge them when they are zero. Reported-by: David Gibson

[Qemu-devel] [PULL 04/20] memfd: fix vhost-user-test on non-memfd capable host

2018-04-06 Thread Paolo Bonzini
From: Marc-André Lureau On RHEL7, memfd is not supported, and vhost-user-test fails: TEST: tests/vhost-user-test... (pid=10248) /x86_64/vhost-user/migrate: qemu-system-x86_64: -object memory-backend-memfd,id=mem,size=2M,: failed to create memfd FAIL There is a

[Qemu-devel] [PULL 06/20] i386/hyperv: add hv-frequencies cpu property

2018-04-06 Thread Paolo Bonzini
From: Roman Kagan In order to guarantee compatibility on migration, QEMU should have complete control over the features it announces to the guest via CPUID. However, the availability of Hyper-V frequency MSRs (HV_X64_MSR_TSC_FREQUENCY and HV_X64_MSR_APIC_FREQUENCY) depends

[Qemu-devel] [PULL 13/20] kvmclock: fix clock_is_reliable on migration from QEMU < 2.9

2018-04-06 Thread Paolo Bonzini
From: Michael Chapman When migrating from a pre-2.9 QEMU, no clock_is_reliable flag is transferred. We should assume that the source host has an unreliable KVM_GET_CLOCK, rather than using whatever was determined locally, to ensure that any drift from the TSC-based value

[Qemu-devel] [PULL 02/20] target/i386: Fix andn instruction

2018-04-06 Thread Paolo Bonzini
From: Alexandro Sanchez Bach In commit 7073fbada733c8d10992f00772c9b9299d740e9b, the `andn` instruction was implemented via `tcg_gen_andc` but passes the operands in the wrong order: - X86 defines `andn dest,src1,src2` as: dest = ~src1 & src2 - TCG defines `andc dest,src1,src2`

[Qemu-devel] [PULL 08/20] configure: Add missing configure options to help text

2018-04-06 Thread Paolo Bonzini
From: Thomas Huth We forgot to mention --with-git, --libexecdir and --with-pkgversion so far. Signed-off-by: Thomas Huth Message-Id: <1522163370-18544-1-git-send-email-th...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 03/20] scripts/checkpatch.pl: Bug fix

2018-04-06 Thread Paolo Bonzini
From: Su Hang Commit 2b9aef6fcd96ba7ed8c1ee723e391901852d344c introduced a regression: checkpatch.pl started complaining about the following valid pattern: do { /* something */ } while (condition); Fix the script to once again permit this pattern. Signed-off-by:

[Qemu-devel] [PULL 00/20] Miscellaneous patches for QEMU 2.12-rc

2018-04-06 Thread Paolo Bonzini
The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: Update version for v2.12.0-rc2 release (2018-04-04 20:37:20 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

[Qemu-devel] [PULL 05/20] target/i386: WHPX: set CPUID_EXT_HYPERVISOR bit

2018-04-06 Thread Paolo Bonzini
From: "Justin Terry (VM)" Implements the CPUID trap for CPUID 1 to include the CPUID_EXT_HYPERVISOR flag in the ECX results. This was preventing some older linux kernels from booting when trying to access MSR's that dont make sense when virtualized. Signed-off-by: Justin

[Qemu-devel] [PULL 01/20] sys_membarrier: fix up include directives

2018-04-06 Thread Paolo Bonzini
From: Bruce Rogers Our rule right now is to use <> for external headers only. util/sys_membarrier.c violates that. Fix it up. Signed-off-by: Bruce Rogers Message-Id: <20180329151018.15319-1-brog...@suse.com> Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v11 01/15] migration: Set error state in case of error

2018-04-06 Thread Juan Quintela
Daniel P. Berrange wrote: > On Fri, Mar 16, 2018 at 05:49:07PM +, Daniel P. Berrangé wrote: >> On Fri, Mar 16, 2018 at 12:53:49PM +0100, Juan Quintela wrote: >> > Signed-off-by: Juan Quintela >> > --- >> > migration/ram.c | 20

Re: [Qemu-devel] -icount changes physical address assignments in QEMU 2.10/2.11

2018-04-06 Thread alarson
"Peter Maydell" wrote on 04/06/2018 09:51:55 AM: > I've now done this, and can reproduce the problem. So the > issue is generic to 32-bit hosts. Supporting evidence: I compiled Cygwin/MINGW with x86_64 and the resulting binaries work properly FWIW, the compile had

Re: [Qemu-devel] [PATCH] iotests: Split 214 off of 122

2018-04-06 Thread Eric Blake
On 04/06/2018 11:41 AM, Max Reitz wrote: > Commit abd3622cc03cf41ed542126a540385f30a4c0175 added a case to 122 > regarding how the qcow2 driver handles an incorrect compressed data > length value. This does not really fit into 122, as that file is > supposed to contain qemu-img convert test

Re: [Qemu-devel] [PATCH for-2.12] vfio-ccw: fix memory leak in vfio_ccw_realize()

2018-04-06 Thread Cornelia Huck
On Fri, 06 Apr 2018 17:14:19 +0200 Greg Kurz wrote: > The vfio_ccw_realize() function currently leaks vcdev->vdev.name if > the subchannel is already attached or if vfio_get_device() fails. > > This happens because vcdev->vdev.name is expected to be freed in > vfio_put_device()

Re: [Qemu-devel] [PULL for-2.12 0/1] target/hppa: seabios-hppa update

2018-04-06 Thread Peter Maydell
On 6 April 2018 at 14:18, Richard Henderson wrote: > Helge Deller has fixed some bios bugs and has asked > that I update qemu thus. > > > r~ > > > The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: > > Update version for v2.12.0-rc2

Re: [Qemu-devel] [PATCH 0/3] Add a CentOS test image to run docker tests

2018-04-06 Thread Paolo Bonzini
On 04/04/2018 04:51, Fam Zheng wrote: > Docker testing on patchew has long suffered from 'make check' hangings. The > cleanness of VM testing is the cure. Now let's add a CentOS 7 image to run the > tests. It's purely ad-hoc, but hopefully still easy to understand and use for > everyone. > > The

Re: [Qemu-devel] [PATCH] Add missing bit for SSE instr in VEX decoding

2018-04-06 Thread Paolo Bonzini
On 06/04/2018 15:41, Eugene Minibaev wrote: > Signed-off-by: Eugene Minibaev > --- > It seems that x86 vector instructions encoded in VEX are not properly > decoded because of missing bit, here is the example: Applied, thanks! Paolo > IN: > 0x08048060: c5 f9 6f c1

Re: [Qemu-devel] [PATCH] iotests: Split 214 off of 122

2018-04-06 Thread Max Reitz
Sorry, Berto, forgot to CC you again... On 2018-04-06 18:41, Max Reitz wrote: > Commit abd3622cc03cf41ed542126a540385f30a4c0175 added a case to 122 > regarding how the qcow2 driver handles an incorrect compressed data > length value. This does not really fit into 122, as that file is > supposed

[Qemu-devel] [PATCH] iotests: Split 214 off of 122

2018-04-06 Thread Max Reitz
Commit abd3622cc03cf41ed542126a540385f30a4c0175 added a case to 122 regarding how the qcow2 driver handles an incorrect compressed data length value. This does not really fit into 122, as that file is supposed to contain qemu-img convert test cases, which this case is not. So this patch splits it

Re: [Qemu-devel] -icount changes physical address assignments in QEMU 2.10/2.11

2018-04-06 Thread Peter Maydell
On 6 April 2018 at 15:51, Peter Maydell wrote: > On 6 April 2018 at 14:33, Peter Maydell wrote: >> On this end I should try this with a 32-bit Linux host. > > I've now done this, and can reproduce the problem. So the > issue is generic to

[Qemu-devel] [Bug 855800] Re: KVM crashes when attempting to restart migration

2018-04-06 Thread Thomas Huth
** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/855800 Title: KVM crashes when attempting to restart migration Status in

Re: [Qemu-devel] [PATCH for-2.12] tap: set vhostfd passed from qemu cli to non-blocking

2018-04-06 Thread Brijesh Singh
On 04/06/2018 10:44 AM, Eric Blake wrote: On 04/06/2018 07:03 AM, Brijesh Singh wrote: A guest boot hangs while probing the network interface when iommu_platform=on is used. The following qemu cli hangs without this patch: # $QEMU \ -netdev tap,fd=3,id=hostnet0,vhost=on,vhostfd=4

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-04-06 Thread Halil Pasic
On 04/05/2018 06:38 PM, Tony Krowiak wrote: > On 04/03/2018 05:36 AM, Cornelia Huck wrote: >> On Mon, 2 Apr 2018 12:36:27 -0400 >> Tony Krowiak  wrote: >> >>> On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: > On 

Re: [Qemu-devel] [PATCH for-2.12] tap: set vhostfd passed from qemu cli to non-blocking

2018-04-06 Thread Eric Blake
On 04/06/2018 07:03 AM, Brijesh Singh wrote: > A guest boot hangs while probing the network interface when > iommu_platform=on is used. > > The following qemu cli hangs without this patch: > > # $QEMU \ > -netdev tap,fd=3,id=hostnet0,vhost=on,vhostfd=4 3<>/dev/tap67 > 4<>/dev/host-net \ >

Re: [Qemu-devel] [PATCH] iotests: 122 needs at least two refcount bits now

2018-04-06 Thread Max Reitz
On 2018-04-06 17:32, Eric Blake wrote: > On 04/06/2018 10:17 AM, Max Reitz wrote: >> The new test case for compressed clusters (added in commit >> abd3622cc03cf41ed542126a540385f30a4c0175) requires two refcount bits to >> succeed, so we need to skip the test when refcount_bits=1 was requested. >

Re: [Qemu-devel] [PATCH 0/2 for-2.12?] iotests: Skip 181 and 201 without userfaultfd

2018-04-06 Thread Max Reitz
On 2018-04-06 17:30, Eric Blake wrote: > On 04/06/2018 10:17 AM, Max Reitz wrote: >> My non-Fedora testing system does not have a kernel with userfaultfd >> support which causes 181 and 201 to fail. That is annoying. This >> series makes those tests recognize the issue and convert it into a >>

Re: [Qemu-devel] [PATCH] iotests: 122 needs at least two refcount bits now

2018-04-06 Thread Eric Blake
On 04/06/2018 10:17 AM, Max Reitz wrote: > The new test case for compressed clusters (added in commit > abd3622cc03cf41ed542126a540385f30a4c0175) requires two refcount bits to > succeed, so we need to skip the test when refcount_bits=1 was requested. We already questioned whether the changes to

Re: [Qemu-devel] [PATCH 0/2 for-2.12?] iotests: Skip 181 and 201 without userfaultfd

2018-04-06 Thread Eric Blake
On 04/06/2018 10:17 AM, Max Reitz wrote: > My non-Fedora testing system does not have a kernel with userfaultfd > support which causes 181 and 201 to fail. That is annoying. This > series makes those tests recognize the issue and convert it into a > _notrun. As this is just testsuite fixes, is

[Qemu-devel] [ARM/FDPIC 4/4] linux-user: ARM-FDPIC: Add arm get tls syscall support

2018-04-06 Thread Christophe Lyon
Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/linux-user/arm/target_syscall.h b/linux-user/arm/target_syscall.h index 94e2a42..afc0772 100644 --- a/linux-user/arm/target_syscall.h +++ b/linux-user/arm/target_syscall.h @@

[Qemu-devel] [ARM/FDPIC 0/4] FDPIC ABI for ARM

2018-04-06 Thread Christophe Lyon
Hello, This patch series implements the QEMU contribution of the FDPIC ABI for ARM targets. This ABI enables to run Linux on ARM MMU-less cores and supports shared libraries to reduce the memory footprint. Without MMU, text and data segment relative distances are different from one process to

Re: [Qemu-devel] [PATCH for-2.12] dump: Fix build with newer gcc

2018-04-06 Thread Paolo Bonzini
On 06/04/2018 17:06, Eric Blake wrote: > On 04/03/2018 01:46 PM, Eric Blake wrote: >> On 03/27/2018 03:21 PM, Eric Blake wrote: >>> gcc 8 on rawhide is picky enough to complain: >>> >>> /home/dummy/qemu/dump.c: In function 'create_header32': >>> /home/dummy/qemu/dump.c:817:5: error: 'strncpy'

[Qemu-devel] [ARM/FDPIC 2/4] linux-user: ARM-FDPIC: Add support of FDPIC for ARM.

2018-04-06 Thread Christophe Lyon
Add FDPIC info into image_info structure since interpreter info is on stack and needs to be saved to be accessed later on. Co-Authored-By: Mickaël Guêné Signed-off-by: Christophe Lyon diff --git a/linux-user/elfload.c b/linux-user/elfload.c index

[Qemu-devel] [ARM/FDPIC 3/4] linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

2018-04-06 Thread Christophe Lyon
The FDPIC restorer needs to deal with a function descriptor, hence we have to extend 'retcode' such that it can hold the instructions needed to perform this. The restorer sequence uses the same thumbness as the exception handler (mainly to support Thumb-only architectures). Co-Authored-By:

[Qemu-devel] [PATCH 2/2] iotests: Skip 181 and 201 without userfaultfd

2018-04-06 Thread Max Reitz
userfaultfd support depends on the host kernel, so it may not be available. If so, 181 and 201 should be skipped. Signed-off-by: Max Reitz --- tests/qemu-iotests/181 | 13 + tests/qemu-iotests/201 | 13 + 2 files changed, 26 insertions(+) diff --git

[Qemu-devel] [ARM/FDPIC 1/4] linux-user: ARM-FDPIC: Add configure option to support loading of FDPIC binaries

2018-04-06 Thread Christophe Lyon
Adds --enable-fdpic and --disable-fdpic configure options. This feature is disabled by default, that's why it is not described in the "Optional features" help section (which are enabled by default if possible). FDPIC ELF objects are identified with e_ident[EI_OSABI] == ELFOSABI_ARM_FDPIC.

[Qemu-devel] [PATCH 0/2] iotests: Skip 181 and 201 without userfaultfd

2018-04-06 Thread Max Reitz
My non-Fedora testing system does not have a kernel with userfaultfd support which causes 181 and 201 to fail. That is annoying. This series makes those tests recognize the issue and convert it into a _notrun. Max Reitz (2): iotests: Add failure matching to common.qemu iotests: Skip 181

[Qemu-devel] [PATCH] iotests: 122 needs at least two refcount bits now

2018-04-06 Thread Max Reitz
The new test case for compressed clusters (added in commit abd3622cc03cf41ed542126a540385f30a4c0175) requires two refcount bits to succeed, so we need to skip the test when refcount_bits=1 was requested. Signed-off-by: Max Reitz --- tests/qemu-iotests/122 | 4 1 file

[Qemu-devel] [PATCH 1/2] iotests: Add failure matching to common.qemu

2018-04-06 Thread Max Reitz
Currently, common.qemu only allows to match for results indicating success. The only way to fail is by provoking a timeout. However, sometimes we do have a defined failure output and can match for that, which saves us from having to wait for the timeout in case of failure. Because failure can

[Qemu-devel] [PATCH for-2.12] vfio-ccw: fix memory leak in vfio_ccw_realize()

2018-04-06 Thread Greg Kurz
The vfio_ccw_realize() function currently leaks vcdev->vdev.name if the subchannel is already attached or if vfio_get_device() fails. This happens because vcdev->vdev.name is expected to be freed in vfio_put_device() which isn't called in this case. Adding g_free(vcdev->vdev.name) on these two

Re: [Qemu-devel] [PATCH for-2.12] maint: Add .mailmap entries for patches claiming list authorship

2018-04-06 Thread Eric Blake
On 04/03/2018 01:45 PM, Eric Blake wrote: > On 03/26/2018 01:41 PM, Eric Blake wrote: >> The list did not author any patches, but it does rewrite the >> 'From:' header of messages sent from any domain with restrictive >> SPF policies that would otherwise prevent the message from reaching >> all

Re: [Qemu-devel] [PATCH for-2.12] dump: Fix build with newer gcc

2018-04-06 Thread Eric Blake
On 04/03/2018 01:46 PM, Eric Blake wrote: > On 03/27/2018 03:21 PM, Eric Blake wrote: >> gcc 8 on rawhide is picky enough to complain: >> >> /home/dummy/qemu/dump.c: In function 'create_header32': >> /home/dummy/qemu/dump.c:817:5: error: 'strncpy' output truncated before >> terminating nul

[Qemu-devel] [PATCH] Add missing bit for SSE instr in VEX decoding

2018-04-06 Thread Eugene Minibaev
Signed-off-by: Eugene Minibaev --- It seems that x86 vector instructions encoded in VEX are not properly decoded because of missing bit, here is the example: IN: 0x08048060: c5 f9 6f c1 vmovdqa %xmm1, %xmm0 0x08048064: b8 01 00 00 00 movl $1, %eax

Re: [Qemu-devel] [PATCH v3 3/7] s390x/cpumodel: Set up CPU model for AP device support

2018-04-06 Thread Pierre Morel
On 16/03/2018 00:24, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilities are installed. This feature will be

Re: [Qemu-devel] [PULL for-2.12 0/1] tcg vector fix

2018-04-06 Thread Peter Maydell
On 6 April 2018 at 14:14, Richard Henderson wrote: > Fixes the reported problem w/ ppc64 host (gcc 4.8.5) + aa64 guest. > > > r~ > > > The following changes since commit 0e87fdc966d05f4e5ad868034fcd8ee2a08ca62d: > > Update version for v2.12.0-rc2 release

Re: [Qemu-devel] -icount changes physical address assignments in QEMU 2.10/2.11

2018-04-06 Thread Peter Maydell
On 6 April 2018 at 14:33, Peter Maydell wrote: > On this end I should try this with a 32-bit Linux host. I've now done this, and can reproduce the problem. So the issue is generic to 32-bit hosts. I'll see if I can figure out what's going wrong. In the meantime, you

Re: [Qemu-devel] [PATCH 05/19] target/hppa: Unify specializations of OR

2018-04-06 Thread Bastian Koppelmann
On 02/17/2018 09:31 PM, Richard Henderson wrote: > With decodetree.py, the specializations would conflict so we > must have a single entry point for all variants of OR. > > Signed-off-by: Richard Henderson > --- > target/hppa/translate.c | 108 >

Re: [Qemu-devel] [PATCH] hw/sparc64/sun4u: Fix introspection by converting prom instance_init to realize

2018-04-06 Thread Thomas Huth
On 06.04.2018 16:41, Mark Cave-Ayland wrote: > On 05/04/18 10:32, Thomas Huth wrote: > >> The instance_init function of devices should always succeed to be able >> to introspect the device. However, the instance_init function of the >> "openprom" device can currently fail, for example like this:

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-04-06 Thread Pierre Morel
On 06/04/2018 16:08, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are not

  1   2   >