Re: [Qemu-devel] [PATCH] virtio-pci: Add subsystem-vendor-id property

Hi Michael, > On Dec 19, 2017, at 8:27 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 13, 2017 at 12:26:44AM -0800, b...@skyportsystems.com wrote: >> From: Ben Warren >> >> Now that virtio-win guest drivers provided by non-Redhat vendors need to >> use a different Subsystem Vendor ID value, a w

Re: [Qemu-devel] [PATCH v4 12/43] misc: remove headers implicitly included

> On Dec 14, 2017, at 7:29 PM, Philippe Mathieu-Daudé wrote: > > applied using ./scripts/clean-includes > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Peter Maydell > Reviewed-by: Stefan Hajnoczi Reviewed-by: Ben Warren > --- > hw/audio/fmopl.h | 1 - > bsd-user/main.c

[Qemu-devel] [PATCH] virtio-pci: Add subsystem-vendor-id property

From: Ben Warren Now that virtio-win guest drivers provided by non-Redhat vendors need to use a different Subsystem Vendor ID value, a way is needed to set this parameter on the host. This works with all of the PCI-based devices, such as NetKVM, viostor, vioscsi, vioserial and balloon. Signed-o

Re: [Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

It looks like you dropped Marc-André and my Reviewed-by lines. Please put them back. > On Nov 27, 2017, at 5:05 AM, Roman Kagan wrote: > > Switch vmgenid device to use the UUID property type introduced in the > previous patch for its 'guid' property. > > One semantic change it introduces is t

Re: [Qemu-devel] [PATCH 1/2] qdev-properties: add UUID property type

> On Nov 24, 2017, at 7:36 AM, Roman Kagan wrote: > > UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated > property type becomes helpful. > > Signed-off-by: Roman Kagan Reviewed-by: Ben Warren > --- > include/hw/qdev-properties.h | 3 +++ > hw/core/qdev-properties.c| 52

Re: [Qemu-devel] [PATCH 2/2] vmgenid: use UUID property type

Thanks Roman, this seems like a nice improvement. Fix the minor point below, and you can add my R-B. > On Nov 24, 2017, at 7:36 AM, Roman Kagan wrote: > > Switch vmgenid device to use the UUID property type introduced in the > previous patch for its 'guid' property. > > One semantic change it

Re: [Qemu-devel] [PATCH 81/88] hw/acpi: use g_new() family of functions

> On Oct 6, 2017, at 4:50 PM, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Ben Warren > --- > hw/acpi/vmgenid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c > index 2876d8a639..ced507d218

Re: [Qemu-devel] [PATCH v2] vmgenid-test: use boot-sector infrastructure

Hi Michael, Looks good. Thanks for taking care of this. > On Jul 14, 2017, at 8:30 AM, Michael S. Tsirkin wrote: > > There's no requirement for RSDP to be installed last > by the firmware, so in rare cases vmgen id test hits > a race: RSDP is there but VM GEN ID isn't. > > To fix, switch to co

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

Hi, > On Jul 13, 2017, at 4:51 AM, Marc-André Lureau > wrote: > > Hi > > On Thu, Jul 13, 2017 at 1:32 PM Laszlo Ersek > wrote: > On 07/13/17 12:47, Peter Maydell wrote: > > On 12 July 2017 at 00:43, Ben Warren > > wrote: > >> Yes, it’s

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

Hi Laszlo, > On Jul 11, 2017, at 3:13 PM, Laszlo Ersek wrote: > > On 07/11/17 22:42, Peter Maydell wrote: >> On 11 July 2017 at 20:10, Michael S. Tsirkin wrote: >>> On Tue, Jul 11, 2017 at 05:49:07PM +0100, Peter Maydell wrote: The good news is it's not aarch64-specific. I just hit this on

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

Hi Peter, > On Jul 11, 2017, at 6:32 AM, Peter Maydell wrote: > > On 3 July 2017 at 20:45, Michael S. Tsirkin wrote: >> From: Ben Warren >> >> The following tests are implemented: >> * test that a GUID passed in by command line is propagated to the guest. >> Read the GUID from guest memory >>

[Qemu-devel] [PATCH v2] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. * test that a GUID passed in can be queried

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

Nice improvement! > On Jun 29, 2017, at 9:23 AM, Marc-André Lureau > wrote: > > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > This has the additional benefit of handlin

Re: [Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

u wrote: >>>> Hi >>>> >>>> On Mon, May 29, 2017 at 7:18 PM Ben Warren via Qemu-devel < >>>> qemu-devel@nongnu.org> wrote: >>>> >>>> From: Ben Warren >>>> >>>> The following tests are implemen

Re: [Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

> On Jun 1, 2017, at 7:21 AM, Michael S. Tsirkin wrote: > > On Thu, Jun 01, 2017 at 08:10:27AM +, Marc-André Lureau wrote: >> Hi >> >> On Mon, May 29, 2017 at 7:18 PM Ben Warren via Qemu-devel < >> qemu-devel@nongnu.org> wrote: >> >>

[Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. * test that a GUID passed in can be queried

Re: [Qemu-devel] [PATCH v8 7/8] tests: Add unit tests for the VM Generation ID feature

Hi, > On Apr 21, 2017, at 3:14 AM, Marc-André Lureau > wrote: > > Hi, > > Was this patch intentionally dropped from the series? > Good question. I thought the whole patch series was pulled in, but it looks like this one was not. I guess we’ll see what Michael has to say. —Ben > > > --

Re: [Qemu-devel] [PULL 02/15] docs: VM Generation ID device description

> On Apr 12, 2017, at 1:47 PM, Marc-André Lureau > wrote: > > Hi > > On Thu, Apr 13, 2017 at 12:25 AM Ben Warren > wrote: >> On Apr 12, 2017, at 1:22 PM, Marc-André Lureau > > wrote: >> >> Hi >> >> On Thu, Apr 13, 2017 at 12

Re: [Qemu-devel] [PULL 02/15] docs: VM Generation ID device description

> On Apr 12, 2017, at 1:22 PM, Marc-André Lureau > wrote: > > Hi > > On Thu, Apr 13, 2017 at 12:17 AM Ben Warren > wrote: >> On Apr 12, 2017, at 1:06 PM, Marc-André Lureau > > wrote: >> >> +Device Usage: >> +- >>

Re: [Qemu-devel] [PULL 02/15] docs: VM Generation ID device description

> On Apr 12, 2017, at 1:06 PM, Marc-André Lureau > wrote: > > Hi > > On Thu, Mar 2, 2017 at 10:22 AM Michael S. Tsirkin > wrote: > From: Ben Warren mailto:b...@skyportsystems.com>> > > This patch is based off an earlier version by > Gal Hammer (gham...@redhat.com