Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Charles Arnold
On 2/12/2015 at 12:05 PM, Peter Lieven p...@kamp.de wrote: Am 12.02.2015 um 18:18 schrieb Charles Arnold carn...@suse.com: On 2/12/2015 at 03:23 AM, Kevin Wolf kw...@redhat.com wrote: Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am

Re: [Qemu-devel] [RFC PATCH] vpc: Ignore geometry for large images

2015-02-12 Thread Charles Arnold
On 2/12/2015 at 03:23 AM, Kevin Wolf kw...@redhat.com wrote: Am 12.02.2015 um 11:09 hat Peter Lieven geschrieben: Am 12.02.2015 um 11:06 schrieb Kevin Wolf: Am 12.02.2015 um 11:02 hat Peter Lieven geschrieben: Am 12.02.2015 um 10:58 schrieb Kevin Wolf: Am 12.02.2015 um 10:23 hat Peter

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-15 Thread Charles Arnold
On 11/14/2012 at 09:35 AM, in message 50a3c853.4010...@redhat.com, Paolo Bonzini pbonz...@redhat.com wrote: Il 14/11/2012 17:25, Thanos Makatos ha scritto: We don't use qemu's VHD driver in XenServer. Instead, we use blktap2 to create a block device in dom0 serving the VHD file in question,

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-12 Thread Charles Arnold
Ping? Any thoughts on whether this is acceptable? - Charles On 10/30/2012 at 08:59 PM, in message 50a0e561.5b74.009...@suse.com, Charles Arnold wrote: The VHD specification allows for up to a 2 TB disk size. The current implementation in qemu emulates EIDE and ATA-2 hardware which only

Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field

2012-11-12 Thread Charles Arnold
Ping? Is this ok? - Charles On 11/2/2012 at 09:54 AM, in message 50a0e829.5b74.009...@suse.com, Charles Arnold wrote: block/vpc: Initialize the uuid field in the footer with a generated uuid. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/block/vpc.c b/block/vpc.c index

[Qemu-devel] [PATCH] block: vpc initialize the uuid footer field

2012-11-02 Thread Charles Arnold
block/vpc: Initialize the uuid field in the footer with a generated uuid. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/block/vpc.c b/block/vpc.c index b6bf52f..f14c6ae 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -26,6 +26,9 @@ #include block_int.h #include module.h #include

[Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-10-30 Thread Charles Arnold
disk images to be created of up to nearly 2 TB. This change does not violate the VHD format specification nor does it change how smaller disks (ie, =127GB) are defined. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/block/vpc.c b/block/vpc.c index b6bf52f..0c2eaf8 100644 --- a/block

[Qemu-devel] [PATCH] qemu-img: Fix segmentation fault

2012-05-11 Thread Charles Arnold
The following command generates a segmentation fault. qemu-img convert -O vpc -o ? test test2 This is because the 'goto out;' statement calls qemu_progress_end before qemu_progress_init is called resulting in a NULL pointer invocation. Signed-off-by: Charles Arnold carn...@suse.com --- diff

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Charles Arnold
: qemu-img convert -O vpc -o type=fixed input filename output filename While it is also allowed to specify '-o type=dynamic', the default disk type remains Dynamic and is what is used when the type is left unspecified. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/block/vpc.c b/block

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Charles Arnold
On 2/6/2012 at 09:51 AM, in message 4f3004fc.7070...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Am 06.02.2012 17:22, schrieb Charles Arnold: On 2/6/2012 at 08:46 AM, in message 4f2ff5b9.9090...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Somehow you lost the ret = -EFBIG here

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-02 Thread Charles Arnold
is left unspecified. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/block/vpc.c b/block/vpc.c index 89a5ee2..d9a1c44 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -161,13 +161,27 @@ static int vpc_open(BlockDriverState *bs, int flags) uint8_t buf[HEADER_SIZE]; uint32_t checksum

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-01 Thread Charles Arnold
On 2/1/2012 at 05:15 AM, in message 4f292cd0.20...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Am 01.02.2012 00:04, schrieb Charles Arnold: Thanks Andreas, The 'TODO uuid is missing' comment in the patch is from the original sources (as well as many '//' comments). The vhd footer

[Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-01-31 Thread Charles Arnold
[size] Example 2: qemu-img convert -O vpc -o type=fixed input filename output filename While it is also allowed to specify '-o type=dynamic', the default disk type remains Dynamic and is what is used when the type is left unspecified. Signed-off-by: Charles Arnold carn...@suse.com diff --git

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-01-31 Thread Charles Arnold
-off-by: Charles Arnold carn...@suse.com diff --git a/block/vpc.c b/block/vpc.c index 89a5ee2..04db372 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -160,14 +160,25 @@ static int vpc_open

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Charles Arnold
On 11/9/2011 at 02:46 AM, in message 4eba4bec.5040...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Am 08.11.2011 20:25, schrieb Charles Arnold: The Data Offset field in the Dynamic Disk Header is an 8 byte field. Although the specification (2006-10-11) gives an example of initializing

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Charles Arnold
specifically for the proper Data Offset field initialization. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/block/vpc.c b/block/vpc.c index 416f489..179c6ae 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -585,7 +585,11 @@ static int vpc_create(const char *filename

[Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-08 Thread Charles Arnold
utilities that check specifically for the complete Data Offset field initialization. Signed-off-by: Charles Arnold carn...@suse.com diff --git a/block/vpc.c b/block/vpc.c index 416f489..35ac3fd 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -585,7 +585,7 @@ static int vpc_create(const char *filename