[Qemu-devel] [PATCH 1/1] qtest:Fix the bug about disabling vnc causes "make check" hang

2013-12-30 Thread Kewei Yu
When we disabling vnc from "./configure", the qemu can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" will hang. Signed-off-by: Kewei Yu --- tests/fdc-test.c |4 tests/ide-test.c | 11 --- 2 file

[Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2013-12-30 Thread Kewei Yu
When we disabling vnc from "./configure", the qemu can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" will hang. Signed-off-by: Kewei Yu --- v2: Consolidate VNC macro's #ifdef'ery to one central point (tests/l

[Qemu-devel] [PATCH 1/1] Add a blank space between the variable and '='

2013-12-31 Thread Kewei Yu
Signed-off-by: Kewei Yu --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 7511e70..92dafa5 100644 --- a/vl.c +++ b/vl.c @@ -2922,7 +2922,7 @@ int main(int argc, char **argv, char **envp) bdrv_init_with_whitelist(); -autostart= 1

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2013-12-31 Thread Kewei Yu
2013/12/31 Peter Crosthwaite > On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: > > When we disabling vnc from "./configure", the qemu can't use the vnc > option. > > "disable", -"the", "QEMU", > Do you mean "s/disabli

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2013-12-31 Thread Kewei Yu
Peter: Happy new year, Today is new year's day, so I will present the v3 patch according to your suggestions tomorrow , thanks for your review. Faithfully yours Kewei Yu 2013/12/31 Kewei Yu > 2013/12/31 Peter Crosthwaite > >> On Tue, Dec 31, 2013 at 2:42 PM

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2013-12-31 Thread Kewei Yu
2014/1/1 Peter Maydell > On 31 December 2013 13:29, Kewei Yu wrote: > > 2013/12/31 Peter Crosthwaite > >> > >> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: > >> >"%s", qemu_binary, s->sock

[Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-01 Thread Kewei Yu
When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. Signed-off-by: Kewei Yu --- v2: Consolidate VNC macro's #ifdef'ery to one central point (tests/libqtest.c

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2014-01-02 Thread Kewei Yu
The fail is caused by "-vnc none", we can't use it when disable vnc from "./configure". Faithfully yours Kewei Yu 2014/1/2 Paolo Bonzini > Il 31/12/2013 05:42, Kewei Yu ha scritto: > > When we disabling vnc from "./configure", the qemu can't

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2014-01-02 Thread Kewei Yu
2014/1/2 Andreas Färber > Am 01.01.2014 05:40, schrieb Peter Crosthwaite: > > On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu wrote: > >> 2013/12/31 Peter Crosthwaite > >>> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: > >>>> When we disabling vnc f

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
Ping. Faithfully yours Kewei Yu 2014/1/2 Kewei Yu > When we disable vnc from "./configure", QEMU can't use the vnc option. > So qtest can't use the "vnc -none ", otherwise "make check" fails. > > Signed-off-by: Kewei Yu > --- > v

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
OK, I'm viewing the code about the two parameters. Thanks for your reply. Faithfully yours Kewei Yu 2014/1/6 Peter Crosthwaite > Hi Kewei, > > On Mon, Jan 6, 2014 at 12:22 PM, Kewei Yu wrote: > > Ping. > > > > Paolo's latest query on the other thread is

Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang

2014-01-05 Thread Kewei Yu
2014/1/3 Paolo Bonzini > Il 02/01/2014 15:45, Andreas Färber ha scritto: > >>> >> v2: Consolidate VNC macro's #ifdef'ery to one central point > (tests/libqtest.c). > >> > > >> > What happens if qtest instead uses "-display none"? > > It does use that, since the commit I pointed to in v1. :) > >

[Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. Signed-off-

[Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. Signed-off-

Re: [Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
Sorry, I don't know something wrong happened to my git or gmail, My patch v4 doesn't use the new title, The two patch v4 are same at all, reviewers just review the first patch_v4. Regard Kewei 2014/1/6 Kewei Yu > When we disable vnc from "./configure", QEMU can

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Add a blank space between the variable and '='

2014-01-16 Thread Kewei Yu
2014/1/16 Peter Maydell > On 16 January 2014 10:50, Michael Tokarev wrote: > > Thanks, applied. > > Can you fix the subject line in your tree to have a > prefix indicating which area of the codebase it affects, > please? > OK, Thanks for your review. I will send it again. > > thanks > -- PMM >

Re: [Qemu-devel] [PULL 11/11] vl: Add a blank space between the variable and '='

2014-01-16 Thread Kewei Yu
Thanks, I will send patch with prefix to indicate which file of the codebase after this. Regard Kewei 2014/1/17 Michael Tokarev > From: Kewei Yu > > Signed-off-by: Kewei Yu > Signed-off-by: Michael Tokarev > --- > vl.c |2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PULL 10/42] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-18 Thread Kewei Yu
2014/1/17 Andreas Färber > Am 15.01.2014 11:22, schrieb Kevin Wolf: > > From: Kewei Yu > > > > When we disable vnc from "./configure", QEMU can't use the vnc option. > > So qtest can't use the "vnc -none ", otherwise "make

[Qemu-devel] [PATCH v4 1/1] qtest: Fix "make check" failing for "--disable-vnc"

2014-01-20 Thread Kewei Yu
When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. Signed-off-by

Re: [Qemu-devel] [PULL 10/42] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-26 Thread Kewei Yu
2014/1/26 Andreas Färber > Am 18.01.2014 12:54, schrieb Kewei Yu: > > > > 2014/1/17 Andreas Färber mailto:afaer...@suse.de>> > > > > Am 15.01.2014 11:22, schrieb Kevin Wolf: > > > From: Kewei Yu mailto:kewe...@gmail.com>> > > &g

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix build regression in qxl-render.c caused by ac86048

2013-12-10 Thread Kewei Yu
I‘m wondering why can't I build qemu successful, I have found the first bad commit with git bisect. I'm a novice to qemu, I hope I will help you to fix some bugs. Who can introduce some documents to me for the preparing. Faithfully yours Kewei Yu Address : Room 4-308, Building FIT o