memcpy() for overlapping regions is undefined behavior; use memmove()
instead in readline_hist_add().
Signed-off-by: Nickolai Zeldovich
---
readline.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/readline.c b/readline.c
index 5fc9643..aeccc7b 100644
--- a
and
fixes select for fds above 32 on x86_64.
Signed-off-by: Nickolai Zeldovich
---
v2 of this patch removes unnecessary parentheses, as suggested by Richard
Henderson -- thanks!
linux-user/syscall.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/
and
fixes select for fds above 32 on x86_64.
Signed-off-by: Nickolai Zeldovich
---
linux-user/syscall.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 5a81d9f..17c3dd6 100644
--- a/linux-user/syscall.c
+++ b/linux-user
Use the correct argument passing convention for select on x86_64.
Previously, select worked for i386 but was broken for x86_64 (always
returning EINVAL). With this change, select works on both i386 and
x86_64. (Other targets untested but should be unaffected.)
Signed-off-by: Nickolai Zeldovich
LWIP can generate packets with a source of 0.0.0.0, which triggers an
assertion failure in arp_table_add(). Instead of crashing, simply return
to avoid adding an invalid ARP table entry.
Signed-off-by: Nickolai Zeldovich
---
slirp/arp_table.c |4 +++-
1 file changed, 3 insertions(+), 1
On Mon, Nov 12, 2012 at 4:37 AM, Jan Kiszka wrote:
> On 2012-11-12 01:59, Nickolai Zeldovich wrote:
>> LWIP can generate packets with a source of 0.0.0.0, which triggers an
>> assertion failure in arp_table_add(). Instead of crashing, simply return
>> to avoid adding an in
LWIP can generate packets with a source of 0.0.0.0, which triggers an
assertion failure in arp_table_add(). Instead of crashing, simply return
to avoid adding an invalid ARP table entry.
Signed-off-by: Nickolai Zeldovich
---
slirp/arp_table.c |3 ++-
1 file changed, 2 insertions(+), 1
Thanks. Looks like inline-generated instructions use
cpu_restore_state() to invert the translated PC into the simulated PC.
Nickolai.
In qemu-0.9.0, an exception in cmpxchg8b (e.g. page fault due to a
missing TLB entry) causes the wrong eip value to be pushed onto the
exception stack -- it seems to be the eip of the last exception or the
start of the translation block, whichever happened last. This makes
it impossible to resume
(PST)
From: Nickolai Zeldovich <[EMAIL PROTECTED]>
To: qemu-devel@nongnu.org
Cc: [EMAIL PROTECTED]
Subject: Set SO_REUSEADDR at the right time
It looks like qemu (at least version 0.7.2, which is what I'm running
here) doesn't set SO_REUSEADDR before calling bind(), which makes
It looks like qemu (at least version 0.7.2, which is what I'm running
here) doesn't set SO_REUSEADDR before calling bind(), which makes that
fairly useless. This obvious patch moves up setting SO_REUSEADDR to the
right place, just before bind().
Apologies if this is already fixed in 0.8.0.
-- ko
11 matches
Mail list logo
