Re: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback

2023-11-13 Thread Robert Hoo
On 11/13/2023 6:05 PM, Philippe Mathieu-Daudé wrote: Hi Robert, On 13/11/23 09:13, Robert Hoo wrote: In the rollback in msix_set_vector_notifiers(), original patch forgot to undo msix_vector_poll_notifier pointer. Out of curiosity, nobody complained during 11 years, so in which use case did y

Re: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback

2023-11-13 Thread Philippe Mathieu-Daudé
Hi Robert, On 13/11/23 09:13, Robert Hoo wrote: In the rollback in msix_set_vector_notifiers(), original patch forgot to undo msix_vector_poll_notifier pointer. Out of curiosity, nobody complained during 11 years, so in which use case did you notice this? Reviewed-by: Philippe Mathieu-Daudé

[PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback

2023-11-13 Thread Robert Hoo
In the rollback in msix_set_vector_notifiers(), original patch forgot to undo msix_vector_poll_notifier pointer. Fixes: bbef882cc193 ("msi: add API to get notified about pending bit poll") Signed-off-by: Robert Hoo --- hw/pci/msix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci/msix