Amos Kong ak...@redhat.com writes:
On Tue, Apr 22, 2014 at 09:20:41AM +0200, Markus Armbruster wrote:
Paolo Bonzini pbonz...@redhat.com writes:
Il 18/04/2014 23:56, Amos Kong ha scritto:
Currently we always add a space after c_type in mcgen(), there is
some redundant space in generated
On Tue, Apr 22, 2014 at 09:20:41AM +0200, Markus Armbruster wrote:
Paolo Bonzini pbonz...@redhat.com writes:
Il 18/04/2014 23:56, Amos Kong ha scritto:
Currently we always add a space after c_type in mcgen(), there is
some redundant space in generated code. The space isn't needed for
Paolo Bonzini pbonz...@redhat.com writes:
Il 18/04/2014 23:56, Amos Kong ha scritto:
Currently we always add a space after c_type in mcgen(), there is
some redundant space in generated code. The space isn't needed for
points by the coding style.
char * value;
^
On Sat, Apr 19, 2014 at 03:16:52PM -0600, Eric Blake wrote:
On 04/18/2014 09:56 PM, Amos Kong wrote:
Currently we always add a space after c_type in mcgen(), there is
some redundant space in generated code. The space isn't needed for
points by the coding style.
Second sentence is
Il 18/04/2014 23:56, Amos Kong ha scritto:
Currently we always add a space after c_type in mcgen(), there is
some redundant space in generated code. The space isn't needed for
points by the coding style.
char * value;
^
qapi_free_NameInfo(NameInfo * obj)
On 04/18/2014 09:56 PM, Amos Kong wrote:
Currently we always add a space after c_type in mcgen(), there is
some redundant space in generated code. The space isn't needed for
points by the coding style.
Second sentence is awkward; maybe:
Avoiding the space when appropriate makes us match the
Currently we always add a space after c_type in mcgen(), there is
some redundant space in generated code. The space isn't needed for
points by the coding style.
char * value;
^
qapi_free_NameInfo(NameInfo * obj)
^
It's fussy to add checking in each