Re: [Qemu-devel] [PATCH 05/33] pc: acpi: consolidate CPU hotplug AML

2016-05-31 Thread Igor Mammedov
On Tue, 31 May 2016 13:18:44 +0300 Marcel Apfelbaum wrote: > On 05/31/2016 10:50 AM, Igor Mammedov wrote: > > On Mon, 30 May 2016 21:18:59 +0300 > > Marcel Apfelbaum wrote: > > > >> On 05/17/2016 05:42 PM, Igor Mammedov wrote: > >>> move the former SSDT part of CPU hoplug close to DSDT part.

Re: [Qemu-devel] [PATCH 05/33] pc: acpi: consolidate CPU hotplug AML

2016-05-31 Thread Marcel Apfelbaum
On 05/31/2016 10:50 AM, Igor Mammedov wrote: On Mon, 30 May 2016 21:18:59 +0300 Marcel Apfelbaum wrote: On 05/17/2016 05:42 PM, Igor Mammedov wrote: move the former SSDT part of CPU hoplug close to DSDT part. AML is only moved but there isn't any functional change. The patch looks good to

Re: [Qemu-devel] [PATCH 05/33] pc: acpi: consolidate CPU hotplug AML

2016-05-31 Thread Igor Mammedov
On Mon, 30 May 2016 21:18:59 +0300 Marcel Apfelbaum wrote: > On 05/17/2016 05:42 PM, Igor Mammedov wrote: > > move the former SSDT part of CPU hoplug close to DSDT part. > > AML is only moved but there isn't any functional change. > > > > The patch looks good to me, > but why did you decide to

Re: [Qemu-devel] [PATCH 05/33] pc: acpi: consolidate CPU hotplug AML

2016-05-30 Thread Marcel Apfelbaum
On 05/17/2016 05:42 PM, Igor Mammedov wrote: move the former SSDT part of CPU hoplug close to DSDT part. AML is only moved but there isn't any functional change. The patch looks good to me, but why did you decide to get rid of the build_processor_devices function? I would simply move it to the

[Qemu-devel] [PATCH 05/33] pc: acpi: consolidate CPU hotplug AML

2016-05-17 Thread Igor Mammedov
move the former SSDT part of CPU hoplug close to DSDT part. AML is only moved but there isn't any functional change. Signed-off-by: Igor Mammedov --- hw/acpi/cpu_hotplug_acpi_table.c | 104 +++- hw/i386/acpi-build.c | 112 +-