On 02/27/2012 03:59 PM, Stefan Hajnoczi wrote:
>> > I guess what I'm saying is, if we need to copy-paste in order to fork
>> > them in the future that's fine, but why maintain duplicates in the
>> > mean-time? Please make the codebase nice today. We can always extend
>> > it in the future, we're
On Mon, Feb 27, 2012 at 2:49 PM, Stefan Hajnoczi wrote:
> On Mon, Feb 27, 2012 at 1:47 PM, Paolo Bonzini wrote:
>> On 02/27/2012 02:09 PM, Stefan Hajnoczi wrote:
>> 3) blkverify in the future could add callbacks to create snapshots or
>> load/save imgstate, and forward them to the test file; this
On Mon, Feb 27, 2012 at 1:47 PM, Paolo Bonzini wrote:
> On 02/27/2012 02:09 PM, Stefan Hajnoczi wrote:
>> > Non-incremental mode is "pre-copy" migration. It would stream in the
>> > background from the source to the destination. In this case:
>> >
>> > - you need to differentiate streaming write
On 02/27/2012 02:09 PM, Stefan Hajnoczi wrote:
> > Non-incremental mode is "pre-copy" migration. It would stream in the
> > background from the source to the destination. In this case:
> >
> > - you need to differentiate streaming writes from other writes. When
> > streaming, you do not want to
On Mon, Feb 27, 2012 at 11:48 AM, Paolo Bonzini wrote:
> On 02/27/2012 12:42 PM, Stefan Hajnoczi wrote:
>>> >
>>> > Once non-incremental mode is added, I suspect blkmirror will diverge
>>> > from blkverify significantly. In particular, we would need to track
>>> > where have writes been done in t
On 02/27/2012 12:42 PM, Stefan Hajnoczi wrote:
>> >
>> > Once non-incremental mode is added, I suspect blkmirror will diverge
>> > from blkverify significantly. In particular, we would need to track
>> > where have writes been done in the destination. We also would need to
>> > hooks for block/st
On Mon, Feb 27, 2012 at 11:37 AM, Paolo Bonzini wrote:
> On 02/27/2012 10:23 AM, Stefan Hajnoczi wrote:
>> > I think the right approach is to create a single blkmirror driver that
>> > also includes blkverify functionality. The code is basically the same
>> > except blkverify also compares reads
On 02/27/2012 10:23 AM, Stefan Hajnoczi wrote:
> > I think the right approach is to create a single blkmirror driver that
> > also includes blkverify functionality. The code is basically the same
> > except blkverify also compares reads - just use a flag to
> > enable/disable that behavior.
> >
>
On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi wrote:
> On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli
> wrote:
>> From: Marcelo Tosatti
>>
>> Mirrored writes are used by live block copy.
>
> I think the right approach is to create a single blkmirror driver that
> also includes blkverify
- Original Message -
> From: "Stefan Hajnoczi"
> To: "Federico Simoncelli"
> Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com
> Sent: Thursday, February 23, 2012 5:28:23 PM
> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driv
23, 2012 5:18:41 PM
>> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver
>>
>> On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi
>> wrote:
>> > By the way, this code does not build against qemu.git/master. It
>> > uses
>> > interfaces w
- Original Message -
> From: "Stefan Hajnoczi"
> To: "Federico Simoncelli"
> Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com
> Sent: Thursday, February 23, 2012 5:18:41 PM
> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driv
- Original Message -
> From: "Stefan Hajnoczi"
> To: "Federico Simoncelli"
> Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com
> Sent: Thursday, February 23, 2012 5:14:09 PM
> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block dr
On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi wrote:
> By the way, this code does not build against qemu.git/master. It uses
> interfaces which have been dropped.
Ah, I see you changed that in Patch 2/3. Please don't do that, it's
hard to review and breaks git-bisect.
Stefan
On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli
wrote:
> From: Marcelo Tosatti
>
> Mirrored writes are used by live block copy.
I think the right approach is to create a single blkmirror driver that
also includes blkverify functionality. The code is basically the same
except blkverify also
From: Marcelo Tosatti
Mirrored writes are used by live block copy.
Signed-off-by: Marcelo Tosatti
---
Makefile.objs |2 +-
block/blkmirror.c | 282
docs/blkmirror.txt | 15 +++
3 files changed, 298 insertions(+), 1 deletions(-)
16 matches
Mail list logo
