Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-19 Thread Peter Xu
On Mon, Sep 18, 2017 at 11:00:15AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 10:22:43AM +0100, Dr. David Alan Gilbert wrote: > > > * Fam Zheng (f...@redhat.com) wrote: > > > > On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > > > > >

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 10:22:43AM +0100, Dr. David Alan Gilbert wrote: > > * Fam Zheng (f...@redhat.com) wrote: > > > On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > > > > * Fam Zheng (f...@redhat.com) wrote: > > > > > On Fri, 09/15 16:03, Peter Xu wrot

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 10:22:43AM +0100, Dr. David Alan Gilbert wrote: > * Fam Zheng (f...@redhat.com) wrote: > > On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > > > * Fam Zheng (f...@redhat.com) wrote: > > > > On Fri, 09/15 16:03, Peter Xu wrote: > > > > > On Fri, Sep 15, 2017 at 01:44:03PM

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-15 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > > * Fam Zheng (f...@redhat.com) wrote: > > > On Fri, 09/15 16:03, Peter Xu wrote: > > > > On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote: > > > > > bdrv_close_all() would abort() due to op blocker

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-15 Thread Dr. David Alan Gilbert
* Fam Zheng (f...@redhat.com) wrote: > On Fri, 09/15 16:03, Peter Xu wrote: > > On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote: > > > bdrv_close_all() would abort() due to op blockers added by BMDS, clean > > > up migration states when main loop quits to avoid that. > > > > > > Signed-o

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-15 Thread Fam Zheng
On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > * Fam Zheng (f...@redhat.com) wrote: > > On Fri, 09/15 16:03, Peter Xu wrote: > > > On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote: > > > > bdrv_close_all() would abort() due to op blockers added by BMDS, clean > > > > up migration sta

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-15 Thread Peter Xu
On Fri, Sep 15, 2017 at 04:20:26PM +0800, Fam Zheng wrote: [...] > > > void qmp_migrate_set_cache_size(int64_t value, Error **errp) > > > { > > > MigrationState *s = migrate_get_current(); > > > diff --git a/vl.c b/vl.c > > > index fb1f05b937..abbe61f40b 100644 > > > --- a/vl.c > > > +++ b

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-15 Thread Fam Zheng
On Fri, 09/15 16:03, Peter Xu wrote: > On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote: > > bdrv_close_all() would abort() due to op blockers added by BMDS, clean > > up migration states when main loop quits to avoid that. > > > > Signed-off-by: Fam Zheng > > --- > > include/migration/

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-15 Thread Peter Xu
On Fri, Sep 15, 2017 at 01:44:03PM +0800, Fam Zheng wrote: > bdrv_close_all() would abort() due to op blockers added by BMDS, clean > up migration states when main loop quits to avoid that. > > Signed-off-by: Fam Zheng > --- > include/migration/misc.h | 1 + > migration/migration.c| 7 ++

[Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-14 Thread Fam Zheng
bdrv_close_all() would abort() due to op blockers added by BMDS, clean up migration states when main loop quits to avoid that. Signed-off-by: Fam Zheng --- include/migration/misc.h | 1 + migration/migration.c| 7 ++- vl.c | 3 +++ 3 files changed, 10 insertions(+), 1