Re: [Qemu-devel] [PATCH 21/23] migration: Don't use callback on file defining it

2011-10-04 Thread Juan Quintela
Anthony Liguori wrote: > On 09/23/2011 07:57 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > I don't think this is better. It just eliminates the possibility of > having useful trace points in get_error. It's use is not consistent at all (same places use get_error() and the others t

Re: [Qemu-devel] [PATCH 21/23] migration: Don't use callback on file defining it

2011-10-04 Thread Anthony Liguori
On 09/23/2011 07:57 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela I don't think this is better. It just eliminates the possibility of having useful trace points in get_error. Regards, Anthony Liguori --- migration-tcp.c |4 ++-- migration-unix.c |6 +++--- 2 files ch

[Qemu-devel] [PATCH 21/23] migration: Don't use callback on file defining it

2011-09-23 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-tcp.c |4 ++-- migration-unix.c |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index f6b2288..bd3aa3a 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -58,7 +58,7 @@ static void

[Qemu-devel] [PATCH 21/23] migration: Don't use callback on file defining it

2011-09-20 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration-tcp.c |4 ++-- migration-unix.c |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index 1ca48fa..c259b8d 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -58,7 +58,7 @@ static void