Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-27 Thread Alistair Francis
On Thu, Jun 8, 2017 at 10:16 PM, Markus Armbruster wrote: > Alistair Francis writes: > >> On Thu, Jun 8, 2017 at 10:56 AM, Markus Armbruster wrote: >>> Alistair Francis writes: >>> On Wed, Jun 7, 2017 at 11:03 PM, Markus Armbruster wrote: > Alistair Francis writes: > >>

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-08 Thread Markus Armbruster
Alistair Francis writes: > On Thu, Jun 8, 2017 at 10:56 AM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> On Wed, Jun 7, 2017 at 11:03 PM, Markus Armbruster >>> wrote: Alistair Francis writes: > On Wed, Jun 7, 2017 at 12:19 AM, Markus Armbruster > wrote: >>>

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-08 Thread Alistair Francis
On Thu, Jun 8, 2017 at 10:56 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> On Wed, Jun 7, 2017 at 11:03 PM, Markus Armbruster wrote: >>> Alistair Francis writes: >>> On Wed, Jun 7, 2017 at 12:19 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-08 Thread Markus Armbruster
Alistair Francis writes: > On Wed, Jun 7, 2017 at 11:03 PM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> On Wed, Jun 7, 2017 at 12:19 AM, Markus Armbruster >>> wrote: Paolo Bonzini writes: > On 06/06/2017 18:30, Alistair Francis wrote: >>> >>> This is som

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-08 Thread Alistair Francis
On Wed, Jun 7, 2017 at 11:03 PM, Markus Armbruster wrote: > Alistair Francis writes: > >> On Wed, Jun 7, 2017 at 12:19 AM, Markus Armbruster wrote: >>> Paolo Bonzini writes: >>> On 06/06/2017 18:30, Alistair Francis wrote: >> >> This is somehow confusing. I don't think it is worth

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-07 Thread Markus Armbruster
Alistair Francis writes: > On Wed, Jun 7, 2017 at 12:19 AM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 06/06/2017 18:30, Alistair Francis wrote: > > This is somehow confusing. I don't think it is worth having another > qemu_log_stderr() function rather than using er

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-07 Thread Alistair Francis
On Wed, Jun 7, 2017 at 12:19 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 06/06/2017 18:30, Alistair Francis wrote: This is somehow confusing. I don't think it is worth having another qemu_log_stderr() function rather than using error_report() but this very cal

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 06/06/2017 18:30, Alistair Francis wrote: >>> >>> This is somehow confusing. I don't think it is worth having another >>> qemu_log_stderr() function rather than using error_report() but this very >>> call might deserve a comment explaining this unusual use. What do you

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-06 Thread Alistair Francis
On Tue, Jun 6, 2017 at 3:14 PM, Paolo Bonzini wrote: > > > On 06/06/2017 18:30, Alistair Francis wrote: >>> >>> This is somehow confusing. I don't think it is worth having another >>> qemu_log_stderr() function rather than using error_report() but this very >>> call might deserve a comment explain

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-06 Thread Paolo Bonzini
On 06/06/2017 18:30, Alistair Francis wrote: >> >> This is somehow confusing. I don't think it is worth having another >> qemu_log_stderr() function rather than using error_report() but this very >> call might deserve a comment explaining this unusual use. What do you think? > > The problem with

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-06 Thread Alistair Francis
On Tue, Jun 6, 2017 at 6:37 AM, Philippe Mathieu-Daudé wrote: > On 06/06/2017 08:58 AM, Marc-André Lureau wrote: >> >> Hi >> >> On Mon, Jun 5, 2017 at 10:37 PM Alistair Francis < >> alistair.fran...@xilinx.com> wrote: >> >>> When QEMU is waiting for a TCP socket connection it reports that message

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-06 Thread Philippe Mathieu-Daudé
On 06/06/2017 08:58 AM, Marc-André Lureau wrote: Hi On Mon, Jun 5, 2017 at 10:37 PM Alistair Francis < alistair.fran...@xilinx.com> wrote: When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error though, so let's change the report to just use qe

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-06 Thread Marc-André Lureau
Hi On Mon, Jun 5, 2017 at 10:37 PM Alistair Francis < alistair.fran...@xilinx.com> wrote: > When QEMU is waiting for a TCP socket connection it reports that message as > an error. This isn't an error though, so let's change the report to just > use qemu_log(). > > I don't think this is a good ide

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-05 Thread Philippe Mathieu-Daudé
On 06/05/2017 03:34 PM, Alistair Francis wrote: When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error though, so let's change the report to just use qemu_log(). Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- cha

[Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

2017-06-05 Thread Alistair Francis
When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error though, so let's change the report to just use qemu_log(). Signed-off-by: Alistair Francis --- chardev/char-socket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ch