Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target

2013-07-25 Thread Stefan Hajnoczi
On Thu, Jul 25, 2013 at 02:08:42PM +0800, Fam Zheng wrote: > On Tue, 07/23 11:52, Stefan Hajnoczi wrote: > > On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote: > > > Signed-off-by: Fam Zheng > > > --- > > > block/backup.c | 3 ++- > > > block/mirror.c | 4 ++-- > > > 2 files changed, 4 in

Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target

2013-07-24 Thread Fam Zheng
On Tue, 07/23 11:52, Stefan Hajnoczi wrote: > On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > block/backup.c | 3 ++- > > block/mirror.c | 4 ++-- > > 2 files changed, 4 insertions(+), 3 deletions(-) > > Should we update the blockjob.c in_use c

Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target

2013-07-23 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > block/backup.c | 3 ++- > block/mirror.c | 4 ++-- > 2 files changed, 4 insertions(+), 3 deletions(-) Should we update the blockjob.c in_use code instead of adding refcounting to specific block jobs? T

[Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target

2013-07-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/backup.c | 3 ++- block/mirror.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/block/backup.c b/block/backup.c index 16105d4..b82f601 100644 --- a/block/backup.c +++ b/block/backup.c @@ -294,7 +294,7 @@ static void coroutine_fn backup_