Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-28 Thread Markus Armbruster
Amos Kong writes: > On Fri, Apr 25, 2014 at 02:52:09PM +0200, Markus Armbruster wrote: >> Amos Kong writes: > > Hi Markus, > >> > Currently we always add a space after c_type in mcgen(), there is >> > some redundant space in generated code. The space isn't needed for >> > points by the coding

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-27 Thread Amos Kong
On Fri, Apr 25, 2014 at 02:52:09PM +0200, Markus Armbruster wrote: > Amos Kong writes: Hi Markus, > > Currently we always add a space after c_type in mcgen(), there is > > some redundant space in generated code. The space isn't needed for > > points by the coding style. > > You mean pointers.

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-25 Thread Markus Armbruster
Amos Kong writes: > Currently we always add a space after c_type in mcgen(), there is > some redundant space in generated code. The space isn't needed for > points by the coding style. You mean pointers. > > char * value; > ^ > qapi_free_NameInfo(NameInfo * obj) >

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-25 Thread Eric Blake
On 04/25/2014 01:56 AM, Amos Kong wrote: > Currently we always add a space after c_type in mcgen(), there is > some redundant space in generated code. The space isn't needed for > points by the coding style. s/points/pointers/ > > char * value; > ^ > qapi_free_NameInfo(NameInfo * obj

[Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-25 Thread Amos Kong
Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. char * value; ^ qapi_free_NameInfo(NameInfo * obj) ^ This patch added a special string 'EATSP