An update of:
v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02047.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02471.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02517.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2017-08/ms
On Thu, 2017-09-14 at 13:40 +0100, Daniel P. Berrange wrote:
> On Thu, Sep 14, 2017 at 12:58:26PM +0100, Peter Maydell wrote:
> > On 14 September 2017 at 12:55, Gerd Hoffmann
> > wrote:
> > > Hi,
> > >
> > > > I think a better approach is to have something in rules.mak
> > > > that ensures the
On Mon, Sep 18, 2017 at 05:12:55PM +0200, Gerd Hoffmann wrote:
> On Thu, 2017-09-14 at 13:40 +0100, Daniel P. Berrange wrote:
> > On Thu, Sep 14, 2017 at 12:58:26PM +0100, Peter Maydell wrote:
> > > On 14 September 2017 at 12:55, Gerd Hoffmann
> > > wrote:
> > > > Hi,
> > > >
> > > > > I think
Hi,
> > So I did the keymaps build with a recursive make call too, which
> > doesn't look that pretty ...
>
> I don't think that's too ugly, but I wonder if there's some way to
> avoid
> the recursive make call.
>
> It feels like this is a similar scenario to 'config-host.mak' being
> outdated
On 19 September 2017 at 11:58, Gerd Hoffmann wrote:
>> It feels like this is a similar scenario to 'config-host.mak' being
>> outdated. I don't entirely understand the logic yet, but we manage to
>> automatically re-run configure and rebuild config-host.make, when
>> configure changes, and that i
On Tue, Sep 19, 2017 at 12:58:20PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > So I did the keymaps build with a recursive make call too, which
> > > doesn't look that pretty ...
> >
> > I don't think that's too ugly, but I wonder if there's some way to
> > avoid
> > the recursive make call.
> >
On Tue, Sep 19, 2017 at 12:20:55PM +0100, Daniel P. Berrange wrote:
> On Tue, Sep 19, 2017 at 12:58:20PM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > > > So I did the keymaps build with a recursive make call too, which
> > > > doesn't look that pretty ...
> > >
> > > I don't think that's too ugl
Hi,
> > The Makefile checks the output of this script, and if it indicates
> > that an submodule update is required, it uses an ifeq() to add a
> > dependancy between "Makefile" and a phony target that re-runs
> > configure (which in turns updates the submodules). If no update was
> > required,
On Tue, Sep 19, 2017 at 04:26:22PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > The Makefile checks the output of this script, and if it indicates
> > > that an submodule update is required, it uses an ifeq() to add a
> > > dependancy between "Makefile" and a phony target that re-runs
> > > configu
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb
Message-id: 20170912123744.14730-1-berra
Hi,
This series failed build test on s390x host. Please find the details below.
Subject: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb
Type: series
Message-id: 20170912123744.14730-1-berra...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked
Hi,
> The keycodemapdb code is designed to be used as a git sub-module, it
> is
> not an external dependancy you need installed before use. In this
> version,
> however, the sub-module is not directly use. Instead all the
> generated
> files are checked into GIT. The downside to this is that we
On Tue, Sep 12, 2017 at 03:46:34PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > The keycodemapdb code is designed to be used as a git sub-module, it
> > is
> > not an external dependancy you need installed before use. In this
> > version,
> > however, the sub-module is not directly use. Instead all t
On 12 September 2017 at 15:19, Daniel P. Berrange wrote:
> My POV is that we should a) never check generated files into GIT, and
> we should use the submodule in such a way that it is indistinguish
> from the content of the submodule being part of the main GIT repo.
AFAICT this is impossible in t
On Tue, Sep 12, 2017 at 03:24:22PM +0100, Peter Maydell wrote:
> On 12 September 2017 at 15:19, Daniel P. Berrange wrote:
> > My POV is that we should a) never check generated files into GIT, and
> > we should use the submodule in such a way that it is indistinguish
> > from the content of the sub
Hi,
> I think a better approach is to have something in rules.mak
> that ensures the submodule is checked out correctly (only
> when building from GIT, not dist), and then have the rules
> which generate the keymap files depend on this.
Care sending a patch doing that for dtc?
cheers,
Gerd
On 14 September 2017 at 12:55, Gerd Hoffmann wrote:
> Hi,
>
>> I think a better approach is to have something in rules.mak
>> that ensures the submodule is checked out correctly (only
>> when building from GIT, not dist), and then have the rules
>> which generate the keymap files depend on this.
On Thu, Sep 14, 2017 at 12:58:26PM +0100, Peter Maydell wrote:
> On 14 September 2017 at 12:55, Gerd Hoffmann wrote:
> > Hi,
> >
> >> I think a better approach is to have something in rules.mak
> >> that ensures the submodule is checked out correctly (only
> >> when building from GIT, not dist),
18 matches
Mail list logo