Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-20 Thread Andrey Shinkevich
On 18/02/2019 13:08, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 16:43, Andrey Shinkevich wrote: >> >> >> On 12/02/2019 14:35, Alberto Garcia wrote: >>> On Mon 11 Feb 2019 05:58:05 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> The problem is in the concept of "base" node. The code

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-18 Thread Vladimir Sementsov-Ogievskiy
14.02.2019 16:43, Andrey Shinkevich wrote: > > > On 12/02/2019 14:35, Alberto Garcia wrote: >> On Mon 11 Feb 2019 05:58:05 PM CET, Vladimir Sementsov-Ogievskiy wrote: > The problem is in the concept of "base" node. The code written in > manner that base is not changed during block job.

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-14 Thread Andrey Shinkevich
On 12/02/2019 14:35, Alberto Garcia wrote: > On Mon 11 Feb 2019 05:58:05 PM CET, Vladimir Sementsov-Ogievskiy wrote: The problem is in the concept of "base" node. The code written in manner that base is not changed during block job. However, job don't own base and there is no

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-12 Thread Alberto Garcia
On Mon 11 Feb 2019 05:58:05 PM CET, Vladimir Sementsov-Ogievskiy wrote: >>> The problem is in the concept of "base" node. The code written in >>> manner that base is not changed during block job. However, job don't >>> own base and there is no guarantee that it will not change during >>> the job.

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
11.02.2019 18:52, Alberto Garcia wrote: > On Mon 11 Feb 2019 03:51:33 PM CET, Vladimir Sementsov-Ogievskiy wrote: > I think this was already discussed in the previous version of this > patch: if you insert a copy-on-read filter here then all guest > reads will copy the data from the

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-11 Thread Alberto Garcia
On Mon 11 Feb 2019 03:51:33 PM CET, Vladimir Sementsov-Ogievskiy wrote: I think this was already discussed in the previous version of this patch: if you insert a copy-on-read filter here then all guest reads will copy the data from the backing chain, but you don't want to copy

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-11 Thread Andrey Shinkevich
On 11/02/2019 17:07, Alberto Garcia wrote: > On Fri 08 Feb 2019 04:29:48 PM CET, Andrey Shinkevich wrote: >> On 08/02/2019 16:13, Alberto Garcia wrote: >>> On Wed 23 Jan 2019 12:54:24 PM CET, Andrey Shinkevich wrote: +static BlockDriverState *insert_filter(BlockDriverState *bs, Error

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
11.02.2019 17:07, Alberto Garcia wrote: > On Fri 08 Feb 2019 04:29:48 PM CET, Andrey Shinkevich wrote: >> On 08/02/2019 16:13, Alberto Garcia wrote: >>> On Wed 23 Jan 2019 12:54:24 PM CET, Andrey Shinkevich wrote: +static BlockDriverState *insert_filter(BlockDriverState *bs, Error **errp)

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-11 Thread Alberto Garcia
On Fri 08 Feb 2019 04:29:48 PM CET, Andrey Shinkevich wrote: > On 08/02/2019 16:13, Alberto Garcia wrote: >> On Wed 23 Jan 2019 12:54:24 PM CET, Andrey Shinkevich wrote: >>> +static BlockDriverState *insert_filter(BlockDriverState *bs, Error **errp) >>> +{ >>> +BlockDriverState *cor_filter_bs;

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-08 Thread Andrey Shinkevich
On 08/02/2019 16:13, Alberto Garcia wrote: > On Wed 23 Jan 2019 12:54:24 PM CET, Andrey Shinkevich wrote: >> +static BlockDriverState *insert_filter(BlockDriverState *bs, Error **errp) >> +{ >> +BlockDriverState *cor_filter_bs; >> +Error *local_err = NULL; >> + >> +cor_filter_bs =

Re: [Qemu-devel] [Qemu-block] [PATCH RFC 1/1] Stream block job involves copy-on-read filter

2019-02-08 Thread Alberto Garcia
On Wed 23 Jan 2019 12:54:24 PM CET, Andrey Shinkevich wrote: > +static BlockDriverState *insert_filter(BlockDriverState *bs, Error **errp) > +{ > +BlockDriverState *cor_filter_bs; > +Error *local_err = NULL; > + > +cor_filter_bs = create_filter_node(bs, errp); > +if (cor_filter_bs