On Tue, 2010-03-09 at 11:22 -0300, Luiz Capitulino wrote:
On Tue, 09 Mar 2010 14:51:31 +0100
Juan Quintela quint...@redhat.com wrote:
Any recompilation/etc would break migration. I have tried to understand
what happened with monitor async commands, and my head exploded in
indirections.
On Tue, 09 Mar 2010 14:51:31 +0100
Juan Quintela quint...@redhat.com wrote:
Any recompilation/etc would break migration. I have tried to understand
what happened with monitor async commands, and my head exploded in
indirections.
The Monitor needs lots of cleanups to make things more
Adam Litke a...@us.ibm.com wrote:
The changes in V8 of this patch are related to the monitor infrastructure. No
changes to the virtio interface core have been made since V4. This is
intended
to apply on top of my API for asynchronous monitor commands patch.
I know that I am late reviewing
On Tue, 09 Mar 2010 08:48:43 -0600
Adam Litke a...@us.ibm.com wrote:
On Tue, 2010-03-09 at 11:22 -0300, Luiz Capitulino wrote:
On Tue, 09 Mar 2010 14:51:31 +0100
Juan Quintela quint...@redhat.com wrote:
Any recompilation/etc would break migration. I have tried to understand
what
On Fri, 15 Jan 2010 13:54:29 -0600
Adam Litke a...@us.ibm.com wrote:
This version improves support for multiple monitors and has been ported up to
HEAD as of 01/14.
Overall review on the Monitor related changes seems ok, but I'm not sure
how I should enable it.
On Mon, 2010-01-18 at 12:12 -0200, Luiz Capitulino wrote:
On Fri, 15 Jan 2010 13:54:29 -0600
Adam Litke a...@us.ibm.com wrote:
This version improves support for multiple monitors and has been ported up
to
HEAD as of 01/14.
Overall review on the Monitor related changes seems ok, but
On Mon, 11 Jan 2010 13:09:35 -0600
Adam Litke a...@us.ibm.com wrote:
After some good discussion, V6 of this patch integrates well with the new QMP
support. When the monitor is in QMP mode, the query-balloon command triggers
a
stats refresh request to the guest. This request is
On Wed, 2010-01-13 at 16:04 -0200, Luiz Capitulino wrote:
I've tried to apply this patch to play with it, but turns out it conflicts
with recent changes in hw/virtio-balloon.
Ahh, I will continue my never-ending quest to stay current :)
Some comments on the QMP side of the patch follows.
On Wed, 13 Jan 2010 12:59:25 -0600
Adam Litke a...@us.ibm.com wrote:
+/*
+ * complete_stats_request - Clean up and report statistics.
+ */
+static void complete_stats_request(VirtIOBalloon *vb)
+{
+QObject *stats = get_stats_qobject(vb);
+
+if
On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
Changes since V2:
- Increase stat field size to 64 bits
- Report all sizes in kb (not pages)
- Drop anon_pages
On 11/23/2009 11:44 AM, Michael S. Tsirkin wrote:
On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
Changes since V2:
- Increase stat field size to 64 bits
- Report all
On 11/23/2009 01:00 PM, Dor Laor wrote:
On 11/23/2009 11:44 AM, Michael S. Tsirkin wrote:
On Thu, Nov 19, 2009 at 09:19:05AM -0600, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch
for
inclusion. Thanks.
Changes since V2:
-
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
+struct virtio_balloon_stat
+{
+ __le16 tag;
+ __le64 val;
+};
+
You're not doing endian conversion in the host?
--
error
On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
+struct virtio_balloon_stat
+{
+ __le16 tag;
+ __le64 val;
+};
+
On 11/19/2009 05:58 PM, Adam Litke wrote:
On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
+struct virtio_balloon_stat
+{
+
On Thu, 2009-11-19 at 18:13 +0200, Avi Kivity wrote:
On 11/19/2009 05:58 PM, Adam Litke wrote:
On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this
On Fri, 20 Nov 2009 01:49:05 am Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
Changes since V2:
- Increase stat field size to 64 bits
- Report all sizes in kb (not pages)
Hi Adam,
Looks like we're
Rusty Russell wrote:
On Wed, 18 Nov 2009 07:06:29 am Adam Litke wrote:
virtio: Add memory statistics reporting to the balloon driver (V2)
Changes since V1:
- Use a virtqueue instead of the device config space
Hi Adam,
If Anthony's happy, I'm happy with this approach.
Couple of
Anthony Liguori wrote:
Rusty Russell wrote:
The little-endian conversion of the balloon driver is a historical mistake
(no other driver does this). Let's not extend it to the stats.
I think the mistake is that the other drivers don't do that.
We cheat in qemu and assume that the guest is
On Thu, 19 Nov 2009 01:32:26 am Anthony Liguori wrote:
Rusty Russell wrote:
The little-endian conversion of the balloon driver is a historical mistake
(no other driver does this). Let's not extend it to the stats.
I think the mistake is that the other drivers don't do that.
We cheat in
On Wed, 18 Nov 2009 07:06:29 am Adam Litke wrote:
virtio: Add memory statistics reporting to the balloon driver (V2)
Changes since V1:
- Use a virtqueue instead of the device config space
Hi Adam,
If Anthony's happy, I'm happy with this approach.
Couple of minor points:
+static
Anthony Liguori wrote:
Avi Kivity wrote:
On 11/10/2009 04:36 PM, Anthony Liguori wrote:
A stats vq might solve this more cleanly?
actual and target are both really just stats. Had we implemented
those with a vq, I'd be inclined to agree with you but since they're
implemented in the
On 11/11/2009 03:26 PM, Adam Litke wrote:
On Wed, 2009-11-11 at 10:12 +, Daniel P. Berrange wrote:
This all suggests that we should only update the stats from the guest
when something on the host actually asks for them by issuing the QEMU
monitor command. We don't want any kind of
On Wed, 2009-11-11 at 13:13 +1030, Rusty Russell wrote:
It's not laziness, it's consistency. How is actual different than free
memory or any other stat?
Because it's a COLLECTION of stats. For example, swap in should be swap
out. Now, the current Linux implementation of
On Thu, 12 Nov 2009 01:38:34 am Adam Litke wrote:
But it raises the question: what stats are generally useful cross-OS?
Should
we be supplying numbers like unused (free) instantly discardable (ie.
clean), discardable to disk (ie. file-backed), discardable to swap
(ie. swap-backed) and
Rusty Russell wrote:
On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote:
A simpler approach is to collect memory statistics in the virtio
balloon driver and communicate them to the host via the device config space.
There are two issues I see with this. First, there's an atomicity
On 11/10/2009 04:36 PM, Anthony Liguori wrote:
A stats vq might solve this more cleanly?
actual and target are both really just stats. Had we implemented
those with a vq, I'd be inclined to agree with you but since they're
implemented in the config space, it seems natural to extend the
Avi Kivity wrote:
On 11/10/2009 04:36 PM, Anthony Liguori wrote:
A stats vq might solve this more cleanly?
actual and target are both really just stats. Had we implemented
those with a vq, I'd be inclined to agree with you but since they're
implemented in the config space, it seems
Rusty Russell wrote:
On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote:
A simpler approach is to collect memory statistics in the virtio
balloon driver and communicate them to the host via the device config space.
There are two issues I see with this. First, there's an atomicity
On Wed, 11 Nov 2009 01:06:14 am Anthony Liguori wrote:
Rusty Russell wrote:
On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote:
A simpler approach is to collect memory statistics in the virtio
balloon driver and communicate them to the host via the device config
space.
Rusty Russell wrote:
On Wed, 11 Nov 2009 08:22:42 am Anthony Liguori wrote:
Rusty Russell wrote:
On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote:
A simpler approach is to collect memory statistics in the virtio
balloon driver and communicate them to the host via the device
On Wed, 11 Nov 2009 10:37:56 am Anthony Liguori wrote:
Rusty Russell wrote:
You register an outbuf at initialization time. The host hands it back when
it wants you to refill it with stats.
That's strangely backwards. Guest send a stat buffer that's filled out,
host acks it when it
On Tue, 10 Nov 2009 03:02:06 am Adam Litke wrote:
A simpler approach is to collect memory statistics in the virtio
balloon driver and communicate them to the host via the device config space.
There are two issues I see with this. First, there's an atomicity problem
since you can't tell when
a...@linux.vnet.ibm.com wrote:
Here are the corresponding changes to the Linux virtio driver...
virtio: Add memory statistics reporting to the balloon driver
When using ballooning to manage overcommitted memory on a host, a system for
guests to communicate their memory usage
34 matches
Mail list logo
