Re: [PATCH] qmp: Stabilize preconfig

2021-11-15 Thread Paolo Bonzini
El lun., 15 nov. 2021 16:40, Markus Armbruster escribió: > > Why do you care? For another example, you can use "reboot" or > > "systemctl isolate reboot.target" and they end up doing the same thing. > > > > As long as qemu_init invokes qmp_machine_set, qmp_accel_set, > > qmp_device_add, qmp_plug

Re: [PATCH] qmp: Stabilize preconfig

2021-11-15 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/13/21 08:52, Markus Armbruster wrote: >> I'm not asking what to do "if it hurts", or "if you want a cold-plugged >> device". I'm asking whether there's a reason for ever wanting hot plug >> instead of cold plug. Or in other words, what can hot plug possibly >> gain

Re: [PATCH] qmp: Stabilize preconfig

2021-11-15 Thread Paolo Bonzini
On 11/13/21 08:52, Markus Armbruster wrote: I'm not asking what to do "if it hurts", or "if you want a cold-plugged device". I'm asking whether there's a reason for ever wanting hot plug instead of cold plug. Or in other words, what can hot plug possibly gain us over cold plug? As far as I kno

Re: [PATCH] qmp: Stabilize preconfig

2021-11-12 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/12/21 12:48, Markus Armbruster wrote: >>> The monitor starts, the question is the availability of the event loop. >> >> What does the event loop depend on? > > It depends on moving the relevant code out of qemu_init (at least > conditionally, as is the case for wha

Re: [PATCH] qmp: Stabilize preconfig

2021-11-12 Thread Paolo Bonzini
On 11/12/21 12:48, Markus Armbruster wrote: The monitor starts, the question is the availability of the event loop. What does the event loop depend on? It depends on moving the relevant code out of qemu_init (at least conditionally, as is the case for what is in qmp_x_exit_preconfig). This

Re: [PATCH] qmp: Stabilize preconfig

2021-11-12 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/11/21 15:37, Markus Armbruster wrote: >>> 1) PHASE_NO_MACHINE - backends can already be created here, but no >>> machine exists yet >>> >>> 2) PHASE_MACHINE_CREATED - the machine object has been created. It's >>> not initialized, but it's there. >>> >>> 3) PHASE_ACC

Re: [PATCH] qmp: Stabilize preconfig

2021-11-11 Thread Paolo Bonzini
On 11/11/21 15:37, Markus Armbruster wrote: 1) PHASE_NO_MACHINE - backends can already be created here, but no machine exists yet 2) PHASE_MACHINE_CREATED - the machine object has been created. It's not initialized, but it's there. 3) PHASE_ACCEL_CREATED - the accelerator object has been creat

Re: [PATCH] qmp: Stabilize preconfig

2021-11-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/11/21 07:11, Markus Armbruster wrote: >> Paolo Bonzini writes: >> On 11/3/21 09:02, Markus Armbruster wrote: > I wonder whether we really have to step through three states > >x-exit-preconfig cont > preconfig ---> pre run ---

Re: [PATCH] qmp: Stabilize preconfig

2021-11-11 Thread Paolo Bonzini
On 11/11/21 07:11, Markus Armbruster wrote: Paolo Bonzini writes: On 11/3/21 09:02, Markus Armbruster wrote: I wonder whether we really have to step through three states x-exit-preconfig cont preconfig ---> pre run ---> run and not two cont pre run ---

Re: [PATCH] qmp: Stabilize preconfig

2021-11-10 Thread Markus Armbruster
Paolo Bonzini writes: >> On 11/3/21 09:02, Markus Armbruster wrote: >>> I wonder whether we really have to step through three states >>> >>> x-exit-preconfig cont >>> preconfig ---> pre run ---> run >>> >>> and not two >>> >>> cont >>> pre run ---> run > > Device

Re: [PATCH] qmp: Stabilize preconfig

2021-11-10 Thread Paolo Bonzini
On 11/3/21 09:02, Markus Armbruster wrote: I wonder whether we really have to step through three states x-exit-preconfig cont preconfig ---> pre run ---> run and not two cont pre run ---> run Devices would be hotplugged between x-exit-preconfig and cont, and

Re: [PATCH] qmp: Stabilize preconfig

2021-11-10 Thread Damien Hedde
On 11/10/21 13:54, Michal Prívozník wrote: On 11/3/21 9:02 AM, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Nov 01, 2021 at 03:37:58PM +0100, Michal Prívozník wrote: On 10/25/21 2:19 PM, Markus Armbruster wrote: Michal Privoznik writes: The -preconfig option and exit-pr

Re: [PATCH] qmp: Stabilize preconfig

2021-11-10 Thread Michal Prívozník
On 11/3/21 9:02 AM, Markus Armbruster wrote: > Daniel P. Berrangé writes: > >> On Mon, Nov 01, 2021 at 03:37:58PM +0100, Michal Prívozník wrote: >>> On 10/25/21 2:19 PM, Markus Armbruster wrote: Michal Privoznik writes: > The -preconfig option and exit-preconfig command are around

Re: [PATCH] qmp: Stabilize preconfig

2021-11-03 Thread Daniel P . Berrangé
On Wed, Nov 03, 2021 at 09:02:49AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Nov 01, 2021 at 03:37:58PM +0100, Michal Prívozník wrote: > >> On 10/25/21 2:19 PM, Markus Armbruster wrote: > >> > Michal Privoznik writes: > >> > > >> >> The -preconfig option and exi

Re: [PATCH] qmp: Stabilize preconfig

2021-11-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Nov 01, 2021 at 03:37:58PM +0100, Michal Prívozník wrote: >> On 10/25/21 2:19 PM, Markus Armbruster wrote: >> > Michal Privoznik writes: >> > >> >> The -preconfig option and exit-preconfig command are around for >> >> quite some time now. However, they are s

Re: [PATCH] qmp: Stabilize preconfig

2021-11-01 Thread Daniel P . Berrangé
On Mon, Nov 01, 2021 at 03:37:58PM +0100, Michal Prívozník wrote: > On 10/25/21 2:19 PM, Markus Armbruster wrote: > > Michal Privoznik writes: > > > >> The -preconfig option and exit-preconfig command are around for > >> quite some time now. However, they are still marked as unstable. > >> This i

Re: [PATCH] qmp: Stabilize preconfig

2021-11-01 Thread Michal Prívozník
On 10/25/21 2:19 PM, Markus Armbruster wrote: > Michal Privoznik writes: > >> The -preconfig option and exit-preconfig command are around for >> quite some time now. However, they are still marked as unstable. >> This is suboptimal because it may block some upper layer in >> consuming it. In this

Re: [PATCH] qmp: Stabilize preconfig

2021-10-25 Thread Paolo Bonzini
On 25/10/21 14:19, Markus Armbruster wrote: Michal Privoznik writes: The -preconfig option and exit-preconfig command are around for quite some time now. However, they are still marked as unstable. This is suboptimal because it may block some upper layer in consuming it. In this specific case

Re: [PATCH] qmp: Stabilize preconfig

2021-10-25 Thread Markus Armbruster
Michal Privoznik writes: > The -preconfig option and exit-preconfig command are around for > quite some time now. However, they are still marked as unstable. > This is suboptimal because it may block some upper layer in > consuming it. In this specific case - Libvirt avoids using > experimental f

[PATCH] qmp: Stabilize preconfig

2021-10-25 Thread Michal Privoznik
The -preconfig option and exit-preconfig command are around for quite some time now. However, they are still marked as unstable. This is suboptimal because it may block some upper layer in consuming it. In this specific case - Libvirt avoids using experimental features. Signed-off-by: Michal Privo