Continous Integration Result: FAILED
See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .
Patches applied :
Patchwork 2004: http://patchwork.quagga.net/patch/2004
[quagga-dev,15630] bgpd: eliminate RD related du
Philippe,
I've posted a fix to this (patch on patch) in
https://github.com/LabNConsulting/quagga-vnc/commit/cd54370cb94d598aa95bd7561cc012200920d97a
If you can take a look and comment that would be great.
My plan is to submit a v2 of the whole patch set once issues raised have
been addressed. (
---
bgpd/bgp_encap.c | 45 -
bgpd/bgp_mplsvpn.c | 8
bgpd/bgp_mplsvpn.h | 4
3 files changed, 8 insertions(+), 49 deletions(-)
diff --git a/bgpd/bgp_encap.c b/bgpd/bgp_encap.c
index d21924c..bd150ce 100644
--- a/bgpd/bgp_encap.c
+++ b/
Continous Integration Result: SUCCESSFUL
Congratulations, this patch passed basic tests
Tested-by: NetDEF CI System
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .
Patches applied :
Patchwork 2003: http://patchwork.quagga.net/patch/
Continous Integration Result: FAILED
See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .
Patches applied :
Patchwork 2002: http://patchwork.quagga.net/patch/2002
[quagga-dev,15621] *: Fix duplicate commands fro
Paul,
See below.
On 6/15/2016 5:53 AM, Paul Jakma wrote:
> On Tue, 12 Jan 2016, Lou Berger wrote:
>
>> +DEFUN (show_commandtree,
>> + show_commandtree_cmd,
>> + "show commandtree",
>> + NO_STR
>> + "Show command tree\n")
>> +{
>> + /* TBD */
>> + vector cmd_vector;
>> +
Continous Integration Result: FAILED
See below for issues.
This is an EXPERIMENTAL automated CI system.
For questions and feedback, feel free to email
Martin Winter .
Patches applied :
Patchwork 2001: http://patchwork.quagga.net/patch/2001
[quagga-dev,15620] lib: keep hash of node's comm
On Tue, Jun 14, 2016 at 7:59 PM, David Lamparter
wrote:
Hello David,
>
> +DEFINE_MTYPE_STATIC(LIB, PLUGIN_LOADNAME, "Plugin loading name")
* I got compilation problems. Some elements are not yet in the master.
I will retry later.
branch of quagga.
error: patch failed: lib/Makefile.am:15
error: l
Le 16/06/2016 16:58, David Lamparter a écrit :
Now, for the "yes" part... there are quite a few things that make sense
to modularise:
- SNMP, if it stays around
- Sproute's/Avneesh's Protobuf stuff
- OSR's/my Cap'n Proto stuff
- the entire CLI
- kernel backends
+1
I like the idea of modularisat
Removed dead code paths and fixed a typo.
Signed-off-by: Quentin Young
---
lib/command.c | 69 +--
1 file changed, 1 insertion(+), 68 deletions(-)
diff --git a/lib/command.c b/lib/command.c
index 8089360..b9259e2 100644
--- a/lib/command.c
On Tue, Jun 14, 2016 at 8:07 PM, Christian Franke
wrote:
Hello Christian,
> +static const size_t attr_flags_values_max = array_size(attr_flags_values) -
> 1;
This macro is very useful.
Acked-by : Philippe Guibert
___
Quagga-dev mailing list
Quagga
---
bgpd/bgp_filter.c | 2 --
bgpd/bgp_mplsvpn.c | 18 --
bgpd/bgp_nexthop.c | 4
isisd/isis_spf.c | 4
isisd/isis_te.c| 2 --
lib/vty.c | 10 --
ospf6d/ospf6d.c| 37 -
ospfd/ospf_ri.c| 2 --
zebra/d
* command.h: (struct cmd_node) Add a hash, so duplicate installs of
a cmd_element to a command node can be detected. To help catch
strays from the VIEW/ENABLE node consolidation particularly
(installs to VIEW automatically install to ENABLE too now).
* command.c: (cmd_hash_{key,cmp}) helpers
On Thu, Jun 16, 2016 at 09:31:20AM -0400, Donald Sharp wrote:
> I personally don't see allot of value in making snmp support runtime
> -vs- compile time,
At the very least, it's a nice halfway step to kicking it out ;)
> but as a proof of concept I think it's fine for what it is.
Yay, mission ac
Acked-by: Donald Sharp
On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke
wrote:
> From: Christian Franke
>
> buf is dynamically allocated and needs to be freed in the error handling
> path too.
>
> Signed-off-by: Christian Franke
> ---
> vtysh/vtysh.c | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Donald Sharp
On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke
wrote:
> From: Christian Franke
>
> While the DEFUN should match the list of clients registered in
> vtysh, it seems better to handle the case explicitly instead of
> relying on the client list and the DEFUN signature bein
Acked-by: Donald Sharp
On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke
wrote:
> From: Christian Franke
>
> The dump of the md5 hash was missing one byte of the hash.
>
> Signed-off-by: Christian Franke
> ---
> ripd/ripd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff
Acked-by: Donald Sharp
On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke
wrote:
> From: Christian Franke
>
> original_s_route is allocated on the heap and was not freed during the
> error case.
>
> Signed-off-by: Christian Franke
> ---
> pimd/pim_static.c | 4
> 1 file changed, 4 inserti
I personally don't see allot of value in making snmp support runtime
-vs- compile time, but as a proof of concept I think it's fine for
what it is.
I do see value in shared libraries though.
Should we be thinking a bit bigger? Could we modify the protocols to
all be shared libraries that could b
Nothing but old habits, so easy to change. I've been favoring clang (much
better warnings) which defaults to it in any case...
Cheers,
Lou
On June 16, 2016 5:49:00 AM Paul Jakma wrote:
On Thu, 16 Jun 2016, Paul Jakma wrote:
If it's trivial like declaring stuff in the first clause of a fo
The substantive part of my comment really relates to coding style and if
variable declarations within for statements and, to a lesser decree,
declarations in the middle of code blocks are accepted in quagga.
Proposed/8 introduces the former to quagga.
For consistency sake, I'd say both should
On Thu, 16 Jun 2016, Paul Jakma wrote:
If it's trivial like declaring stuff in the first clause of a for, I'm
happy to change it.
Oh, but... also be good to fix whatever it is that prevents you running
your compiler in C99+ mode. ;)
regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID
Paul Jakma wrote:
> Note, mailman can be configured to filter messages and block HTML, or
> else convert it to text. See the 'content filtering' section Vincent. It
> just needs to be turned on.
the please-don't-post-html war was lost years ago and nothing is going
to roll back the clock on that.
On Wed, 15 Jun 2016, Lou Berger wrote:
Why use -std=gnu99? Before these changes quagga, e.g., the current
release, compiled fine without the flag.
If it's trivial like declaring stuff in the first clause of a for, I'm
happy to change it.
regards,
--
Paul Jakma | p...@jakma.org | @pjakma | K
On Wed, 15 Jun 2016, Vincent JARDIN wrote:
PS: please, stop posting some HTML emails.
I'll add: "PPPS: Please trim extraneous quoted text from replies!"
Note, mailman can be configured to filter messages and block HTML, or
else convert it to text. See the 'content filtering' section Vincent.
Olivier,
On 15 Jun 2016, at 23:47, Olivier Dugeon wrote:
Hi Donald, all,
Concerning the Maintainer document, I add a comment I would discuss on
the mailing list.
Is there room to define a new role named 'Reviewer' that stand between
contributor and maintainer. I mean volunteer who could he
26 matches
Mail list logo