Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joe Smith
> On May 8, 2015, 5:22 p.m., Bill Farner wrote: > > Ship It! Mind committing for me? - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83119 -

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83121 --- Ship it! Master (1c09d58) is green with this patch. ./build-suppo

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83119 --- Ship it! Ship It! - Bill Farner On May 9, 2015, 12:11 a.m., Joe

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83118 --- Ship it! Ship It! - Joshua Cohen On May 9, 2015, 12:11 a.m., Joe

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/ --- (Updated May 8, 2015, 5:11 p.m.) Review request for Aurora and Bill Farner. C

Re: Review Request 33999: Add missing binding to ThriftApiBenchmarks.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33999/ --- (Updated May 8, 2015, 10:02 p.m.) Review request for Aurora and Joshua Cohen.

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review83104 --- Ship it! Master (288f00b) is green with this patch. ./build-suppo

Re: Review Request 33999: Add missing binding to ThriftApiBenchmarks.

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33999/#review83102 --- Ship it! Ship It! - Joshua Cohen On May 8, 2015, 8:45 p.m., Bill

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review83094 --- @ReviewBot retry Last build result is for the previous diff. - Bil

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review83093 --- Master (288f00b) is red with this patch. ./build-support/jenkins/b

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 8, 2015, 9:07 p.m.) Review request for Aurora, Kevin Sweeney and Z

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/#review83089 --- Ship it! Ship It! - Zameer Manji On May 8, 2015, 1:57 p.m., Bill

Re: Review Request 33999: Add missing binding to ThriftApiBenchmarks.

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33999/#review83088 --- Ship it! Master (288f00b) is green with this patch. ./build-suppo

Re: Review Request 33959: Add update wait and update start --wait flag.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33959/ --- (Updated May 8, 2015, 8:57 p.m.) Review request for Aurora, Kevin Sweeney and Z

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-08 Thread Bill Farner
> On May 8, 2015, 2:49 a.m., Zameer Manji wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 200 > > > > > > Shouldn't we abort if the response is not OK? Also how does this work > > when the schedule

Re: Review Request 33959: Add update watch and update start --watch flag.

2015-05-08 Thread Bill Farner
> On May 8, 2015, 1:08 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 205 > > > > > > Since this is also used in "update wait" command, suggest reprhasing to > > something

Review Request 33999: Add missing binding to ThriftApiBenchmarks.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33999/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joe Smith
> On May 8, 2015, 1:23 p.m., Joshua Cohen wrote: > > build-support/release/verify-release-candidate, line 81 > > > > > > do we need to explicitly set this to /tmp? Won't it use TMPDIR by > > default? It would use TMPD

Re: Review Request 33924: Adding missing API hook support in kill commands.

2015-05-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33924/#review83072 --- Ship it! Ship It! - Zameer Manji On May 6, 2015, 6:28 p.m., Maxi

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83071 --- Ship it! Master (288f00b) is green with this patch. ./build-suppo

Re: Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/#review83068 --- build-support/release/verify-release-candidate

Review Request 33997: Improve GPG key validation for release verification script

2015-05-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33997/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 33994: Change RC verification script to use a temp dir.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33994/ --- (Updated May 8, 2015, 7:33 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 33994: Change RC verification script to use a temp dir.

2015-05-08 Thread Bill Farner
> On May 8, 2015, 7:24 p.m., Kevin Sweeney wrote: > > build-support/release/verify-release-candidate, line 59 > > > > > > local dist_name=$1 Done. - Bill ---

Re: Review Request 33994: Change RC verification script to use a temp dir.

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33994/#review83058 --- Ship it! Master (8d8d75e) is green with this patch. ./build-suppo

Re: Review Request 33994: Change RC verification script to use a temp dir.

2015-05-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33994/#review83057 --- Ship it! build-support/release/verify-release-candidate

Re: Review Request 33994: Change RC verification script to use a temp dir.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33994/ --- (Updated May 8, 2015, 7:16 p.m.) Review request for Aurora and Kevin Sweeney.

Review Request 33994: Change RC verification script to use a temp dir.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33994/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

2015-05-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33991/#review83040 --- Ship it! Master (8157181) is green with this patch. ./build-suppo

Re: Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

2015-05-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33991/#review83038 --- Ship it! Ship It! - Joshua Cohen On May 8, 2015, 6:10 p.m., Bill

Re: Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33991/ --- (Updated May 8, 2015, 6:10 p.m.) Review request for Aurora and Joshua Cohen.

Review Request 33991: Add a StatsProvider binding to UpdateStoreBenchmarks.

2015-05-08 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33991/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --