[kudu-CR] python-client: fix test scan rows string predicate and projection

2018-04-30 Thread Anonymous Coward (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10255 to look at the new patch set (#5). Change subject: python-client: fix test_scan_rows_string_predicate_and_projection

[kudu-CR] python-client: fix test scan rows string predicate and projection

2018-04-30 Thread Anonymous Coward (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10255 to look at the new patch set (#4). Change subject: python-client: fix test_scan_rows_string_predicate_and_projection

[kudu-CR] python-client: fix test scan rows string predicate and projection

2018-04-30 Thread Anonymous Coward (Code Review)
a...@phdata.io has posted comments on this change. ( http://gerrit.cloudera.org:8080/10255 ) Change subject: python-client: fix test_scan_rows_string_predicate_and_projection .. Patch Set 3: (1 comment)

[kudu-CR] python-client: fix test scan rows string predicate and projection

2018-04-30 Thread Anonymous Coward (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10255 to look at the new patch set (#3). Change subject: python-client: fix test_scan_rows_string_predicate_and_projection

[kudu-CR] KUDU-2214 Update logging to differentiate voting while copying/tombstoned

2018-04-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10169 ) Change subject: KUDU-2214 Update logging to differentiate voting while copying/tombstoned .. Patch Set 1: (4 comments)

[kudu-CR] python-client: fix test scan rows string predicate and projection

2018-04-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10255 ) Change subject: python-client: fix test_scan_rows_string_predicate_and_projection .. Patch Set 2: (1 comment)

[kudu-CR] python-client: fix test scan rows string predicate and projection

2018-04-30 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10255 to look at the new patch set (#2). Change subject: python-client: fix test_scan_rows_string_predicate_and_projection

[kudu-CR] Revert unneccesary change to test in test scanner.py in commit 3bf125f469a2929f7fe20e4e31f073376f37575d. The test test scan rows string predicate and projection was already working and using

2018-04-30 Thread Anonymous Coward (Code Review)
a...@phdata.io has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10255 Change subject: Revert unneccesary change to test in test_scanner.py in commit 3bf125f469a2929f7fe20e4e31f073376f37575d. The test test_scan_rows_string_predicate_and_projection was already working and

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-04-30 Thread Hao Hao (Code Review)
Hello Alexey Serbin, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9526 to look at the new patch set (#8). Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode

[kudu-CR] [tests] fixed flake in consensus peer health status

2018-04-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10237 ) Change subject: [tests] fixed flake in consensus_peer_health_status .. [tests] fixed flake in consensus_peer_health_status

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-04-30 Thread Hao Hao (Code Review)
Hello Alexey Serbin, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9526 to look at the new patch set (#7). Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode

[kudu-CR] [tests] fixed flake in consensus peer health status

2018-04-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10237 ) Change subject: [tests] fixed flake in consensus_peer_health_status .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-04-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 ) Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode .. Patch Set 5: (9 comments)

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor result handling .. Patch Set 13: (4 comments)

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10199 ) Change subject: java: fix minor synchronization issues exposed by error-prone .. Patch Set 3: Verified+1 -- To view, visit

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10199 ) Change subject: java: fix minor synchronization issues exposed by error-prone .. java: fix minor synchronization issues exposed

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: java: fix minor synchronization issues exposed by error-prone .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10199 To

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10196 ) Change subject: java: fix error-prone 'StringSplit' pattern[1] .. java: fix error-prone 'StringSplit' pattern[1] This should be

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: java: fix error-prone 'StringSplit' pattern[1] .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/10196 To unsubscribe,

[kudu-CR] java: fix error-prone DefaultCharset[1] issues

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10197 ) Change subject: java: fix error-prone DefaultCharset[1] issues .. Patch Set 3: (1 comment)

[kudu-CR] A new Jepsen checker for READ YOUR WRITES scan mode

2018-04-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9526 ) Change subject: A new Jepsen checker for READ_YOUR_WRITES scan mode .. Patch Set 5: (2 comments)

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 ) Change subject: java: fix error-prone 'StringSplit' pattern[1] .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python

2018-04-30 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10072 ) Change subject: KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python .. KUDU-2399: Support IS NULL / IS NOT NULL

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10199 ) Change subject: java: fix minor synchronization issues exposed by error-prone .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] java: fix error-prone DefaultCharset[1] issues

2018-04-30 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10197 ) Change subject: java: fix error-prone DefaultCharset[1] issues .. Patch Set 3: (1 comment)

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-30 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10151 to look at the new patch set (#13). Change subject: [tools] ksck improvements [6/n]: Refactor result handling

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor result handling .. Patch Set 12: (9 comments)

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 ) Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 ) Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 6: Code-Review+2 thanks -- To

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10196 ) Change subject: java: fix error-prone 'StringSplit' pattern[1] .. Patch Set 1: Fixed the spot in the integration test build -- To

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7362 ) Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 4: (1 comment)

[kudu-CR] java: fix error-prone 'StringSplit' pattern[1]

2018-04-30 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10196 to look at the new patch set (#3). Change subject: java: fix error-prone 'StringSplit' pattern[1] ..

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10199 ) Change subject: java: fix minor synchronization issues exposed by error-prone .. Patch Set 1: (1 comment)

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2018-04-30 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, David Ribeiro Alves, Jean-Daniel Cryans, Kudu Jenkins, Anonymous Coward #314, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7362 to look at the new patch set (#6). Change subject: java: prohibit use of a KuduTable from

[kudu-CR] java: fix error-prone DefaultCharset[1] issues

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10197 ) Change subject: java: fix error-prone DefaultCharset[1] issues .. Patch Set 1: Switched to StandardCharsets -- To view, visit

[kudu-CR] java: fix error-prone DefaultCharset[1] issues

2018-04-30 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10197 to look at the new patch set (#3). Change subject: java: fix error-prone DefaultCharset[1] issues ..

[kudu-CR] java: fix minor synchronization issues exposed by error-prone

2018-04-30 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10199 to look at the new patch set (#3). Change subject: java: fix minor synchronization issues exposed by error-prone

[kudu-CR] benchmarks: update parameters for mt-bloomfile benchmark

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10242 ) Change subject: benchmarks: update parameters for mt-bloomfile benchmark .. benchmarks: update parameters for mt-bloomfile

[kudu-CR] benchmarks: update parameters for mt-bloomfile benchmark

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10242 ) Change subject: benchmarks: update parameters for mt-bloomfile benchmark .. Patch Set 1: The performance of the benchmark got slower

[kudu-CR] [tools] ksck improvements [6/n]: Refactor result handling

2018-04-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10151 ) Change subject: [tools] ksck improvements [6/n]: Refactor result handling .. Patch Set 12: (11 comments)

[kudu-CR] mini-cluster: support parallel multi-master clusters

2018-04-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8280 ) Change subject: mini-cluster: support parallel multi-master clusters .. Patch Set 3: (4 comments)

[kudu-CR] benchmarks: update parameters for mt-bloomfile benchmark

2018-04-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10242 ) Change subject: benchmarks: update parameters for mt-bloomfile benchmark .. Patch Set 1: Code-Review+2 What tipped you off that the

[kudu-CR] KUDU-2422. Fix TSAN hangs in Subprocess::Start

2018-04-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10240 ) Change subject: KUDU-2422. Fix TSAN hangs in Subprocess::Start .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] benchmarks: update parameters for mt-bloomfile benchmark

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10242 Change subject: benchmarks: update parameters for mt-bloomfile benchmark .. benchmarks: update parameters for mt-bloomfile benchmark The

[kudu-CR] mini-cluster: support parallel multi-master clusters

2018-04-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8280 ) Change subject: mini-cluster: support parallel multi-master clusters .. Patch Set 3: (14 comments)

[kudu-CR] rpc: add experimental rpc reuseport flag

2018-04-30 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8279 to look at the new patch set (#3). Change subject: rpc: add experimental rpc_reuseport flag .. rpc: add

[kudu-CR] mini-cluster: support parallel multi-master clusters

2018-04-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8280 to look at the new patch set (#3). Change subject: mini-cluster: support parallel multi-master clusters

[kudu-CR] [tests] fixed flake in consensus peer health status

2018-04-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10237 ) Change subject: [tests] fixed flake in consensus_peer_health_status .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2422. Fix TSAN hangs in Subprocess::Start

2018-04-30 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10240 to review the following change. Change subject: KUDU-2422. Fix TSAN hangs in Subprocess::Start .. KUDU-2422. Fix TSAN

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Fix table formatting in full data dirs docs Change-Id:

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Patch Set 2: Verified+1 Unrelated flake in on of tests in TSAN build.

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [tests] fixed flake in consensus peer health status

2018-04-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10237 Change subject: [tests] fixed flake in consensus_peer_health_status .. [tests] fixed flake in consensus_peer_health_status Fixed flake

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-30 Thread Will Berkeley (Code Review)
Hello Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10211 to look at the new patch set (#2). Change subject: Fix table formatting in full data dirs docs

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Patch Set 2: Rendered by GitHub:

[kudu-CR] Fix table formatting in full data dirs docs

2018-04-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10211 ) Change subject: Fix table formatting in full data dirs docs .. Patch Set 2: (1 comment)